Message ID | 20231102152033.5511-1-duje.mihanovic@skole.hr |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp429561vqu; Thu, 2 Nov 2023 08:21:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGLQ4EsMxtvtrq9l3lsIk2vhZ6H7xuUW5XfnzbYHbi0CoUFug48A0llhLcYv9P+52N31LPW X-Received: by 2002:a05:6a21:7983:b0:181:5f5:11a4 with SMTP id bh3-20020a056a21798300b0018105f511a4mr8186712pzc.36.1698938479199; Thu, 02 Nov 2023 08:21:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698938479; cv=none; d=google.com; s=arc-20160816; b=hw4M3AtkdN8BvMDlsgHLQXfvbxx7MGEe/JnKl//5l1Lp6LZ38FF+clwDh9b+4Qd/ZQ OzZvVyvYm/Wwfxpy4LfWGtuIwtKRFCiCIZ/Mb4+VjXN+OiIJgXP1RXxXbb/8dqDS6LRn fTp7tOhVGMTrKVcuporWqv8ag4Q/zs/yT9ddyvuxYdd5HzQ9teMpq5ipHcCHcnwODtwV oQmxXNA/et4oeN6qZD5hIjf44hMZv7MnT8CgvC3VLFd5A8WECcYUhQWLKQjQZOHZAXDU MxbFtyAoJ6rQcY24XctWiADGoDq+UKHFSj5Qtv0KzWZQ+quairLNDDhvgQK6fzd9GWlq gkUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=fkcmsQi8RevlcatxUybEBf1AJhBIpGHArBI0yM8LNDI=; fh=o56bN5KLc64H5n9ExtYS7tDJLb648Jix4J0nSHvQ13g=; b=Hs7rH6TpJ3SEOZXPK9AyVZEpl+x17qXHQ0VoBHJf/LU52ksxIAPH9xbIpAmRXtLuN0 H9DC7UoUecqiMbTmA5NKpp1f0xmnRWVc2g7d7++5fDlyiS18AJndpew3UyEt+7NBB+rT mZVUYTtN+07GREEAuef0sQzyTOe44EpzwdRBCXeXjYobZfm5PiqwhLaHRpuTvBvfDU4p 0uylppy+nBi76GEOHQueKeXpJHoV8Go87BRFu1F/+zLbyQP4jS/Yok89wGAHDz1GIrh4 3tKE3DnLX8wUoDIVugqMgiYkkppIGaMMoIo1abVUI12BmG73SU/HA+OvKh4I2IOX1ECL H14w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id b23-20020a630c17000000b00578d5a135dasi1921064pgl.891.2023.11.02.08.21.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 08:21:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id A386982DDAC9; Thu, 2 Nov 2023 08:21:14 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346677AbjKBPVF (ORCPT <rfc822;heyuhang3455@gmail.com> + 35 others); Thu, 2 Nov 2023 11:21:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230037AbjKBPVD (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 2 Nov 2023 11:21:03 -0400 Received: from mx.skole.hr (mx1.hosting.skole.hr [161.53.165.185]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 107571A8; Thu, 2 Nov 2023 08:20:50 -0700 (PDT) Received: from mx1.hosting.skole.hr (localhost.localdomain [127.0.0.1]) by mx.skole.hr (mx.skole.hr) with ESMTP id A56FD83FE9; Thu, 2 Nov 2023 16:20:48 +0100 (CET) From: =?utf-8?q?Duje_Mihanovi=C4=87?= <duje.mihanovic@skole.hr> To: Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Tony Lindgren <tony@atomide.com>, =?utf-8?q?Duje_Mihanovi=C4=87?= <duje.mihanovic@skole.hr>, Daniel Mack <daniel@zonque.org>, Haojian Zhuang <haojian.zhuang@gmail.com>, Robert Jarzmik <robert.jarzmik@free.fr>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Leo Yan <leoy@marvell.com>, Zhangfei Gao <zhangfei.gao@marvell.com>, Lubomir Rintel <lkundrak@v3.sk>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Kees Cook <keescook@chromium.org>, Tony Luck <tony.luck@intel.com>, "Guilherme G . Piccoli" <gpiccoli@igalia.com> Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, alsa-devel@alsa-project.org, linux-hardening@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Karel Balej <balejk@matfyz.cz>, kernel test robot <lkp@intel.com> Subject: [PATCH v7 06/10] ASoC: pxa: Suppress SSPA on ARM64 Date: Thu, 2 Nov 2023 16:20:29 +0100 Message-ID: <20231102152033.5511-1-duje.mihanovic@skole.hr> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 02 Nov 2023 08:21:14 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781466114815981725 X-GMAIL-MSGID: 1781466114815981725 |
Series |
Initial Marvell PXA1908 support
|
|
Commit Message
Duje Mihanović
Nov. 2, 2023, 3:20 p.m. UTC
The SSPA driver currently seems to generate ARM32 assembly, which causes
build errors when building a kernel for an ARM64 ARCH_MMP platform.
Fixes: fa375d42f0e5 ("ASoC: mmp: add sspa support")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202310230518.zs9Qpg3j-lkp@intel.com/
Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
---
sound/soc/pxa/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Thu, Nov 02, 2023 at 04:20:29PM +0100, Duje Mihanović wrote: > The SSPA driver currently seems to generate ARM32 assembly, which causes > build errors when building a kernel for an ARM64 ARCH_MMP platform. > > Fixes: fa375d42f0e5 ("ASoC: mmp: add sspa support") > Reported-by: kernel test robot <lkp@intel.com> > tristate "SoC Audio via MMP SSPA ports" > - depends on ARCH_MMP > + depends on ARCH_MMP && ARM This isn't a fix for the existing code, AFAICT the issue here is that ARCH_MMP is currently only available for arm and presumably something in the rest of your series makes it available for arm64. This would be a prerequisite for that patch. Please don't just insert random fixes tags just because you can.
On 2023-11-02 3:26 pm, Mark Brown wrote: > On Thu, Nov 02, 2023 at 04:20:29PM +0100, Duje Mihanović wrote: >> The SSPA driver currently seems to generate ARM32 assembly, which causes >> build errors when building a kernel for an ARM64 ARCH_MMP platform. >> >> Fixes: fa375d42f0e5 ("ASoC: mmp: add sspa support") >> Reported-by: kernel test robot <lkp@intel.com> > >> tristate "SoC Audio via MMP SSPA ports" >> - depends on ARCH_MMP >> + depends on ARCH_MMP && ARM > > This isn't a fix for the existing code, AFAICT the issue here is that > ARCH_MMP is currently only available for arm and presumably something in > the rest of your series makes it available for arm64. This would be a > prerequisite for that patch. > > Please don't just insert random fixes tags just because you can. FWIW it doesn't even seem to be the right reason either. AFACIT the issue being introduced is that SND_MMP_SOC_SSPA selects SND_ARM which depends on ARM, but after patch #8 ARCH_MMP itself will no longer necessarily imply ARM. The fact that selecting SND_ARM with unmet dependencies also allows SND_ARMAACI to be enabled (which appears to be the only thing actually containing open-coded Arm asm) is tangential. Robin.
On Friday, November 3, 2023 4:23:28 PM CET Robin Murphy wrote: > On 2023-11-02 3:26 pm, Mark Brown wrote: > > This isn't a fix for the existing code, AFAICT the issue here is that > > ARCH_MMP is currently only available for arm and presumably something in > > the rest of your series makes it available for arm64. This would be a > > prerequisite for that patch. > > > > Please don't just insert random fixes tags just because you can. > > FWIW it doesn't even seem to be the right reason either. AFACIT the > issue being introduced is that SND_MMP_SOC_SSPA selects SND_ARM which > depends on ARM, but after patch #8 ARCH_MMP itself will no longer > necessarily imply ARM. The fact that selecting SND_ARM with unmet > dependencies also allows SND_ARMAACI to be enabled (which appears to be > the only thing actually containing open-coded Arm asm) is tangential. I just looked at it again and it looks like no code in sound/soc/pxa/* or sound/arm/pxa* depends on AACI in any way. Therefore, I believe that to fix this correctly, I would have to remove "select SND_ARM" from sound/soc/pxa/ Kconfig and optionally move the PXA2xx code out of sound/arm/ and into sound/ soc/pxa/. Is this correct? If so, I'd also split that fix into a separate series. Regards, Duje
On Fri, Nov 03, 2023 at 05:58:05PM +0100, Duje Mihanović wrote: > I just looked at it again and it looks like no code in sound/soc/pxa/* or > sound/arm/pxa* depends on AACI in any way. Therefore, I believe that to fix > this correctly, I would have to remove "select SND_ARM" from sound/soc/pxa/ > Kconfig and optionally move the PXA2xx code out of sound/arm/ and into sound/ > soc/pxa/. Is this correct? If so, I'd also split that fix into a separate > series. There's the pxa-ac97 driver to consider...
On Monday, November 6, 2023 11:58:46 AM CET Mark Brown wrote: > On Fri, Nov 03, 2023 at 05:58:05PM +0100, Duje Mihanović wrote: > > I just looked at it again and it looks like no code in sound/soc/pxa/* or > > sound/arm/pxa* depends on AACI in any way. Therefore, I believe that to fix > > this correctly, I would have to remove "select SND_ARM" from sound/soc/ pxa/ > > Kconfig and optionally move the PXA2xx code out of sound/arm/ and into > > sound/ > > soc/pxa/. Is this correct? If so, I'd also split that fix into a separate > > series. > > There's the pxa-ac97 driver to consider... Can you elaborate? As far as I can tell there are 2 drivers named pxa2xx-ac97 in sound/{arm,soc/pxa} and neither one has any dependency on AACI. Regards, Duje
On Fri, Nov 10, 2023 at 08:28:56PM +0100, Duje Mihanović wrote: > On Monday, November 6, 2023 11:58:46 AM CET Mark Brown wrote: > > On Fri, Nov 03, 2023 at 05:58:05PM +0100, Duje Mihanović wrote: > > > this correctly, I would have to remove "select SND_ARM" from sound/soc/ > pxa/ > > > Kconfig and optionally move the PXA2xx code out of sound/arm/ and into > > > sound/ > > > soc/pxa/. Is this correct? If so, I'd also split that fix into a separate > > > series. > > There's the pxa-ac97 driver to consider... > Can you elaborate? As far as I can tell there are 2 drivers named pxa2xx-ac97 > in sound/{arm,soc/pxa} and neither one has any dependency on AACI. They do both share a lot of library code and the one in sound/arm has no dependency on ASoC so I don't understand why you're suggesting moving it to sound/soc.
On Saturday, November 11, 2023 12:39:17 PM CET Mark Brown wrote: > On Fri, Nov 10, 2023 at 08:28:56PM +0100, Duje Mihanović wrote: > > Can you elaborate? As far as I can tell there are 2 drivers named > > pxa2xx-ac97 > > in sound/{arm,soc/pxa} and neither one has any dependency on AACI. > > They do both share a lot of library code and the one in sound/arm has no > dependency on ASoC so I don't understand why you're suggesting moving it > to sound/soc. Right. Do you have any objections on removing "select SND_ARM" from SND_MMP_SOC_SSPA? Regards, Duje
diff --git a/sound/soc/pxa/Kconfig b/sound/soc/pxa/Kconfig index e6bca9070953..8ebce669e4a7 100644 --- a/sound/soc/pxa/Kconfig +++ b/sound/soc/pxa/Kconfig @@ -33,7 +33,7 @@ config SND_PXA_SOC_SSP config SND_MMP_SOC_SSPA tristate "SoC Audio via MMP SSPA ports" - depends on ARCH_MMP + depends on ARCH_MMP && ARM select SND_SOC_GENERIC_DMAENGINE_PCM select SND_ARM help