[RFC,v2,6/7] dt-bindings: arm: mediatek: Remove SKU specific compatibles for Google Krane
Message ID | 20231109100606.1245545-7-wenst@chromium.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b129:0:b0:403:3b70:6f57 with SMTP id q9csp332874vqs; Thu, 9 Nov 2023 02:08:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IGQBMRTK6dV4RD2dSgaMlq2hRPZl6Qss0lZ8Ga1UKa1DLpYCOAg/KbL0uKoC0cbjuQFDneK X-Received: by 2002:a05:6358:7581:b0:168:ec61:c26 with SMTP id x1-20020a056358758100b00168ec610c26mr3104773rwf.21.1699524507166; Thu, 09 Nov 2023 02:08:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699524507; cv=none; d=google.com; s=arc-20160816; b=SGvmw9BTAkFexxyuHSykaSWmk3Bt1NVB6WXtFO48jC3krQ0v/b+ArfXViEcZKiMhF4 0n/J4uJVjWjMYioq1McGLmpvTq6NxYCssDF2eqyY4ODvctyXpKS9yIBXO7iy2lgSwdoH G/wonxY6mtoTuWJntiavhhseM51lWz7Nwd1VagsDiKSmgX/XUWhA4fJi2ZD/LQUY1fcz k7spgcy5nhjISU26EPBF23GMMXexzJZv+Ok5e+Tj3ajqZ4HovKF2EJGg2DGKNAi3pR+8 Hz9rA8J90WS0nwpCrwlbKPRtTc+CowdkOZ6CMeQmbjwBnnS+7JU0e8M9OAb87igXmJG/ /fiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0ireTpCfN0lAkDpS22SoHjbEWTJUzLlFEUnZESQj8kY=; fh=9RjyB+hDNs618LdaNPm846thAWpv+UOF4Pqs3eQuhzI=; b=ColkAgj8akA8ios+Kld7mM2X/f1LJrvavkcC69qfJBFssJ3HII1VNImtUCY+0pFthT 8uCtQ47xuFyKrdxKzlTLJuTaUw5lD0e33McpbJrOLjYQiMmAArPU3MUusV3wFISf8zYU Z7hoJBWlMgTetfXZSNEBn3bO4BOCOms7ZOzxPW8J6CeT6gbr7dnN2ZcaWAwJHOSB23ds UdFr7dw6zZDqrUp7qweYWck1w9viIkkBSRNE2R6BKSsBQZJuxwDKi8FMoEHwqsN3ALqn BZdB9V+O+Lsk1voNTxEnz+8+HHWcvVCu8vpNa1HT3HWGkc4dltGSas668sar2lmCGZwu ArGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=V+U3PVkf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id z23-20020a634c17000000b00588fa0def2asi6469491pga.778.2023.11.09.02.08.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 02:08:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=V+U3PVkf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 75EEC83113A4; Thu, 9 Nov 2023 02:08:16 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233454AbjKIKHc (ORCPT <rfc822;jaysivo@gmail.com> + 32 others); Thu, 9 Nov 2023 05:07:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232046AbjKIKHS (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 9 Nov 2023 05:07:18 -0500 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A78E3250 for <linux-kernel@vger.kernel.org>; Thu, 9 Nov 2023 02:07:09 -0800 (PST) Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1cc329ce84cso6282015ad.2 for <linux-kernel@vger.kernel.org>; Thu, 09 Nov 2023 02:07:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699524428; x=1700129228; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0ireTpCfN0lAkDpS22SoHjbEWTJUzLlFEUnZESQj8kY=; b=V+U3PVkfF5uxOrXpN8BVULqi55XRpztj0ymrjnICLVyJmKd10JQNEw0fITvjirFT0S kik+ceQR3+ctMCdte0jR42wXZWRkoVmrmRqVtcCGiAdVfi/krDrfZC9zTyL2/U0yP2EW xRwymNhHUdCT7ZuaIklIrRPeOvpXWr5Vn05ZY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699524428; x=1700129228; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0ireTpCfN0lAkDpS22SoHjbEWTJUzLlFEUnZESQj8kY=; b=HM0rBDNNaYGJP5cEwWqaXALCOuvbxQo08UwnAtAEhrYGFdnS5Jme1KtbqH51miDcEI gGdP+i3h7JCl7WjSOY6ZEUvRX+3uCNXctXrDOwzcBpE4g1mGkq16OByRELFPczjVNawx F1gQsou1fHg5zQXyv5xMHxqv/2kc/N78+SgwYp8o+6xTM/77WgcIclTDvAif3gTWz+wv bNWZWectUoXX8DDIZJzAZGSmUtj5ZJOzEDvfrVtHJD37XiA88Xz2T76dDTTABwLg0/vu HlrkVlgfhUcRaVEiEl26T+P8VKwsmBY4oefdhEv3cf+Wd2IO9uJpT4yHojqZuB3fhbQD 0Rgw== X-Gm-Message-State: AOJu0YycKy1KskkWaoxEORnAOOmN5+eMmhymx3v9vMPNyeQnpXBO1Cvn 6X4afu0YwS/D8FhLsMViO+9m2Q== X-Received: by 2002:a17:902:ecc1:b0:1cc:2ed0:5ab1 with SMTP id a1-20020a170902ecc100b001cc2ed05ab1mr5039394plh.17.1699524428617; Thu, 09 Nov 2023 02:07:08 -0800 (PST) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:6f57:d4c:468c:5daf]) by smtp.gmail.com with ESMTPSA id c13-20020a170902d48d00b001c60ba709b7sm3127511plg.125.2023.11.09.02.07.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 02:07:08 -0800 (PST) From: Chen-Yu Tsai <wenst@chromium.org> To: Rob Herring <robh+dt@kernel.org>, Frank Rowand <frowand.list@gmail.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cc: Hsin-Yi Wang <hsinyi@chromium.org>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, andriy.shevchenko@linux.intel.com, Jiri Kosina <jikos@kernel.org>, linus.walleij@linaro.org, broonie@kernel.org, gregkh@linuxfoundation.org, hdegoede@redhat.com, james.clark@arm.com, james@equiv.tech, keescook@chromium.org, petr.tesarik.ext@huawei.com, rafael@kernel.org, tglx@linutronix.de, Jeff LaBundy <jeff@labundy.com>, linux-input@vger.kernel.org, Chen-Yu Tsai <wenst@chromium.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Douglas Anderson <dianders@chromium.org>, Johan Hovold <johan@kernel.org> Subject: [RFC PATCH v2 6/7] dt-bindings: arm: mediatek: Remove SKU specific compatibles for Google Krane Date: Thu, 9 Nov 2023 18:06:03 +0800 Message-ID: <20231109100606.1245545-7-wenst@chromium.org> X-Mailer: git-send-email 2.42.0.869.gea05f2083d-goog In-Reply-To: <20231109100606.1245545-1-wenst@chromium.org> References: <20231109100606.1245545-1-wenst@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 09 Nov 2023 02:08:16 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782080609444375801 X-GMAIL-MSGID: 1782080609444375801 |
Series |
of: Introduce hardware prober driver
|
|
Commit Message
Chen-Yu Tsai
Nov. 9, 2023, 10:06 a.m. UTC
In cases where the same Chromebook model is manufactured with different
components (MIPI DSI panels, MIPI CSI camera sensors, or trackpad /
touchscreens with conflicting addresses), a different SKU ID is
allocated to each specific combination. This SKU ID is exported by the
bootloader into the device tree, and can be used to "discover" which
combination is present on the current machine. Thus we no longer have
to specify separate compatible strings for each of them.
Remove the SKU specific compatible strings for Google Krane.
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
Documentation/devicetree/bindings/arm/mediatek.yaml | 3 ---
1 file changed, 3 deletions(-)
Comments
On Thu, Nov 09, 2023 at 06:06:03PM +0800, Chen-Yu Tsai wrote: > In cases where the same Chromebook model is manufactured with different > components (MIPI DSI panels, MIPI CSI camera sensors, or trackpad / > touchscreens with conflicting addresses), a different SKU ID is > allocated to each specific combination. This SKU ID is exported by the > bootloader into the device tree, and can be used to "discover" which > combination is present on the current machine. Thus we no longer have > to specify separate compatible strings for each of them. You just broke an existing kernel with a new DT having this change. Just because you come up with a new way to do things, doesn't mean you can remove the old way. > > Remove the SKU specific compatible strings for Google Krane. > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > --- > Documentation/devicetree/bindings/arm/mediatek.yaml | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > index a4541855a838..ef3dfb286814 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > @@ -186,9 +186,6 @@ properties: > - const: mediatek,mt8183 > - description: Google Krane (Lenovo IdeaPad Duet, 10e,...) > items: > - - enum: > - - google,krane-sku0 > - - google,krane-sku176 > - const: google,krane > - const: mediatek,mt8183 > - description: Google Willow (Acer Chromebook 311 C722/C722T) > -- > 2.42.0.869.gea05f2083d-goog >
Hi, On Fri, Nov 10, 2023 at 1:04 PM Rob Herring <robh@kernel.org> wrote: > > On Thu, Nov 09, 2023 at 06:06:03PM +0800, Chen-Yu Tsai wrote: > > In cases where the same Chromebook model is manufactured with different > > components (MIPI DSI panels, MIPI CSI camera sensors, or trackpad / > > touchscreens with conflicting addresses), a different SKU ID is > > allocated to each specific combination. This SKU ID is exported by the > > bootloader into the device tree, and can be used to "discover" which > > combination is present on the current machine. Thus we no longer have > > to specify separate compatible strings for each of them. > > You just broke an existing kernel with a new DT having this change. > > Just because you come up with a new way to do things, doesn't mean you > can remove the old way. I was wondering about that, actually. My understanding was that what Chen-Yu was doing here was correct, but I'm happy to be educated. Specifically, I think that after his series old device trees will continue to boot just fine. ...so if someone took a device tree from before his series and booted it on a kernel after his series that everything would be hunky dory. If that doesn't work then, I agree, that should be fixed. However, here, he is documenting what the "latest and greatest" device tree should look at and that matches what's checked into the "dts" directory. In general, I thought that yaml files didn't necessarily always document old/deprecated ways of doing things and just focused on documenting the new/best way. Now, obviously, if someone took a new device tree and tried to put it on an old kernel then it wouldn't work, but I was always under the impression that wasn't a requirement. -Doug
diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml index a4541855a838..ef3dfb286814 100644 --- a/Documentation/devicetree/bindings/arm/mediatek.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml @@ -186,9 +186,6 @@ properties: - const: mediatek,mt8183 - description: Google Krane (Lenovo IdeaPad Duet, 10e,...) items: - - enum: - - google,krane-sku0 - - google,krane-sku176 - const: google,krane - const: mediatek,mt8183 - description: Google Willow (Acer Chromebook 311 C722/C722T)