Message ID | 20231031114728.41485-1-bagasdotme@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b90f:0:b0:403:3b70:6f57 with SMTP id t15csp174642vqg; Tue, 31 Oct 2023 04:47:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFuaj5zUtt/yugnr/Sd2AlSjZjMg85oVTVLDpO35yihi5YOOk0DDy4XXBwzSYD+Gs0lNh8K X-Received: by 2002:a17:903:41d0:b0:1cc:5273:2105 with SMTP id u16-20020a17090341d000b001cc52732105mr5879571ple.47.1698752869690; Tue, 31 Oct 2023 04:47:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698752869; cv=none; d=google.com; s=arc-20160816; b=RGcnArGqrqmoRwK6J6rAyYK/lXQNsaVJjwPEnZ5MQ2yxKfOWAM6sZdDr5Tewm+6kjG BxnBJAMJ8ILJhFv3hoY9qUTUmnxrej353MCLNWo31F2bNEW/FO9OELt5tW8s71CfGtOn ImMOEv4cBm0lunHFeDoxZZofDOGMJbxfhJlryqsH6s/2a7QJE+v/sFHWOZOc3OwZr50c UjmDVLJvyS7HBWkyx1G+GKVBtoLcZ5XUFFsWNRQsiwxAsMuUtuYP03ZlzBSE80ZDjVn/ aVBZCVpTcvtAANoqJ3d7TRrgY/QjpyZuY1Ldrhu7AEGERPQszO0OBlGXXNDm32NADci1 upIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=3C17UJiVwd6DOa03RYkc0No/IhhZUWEzgYPRcFfwfdM=; fh=tB6vVQYZ10KX+0NC/Ov42I38NsiMu8ucaMsKhBNrHWg=; b=u3gJpvfD/ehycD8V2MKMe2J9C6w4hYkKqrPVyhWxHwl5T50O/UBknK6UmHYCaEejea NoKy5Xxb8lfDKTWze/AnT5UJ2KvK4j+L6sEEfscKSOt7mNA5E3KcLxaPlFKQY/Mmjg/+ 6G6dRub/EHKmboqiRZD5zPpuPRoGoIQveJpRiByYejrk+IuEPuaik0YCvpXagCX4VyN4 BKrkEBwNuzWNkMIfXAjS+9NhfqA0wX340Po/IHDyMEJAmHBPaLIXJTe21gmPTbBUy7Qh HZYA3LKfrPWehEye4KcFc+GEoW0j+Ua8bquCkh8WH1DPzK73VklUFalTypurTWwlgDgx bpeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=EJgcO3uJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id e3-20020a170902e0c300b001b9c992945fsi866818pla.555.2023.10.31.04.47.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 04:47:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=EJgcO3uJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 393B18060C86; Tue, 31 Oct 2023 04:47:47 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344075AbjJaLrj (ORCPT <rfc822;chrisjones.unixmen@gmail.com> + 33 others); Tue, 31 Oct 2023 07:47:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344042AbjJaLrh (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 31 Oct 2023 07:47:37 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6AF991; Tue, 31 Oct 2023 04:47:35 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1cc58219376so15104295ad.1; Tue, 31 Oct 2023 04:47:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698752855; x=1699357655; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3C17UJiVwd6DOa03RYkc0No/IhhZUWEzgYPRcFfwfdM=; b=EJgcO3uJFikFayJPOBxdndx2o1Y81EMmkHIhmkF42b1a6A14uoFIhsX1oUBYNEWBt4 2iqxfqkyOo4pDcsunXaxsAxhu9Dk+Favvp8G1m8ZuW3imREFfh5UxhgQ58VA+cRIkItf UwafJ9/SdlRS5DM1XNuZa+DLktMdYkEsl7I7l3s29AzqgTQX/2RacolIIfIHOs1PrdBf wHf6W8tUQQ3EM7xZt17Q2sqxkwUYDRk0mPv9uwVd2p+sRpfEXMJjznbadfOADTnjYniX 4SMdwIMkzXJ33Z+YN7kS1/9cIUDQ8bsNZFMMsGIkC84OFdD16lSEqppIduyCBamu7yOF OCHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698752855; x=1699357655; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3C17UJiVwd6DOa03RYkc0No/IhhZUWEzgYPRcFfwfdM=; b=uKPTgG+sRhBiYhx60YHO18kOQE761hAYKOlW7NvDJ6afsqXWa0pZyejE8lQCTd8Mjk TdvKOxL2qh27E5Nu98WNJ5PxwB37AqvkI8ssDDKqtonxmYfcr6sffWBCHs+BHI63jHYh aobJcoQVXuxdO28gwSBGPGMyZJVoUG1Jpr9GxbJSuAVDsE3WMMxDIqqb3qqlPDz5AwoK pLw08DYz+qR/b6bIFowtjwCr2mrFh80zgSsrk6owKb1Uqutyz9svFSr67okwQVY2lWwZ 0wwygv8egHXF0WRVcUE5esBdr1CBqOa/E+2Pse7wi60ZxPUpP0uYnTD/7KcLlYs9JZBs p7kg== X-Gm-Message-State: AOJu0Yzs/zESH+Sj9ljfZhk/TNW7vBT5muUZap9nGBI2ZGUeEG1YlV5T TYHKAl6pUD6r1FEo58cKOLs= X-Received: by 2002:a17:903:807:b0:1cc:2a23:cbab with SMTP id kr7-20020a170903080700b001cc2a23cbabmr10730665plb.27.1698752855137; Tue, 31 Oct 2023 04:47:35 -0700 (PDT) Received: from debian.me ([103.131.18.64]) by smtp.gmail.com with ESMTPSA id b15-20020a170902d50f00b001c9b8f76a89sm1165904plg.82.2023.10.31.04.47.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 04:47:34 -0700 (PDT) Received: by debian.me (Postfix, from userid 1000) id 98CE8819BFD9; Tue, 31 Oct 2023 18:47:31 +0700 (WIB) From: Bagas Sanjaya <bagasdotme@gmail.com> To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Filesystems Development <linux-fsdevel@vger.kernel.org> Cc: Alexander Viro <viro@zeniv.linux.org.uk>, Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>, Yusong Gao <a869920004@163.com>, Bagas Sanjaya <bagasdotme@gmail.com> Subject: [PATCH] fs: Clarify "non-RCY" in access_override_creds() comment Date: Tue, 31 Oct 2023 18:47:28 +0700 Message-ID: <20231031114728.41485-1-bagasdotme@gmail.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1037; i=bagasdotme@gmail.com; h=from:subject; bh=u5ekTWI8pmEnF9ckTR+SSRBAZyiP/895cBZE6O+O9IE=; b=owGbwMvMwCX2bWenZ2ig32LG02pJDKkOL7585ZvKVbn7cL/DDeUtT30jX25+fFTS6/yK7z2yZ ibMSxQdOkpZGMS4GGTFFFkmJfI1nd5lJHKhfa0jzBxWJpAhDFycAjAR810M/+MP7PR/1MgsPqcv 4avC3T+rFKT3FTvZGS9xmsPWZFZo3sjIcLQq2dJmnUTCqYzu6P4W3TMvL6w7pWnNKb59q9VrFUE mbgA= X-Developer-Key: i=bagasdotme@gmail.com; a=openpgp; fpr=701B806FDCA5D3A58FFB8F7D7C276C64A5E44A1D Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 31 Oct 2023 04:47:47 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781271489183012569 X-GMAIL-MSGID: 1781271489183012569 |
Series |
fs: Clarify "non-RCY" in access_override_creds() comment
|
|
Commit Message
Bagas Sanjaya
Oct. 31, 2023, 11:47 a.m. UTC
The term is originally intended as a joke that stands for "non-racy".
This trips new contributors who mistake it for RCU typo [1].
Replace the term with more-explicit wording.
Link: https://lore.kernel.org/r/20231030-debatten-nachrangig-f58abcdac530@brauner/
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
fs/open.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
base-commit: 7f680e5f256f346a5d3cd83a17c84bb6bc950008
Comments
On Tue, 31 Oct 2023 18:47:28 +0700, Bagas Sanjaya wrote: > The term is originally intended as a joke that stands for "non-racy". > This trips new contributors who mistake it for RCU typo [1]. > > Replace the term with more-explicit wording. > > Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc [1/1] fs: Clarify "non-RCY" in access_override_creds() comment https://git.kernel.org/vfs/vfs/c/effa12a475e6
diff --git a/fs/open.c b/fs/open.c index 98f6601fbac65e..a89c64629aacf4 100644 --- a/fs/open.c +++ b/fs/open.c @@ -442,7 +442,8 @@ static const struct cred *access_override_creds(void) * 'get_current_cred()' function), that will clear the * non_rcu field, because now that other user may be * expecting RCU freeing. But normal thread-synchronous - * cred accesses will keep things non-RCY. + * cred accesses will keep things non-racy to avoid RCU + * freeing. */ override_cred->non_rcu = 1;