diff mbox series

[RESEND] fixp-arith: do not require users to include bug.h

Message ID Y3SgVdVey9legtX+@dc75zzyyyyyyyyyyyyydt-3.rev.dnainternet.fi
State New
Headers
Series [RESEND] fixp-arith: do not require users to include bug.h |

Commit Message

Matti Vaittinen Nov. 16, 2022, 8:33 a.m. UTC 
  The fixp_sin32_rad()() contains a call to BUG_ON(). If users of
fixp-arith.h have not included the bug.h prior including the fixp-arith.h
the compiler will not find the BUG_ON. Thus every user of fixp-arith.h
must also include bug.h (or roll own variant of BUG_ON()).

Include bug.h from fixp-arith.h so every user of fixp-arith.h does not
need to include the bug.h prior inclusion of fixp-arith.h

Fixes: 559addc25b00 ("[media] fixp-arith: replace sin/cos table by a better precision one")
Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
---

Another forgotten patch I encountered while cleaning up my local git.
Seems like this has fell through the cracks.

 include/linux/fixp-arith.h | 1 +
 1 file changed, 1 insertion(+)


base-commit: 094226ad94f471a9f19e8f8e7140a09c2625abaa

Comments

Dmitry Torokhov Nov. 16, 2022, 11:54 p.m. UTC | #1 
On Wed, Nov 16, 2022 at 10:33:25AM +0200, Matti Vaittinen wrote:
> The fixp_sin32_rad()() contains a call to BUG_ON(). If users of
> fixp-arith.h have not included the bug.h prior including the fixp-arith.h
> the compiler will not find the BUG_ON. Thus every user of fixp-arith.h
> must also include bug.h (or roll own variant of BUG_ON()).
> 
> Include bug.h from fixp-arith.h so every user of fixp-arith.h does not
> need to include the bug.h prior inclusion of fixp-arith.h
> 
> Fixes: 559addc25b00 ("[media] fixp-arith: replace sin/cos table by a better precision one")
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>

Applied, thank you.
diff mbox series

Patch

diff --git a/include/linux/fixp-arith.h b/include/linux/fixp-arith.h
index 281cb4f83dbe..e485fb0c1201 100644
--- a/include/linux/fixp-arith.h
+++ b/include/linux/fixp-arith.h
@@ -2,6 +2,7 @@ 
 #ifndef _FIXP_ARITH_H
 #define _FIXP_ARITH_H
 
+#include <linux/bug.h>
 #include <linux/math64.h>
 
 /*