[GIT,PULL] gfs2 fixes

  Hi Linus,

please consider pulling the following gfs2 fixes.

Thank you very much,
Andreas

The following changes since commit a49d273e579615ed63d0347f94075dd22b9458a3:

  Merge tag 'gfs2-v6.6-rc1-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2 (2023-09-18 11:59:38 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v6.6-rc2-fixes

for you to fetch changes up to 0cdc6f44e9fdc2d20d720145bf99a39f611f6d61:

  gfs2: don't withdraw if init_threads() got interrupted (2023-11-06 01:51:26 +0100)

----------------------------------------------------------------
gfs2 fixes

- Don't update inode timestamps for direct writes (performance regression fix).

- Skip no-op quota records instead of panicing.

- Fix a RCU race in gfs2_permission().

- Various other smaller fixes and cleanups all over the place.

----------------------------------------------------------------
Al Viro (1):
      gfs2: fix an oops in gfs2_permission

Amir Goldstein (1):
      gfs2: fs: derive f_fsid from s_uuid

Andreas Gruenbacher (19):
      gfs2: Simplify function gfs2_upgrade_iopen_glock
      gfs2: Remove freeze_go_demote_ok
      gfs2: Remove unused gfs2_extent_length argument
      gfs2: Get rid of the gfs2_glock_is_held_* helpers
      gfs2: Don't update inode timestamps for direct writes
      gfs2: setattr_chown: Add missing initialization
      gfs2: Stop using GFS2_BASIC_BLOCK and GFS2_BASIC_BLOCK_SHIFT
      gfs2: Two quota=account mode fixes
      gfs2: Clean up gfs2_alloc_parms initializers
      gfs2: Clean up quota.c:print_message
      gfs2: Add metapath_dibh helper
      gfs2: Get rid of gfs2_alloc_blocks generation parameter
      gfs2: Minor gfs2_write_jdata_batch PAGE_SIZE cleanup
      gfs2: Convert stuffed_readpage to folios
      gfs2: Convert gfs2_internal_read to folios
      gfs2: Rename gfs2_lookup_{ simple => meta }
      gfs2: No longer use 'extern' in function declarations
      gfs2: Silence "suspicious RCU usage in gfs2_permission" warning
      gfs2: don't withdraw if init_threads() got interrupted

Bob Peterson (1):
      gfs2: ignore negated quota changes

Juntong Deng (1):
      gfs2: Fix slab-use-after-free in gfs2_qd_dealloc

Su Hui (1):
      gfs2: remove dead code in add_to_queue

 fs/gfs2/acl.h        |   8 ++--
 fs/gfs2/aops.c       |  72 ++++++++++++++++----------------
 fs/gfs2/aops.h       |   6 +--
 fs/gfs2/bmap.c       |  17 +++++---
 fs/gfs2/bmap.h       |  38 ++++++++---------
 fs/gfs2/dir.c        |   2 +-
 fs/gfs2/dir.h        |  38 ++++++++---------
 fs/gfs2/file.c       |  18 +++++---
 fs/gfs2/glock.c      |   1 -
 fs/gfs2/glock.h      | 113 ++++++++++++++++++++++-----------------------------
 fs/gfs2/glops.c      |  13 ------
 fs/gfs2/glops.h      |   4 +-
 fs/gfs2/incore.h     |   2 +-
 fs/gfs2/inode.c      |  33 +++++++++------
 fs/gfs2/inode.h      |  60 +++++++++++++--------------
 fs/gfs2/log.h        |  46 ++++++++++-----------
 fs/gfs2/lops.h       |  22 +++++-----
 fs/gfs2/meta_io.h    |  20 ++++-----
 fs/gfs2/ops_fstype.c |  28 ++++++-------
 fs/gfs2/quota.c      |  31 +++++++++-----
 fs/gfs2/quota.h      |  38 ++++++++---------
 fs/gfs2/recovery.h   |  18 ++++----
 fs/gfs2/rgrp.c       |  12 +++---
 fs/gfs2/rgrp.h       |  85 +++++++++++++++++++-------------------
 fs/gfs2/super.c      |  29 +++++--------
 fs/gfs2/super.h      |  50 +++++++++++------------
 fs/gfs2/trans.h      |  24 +++++------
 fs/gfs2/util.h       |   8 ++--
 fs/gfs2/xattr.c      |   6 +--
 fs/gfs2/xattr.h      |  12 +++---
 30 files changed, 421 insertions(+), 433 deletions(-)
  

On Tue, 7 Nov 2023 at 06:22, Andreas Gruenbacher <agruenba@redhat.com> wrote:
>
> please consider pulling the following gfs2 fixes.

You are officially on my shit-list for

 (a) claiming it's fixes

 (b) apparently lying about that fact to make it appear that it's ok
that this wasn't in linux-next and was committed within the last few
days

about half of the commits in that pull request are very recent,
weren't in linux-next when the merge window started, and while a
couple of of them are fixes, most of them are just minor cleanups.

DON'T LIE ABOUT THINGS. It only annoys the hell out of me when I
notice that somebody was trying to pull wool over my eyes.

I've pulled this and I'll let it be (because I already merged other
stuff on top), but dammit, just be honest about what happened, don't
try to claim this is somehow "fixes" and thus ok to not have gone
through linux-next.

Or, better yet, get your ducks actually lined up before the merge window.

                        Linus
  

The pull request you sent on Tue,  7 Nov 2023 15:21:53 +0100:

> git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v6.6-rc2-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/1a0507d8780e2902c4c17c5a4c45d298bd7048af

Thank you!
  

Am Di., 7. Nov. 2023 um 21:31 Uhr schrieb Linus Torvalds
<torvalds@linux-foundation.org>:
> On Tue, 7 Nov 2023 at 06:22, Andreas Gruenbacher <agruenba@redhat.com> wrote:
> >
> > please consider pulling the following gfs2 fixes.
>
> You are officially on my shit-list for
>
>  (a) claiming it's fixes
>
>  (b) apparently lying about that fact to make it appear that it's ok
> that this wasn't in linux-next and was committed within the last few
> days
>
> about half of the commits in that pull request are very recent,
> weren't in linux-next when the merge window started, and while a
> couple of of them are fixes, most of them are just minor cleanups.
>
> DON'T LIE ABOUT THINGS. It only annoys the hell out of me when I
> notice that somebody was trying to pull wool over my eyes.

I apologize for referring to the entire set of commits as fixes when
it's really fixes and various other things. I've said so in the tag
description, but I realize now that that's not good enough. Lying
about what those commits are wasn't my intention though.

And I apologize for the last -minute changes. There is one commit that
removes a single line of dead code which could easily have waited. The
rest are fixes, but they should have been completed much sooner.
That's entirely my fault.

> I've pulled this and I'll let it be (because I already merged other
> stuff on top), but dammit, just be honest about what happened, don't
> try to claim this is somehow "fixes" and thus ok to not have gone
> through linux-next.
>
> Or, better yet, get your ducks actually lined up before the merge window.
>
>                         Linus

Thanks,
Andreas
  

On Tue, 7 Nov 2023 at 14:18, Andreas Grünbacher
<andreas.gruenbacher@gmail.com> wrote:
>
> I apologize for referring to the entire set of commits as fixes when
> it's really fixes and various other things. I've said so in the tag
> description, but I realize now that that's not good enough. Lying
> about what those commits are wasn't my intention though.

.. and hey, sorry about my outburst.

Your pull request was the first one this merge window where I reacted
to how many of the commits weren't in my copy of the linux-next tree,
and there wasn't any reason why in the description. So I reacted very
strongly.

It didn't help that I had a headache. Rather than look at how many
other of the pending pull requests I have that ended up coming in in
the last 24 hours have the same issue, I decided to lie down in a dark
room for a few hours.

                  Linus