diff mbox series

RISC-V: Use stdint-gcc.h in rvv testsuite

Message ID 20231107094519.1822582-1-christoph.muellner@vrull.eu
State Unresolved
Headers
Series RISC-V: Use stdint-gcc.h in rvv testsuite |

Checks

Context Check Description
snail/gcc-patch-check warning Git am fail log

Commit Message

Christoph Müllner Nov. 7, 2023, 9:45 a.m. UTC 
  From: Christoph Müllner <christoph.muellner@vrull.eu>

stdint.h can be replaced with stdint-gcc.h to resolve some missing
system headers in non-multilib installations.

gcc/testsuite/ChangeLog:

	* gcc.target/riscv/xtheadmemidx-helpers.h:
	Replace stdint.h with stdint-gcc.h.

Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
---
 gcc/testsuite/gcc.target/riscv/xtheadmemidx-helpers.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kito Cheng Nov. 7, 2023, 10:16 a.m. UTC | #1 
LGTM, but title is little bit misleading, it's not really related to rvv,
change to either RISC-V or T-head is fine, anyway, you can commit without
send v2 :)

Christoph Muellner <christoph.muellner@vrull.eu> 於 2023年11月7日 週二 17:45 寫道：

> From: Christoph Müllner <christoph.muellner@vrull.eu>
>
> stdint.h can be replaced with stdint-gcc.h to resolve some missing
> system headers in non-multilib installations.
>
> gcc/testsuite/ChangeLog:
>
>         * gcc.target/riscv/xtheadmemidx-helpers.h:
>         Replace stdint.h with stdint-gcc.h.
>
> Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
> ---
>  gcc/testsuite/gcc.target/riscv/xtheadmemidx-helpers.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.target/riscv/xtheadmemidx-helpers.h
> b/gcc/testsuite/gcc.target/riscv/xtheadmemidx-helpers.h
> index a97f08c5cc1..9d8ce124a93 100644
> --- a/gcc/testsuite/gcc.target/riscv/xtheadmemidx-helpers.h
> +++ b/gcc/testsuite/gcc.target/riscv/xtheadmemidx-helpers.h
> @@ -1,7 +1,7 @@
>  #ifndef XTHEADMEMIDX_HELPERS_H
>  #define XTHEADMEMIDX_HELPERS_H
>
> -#include <stdint.h>
> +#include <stdint-gcc.h>
>
>  #define intX_t long
>  #define uintX_t unsigned long
> --
> 2.41.0
>
>
Christoph Müllner Nov. 7, 2023, 10:47 a.m. UTC | #2 
On Tue, Nov 7, 2023 at 11:16 AM Kito Cheng <kito.cheng@sifive.com> wrote:
>
> LGTM, but title is little bit misleading, it's not really related to rvv, change to either RISC-V or T-head is fine, anyway, you can commit without send v2 :)

Fixed and pushed.

Thanks!

>
> Christoph Muellner <christoph.muellner@vrull.eu> 於 2023年11月7日 週二 17:45 寫道：
>>
>> From: Christoph Müllner <christoph.muellner@vrull.eu>
>>
>> stdint.h can be replaced with stdint-gcc.h to resolve some missing
>> system headers in non-multilib installations.
>>
>> gcc/testsuite/ChangeLog:
>>
>>         * gcc.target/riscv/xtheadmemidx-helpers.h:
>>         Replace stdint.h with stdint-gcc.h.
>>
>> Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
>> ---
>>  gcc/testsuite/gcc.target/riscv/xtheadmemidx-helpers.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gcc/testsuite/gcc.target/riscv/xtheadmemidx-helpers.h b/gcc/testsuite/gcc.target/riscv/xtheadmemidx-helpers.h
>> index a97f08c5cc1..9d8ce124a93 100644
>> --- a/gcc/testsuite/gcc.target/riscv/xtheadmemidx-helpers.h
>> +++ b/gcc/testsuite/gcc.target/riscv/xtheadmemidx-helpers.h
>> @@ -1,7 +1,7 @@
>>  #ifndef XTHEADMEMIDX_HELPERS_H
>>  #define XTHEADMEMIDX_HELPERS_H
>>
>> -#include <stdint.h>
>> +#include <stdint-gcc.h>
>>
>>  #define intX_t long
>>  #define uintX_t unsigned long
>> --
>> 2.41.0
>>
Palmer Dabbelt Nov. 7, 2023, 5:41 p.m. UTC | #3 
On Tue, 07 Nov 2023 01:45:19 PST (-0800), christoph.muellner@vrull.eu wrote:
> From: Christoph Müllner <christoph.muellner@vrull.eu>
>
> stdint.h can be replaced with stdint-gcc.h to resolve some missing
> system headers in non-multilib installations.
>
> gcc/testsuite/ChangeLog:
>
> 	* gcc.target/riscv/xtheadmemidx-helpers.h:
> 	Replace stdint.h with stdint-gcc.h.
>
> Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
> ---
>  gcc/testsuite/gcc.target/riscv/xtheadmemidx-helpers.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.target/riscv/xtheadmemidx-helpers.h b/gcc/testsuite/gcc.target/riscv/xtheadmemidx-helpers.h
> index a97f08c5cc1..9d8ce124a93 100644
> --- a/gcc/testsuite/gcc.target/riscv/xtheadmemidx-helpers.h
> +++ b/gcc/testsuite/gcc.target/riscv/xtheadmemidx-helpers.h
> @@ -1,7 +1,7 @@
>  #ifndef XTHEADMEMIDX_HELPERS_H
>  #define XTHEADMEMIDX_HELPERS_H
>
> -#include <stdint.h>
> +#include <stdint-gcc.h>
>
>  #define intX_t long
>  #define uintX_t unsigned long


Presumably this still passes the tests?  If so it LGTM so

Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>

Thanks!
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.target/riscv/xtheadmemidx-helpers.h b/gcc/testsuite/gcc.target/riscv/xtheadmemidx-helpers.h
index a97f08c5cc1..9d8ce124a93 100644
--- a/gcc/testsuite/gcc.target/riscv/xtheadmemidx-helpers.h
+++ b/gcc/testsuite/gcc.target/riscv/xtheadmemidx-helpers.h
@@ -1,7 +1,7 @@ 
 #ifndef XTHEADMEMIDX_HELPERS_H
 #define XTHEADMEMIDX_HELPERS_H
 
-#include <stdint.h>
+#include <stdint-gcc.h>
 
 #define intX_t long
 #define uintX_t unsigned long