Message ID | 20231107160122.1648093-1-hugo@hugovil.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:aa0b:0:b0:403:3b70:6f57 with SMTP id k11csp338935vqo; Tue, 7 Nov 2023 08:10:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IHiFuE53KOFX95z4tZ4+ITMcd5R3I9zHnFnBPGkgqyXrWazZ34mYoSFOCfl2IO+V3YIAaWZ X-Received: by 2002:a17:902:f812:b0:1c0:afda:7707 with SMTP id ix18-20020a170902f81200b001c0afda7707mr3524417plb.34.1699373429438; Tue, 07 Nov 2023 08:10:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699373429; cv=none; d=google.com; s=arc-20160816; b=bQF1UBa2xtY01QE9NuH8mwZke9QjylVNmBU6G9C4Bd/Zb20JWigPrywHzDMaEfnfI0 SUjNlgzQK/i2NF6PGIxhqoyEPBVjdpY57AMPPmdmG/seyYP2VgjFMd3wBxXIPtJW3XMA SU6eWg+CEx6nMrluYlTspt6I5cA6/8yUeE7MRu0Llq1HJ82qa4Uf0ocq7W5gPW1cUWE5 7uQLYRuqvao23REEfKmEES48qf1c+ZlauflPvEmbWxV1fhXwDvEVTDsNHqaY0l64IEYS MX9DgLTq/gNCsH6Er/yoDvZF4qDn8UfC7RYJ5zJbDNK95pHmgVLoQpuBiHPPRSezmBoJ TvJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :message-id:date:cc:to:from:dkim-signature; bh=xGRenfqQZdi2lQn1cViqb8siKduR9EzX8BshZ0vUjaM=; fh=X6r1Bea5hzS19+N13jbqbcZvZbdfvOXu8EPn1uBO7NY=; b=es0KSA4FFQvTkedaOYl3/qromOAxFN3+32L4qmlQT02byI7LrdGMn2EHwN5bj6Cd2O gSzBX4iwLVfrHY+kWMnxaNBC7CF3ZVNYnOyTp1B3tsy0MktMmtxJ0AQ1vcj2cn8O3BFl xIR8+it9qP1nC+kqrvXuIsqHqDgf5G6h6J3GHuhPOOoPGfXqC/qA4c0ONsLHXX+Bq1P6 F76nYGc2He41yBEvCGXsol34cg1gTzyV3i1iD4643xz0lshXb/sJEAvm8Mu4dL2/PT+r lF1/TtujdM6zJNLzQNiSPR8SEkHU/yWdGnH85/Qes3GbvpyXF9za//w5ta904vK72rXf JD/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@hugovil.com header.s=x header.b=SVNFB5hd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id r9-20020a1709028bc900b001c5fd2a28desi47698plo.222.2023.11.07.08.10.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Nov 2023 08:10:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@hugovil.com header.s=x header.b=SVNFB5hd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 8489D83187A1; Tue, 7 Nov 2023 08:10:28 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344338AbjKGQKY (ORCPT <rfc822;lhua1029@gmail.com> + 32 others); Tue, 7 Nov 2023 11:10:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344987AbjKGQJb (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 7 Nov 2023 11:09:31 -0500 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B285D2BBCE; Tue, 7 Nov 2023 08:01:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Cc:To :From:subject:date:message-id:reply-to; bh=xGRenfqQZdi2lQn1cViqb8siKduR9EzX8BshZ0vUjaM=; b=SVNFB5hdMjgsNycHzMQD7ahyNc txV6przMnRMbx9KJk/GVy+uO0h0rRjl6P7fVRT8IwCE6mTccdilG376b8ilPXUue0/Z0ba15VeKWV DSwxKfyD1f46xuUKfv1lMrC/cxXZxc7YlrewOo+ToZQERzccdLobEoQtmy2s+rQ7gSds=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:35618 helo=pettiford.lan) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from <hugo@hugovil.com>) id 1r0OW4-0007eo-A3; Tue, 07 Nov 2023 11:01:24 -0500 From: Hugo Villeneuve <hugo@hugovil.com> To: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com> Cc: hugo@hugovil.com, Hugo Villeneuve <hvilleneuve@dimonoff.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Tue, 7 Nov 2023 11:01:22 -0500 Message-Id: <20231107160122.1648093-1-hugo@hugovil.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.hugovil.com X-Spam-Level: X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Subject: [PATCH] arm64: dts: imx8mn-var-som: reorder reg properties after compatible strings X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 07 Nov 2023 08:10:28 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781922193015671378 X-GMAIL-MSGID: 1781922193015671378 |
Series |
arm64: dts: imx8mn-var-som: reorder reg properties after compatible strings
|
|
Commit Message
Hugo Villeneuve
Nov. 7, 2023, 4:01 p.m. UTC
From: Hugo Villeneuve <hvilleneuve@dimonoff.com> Move reg nodes after the compatible string, to follow DT conventions. Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> --- arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: be3ca57cfb777ad820c6659d52e60bbdd36bf5ff
Comments
On 07/11/2023 17:01, Hugo Villeneuve wrote: > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > Move reg nodes after the compatible string, to follow DT conventions. This is a bit of churn... like patches for checkpatch. But unlike checkpatch, it's not even documented. Best regards, Krzysztof
On Tue, 7 Nov 2023 17:19:20 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 07/11/2023 17:01, Hugo Villeneuve wrote: > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > > Move reg nodes after the compatible string, to follow DT conventions. > > This is a bit of churn... like patches for checkpatch. But unlike > checkpatch, it's not even documented. Hi, I do not really understand your point or if I must change something... But looking at a lot of dts, the reg property is always following the compatible string, so I assumed it was an undocumented convention or best practice... Hugo.
On 07/11/2023 17:28, Hugo Villeneuve wrote: > On Tue, 7 Nov 2023 17:19:20 +0100 > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > >> On 07/11/2023 17:01, Hugo Villeneuve wrote: >>> From: Hugo Villeneuve <hvilleneuve@dimonoff.com> >>> >>> Move reg nodes after the compatible string, to follow DT conventions. >> >> This is a bit of churn... like patches for checkpatch. But unlike >> checkpatch, it's not even documented. > > Hi, > I do not really understand your point or if I must change > something... > > But looking at a lot of dts, the reg property is always following the > compatible string, so I assumed it was an undocumented convention or > best practice... > Patches fixing only checkpatch --strict are usually welcomed only in staging. But even there no one wants to deal with one patch changing one style issue in one file. You are doing the same, outside of staging, but relying on undocumented practice. Such patches are unnecessary churn. Documenting the practice and fixing entire subsystems or groups of devices would be welcomed. Fixing line by line some style issue is just effort for maintainers. Best regards, Krzysztof
On Tue, 7 Nov 2023 17:37:44 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 07/11/2023 17:28, Hugo Villeneuve wrote: > > On Tue, 7 Nov 2023 17:19:20 +0100 > > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > > >> On 07/11/2023 17:01, Hugo Villeneuve wrote: > >>> From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > >>> > >>> Move reg nodes after the compatible string, to follow DT conventions. > >> > >> This is a bit of churn... like patches for checkpatch. But unlike > >> checkpatch, it's not even documented. > > > > Hi, > > I do not really understand your point or if I must change > > something... > > > > But looking at a lot of dts, the reg property is always following the > > compatible string, so I assumed it was an undocumented convention or > > best practice... > > > > Patches fixing only checkpatch --strict are usually welcomed only in > staging. But even there no one wants to deal with one patch changing one > style issue in one file. > > You are doing the same, outside of staging, but relying on undocumented > practice. Such patches are unnecessary churn. Documenting the practice > and fixing entire subsystems or groups of devices would be welcomed. > Fixing line by line some style issue is just effort for maintainers. Hi, ok, now it is more clear. I tried to search in Documentation/ or the web for DT conventions/best practices, but couldn't find anything relevant, apart from "use YAML coding style"... Maybe it would be a good thing to add a document for DT best practices eventually... Thank you, Hugo.
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi index b8946edf317b..9124476500f8 100644 --- a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi @@ -60,8 +60,8 @@ &ecspi1 { /* Resistive touch controller */ touchscreen@0 { - reg = <0>; compatible = "ti,ads7846"; + reg = <0>; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_restouch>; interrupt-parent = <&gpio1>; @@ -292,8 +292,8 @@ &usdhc1 { status = "okay"; brcmf: bcrmf@1 { - reg = <1>; compatible = "brcm,bcm4329-fmac"; + reg = <1>; }; };