Message ID | 20231105-nolibc-align-v1-1-5bfc542cb6ee@weissschuh.net |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp2147418vqu; Sun, 5 Nov 2023 06:22:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IET1w8dvpEkslIYtgIo3/O6XGZTZxYZwJfx5oXQMPOy3NrVr9/24iHLPzJDiECq9797nTCS X-Received: by 2002:a05:6a20:8f1f:b0:174:af85:9626 with SMTP id b31-20020a056a208f1f00b00174af859626mr25064010pzk.11.1699194176932; Sun, 05 Nov 2023 06:22:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699194176; cv=none; d=google.com; s=arc-20160816; b=iTiRYs6ex5pwRFI3dY+AyE+rCIcHin62aZzXJGOgIJR/3CzR2ug5a+yt43YdVndr7v 78csEt6YVOxnMfnlB1ybfmMTIYaJ80zNP1Oy7+YGgivjODLlOR6EQw3UuCOC+nGMUhiv E3I7o3pJ5L2qlidORj+hKgtdaT/AMSN4W3zh4CaNSfxZfVPrEuBU5vl82hSrIlVWna4g gaQEWHHreI8Lan87QBOs+u2lJoKQRB5etLv2j1m9fKNr21E7lEiDgfjb09FJrhxDDUwX 8+IVjyzIvHrVbyNVRWwbtREpYQ3bCRmhFybZY27jzgmulb0YQLpqdivDkXWF8AZwKjrc Kk1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=hVgl/i8+jNil9grFBvA0tKgsz2cc5W9evhKIzM4lTHk=; fh=lrawtlvYUyTnD3YboMckJjmalpw48Rm60lz21Jj4CJE=; b=uIHTB9ZqvqmgnnSm1bdbuYERa3MvG8Up2T7XO50dEPmr6h9p+MXNeeNuxBBVg1PCa6 mdCMB35vpFy4FCD0DQmZC3QnLdK6ZEUN2UB0YrqjzeWQPfYiJFZbUBa4ltUkI9/e0akb +5dZ74gJ3xpbuSkQpQyRCuoJkvfFHxGr53zBaWJ47h8Av/2axh+neOPzS7Thm0PG0oxb 6CFqztpTXAOU/Gnx7RaUtBGUU+Yr+i/hqnQPpO6oXx6FOIVyiitWzeTeoKd8zqn+eip8 qASibd7xn3HIhLqrORJeki3rt6t2siDxo+zDOIKGdpMiKRl42Cd93UFEC4FC3Xye8E8t oqCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@weissschuh.net header.s=mail header.b=YUBKJcLH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id jx7-20020a170903138700b001ca7a4c8360si5747014plb.31.2023.11.05.06.22.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Nov 2023 06:22:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@weissschuh.net header.s=mail header.b=YUBKJcLH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 3281E80AEB07; Sun, 5 Nov 2023 06:22:52 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229983AbjKEOWj (ORCPT <rfc822;heyuhang3455@gmail.com> + 34 others); Sun, 5 Nov 2023 09:22:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229939AbjKEOWh (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 5 Nov 2023 09:22:37 -0500 Received: from todd.t-8ch.de (todd.t-8ch.de [IPv6:2a01:4f8:c010:41de::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57AE6D9; Sun, 5 Nov 2023 06:22:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1699194152; bh=FhnRHVVe+PHf+ugZHAO2JXY1kUkT30VNjI8oHcu7ofI=; h=From:Date:Subject:To:Cc:From; b=YUBKJcLHqXU2ru+rtoKJxlq5qZmu11rDpDlc6so4DqTFycyLQPp+tV4eeT4b3adUr gTEkDRAayn0i6DRitO9TRjHNNX/0c9s60VswSGwK5wYA4ZL3eJKEIqkSkY6GDX9RVa Bu6LW67WSauno+GM1f7ujnrO4DdlNXaac4RckWfg= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net> Date: Sun, 05 Nov 2023 15:22:30 +0100 Subject: [PATCH] selftests/nolibc: fix testcase status alignment MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20231105-nolibc-align-v1-1-5bfc542cb6ee@weissschuh.net> X-B4-Tracking: v=1; b=H4sIACWlR2UC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDI2NDQwNT3bz8nMykZN3EnMz0PF1zU0tLo6SUtDRTExMloJaCotS0zAqwcdG xtbUAXDeqqF4AAAA= To: Willy Tarreau <w@1wt.eu>, Shuah Khan <shuah@kernel.org> Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net> X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1699194151; l=2095; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=FhnRHVVe+PHf+ugZHAO2JXY1kUkT30VNjI8oHcu7ofI=; b=mdM3igfqOhDiyq9aAsX9NxePvbRBJPTaK5DAcDpvpQdAAEgJTxRpIWCr3/x867hlU0Wk2+Qhm FlGM/Hz72RzBFUuzYLzYw7S+JIqJgGEVUjfIGN8eDv3tAYW+9bM0Hn5 X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 05 Nov 2023 06:22:52 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781734233254779001 X-GMAIL-MSGID: 1781734233254779001 |
Series |
selftests/nolibc: fix testcase status alignment
|
|
Commit Message
Thomas Weißschuh
Nov. 5, 2023, 2:22 p.m. UTC
Center-align all possible status reports.
Before OK and FAIL were center-aligned in relation to each other but
SKIPPED and FAILED would be left-aligned.
Before:
7 environ_addr = <0x7fffef3e7c50> [OK]
8 environ_envp = <0x7fffef3e7c58> [FAIL]
9 environ_auxv [SKIPPED]
10 environ_total [SKIPPED]
11 environ_HOME = <0x7fffef3e99bd> [OK]
12 auxv_addr [SKIPPED]
13 auxv_AT_UID = 1000 [OK]
After:
7 environ_addr = <0x7ffff13b00a0> [OK]
8 environ_envp = <0x7ffff13b00a8> [FAIL]
9 environ_auxv [SKIPPED]
10 environ_total [SKIPPED]
11 environ_HOME = <0x7ffff13b19bd> [OK]
12 auxv_addr [SKIPPED]
13 auxv_AT_UID = 1000 [OK]
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
tools/testing/selftests/nolibc/nolibc-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
---
base-commit: 6de6466e41182875252fe09658f9b7d74c4fa43c
change-id: 20231105-nolibc-align-75992bdff544
Best regards,
Comments
On Sun, Nov 05, 2023 at 03:22:30PM +0100, Thomas Weißschuh wrote: > Center-align all possible status reports. > Before OK and FAIL were center-aligned in relation to each other but > SKIPPED and FAILED would be left-aligned. > > Before: > > 7 environ_addr = <0x7fffef3e7c50> [OK] > 8 environ_envp = <0x7fffef3e7c58> [FAIL] > 9 environ_auxv [SKIPPED] > 10 environ_total [SKIPPED] > 11 environ_HOME = <0x7fffef3e99bd> [OK] > 12 auxv_addr [SKIPPED] > 13 auxv_AT_UID = 1000 [OK] > > After: > > 7 environ_addr = <0x7ffff13b00a0> [OK] > 8 environ_envp = <0x7ffff13b00a8> [FAIL] > 9 environ_auxv [SKIPPED] > 10 environ_total [SKIPPED] > 11 environ_HOME = <0x7ffff13b19bd> [OK] > 12 auxv_addr [SKIPPED] > 13 auxv_AT_UID = 1000 [OK] > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> Quite frankly for trivial cleanups like this you should not even bother with sending a review, and could queue them directly! Thanks, Willy
On 2023-11-05 15:27:00+0100, Willy Tarreau wrote: > On Sun, Nov 05, 2023 at 03:22:30PM +0100, Thomas Weißschuh wrote: > > Center-align all possible status reports. > > Before OK and FAIL were center-aligned in relation to each other but > > SKIPPED and FAILED would be left-aligned. > > > > Before: > > > > 7 environ_addr = <0x7fffef3e7c50> [OK] > > 8 environ_envp = <0x7fffef3e7c58> [FAIL] > > 9 environ_auxv [SKIPPED] > > 10 environ_total [SKIPPED] > > 11 environ_HOME = <0x7fffef3e99bd> [OK] > > 12 auxv_addr [SKIPPED] > > 13 auxv_AT_UID = 1000 [OK] > > > > After: > > > > 7 environ_addr = <0x7ffff13b00a0> [OK] > > 8 environ_envp = <0x7ffff13b00a8> [FAIL] > > 9 environ_auxv [SKIPPED] > > 10 environ_total [SKIPPED] > > 11 environ_HOME = <0x7ffff13b19bd> [OK] > > 12 auxv_addr [SKIPPED] > > 13 auxv_AT_UID = 1000 [OK] > > > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> > > Quite frankly for trivial cleanups like this you should not even bother > with sending a review, and could queue them directly! Ok, will do! Thomas
diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c index 2f10541e6f38..e173014f6b66 100644 --- a/tools/testing/selftests/nolibc/nolibc-test.c +++ b/tools/testing/selftests/nolibc/nolibc-test.c @@ -150,11 +150,11 @@ static void result(int llen, enum RESULT r) const char *msg; if (r == OK) - msg = " [OK]"; + msg = " [OK]"; else if (r == SKIPPED) msg = "[SKIPPED]"; else - msg = "[FAIL]"; + msg = " [FAIL]"; if (llen < 64) putcharn(' ', 64 - llen);