[v8,1/6] dt-bindings: remoteproc: Add PRU consumer bindings
Commit Message
From: Suman Anna <s-anna@ti.com>
Add DT schema binding for PRU consumers. The binding includes
all the common properties that can be used by different PRU consumer
or application nodes and supported by the PRU remoteproc driver.
These are used to configure the PRU hardware for specific user
applications.
The application nodes themselves should define their own bindings.
Co-developed-by: Tero Kristo <t-kristo@ti.com>
Co-developed-by: Suman Anna <s-anna@ti.com>
Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
Co-developed-by: Puranjay Mohan <p-mohan@ti.com>
Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
.../bindings/remoteproc/ti,pru-consumer.yaml | 60 +++++++++++++++++++
1 file changed, 60 insertions(+)
create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml
Comments
On Wed, Nov 16, 2022 at 05:46:29PM +0530, MD Danish Anwar wrote:
> From: Suman Anna <s-anna@ti.com>
>
> Add DT schema binding for PRU consumers. The binding includes
> all the common properties that can be used by different PRU consumer
> or application nodes and supported by the PRU remoteproc driver.
> These are used to configure the PRU hardware for specific user
> applications.
>
> The application nodes themselves should define their own bindings.
>
> Co-developed-by: Tero Kristo <t-kristo@ti.com>
> Co-developed-by: Suman Anna <s-anna@ti.com>
> Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
> Co-developed-by: Puranjay Mohan <p-mohan@ti.com>
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
Run checkpatch.pl and fix the warnings with the tags.
You didn't add review/ack tags either.
> ---
> .../bindings/remoteproc/ti,pru-consumer.yaml | 60 +++++++++++++++++++
> 1 file changed, 60 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml
On Wed, Nov 16, 2022 at 10:09:48AM -0600, Rob Herring wrote:
> On Wed, Nov 16, 2022 at 05:46:29PM +0530, MD Danish Anwar wrote:
> > From: Suman Anna <s-anna@ti.com>
> >
> > Add DT schema binding for PRU consumers. The binding includes
> > all the common properties that can be used by different PRU consumer
> > or application nodes and supported by the PRU remoteproc driver.
> > These are used to configure the PRU hardware for specific user
> > applications.
> >
> > The application nodes themselves should define their own bindings.
> >
> > Co-developed-by: Tero Kristo <t-kristo@ti.com>
> > Co-developed-by: Suman Anna <s-anna@ti.com>
> > Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
> > Co-developed-by: Puranjay Mohan <p-mohan@ti.com>
> > Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>
> Run checkpatch.pl and fix the warnings with the tags.
My bad - I asked Danish to remove the SoBs to lighten the changelog
presentation. Danish, do you absolutely need to list everyone that touched that
patchset? If so I suppose just listing the SoBs would be a compromise.
>
> You didn't add review/ack tags either.
Those are important.
Please send another patchset that clears checkpatch with review/acks and I'll
look at it.
Thanks,
Mathieu
>
> > ---
> > .../bindings/remoteproc/ti,pru-consumer.yaml | 60 +++++++++++++++++++
> > 1 file changed, 60 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml
Hi Mathieu,
On 16/11/22 23:39, Mathieu Poirier wrote:
> On Wed, Nov 16, 2022 at 10:09:48AM -0600, Rob Herring wrote:
>> On Wed, Nov 16, 2022 at 05:46:29PM +0530, MD Danish Anwar wrote:
>>> From: Suman Anna <s-anna@ti.com>
>>>
>>> Add DT schema binding for PRU consumers. The binding includes
>>> all the common properties that can be used by different PRU consumer
>>> or application nodes and supported by the PRU remoteproc driver.
>>> These are used to configure the PRU hardware for specific user
>>> applications.
>>>
>>> The application nodes themselves should define their own bindings.
>>>
>>> Co-developed-by: Tero Kristo <t-kristo@ti.com>
>>> Co-developed-by: Suman Anna <s-anna@ti.com>
>>> Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
>>> Co-developed-by: Puranjay Mohan <p-mohan@ti.com>
>>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>>
>> Run checkpatch.pl and fix the warnings with the tags.
>
> My bad - I asked Danish to remove the SoBs to lighten the changelog
> presentation. Danish, do you absolutely need to list everyone that touched that
> patchset? If so I suppose just listing the SoBs would be a compromise.
>
I started working on this patch series after version 5. In the first version of
this patch series below were the tags.
Co-developed-by: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Suman Anna <s-anna@ti.com>
Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
I am not sure whom to drop and whom to keep that's why I have been keeping all
the tags that were present from the beginning.
In the next version I'll keep only the SoBs tags of the the people listed above.
>>
>> You didn't add review/ack tags either.
>
> Those are important.
>
> Please send another patchset that clears checkpatch with review/acks and I'll
> look at it.
>
I am really sorry for that, I was not aware about adding review tags as I am
very new to upstreaming.
I will share new version after fixing checkpatch errors/warnings and adding
review tags.
Thanks,
Danish.
> Thanks,
> Mathieu
>
>>
>>> ---
>>> .../bindings/remoteproc/ti,pru-consumer.yaml | 60 +++++++++++++++++++
>>> 1 file changed, 60 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml
On Thu, 17 Nov 2022 at 22:49, Md Danish Anwar <a0501179@ti.com> wrote:
>
> Hi Mathieu,
>
> On 16/11/22 23:39, Mathieu Poirier wrote:
> > On Wed, Nov 16, 2022 at 10:09:48AM -0600, Rob Herring wrote:
> >> On Wed, Nov 16, 2022 at 05:46:29PM +0530, MD Danish Anwar wrote:
> >>> From: Suman Anna <s-anna@ti.com>
> >>>
> >>> Add DT schema binding for PRU consumers. The binding includes
> >>> all the common properties that can be used by different PRU consumer
> >>> or application nodes and supported by the PRU remoteproc driver.
> >>> These are used to configure the PRU hardware for specific user
> >>> applications.
> >>>
> >>> The application nodes themselves should define their own bindings.
> >>>
> >>> Co-developed-by: Tero Kristo <t-kristo@ti.com>
> >>> Co-developed-by: Suman Anna <s-anna@ti.com>
> >>> Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
> >>> Co-developed-by: Puranjay Mohan <p-mohan@ti.com>
> >>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> >>
> >> Run checkpatch.pl and fix the warnings with the tags.
> >
> > My bad - I asked Danish to remove the SoBs to lighten the changelog
> > presentation. Danish, do you absolutely need to list everyone that touched that
> > patchset? If so I suppose just listing the SoBs would be a compromise.
> >
>
> I started working on this patch series after version 5. In the first version of
> this patch series below were the tags.
>
> Co-developed-by: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Suman Anna <s-anna@ti.com>
> Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
> Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
>
> I am not sure whom to drop and whom to keep that's why I have been keeping all
> the tags that were present from the beginning.
>
> In the next version I'll keep only the SoBs tags of the the people listed above.
>
> >>
> >> You didn't add review/ack tags either.
> >
> > Those are important.
> >
> > Please send another patchset that clears checkpatch with review/acks and I'll
> > look at it.
> >
>
> I am really sorry for that, I was not aware about adding review tags as I am
> very new to upstreaming.
>
... and that is fine - we all learn as we go. Your new patchset is at
the top of my queue and I will review it next week.
> I will share new version after fixing checkpatch errors/warnings and adding
> review tags.
>
> Thanks,
> Danish.
>
> > Thanks,
> > Mathieu
> >
> >>
> >>> ---
> >>> .../bindings/remoteproc/ti,pru-consumer.yaml | 60 +++++++++++++++++++
> >>> 1 file changed, 60 insertions(+)
> >>> create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml
new file mode 100644
@@ -0,0 +1,60 @@
+# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/remoteproc/ti,pru-consumer.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Common TI PRU Consumer Binding
+
+maintainers:
+ - Suman Anna <s-anna@ti.com>
+
+description: |
+ A PRU application/consumer/user node typically uses one or more PRU device
+ nodes to implement a PRU application/functionality. Each application/client
+ node would need a reference to at least a PRU node, and optionally define
+ some properties needed for hardware/firmware configuration. The below
+ properties are a list of common properties supported by the PRU remoteproc
+ infrastructure.
+
+ The application nodes shall define their own bindings like regular platform
+ devices, so below are in addition to each node's bindings.
+
+properties:
+ ti,prus:
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ description: phandles to the PRU, RTU or Tx_PRU nodes used
+ minItems: 1
+ maxItems: 6
+ items:
+ maxItems: 1
+
+ firmware-name:
+ $ref: /schemas/types.yaml#/definitions/string-array
+ minItems: 1
+ maxItems: 6
+ description: |
+ firmwares for the PRU cores, the default firmware for the core from
+ the PRU node will be used if not provided. The firmware names should
+ correspond to the PRU cores listed in the 'ti,prus' property
+
+ ti,pruss-gp-mux-sel:
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ minItems: 1
+ maxItems: 6
+ items:
+ enum: [0, 1, 2, 3, 4]
+ description: |
+ array of values for the GP_MUX_SEL under PRUSS_GPCFG register for a PRU.
+ This selects the internal muxing scheme for the PRU instance. Values
+ should correspond to the PRU cores listed in the 'ti,prus' property. The
+ GP_MUX_SEL setting is a per-slice setting (one setting for PRU0, RTU0,
+ and Tx_PRU0 on K3 SoCs). Use the same value for all cores within the
+ same slice in the associative array. If the array size is smaller than
+ the size of 'ti,prus' property, the default out-of-reset value (0) for the
+ PRU core is used.
+
+required:
+ - ti,prus
+
+additionalProperties: true