diff mbox series

[v3,3/4] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE (SM-T535)

Message ID 20231025083952.12367-4-newbyte@postmarketos.org
State New
Headers
Series Add samsung-matisselte and common matisse dtsi |

Commit Message

Stefan Hansson Oct. 25, 2023, 8:37 a.m. UTC 
  Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T535) LTE tablet
based on the MSM8926 platform.

Signed-off-by: Stefan Hansson <newbyte@postmarketos.org>
---
 arch/arm/boot/dts/qcom/Makefile               |  1 +
 .../qcom/qcom-msm8926-samsung-matisselte.dts  | 36 +++++++++++++++++++
 2 files changed, 37 insertions(+)
 create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts

Comments

Konrad Dybcio Oct. 31, 2023, 11:08 a.m. UTC | #1 
On 25.10.2023 10:37, Stefan Hansson wrote:
> Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T535) LTE tablet
> based on the MSM8926 platform.
> 
> Signed-off-by: Stefan Hansson <newbyte@postmarketos.org>
> ---
>  arch/arm/boot/dts/qcom/Makefile               |  1 +
>  .../qcom/qcom-msm8926-samsung-matisselte.dts  | 36 +++++++++++++++++++
>  2 files changed, 37 insertions(+)
>  create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
> 
> diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
> index a3d293e40820..cab35eeb30f6 100644
> --- a/arch/arm/boot/dts/qcom/Makefile
> +++ b/arch/arm/boot/dts/qcom/Makefile
> @@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
>  	qcom-msm8916-samsung-serranove.dtb \
>  	qcom-msm8926-microsoft-superman-lte.dtb \
>  	qcom-msm8926-microsoft-tesla.dtb \
> +	qcom-msm8926-samsung-matisselte.dtb \
>  	qcom-msm8960-cdp.dtb \
>  	qcom-msm8960-samsung-expressatt.dtb \
>  	qcom-msm8974-lge-nexus5-hammerhead.dtb \
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
> new file mode 100644
> index 000000000000..6e25b1a74ce5
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
> @@ -0,0 +1,36 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2022, Matti Lehtimäki <matti.lehtimaki@gmail.com>
> + * Copyright (c) 2023, Stefan Hansson <newbyte@postmarketos.org>
> + */
> +
> +/dts-v1/;
> +
> +#include "qcom-msm8226-samsung-matisse-common.dtsi"
> +
> +/ {
> +	model = "Samsung Galaxy Tab 4 10.1 LTE";
> +	compatible = "samsung,matisselte", "qcom,msm8926", "qcom,msm8226";
> +	chassis-type = "tablet";
> +};
> +
> +&pm8226_l3 {
> +	regulator-max-microvolt = <1350000>;
> +};
> +
> +&pm8226_s4 {
> +	regulator-max-microvolt = <2200000>;
> +};
> +
> +&reg_tsp_3p3v {
> +	gpio = <&tlmm 32 GPIO_ACTIVE_HIGH>;
> +};
> +
> +&sdhc_2 {
> +	/* SD card fails to probe with error -110 */
> +	status = "disabled";
Can you give us some logs?

Konrad
Stefan Hansson Oct. 31, 2023, 1:52 p.m. UTC | #2 
On 2023-10-31 12:08, Konrad Dybcio wrote:
> On 25.10.2023 10:37, Stefan Hansson wrote:
>> Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T535) LTE tablet
>> based on the MSM8926 platform.
>>
>> Signed-off-by: Stefan Hansson <newbyte@postmarketos.org>
>> ---
>>   arch/arm/boot/dts/qcom/Makefile               |  1 +
>>   .../qcom/qcom-msm8926-samsung-matisselte.dts  | 36 +++++++++++++++++++
>>   2 files changed, 37 insertions(+)
>>   create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
>>
>> diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
>> index a3d293e40820..cab35eeb30f6 100644
>> --- a/arch/arm/boot/dts/qcom/Makefile
>> +++ b/arch/arm/boot/dts/qcom/Makefile
>> @@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
>>   	qcom-msm8916-samsung-serranove.dtb \
>>   	qcom-msm8926-microsoft-superman-lte.dtb \
>>   	qcom-msm8926-microsoft-tesla.dtb \
>> +	qcom-msm8926-samsung-matisselte.dtb \
>>   	qcom-msm8960-cdp.dtb \
>>   	qcom-msm8960-samsung-expressatt.dtb \
>>   	qcom-msm8974-lge-nexus5-hammerhead.dtb \
>> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
>> new file mode 100644
>> index 000000000000..6e25b1a74ce5
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
>> @@ -0,0 +1,36 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) 2022, Matti Lehtimäki <matti.lehtimaki@gmail.com>
>> + * Copyright (c) 2023, Stefan Hansson <newbyte@postmarketos.org>
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "qcom-msm8226-samsung-matisse-common.dtsi"
>> +
>> +/ {
>> +	model = "Samsung Galaxy Tab 4 10.1 LTE";
>> +	compatible = "samsung,matisselte", "qcom,msm8926", "qcom,msm8226";
>> +	chassis-type = "tablet";
>> +};
>> +
>> +&pm8226_l3 {
>> +	regulator-max-microvolt = <1350000>;
>> +};
>> +
>> +&pm8226_s4 {
>> +	regulator-max-microvolt = <2200000>;
>> +};
>> +
>> +&reg_tsp_3p3v {
>> +	gpio = <&tlmm 32 GPIO_ACTIVE_HIGH>;
>> +};
>> +
>> +&sdhc_2 {
>> +	/* SD card fails to probe with error -110 */
>> +	status = "disabled";
> Can you give us some logs?

I tested it again just now, and it worked without issues. Maybe I used a 
defective SD card to test it or hadn't inserted it properly. I'll send 
another revision fixing this.

> Konrad

Stefan
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
index a3d293e40820..cab35eeb30f6 100644
--- a/arch/arm/boot/dts/qcom/Makefile
+++ b/arch/arm/boot/dts/qcom/Makefile
@@ -34,6 +34,7 @@  dtb-$(CONFIG_ARCH_QCOM) += \
 	qcom-msm8916-samsung-serranove.dtb \
 	qcom-msm8926-microsoft-superman-lte.dtb \
 	qcom-msm8926-microsoft-tesla.dtb \
+	qcom-msm8926-samsung-matisselte.dtb \
 	qcom-msm8960-cdp.dtb \
 	qcom-msm8960-samsung-expressatt.dtb \
 	qcom-msm8974-lge-nexus5-hammerhead.dtb \
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
new file mode 100644
index 000000000000..6e25b1a74ce5
--- /dev/null
+++ b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
@@ -0,0 +1,36 @@ 
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2022, Matti Lehtimäki <matti.lehtimaki@gmail.com>
+ * Copyright (c) 2023, Stefan Hansson <newbyte@postmarketos.org>
+ */
+
+/dts-v1/;
+
+#include "qcom-msm8226-samsung-matisse-common.dtsi"
+
+/ {
+	model = "Samsung Galaxy Tab 4 10.1 LTE";
+	compatible = "samsung,matisselte", "qcom,msm8926", "qcom,msm8226";
+	chassis-type = "tablet";
+};
+
+&pm8226_l3 {
+	regulator-max-microvolt = <1350000>;
+};
+
+&pm8226_s4 {
+	regulator-max-microvolt = <2200000>;
+};
+
+&reg_tsp_3p3v {
+	gpio = <&tlmm 32 GPIO_ACTIVE_HIGH>;
+};
+
+&sdhc_2 {
+	/* SD card fails to probe with error -110 */
+	status = "disabled";
+};
+
+&tsp_en1_default_state {
+	pins = "gpio32";
+};