diff mbox series

greybus: BeaglePlay driver needs CRC_CCITT

Message ID 20231031040909.21201-1-rdunlap@infradead.org
State New
Headers
Series greybus: BeaglePlay driver needs CRC_CCITT |

Commit Message

Randy Dunlap Oct. 31, 2023, 4:09 a.m. UTC 
  The gb-beagleplay driver uses crc_ccitt(), so it should select
CRC_CCITT to make sure that the function is available.

Fixes these build errors:

s390-linux-ld: drivers/greybus/gb-beagleplay.o: in function `hdlc_append_tx_u8':
gb-beagleplay.c:(.text+0x2c0): undefined reference to `crc_ccitt'
s390-linux-ld: drivers/greybus/gb-beagleplay.o: in function `hdlc_rx_frame':
gb-beagleplay.c:(.text+0x6a0): undefined reference to `crc_ccitt'

Fixes: ec558bbfea67 ("greybus: Add BeaglePlay Linux Driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Ayush Singh <ayushdevel1325@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Johan Hovold <johan@kernel.org>
Cc: Alex Elder <elder@kernel.org>
Cc: greybus-dev@lists.linaro.org
---
 drivers/greybus/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Comments

Ayush Singh Oct. 31, 2023, 6:01 a.m. UTC | #1 
On 10/31/23 09:39, Randy Dunlap wrote:

> The gb-beagleplay driver uses crc_ccitt(), so it should select
> CRC_CCITT to make sure that the function is available.
>
> Fixes these build errors:
>
> s390-linux-ld: drivers/greybus/gb-beagleplay.o: in function `hdlc_append_tx_u8':
> gb-beagleplay.c:(.text+0x2c0): undefined reference to `crc_ccitt'
> s390-linux-ld: drivers/greybus/gb-beagleplay.o: in function `hdlc_rx_frame':
> gb-beagleplay.c:(.text+0x6a0): undefined reference to `crc_ccitt'
>
> Fixes: ec558bbfea67 ("greybus: Add BeaglePlay Linux Driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Ayush Singh <ayushdevel1325@gmail.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Johan Hovold <johan@kernel.org>
> Cc: Alex Elder <elder@kernel.org>
> Cc: greybus-dev@lists.linaro.org
> ---
>   drivers/greybus/Kconfig |    1 +
>   1 file changed, 1 insertion(+)
>
> diff -- a/drivers/greybus/Kconfig b/drivers/greybus/Kconfig
> --- a/drivers/greybus/Kconfig
> +++ b/drivers/greybus/Kconfig
> @@ -20,6 +20,7 @@ if GREYBUS
>   config GREYBUS_BEAGLEPLAY
>   	tristate "Greybus BeaglePlay driver"
>   	depends on SERIAL_DEV_BUS
> +	select CRC_CCITT
>   	help
>   	  Select this option if you have a BeaglePlay where CC1352
>   	  co-processor acts as Greybus SVC.

Thanks.

Reviewed-by: Ayush Singh <ayushdevel1325@gmail.com>


Ayush Singh
diff mbox series

Patch

diff -- a/drivers/greybus/Kconfig b/drivers/greybus/Kconfig
--- a/drivers/greybus/Kconfig
+++ b/drivers/greybus/Kconfig
@@ -20,6 +20,7 @@  if GREYBUS
 config GREYBUS_BEAGLEPLAY
 	tristate "Greybus BeaglePlay driver"
 	depends on SERIAL_DEV_BUS
+	select CRC_CCITT
 	help
 	  Select this option if you have a BeaglePlay where CC1352
 	  co-processor acts as Greybus SVC.