Message ID | 20231027-sc7280-remoteprocs-v1-9-05ce95d9315a@fairphone.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:d641:0:b0:403:3b70:6f57 with SMTP id cy1csp640880vqb; Fri, 27 Oct 2023 07:22:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4Wf5glMKhobQ7bNlsSC4ocf5nLKAdFxF2bQ3p6AsH1Keug7jovoa4+hKQSXC+WsmupaxE X-Received: by 2002:a25:6912:0:b0:da0:caba:9017 with SMTP id e18-20020a256912000000b00da0caba9017mr2799364ybc.16.1698416530455; Fri, 27 Oct 2023 07:22:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698416530; cv=none; d=google.com; s=arc-20160816; b=yxbP1C4M8PfYPzIwQOrh+mgd6zdiMTJtf4k7qbMIGbCKnlAEEObFqAN8DC3qgktNPw CLbvpR/4FJqYocOgYNGWA9ilk4a13B3mV+CgVDgIhhlb3D/DKd/fzJvI6ONYIVdn6hLg Jkkib96GyfChitCISqATvN8k/m8scG1srCTBeG89y+XK4ORIOa+VHUYtb83T45fem+SO ARTQDpkgEE22qU4tMDDdkqxkmMCOPY0kqmBsQF7o0jKL/XBo8LxVQKka2lxmxzuqUJVL N7vKKhI37C+XL1xbivb+5knZzJadB+tgyjcXReFsD5LzV4y2AX1mvetCAQvpuCITnB0M OgIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=L5VK2HSIOWZmUzPwXwqeSeHrMobAdR7tlAySzxFYWrY=; fh=4YRGpp4+erIE8EulKv6vTURWMTZkR1ZrVdHONvEW04M=; b=eyasPfd8EAmC0nvSwNUAu9jFctRjj2GVj1YkZrbX7Ov8HXHr51LDpzsgOuydBWuD3E HHjXRAPW6cXBytBi+cM29yVW0FTYoazNP1NjIN4Qf8CiO16po+lYbkP+E3Zt2MUdRmuD kZp9WGrS3qHQp0GfRXMWbSfZMHIxuf4kjCAZRrA2Cdxxw1UuRZk14RNFMbhG3wbFlkq0 X4Yo3uKLJTrdQMP8kljlxjo20ek8agRnynRlOwRsopjWaI/jNnaHGGwN5HwZVHeOzqSh 2eZktBH3Qh+fqquXxW5PxYdpBjRo+a99bW+akdviUvY7Fy93qy2M3w6xfPcp7CqtKisi aDXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fairphone.com header.s=fair header.b=kju7MqYA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fairphone.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id 189-20020a2500c6000000b00da1e007da59si1779943yba.35.2023.10.27.07.22.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 07:22:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@fairphone.com header.s=fair header.b=kju7MqYA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fairphone.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 1900D835451C; Fri, 27 Oct 2023 07:21:23 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346158AbjJ0OVG (ORCPT <rfc822;a1648639935@gmail.com> + 25 others); Fri, 27 Oct 2023 10:21:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346150AbjJ0OUo (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 27 Oct 2023 10:20:44 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F11DD6A for <linux-kernel@vger.kernel.org>; Fri, 27 Oct 2023 07:20:38 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-9ada2e6e75fso343032766b.2 for <linux-kernel@vger.kernel.org>; Fri, 27 Oct 2023 07:20:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1698416436; x=1699021236; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=L5VK2HSIOWZmUzPwXwqeSeHrMobAdR7tlAySzxFYWrY=; b=kju7MqYAJmlHUDfIkQKsMnzzAr2o7ukRwdw9kG/ruxKWZheoyDFlQz/LdvFvAPmAd1 qjgnQAvi9ak+W0Vqqod9OcoLnyHLGf3CiHMe4yZx0vtgQzC5YSaiOehB991vvrPz47pp YQHJmYPtqvSayMBll0gXLrvBcVFroZAQhxYu5rqRUc2Jc51bfkcW7BAs6UdXxiCd0S5H +h+9lquEucc6m8D/SNnjRlfHXkQBrEHXHjnGEvZ0AvwiO1jL8b9pv+8JLyycShsLS6Nh 6xET2gNvrEJkDmWC4wz9yfwHKa0qteNtg1ko3TLBNw9fYJ3776afsG4+H8atAWppWZPq f+lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698416436; x=1699021236; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L5VK2HSIOWZmUzPwXwqeSeHrMobAdR7tlAySzxFYWrY=; b=ONCVg7z/uVdRp3yS2VrpOiocBQVKEEfyRya9TvnYqY1hiQE3e7pXnib1XCM8LlIIis oBuwULee3jDExZxjUxX9LYGFRNHotcYPsB4XKH+XbwKxft/1IdzB9CpaqEzOxyA9APm6 rfmM4O29kYmNLK8NCMS+y2J+zvhjZqwK/IbFZprmL5/67e/4Ng6U/f3YcCMCCSA+MLAT 3jMoyAZoDjuVQGchtODAcCki2pulXtw8UcNuEUrYJqj6d+95B5gALSmqeV/86A6U/XkH R3my2Pff1Tdyk7CKrjZW8T8vfZ/CqWV2SMCQHHf3yvfjq9EhbmL0nKeHuGfWR6U0pZHY LRPg== X-Gm-Message-State: AOJu0YyTfkw8HZHIhStYfbAA26u3p9zoZ2O9+lX1bOKlzD/lC5YQVRZn cUbtBLpJXvFdEWlgUZyKDzzCUQ== X-Received: by 2002:a17:907:3da7:b0:9be:6ff7:128a with SMTP id he39-20020a1709073da700b009be6ff7128amr2350241ejc.67.1698416436593; Fri, 27 Oct 2023 07:20:36 -0700 (PDT) Received: from otso.luca.vpn.lucaweiss.eu (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id z23-20020a170906075700b0099cc36c4681sm1254076ejb.157.2023.10.27.07.20.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 07:20:36 -0700 (PDT) From: Luca Weiss <luca.weiss@fairphone.com> Date: Fri, 27 Oct 2023 16:20:31 +0200 Subject: [PATCH 9/9] arm64: dts: qcom: qcm6490-fairphone-fp5: Enable WiFi MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20231027-sc7280-remoteprocs-v1-9-05ce95d9315a@fairphone.com> References: <20231027-sc7280-remoteprocs-v1-0-05ce95d9315a@fairphone.com> In-Reply-To: <20231027-sc7280-remoteprocs-v1-0-05ce95d9315a@fairphone.com> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Mathieu Poirier <mathieu.poirier@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Manivannan Sadhasivam <mani@kernel.org>, cros-qcom-dts-watchers@chromium.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Rob Herring <robh@kernel.org>, =?utf-8?q?Matti_Lehtim=C3=A4ki?= <matti.lehtimaki@gmail.com>, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss <luca.weiss@fairphone.com> X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 27 Oct 2023 07:21:23 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780918811341839273 X-GMAIL-MSGID: 1780918811341839273 |
Series |
Remoteprocs (ADSP, CDSP, WPSS) for SC7280
|
|
Commit Message
Luca Weiss
Oct. 27, 2023, 2:20 p.m. UTC
Now that the WPSS remoteproc is enabled, enable wifi so we can use it.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 4 ++++
1 file changed, 4 insertions(+)
Comments
On 27.10.2023 16:20, Luca Weiss wrote: > Now that the WPSS remoteproc is enabled, enable wifi so we can use it. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- > arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > index d65eef30091b..e7e20f73cbe6 100644 > --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > @@ -713,3 +713,7 @@ &venus { > firmware-name = "qcom/qcm6490/fairphone5/venus.mbn"; > status = "okay"; > }; > + > +&wifi { > + status = "okay"; qcom,ath11k-calibration-variant? Konrad
On Mon Oct 30, 2023 at 8:26 PM CET, Konrad Dybcio wrote: > On 27.10.2023 16:20, Luca Weiss wrote: > > Now that the WPSS remoteproc is enabled, enable wifi so we can use it. > > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > --- > > arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > > index d65eef30091b..e7e20f73cbe6 100644 > > --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > > +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > > @@ -713,3 +713,7 @@ &venus { > > firmware-name = "qcom/qcm6490/fairphone5/venus.mbn"; > > status = "okay"; > > }; > > + > > +&wifi { > > + status = "okay"; > qcom,ath11k-calibration-variant? What value would I put there for my device? Based on existing usages (mostly for ath10k) I'd say "Fairphone_5"? And you mean I should add this property in dts before even looking into the firmware/calibration side of it? Regards Luca > > Konrad
On 31.10.2023 11:31, Luca Weiss wrote: > On Mon Oct 30, 2023 at 8:26 PM CET, Konrad Dybcio wrote: >> On 27.10.2023 16:20, Luca Weiss wrote: >>> Now that the WPSS remoteproc is enabled, enable wifi so we can use it. >>> >>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> >>> --- >>> arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts >>> index d65eef30091b..e7e20f73cbe6 100644 >>> --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts >>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts >>> @@ -713,3 +713,7 @@ &venus { >>> firmware-name = "qcom/qcm6490/fairphone5/venus.mbn"; >>> status = "okay"; >>> }; >>> + >>> +&wifi { >>> + status = "okay"; >> qcom,ath11k-calibration-variant? > > What value would I put there for my device? Based on existing usages > (mostly for ath10k) I'd say "Fairphone_5"? > > And you mean I should add this property in dts before even looking into > the firmware/calibration side of it? This is basically a "compatible" for the board file, I think Fairphone_5 makes sense here, perhaps Dmitry can confirm Konrad
[Added Kalle to the CC list] On Tue, 31 Oct 2023 at 12:31, Luca Weiss <luca.weiss@fairphone.com> wrote: > > On Mon Oct 30, 2023 at 8:26 PM CET, Konrad Dybcio wrote: > > On 27.10.2023 16:20, Luca Weiss wrote: > > > Now that the WPSS remoteproc is enabled, enable wifi so we can use it. > > > > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > > --- > > > arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > > > index d65eef30091b..e7e20f73cbe6 100644 > > > --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > > > +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > > > @@ -713,3 +713,7 @@ &venus { > > > firmware-name = "qcom/qcm6490/fairphone5/venus.mbn"; > > > status = "okay"; > > > }; > > > + > > > +&wifi { > > > + status = "okay"; > > qcom,ath11k-calibration-variant? > > What value would I put there for my device? Based on existing usages > (mostly for ath10k) I'd say "Fairphone_5"? I think this is fine. > And you mean I should add this property in dts before even looking into > the firmware/calibration side of it? From my experience some (most?) of the device manufacturers do the wrong thing here. They do not program a sensible board_id, leaving it as 0xff or some other semi-random value. The calibration variant is the only way for the kernel to distinguish between such poor devices. The kernel will do a smart thing though. If the device-specific calibration data is not present, it will try to fall back to the generic data.
(adding ath11k list) Dmitry Baryshkov <dmitry.baryshkov@linaro.org> writes: > [Added Kalle to the CC list] > > On Tue, 31 Oct 2023 at 12:31, Luca Weiss <luca.weiss@fairphone.com> wrote: >> >> On Mon Oct 30, 2023 at 8:26 PM CET, Konrad Dybcio wrote: >> > On 27.10.2023 16:20, Luca Weiss wrote: >> > > Now that the WPSS remoteproc is enabled, enable wifi so we can use it. >> > > >> > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> >> > > --- >> > > arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 4 ++++ >> > > 1 file changed, 4 insertions(+) >> > > >> > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts >> > > index d65eef30091b..e7e20f73cbe6 100644 >> > > --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts >> > > +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts >> > > @@ -713,3 +713,7 @@ &venus { >> > > firmware-name = "qcom/qcm6490/fairphone5/venus.mbn"; >> > > status = "okay"; >> > > }; >> > > + >> > > +&wifi { >> > > + status = "okay"; >> > qcom,ath11k-calibration-variant? >> >> What value would I put there for my device? Based on existing usages >> (mostly for ath10k) I'd say "Fairphone_5"? > > I think this is fine. From style point of view I would prefer lower case and dashes, for example "fairphone-5" but I'm just nitpicking, uppercase and underscores work fine as well. If you have different SKUs or similar which need different ath11k board files being more specific like "fairphone-5-eu" and "fairphone-5-us" is one option. But I'm sure Luca knows best what is needed for Fairphone, just throwing out ideas here. >> And you mean I should add this property in dts before even looking into >> the firmware/calibration side of it? > > From my experience some (most?) of the device manufacturers do the > wrong thing here. They do not program a sensible board_id, leaving it > as 0xff or some other semi-random value. The calibration variant is > the only way for the kernel to distinguish between such poor devices. > > The kernel will do a smart thing though. If the device-specific > calibration data is not present, it will try to fall back to the > generic data. You are correct, just to be specific it's ath11k which will choose which board file to use. I recommend always setting qcom,ath11k-calibration-variant in DTS if you can. Back in the day I have tried to push for the firmware team to improve the board file selection but no success. So the only practical solution we have is qcom,ath11k-calibration-variant in DTS.
On Mon Nov 13, 2023 at 1:22 PM CET, Kalle Valo wrote: > (adding ath11k list) > > Dmitry Baryshkov <dmitry.baryshkov@linaro.org> writes: > > > [Added Kalle to the CC list] > > > > On Tue, 31 Oct 2023 at 12:31, Luca Weiss <luca.weiss@fairphone.com> wrote: > >> > >> On Mon Oct 30, 2023 at 8:26 PM CET, Konrad Dybcio wrote: > >> > On 27.10.2023 16:20, Luca Weiss wrote: > >> > > Now that the WPSS remoteproc is enabled, enable wifi so we can use it. > >> > > > >> > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > >> > > --- > >> > > arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 4 ++++ > >> > > 1 file changed, 4 insertions(+) > >> > > > >> > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > >> > > index d65eef30091b..e7e20f73cbe6 100644 > >> > > --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > >> > > +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts > >> > > @@ -713,3 +713,7 @@ &venus { > >> > > firmware-name = "qcom/qcm6490/fairphone5/venus.mbn"; > >> > > status = "okay"; > >> > > }; > >> > > + > >> > > +&wifi { > >> > > + status = "okay"; > >> > qcom,ath11k-calibration-variant? > >> > >> What value would I put there for my device? Based on existing usages > >> (mostly for ath10k) I'd say "Fairphone_5"? > > > > I think this is fine. > > From style point of view I would prefer lower case and dashes, for > example "fairphone-5" but I'm just nitpicking, uppercase and underscores > work fine as well. I really don't mind, but I used "Fairphone_5" in v2 now, but I can change it for v3 if that happens if you wish. > > If you have different SKUs or similar which need different ath11k board > files being more specific like "fairphone-5-eu" and "fairphone-5-us" is > one option. But I'm sure Luca knows best what is needed for Fairphone, > just throwing out ideas here. As far as I am aware, there's only one hardware variant, so nothing extra should be needed there. (We also only really sell in Europe, apart from a small rollout in Taiwan and a trial in the US, but same HW there) Regards Luca > > >> And you mean I should add this property in dts before even looking into > >> the firmware/calibration side of it? > > > > From my experience some (most?) of the device manufacturers do the > > wrong thing here. They do not program a sensible board_id, leaving it > > as 0xff or some other semi-random value. The calibration variant is > > the only way for the kernel to distinguish between such poor devices. > > > > The kernel will do a smart thing though. If the device-specific > > calibration data is not present, it will try to fall back to the > > generic data. > > You are correct, just to be specific it's ath11k which will choose which > board file to use. I recommend always setting > qcom,ath11k-calibration-variant in DTS if you can. > > Back in the day I have tried to push for the firmware team to improve > the board file selection but no success. So the only practical solution > we have is qcom,ath11k-calibration-variant in DTS.
"Luca Weiss" <luca.weiss@fairphone.com> writes: >> >> > > --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts >> >> > > +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts >> >> > > @@ -713,3 +713,7 @@ &venus { >> >> > > firmware-name = "qcom/qcm6490/fairphone5/venus.mbn"; >> >> > > status = "okay"; >> >> > > }; >> >> > > + >> >> > > +&wifi { >> >> > > + status = "okay"; >> >> > qcom,ath11k-calibration-variant? >> >> >> >> What value would I put there for my device? Based on existing usages >> >> (mostly for ath10k) I'd say "Fairphone_5"? >> > >> > I think this is fine. >> >> From style point of view I would prefer lower case and dashes, for >> example "fairphone-5" but I'm just nitpicking, uppercase and underscores >> work fine as well. > > I really don't mind, but I used "Fairphone_5" in v2 now, but I can > change it for v3 if that happens if you wish. Nah, no need to resend. That's fine. But in the future please try to CC the ath11k list for patches like this, easier to follow what's happening.
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts index d65eef30091b..e7e20f73cbe6 100644 --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts @@ -713,3 +713,7 @@ &venus { firmware-name = "qcom/qcm6490/fairphone5/venus.mbn"; status = "okay"; }; + +&wifi { + status = "okay"; +};