diff mbox series

[1/1] of: unittest: Fix test build on config without CONFIG_OF_ADDRESS

Message ID 20231027102440.677773-1-herve.codina@bootlin.com
State New
Headers
Series [1/1] of: unittest: Fix test build on config without CONFIG_OF_ADDRESS |

Commit Message

Herve Codina Oct. 27, 2023, 10:24 a.m. UTC 
  of_address_to_resource() is not defined if !CONFIG_OF_ADDRESS.

Return early in of_unittest_check_addr() to avoid the
of_address_to_resource() usage.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202310271513.8MUErCK4-lkp@intel.com/
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
Rob,

This fixes a patch you already applied from my series
https://lore.kernel.org/all/20231017110221.189299-1-herve.codina@bootlin.com/

I don't know if it's too late or not but maybe you can squash this fix patch.

My apologies for this issue.

Hervé

 drivers/of/unittest.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rob Herring Oct. 27, 2023, 9:38 p.m. UTC | #1 
On Fri, 27 Oct 2023 12:24:37 +0200, Herve Codina wrote:
> of_address_to_resource() is not defined if !CONFIG_OF_ADDRESS.
> 
> Return early in of_unittest_check_addr() to avoid the
> of_address_to_resource() usage.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202310271513.8MUErCK4-lkp@intel.com/
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> ---
> Rob,
> 
> This fixes a patch you already applied from my series
> https://lore.kernel.org/all/20231017110221.189299-1-herve.codina@bootlin.com/
> 
> I don't know if it's too late or not but maybe you can squash this fix patch.
> 
> My apologies for this issue.
> 
> Hervé
> 
>  drivers/of/unittest.c | 3 +++
>  1 file changed, 3 insertions(+)
> 

Squashed and applied, thanks!
diff mbox series

Patch

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index ffbecd349899..e9e90e96600e 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -1201,6 +1201,9 @@  static void __init of_unittest_check_addr(const char *node_path,
 	unsigned int count;
 	int ret;
 
+	if (!IS_ENABLED(CONFIG_OF_ADDRESS))
+		return;
+
 	np = of_find_node_by_path(node_path);
 	if (!np) {
 		pr_err("missing testcase data (%s)\n", node_path);