Message ID | 20231020223029.1667190-1-javierm@redhat.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6359:6b8b:b0:164:83eb:24d7 with SMTP id ta11csp33057rwb; Fri, 20 Oct 2023 15:32:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGcCgepRWjbUJpQRSmVkMvaZx0l+6StJ5oEKO+RnDNR4Dkmd23VYFb1blattrDhrCQyLboc X-Received: by 2002:a05:6a21:488b:b0:17a:eff5:fbcb with SMTP id av11-20020a056a21488b00b0017aeff5fbcbmr3494235pzc.43.1697841162643; Fri, 20 Oct 2023 15:32:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697841162; cv=none; d=google.com; s=arc-20160816; b=LByZkVEnyJM1MvRf2/glAe+pZyNt124VRoISpc5gb3T2hoe3fEcRSQXG1dzPbyRb4l NsM97iIGSLdL/f5bexa9YHj4qWPV/MYyb2QjBIp+5Vpdc9n4juKufclE14UbWUOYYJy4 b0Sr+vNJ2jdh52t6j13rx0iTzq7+V2mgzPPEWKLjabQOLfl64USKwE9fqmnmq4/V2xEI 1rGW+kIRQo8uuvAyTxZWfBXxKcUp0+AnS0OiJCIhaeXNZQ72aDpCTj1e3uJJqP/REXFs rf4M9tfb8FEeJJfBPcEaKQaQIbI3zSSjCX1N/yeyI85ycZAZBVgwIsY8hnZ5WX/WrJF6 vWTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=U9iwHq/WW92wIMDf4fjn3PaKiv4Qj6cmxyyqbItQ0rE=; fh=uzp9btbyNwUhRyox48nPGOYnlfRkGlC0yA2ULZKcGF4=; b=gbYxRM69awx1/rlBALqux6Ji7DnLrj41B2NFMqkJTGw4s+sI5NpvaPQHYyk9uj8Ivw tHLIzDanlMcynkXgWisiccAhZSeGR+7BlVpUOOptqRFGik5Qo742njePZJW4WmM5X4t6 enkQ+pJzOxtmUxzWmQZiWyFzwvl/8e4VeZI/Lzc+dTdpBOCYz0gshwDMPjj1E4x5QdQE W6VjC1y/BgmrqdZ6Q+gFcF8YQEoDh7kIOdjr5SBlemZ4t/flWztkCsu026CoucWPvYc2 0H6PfV5RWs+ReCrlU7jS9rS65Un7p4BkPrMdLrh6paM3amlb4WhjmmtVG3vefTI17tjg 2bzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FxqLagcY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id g22-20020a056a0023d600b0068fa8499af1si2765874pfc.11.2023.10.20.15.32.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 15:32:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FxqLagcY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 220AE83B009C; Fri, 20 Oct 2023 15:32:40 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231288AbjJTWc1 (ORCPT <rfc822;a1648639935@gmail.com> + 26 others); Fri, 20 Oct 2023 18:32:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230204AbjJTWcZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 20 Oct 2023 18:32:25 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13616D5B for <linux-kernel@vger.kernel.org>; Fri, 20 Oct 2023 15:31:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697841094; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=U9iwHq/WW92wIMDf4fjn3PaKiv4Qj6cmxyyqbItQ0rE=; b=FxqLagcY2XmiDsZp9BOxMlfAFwdbngXnu0psfBWJZLSdGIjRdZJotonjw4n/KLEGLoA0oT Rd+3Apl/CLaSL+vNWaAqXXyw94I0CVZbfV7ftbgpZUQq/nF00Hj91HUNA/MA2kJtNJWt3f bmZQQgrQmhNU3ZC8c0JhfMXmlInXS/Q= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-218-3YA-EhpHPiWHBYrhBxhaQw-1; Fri, 20 Oct 2023 18:31:33 -0400 X-MC-Unique: 3YA-EhpHPiWHBYrhBxhaQw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-407f9d07b41so7921145e9.0 for <linux-kernel@vger.kernel.org>; Fri, 20 Oct 2023 15:31:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697841091; x=1698445891; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U9iwHq/WW92wIMDf4fjn3PaKiv4Qj6cmxyyqbItQ0rE=; b=FDKfaEcKdT/BeJxCptf6LmIh9grHDkr4FNC1H0Ug2OG8FwCwRCwHNQKS8I9NLj5+Iq dD785vlLPRIxa53P4uWiGcpo9NXeu0laRecbtNjA6sONhmXHnLQ5hsaiXvh+bipoNdJB ivOeMgKny+2+KzBSGPimoe4WBa5MVLfF8F9zj5XtiXAxaMXI9/GrM6rjmMJkN4mvyrvt rtNfwwZBkouZyALVWKIotBMVrIoOLQPJW2pFB73EVQEKrIHFB7iDg38A6AhY9GxPdxNd b2eG87jdm1DeafeMoeWDVp6lace6EqkLYwidnF9JzhJKR3p9y34OoeUwxChoaJvRsr6b Td7A== X-Gm-Message-State: AOJu0YwzuT3FbZH6/LED5mSvMKO1Yh519L+dRInqm/eoArysnpZi0Z/y /tpP7MMEkcQvRkuediR38KKpR/CsWzMn3TfeKNUe14xA83vUu/2DnqNEqPwFEtoIrW9JpBA9HLr RjFRJoHrX24gvuW5ux0P55RLj/vpl235+q5A61fWnjrXgDkeZ84m/WaNFMZBfEeo1g278AneHqv zda6HXWAc= X-Received: by 2002:a05:600c:1c21:b0:408:4cf1:e9d7 with SMTP id j33-20020a05600c1c2100b004084cf1e9d7mr2415660wms.20.1697841091494; Fri, 20 Oct 2023 15:31:31 -0700 (PDT) X-Received: by 2002:a05:600c:1c21:b0:408:4cf1:e9d7 with SMTP id j33-20020a05600c1c2100b004084cf1e9d7mr2415635wms.20.1697841091092; Fri, 20 Oct 2023 15:31:31 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id n16-20020a05600c3b9000b003fee6e170f9sm3113382wms.45.2023.10.20.15.31.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 15:31:28 -0700 (PDT) From: Javier Martinez Canillas <javierm@redhat.com> To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas <javierm@redhat.com>, Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Rob Herring <robh+dt@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH] dt-bindings: display: ssd132x: Remove '-' before compatible enum Date: Sat, 21 Oct 2023 00:30:17 +0200 Message-ID: <20231020223029.1667190-1-javierm@redhat.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 20 Oct 2023 15:32:40 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780315494632483574 X-GMAIL-MSGID: 1780315494632483574 |
Series |
dt-bindings: display: ssd132x: Remove '-' before compatible enum
|
|
Commit Message
Javier Martinez Canillas
Oct. 20, 2023, 10:30 p.m. UTC
This is a leftover from when the binding schema had the compatible string
property enum as a 'oneOf' child and the '-' was not removed when 'oneOf'
got dropped during the binding review process.
Reported-by: Rob Herring <robh@kernel.org>
Closes: https://lore.kernel.org/dri-devel/CAL_Jsq+h8DcnpKqhokQOODCc8+Qi3M0PrxRFKz_Y4v37yMJvvA@mail.gmail.com/
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
.../devicetree/bindings/display/solomon,ssd132x.yaml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Comments
On Sat, Oct 21, 2023 at 12:30:17AM +0200, Javier Martinez Canillas wrote: > This is a leftover from when the binding schema had the compatible string > property enum as a 'oneOf' child and the '-' was not removed when 'oneOf' > got dropped during the binding review process. > > Reported-by: Rob Herring <robh@kernel.org> > Closes: https://lore.kernel.org/dri-devel/CAL_Jsq+h8DcnpKqhokQOODCc8+Qi3M0PrxRFKz_Y4v37yMJvvA@mail.gmail.com/ > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > > .../devicetree/bindings/display/solomon,ssd132x.yaml | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/solomon,ssd132x.yaml b/Documentation/devicetree/bindings/display/solomon,ssd132x.yaml > index 0aa41bd9ddca..37975ee61c5a 100644 > --- a/Documentation/devicetree/bindings/display/solomon,ssd132x.yaml > +++ b/Documentation/devicetree/bindings/display/solomon,ssd132x.yaml > @@ -11,10 +11,10 @@ maintainers: > > properties: > compatible: > - - enum: > - - solomon,ssd1322 > - - solomon,ssd1325 > - - solomon,ssd1327 > + enum: > + - solomon,ssd1322 > + - solomon,ssd1325 > + - solomon,ssd1327 > > required: > - compatible > -- > 2.41.0 >
On Sat, 21 Oct 2023 00:30:17 +0200, Javier Martinez Canillas wrote: > This is a leftover from when the binding schema had the compatible string > property enum as a 'oneOf' child and the '-' was not removed when 'oneOf' > got dropped during the binding review process. > > Reported-by: Rob Herring <robh@kernel.org> > Closes: https://lore.kernel.org/dri-devel/CAL_Jsq+h8DcnpKqhokQOODCc8+Qi3M0PrxRFKz_Y4v37yMJvvA@mail.gmail.com/ > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > --- > > .../devicetree/bindings/display/solomon,ssd132x.yaml | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
Rob Herring <robh@kernel.org> writes: > On Sat, 21 Oct 2023 00:30:17 +0200, Javier Martinez Canillas wrote: >> This is a leftover from when the binding schema had the compatible string >> property enum as a 'oneOf' child and the '-' was not removed when 'oneOf' >> got dropped during the binding review process. >> >> Reported-by: Rob Herring <robh@kernel.org> >> Closes: https://lore.kernel.org/dri-devel/CAL_Jsq+h8DcnpKqhokQOODCc8+Qi3M0PrxRFKz_Y4v37yMJvvA@mail.gmail.com/ >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> >> --- >> >> .../devicetree/bindings/display/solomon,ssd132x.yaml | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> > > Reviewed-by: Rob Herring <robh@kernel.org> > Pushed to drm-misc (drm-misc-next). Thanks!
On Fri, Oct 27, 2023 at 11:30:56AM +0200, Javier Martinez Canillas wrote: > Rob Herring <robh@kernel.org> writes: > > > On Sat, 21 Oct 2023 00:30:17 +0200, Javier Martinez Canillas wrote: > >> This is a leftover from when the binding schema had the compatible string > >> property enum as a 'oneOf' child and the '-' was not removed when 'oneOf' > >> got dropped during the binding review process. > >> > >> Reported-by: Rob Herring <robh@kernel.org> > >> Closes: https://lore.kernel.org/dri-devel/CAL_Jsq+h8DcnpKqhokQOODCc8+Qi3M0PrxRFKz_Y4v37yMJvvA@mail.gmail.com/ > >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > >> --- > >> > >> .../devicetree/bindings/display/solomon,ssd132x.yaml | 8 ++++---- > >> 1 file changed, 4 insertions(+), 4 deletions(-) > >> > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > > > Pushed to drm-misc (drm-misc-next). Thanks! Given what introduced this is before the drm-misc-next-2023-10-19 tag, isn't it going into 6.7 and needs to be in the fixes branch? Though that doesn't exist yet for 6.7 fixes. I don't understand why that's not done as part of the last tag for a cycle. But drm-misc is special. Rob
Rob Herring <robh@kernel.org> writes: Hello Rob, > On Fri, Oct 27, 2023 at 11:30:56AM +0200, Javier Martinez Canillas wrote: >> Rob Herring <robh@kernel.org> writes: >> >> > On Sat, 21 Oct 2023 00:30:17 +0200, Javier Martinez Canillas wrote: >> >> This is a leftover from when the binding schema had the compatible string >> >> property enum as a 'oneOf' child and the '-' was not removed when 'oneOf' >> >> got dropped during the binding review process. >> >> >> >> Reported-by: Rob Herring <robh@kernel.org> >> >> Closes: https://lore.kernel.org/dri-devel/CAL_Jsq+h8DcnpKqhokQOODCc8+Qi3M0PrxRFKz_Y4v37yMJvvA@mail.gmail.com/ >> >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> >> >> --- >> >> >> >> .../devicetree/bindings/display/solomon,ssd132x.yaml | 8 ++++---- >> >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> >> > >> > Reviewed-by: Rob Herring <robh@kernel.org> >> > >> >> Pushed to drm-misc (drm-misc-next). Thanks! > > Given what introduced this is before the drm-misc-next-2023-10-19 tag, > isn't it going into 6.7 and needs to be in the fixes branch? Though that > doesn't exist yet for 6.7 fixes. I don't understand why that's not done > as part of the last tag for a cycle. But drm-misc is special. > I pushed to drm-misc-next because I thought that there will be a last PR of drm-misc-next for 6.7, but it seems I missed it for a couple of hours (that is drm-misc-next-2023-10-27) :( https://lists.freedesktop.org/archives/dri-devel/2023-October/425698.html The solution now is to cherry-pick the fixes already in drm-misc-next to drm-misc-next-fixes, to make sure that land in 6.7. I can do that once drm-next is back merged to that branch, if you think the schema warning fix must land in 6.7 and can't wait for the next release. > Rob >
Javier Martinez Canillas <javierm@redhat.com> writes: [...] >>> Pushed to drm-misc (drm-misc-next). Thanks! >> >> Given what introduced this is before the drm-misc-next-2023-10-19 tag, >> isn't it going into 6.7 and needs to be in the fixes branch? Though that >> doesn't exist yet for 6.7 fixes. I don't understand why that's not done >> as part of the last tag for a cycle. But drm-misc is special. >> > > I pushed to drm-misc-next because I thought that there will be a last PR > of drm-misc-next for 6.7, but it seems I missed it for a couple of hours > (that is drm-misc-next-2023-10-27) :( > > https://lists.freedesktop.org/archives/dri-devel/2023-October/425698.html > > The solution now is to cherry-pick the fixes already in drm-misc-next to > drm-misc-next-fixes, to make sure that land in 6.7. I can do that once > drm-next is back merged to that branch, if you think the schema warning > fix must land in 6.7 and can't wait for the next release. > Or wait for the drm-misc-fixes branch to be back merged and land it as a part of the 6.7-rc cycle. I'll do that since it would cause less trouble to the drm-misc maintainers.
Javier Martinez Canillas <javierm@redhat.com> writes: > Rob Herring <robh@kernel.org> writes: > > Hello Rob, > [...] >>> Pushed to drm-misc (drm-misc-next). Thanks! >> >> Given what introduced this is before the drm-misc-next-2023-10-19 tag, >> isn't it going into 6.7 and needs to be in the fixes branch? Though that >> doesn't exist yet for 6.7 fixes. I don't understand why that's not done >> as part of the last tag for a cycle. But drm-misc is special. >> > > I pushed to drm-misc-next because I thought that there will be a last PR > of drm-misc-next for 6.7, but it seems I missed it for a couple of hours > (that is drm-misc-next-2023-10-27) :( > > https://lists.freedesktop.org/archives/dri-devel/2023-October/425698.html > > The solution now is to cherry-pick the fixes already in drm-misc-next to > drm-misc-next-fixes, to make sure that land in 6.7. I can do that once Cherry-picked the commit in drm-misc-next-fixes as well.
diff --git a/Documentation/devicetree/bindings/display/solomon,ssd132x.yaml b/Documentation/devicetree/bindings/display/solomon,ssd132x.yaml index 0aa41bd9ddca..37975ee61c5a 100644 --- a/Documentation/devicetree/bindings/display/solomon,ssd132x.yaml +++ b/Documentation/devicetree/bindings/display/solomon,ssd132x.yaml @@ -11,10 +11,10 @@ maintainers: properties: compatible: - - enum: - - solomon,ssd1322 - - solomon,ssd1325 - - solomon,ssd1327 + enum: + - solomon,ssd1322 + - solomon,ssd1325 + - solomon,ssd1327 required: - compatible