| Message ID | 20231026084735.3595944-3-enachman@marvell.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:d641:0:b0:403:3b70:6f57 with SMTP id cy1csp521352vqb;
Thu, 26 Oct 2023 01:48:39 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IGki5tMcy8b/B3o/HEJDZA6n388QZMLTN/EciEoLKgaQjCJy2tk8cqcSQQXj3PUT34fnGVu
X-Received: by 2002:a25:cec8:0:b0:da0:5859:8465 with SMTP id
x191-20020a25cec8000000b00da058598465mr6028663ybe.20.1698310119109;
Thu, 26 Oct 2023 01:48:39 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1698310119; cv=none;
d=google.com; s=arc-20160816;
b=Rf5wOHChmSEwBLtQIL7nSxzWx4d0nM+gzTNryVYjEX8vcIYE/FMzrqdIQ/zXZkBD9+
Sq4mWyuwWBqahhpvOLvEplKwxUHTa6k0chE+SpieQH3uaSyCp0hl6NZOiBI6gcvEClic
0gUpNly5oSUcfaoGgq//oDvfgMCn8ddBRvlD81u6kcD/CuUirEFkFcoCOZGCX3ZslQzI
P6ECed4qweLgNtjasN5JLjd5jqWzbJhtBOTProz4RDoNWczVRI5DJ/f6KwYlMQF1wL5G
F4uEEVhLAtGv75pZZ2MXwkkdlmmZlksoexlecBjyaHq5Vp36cDOBhQ8BkqhOwZym8BGm
Z1GQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=RYi3y6cD1TpaFcvH4KDKraF8GJ1jvPIh+434TvZb/ZM=;
fh=RxW+ygTLip7GkByOQG2q6iLPJrY1W9i2RGWSrvL2muE=;
b=rNqR11lvuI6533C/ya8kbof1+3DcHrlqnoFN8VG0k/sS3Z4pFu0+HH0Dr6nc9wU4q9
SLUyJLjSfuXpoSAWnuQNkL2WRdS7XPcJe+3cME6imXe4kLoSA+lkgxMQL79/jNZKBoUi
A61rAwutcyccpFCZOYa9Tt+nfcCiusyrtUtpxmG+xZmToPonUZJnn05c76ZMPsDF9DG1
qpNGYXCsxqxScGDht5Oc2hILpkArJSQDXKxKSS3f0TqJ2a4cT9CxDMsFqlltkrmap6eT
w1SarhjoNHAsZe5kR2Os5+q0CyYakVrduxdTSt8ZtDYZmEYrWxsE0g9tnbpAbvMXiwaC
hKJg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=DY8Nu8Dn;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:2 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=marvell.com
Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2])
by mx.google.com with ESMTPS id
y80-20020a253253000000b00d9a54bf97a7si13170963yby.154.2023.10.26.01.48.37
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 26 Oct 2023 01:48:38 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:2 as permitted sender)
client-ip=2620:137:e000::3:2;
Authentication-Results: mx.google.com;
dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=DY8Nu8Dn;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:2 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=marvell.com
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by agentk.vger.email (Postfix) with ESMTP id E6C288112A82;
Thu, 26 Oct 2023 01:48:35 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S1344697AbjJZIsQ (ORCPT <rfc822;aposhian.dev@gmail.com>
+ 26 others); Thu, 26 Oct 2023 04:48:16 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40122 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229653AbjJZIsJ (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 26 Oct 2023 04:48:09 -0400
Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com
[67.231.148.174])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25B4B189;
Thu, 26 Oct 2023 01:48:07 -0700 (PDT)
Received: from pps.filterd (m0045849.ppops.net [127.0.0.1])
by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
39Q7OZGw015302;
Thu, 26 Oct 2023 01:47:59 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;
h=from : to : cc :
subject : date : message-id : in-reply-to : references : mime-version :
content-transfer-encoding : content-type; s=pfpt0220;
bh=RYi3y6cD1TpaFcvH4KDKraF8GJ1jvPIh+434TvZb/ZM=;
b=DY8Nu8DntJBK/CRM4WsqLJqEOCKOIucn9VkKid6iLZ5eaww7wTCShn3m2Fu6Cj9b6yNs
x0clLWcn939ZGjVClvUFTGTRd7JmFVpFxadraOdZK6xSABv0TU9pq9ZD30VwoyJ+eNs5
+Hzbz287gBfE88M7qfI5E2F5pVb3qadpM+dOOs1zzoi2UsqwJtH++8//wp7AKLPxHxOH
XND+UQxtuymzWta2SOKSl/C7xGx9DMh/gQ1gA/dr4i82JmVZkdMGZot5JHDuKURFEZpm
jv/UIMuLJ6TC4CI2WMyt5bYP33JCzkhjbWY5UijpkAVFC+NAKVtuuJzf6OEJCts+JSoF 6A==
Received: from dc5-exch01.marvell.com ([199.233.59.181])
by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3ty0vrcymc-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);
Thu, 26 Oct 2023 01:47:59 -0700
Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com
(10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Thu, 26 Oct
2023 01:47:57 -0700
Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com
(10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend
Transport; Thu, 26 Oct 2023 01:47:57 -0700
Received: from dc3lp-swdev041.marvell.com (dc3lp-swdev041.marvell.com
[10.6.60.191])
by maili.marvell.com (Postfix) with ESMTP id A22F13F70BF;
Thu, 26 Oct 2023 01:47:54 -0700 (PDT)
From: Elad Nachman <enachman@marvell.com>
To: <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>, <andrew@lunn.ch>,
<gregory.clement@bootlin.com>, <sebastian.hesselbarth@gmail.com>,
<pali@kernel.org>, <mrkiko.rs@gmail.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
CC: <enachman@marvell.com>, <cyuval@marvell.com>
Subject: [PATCH v3 2/3] dt-bindings: arm64: dts: add dt-bindings for ac5x rd
carrier
Date: Thu, 26 Oct 2023 11:47:34 +0300
Message-ID: <20231026084735.3595944-3-enachman@marvell.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20231026084735.3595944-1-enachman@marvell.com>
References: <20231026084735.3595944-1-enachman@marvell.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Proofpoint-GUID: 5kPPOidPerLWhDbImRJeH4RUn2LCeaVu
X-Proofpoint-ORIG-GUID: 5kPPOidPerLWhDbImRJeH4RUn2LCeaVu
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
definitions=2023-10-26_06,2023-10-25_01,2023-05-22_02
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]);
Thu, 26 Oct 2023 01:48:35 -0700 (PDT)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1780807230417905566
X-GMAIL-MSGID: 1780807230417905566
|
| Series |
arm64: dts: cn913x: add device trees for COM Express boards
|
|
Commit Message
Elad Nachman
Oct. 26, 2023, 8:47 a.m. UTC
From: Elad Nachman <enachman@marvell.com> Add dt bindings for AC5X RD COM Express Type 7 carrier board. This board will Accept a CN9131 COM Express Type 7 CPU module. Signed-off-by: Elad Nachman <enachman@marvell.com> --- .../devicetree/bindings/arm/marvell/armada-7k-8k.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)
Comments
On Thu, Oct 26, 2023 at 11:47:34AM +0300, Elad Nachman wrote: > From: Elad Nachman <enachman@marvell.com> > > Add dt bindings for AC5X RD COM Express Type 7 carrier board. > This board will Accept a CN9131 COM Express Type 7 CPU module. > > Signed-off-by: Elad Nachman <enachman@marvell.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > .../devicetree/bindings/arm/marvell/armada-7k-8k.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > index 52d78521e412..71bc94047d1b 100644 > --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > @@ -60,4 +60,12 @@ properties: > - const: marvell,armada-ap807-quad > - const: marvell,armada-ap807 > > + - description: AC5X RD COM Express Carrier for Armada CN9131 SoC with one external CP > + items: > + - const: marvell,ac5x_rd_carrier > + - const: marvell,cn9131 > + - const: marvell,cn9130 > + - const: marvell,armada-ap807-quad > + - const: marvell,armada-ap807 > + > additionalProperties: true > -- > 2.25.1 >
On Thu, Oct 26, 2023 at 11:47:34AM +0300, Elad Nachman wrote: > From: Elad Nachman <enachman@marvell.com> > > Add dt bindings for AC5X RD COM Express Type 7 carrier board. > This board will Accept a CN9131 COM Express Type 7 CPU module. > > Signed-off-by: Elad Nachman <enachman@marvell.com> > --- > .../devicetree/bindings/arm/marvell/armada-7k-8k.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > index 52d78521e412..71bc94047d1b 100644 > --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > @@ -60,4 +60,12 @@ properties: > - const: marvell,armada-ap807-quad > - const: marvell,armada-ap807 > > + - description: AC5X RD COM Express Carrier for Armada CN9131 SoC with one external CP This description is i think technically wrong. You have the combination of the carrier and the module. > + items: > + - const: marvell,ac5x_rd_carrier > + - const: marvell,cn9131 > + - const: marvell,cn9130 > + - const: marvell,armada-ap807-quad > + - const: marvell,armada-ap807 Andrew
On 26/10/2023 10:47, Elad Nachman wrote: > From: Elad Nachman <enachman@marvell.com> > > Add dt bindings for AC5X RD COM Express Type 7 carrier board. > This board will Accept a CN9131 COM Express Type 7 CPU module. > > Signed-off-by: Elad Nachman <enachman@marvell.com> > --- > .../devicetree/bindings/arm/marvell/armada-7k-8k.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > index 52d78521e412..71bc94047d1b 100644 > --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > @@ -60,4 +60,12 @@ properties: > - const: marvell,armada-ap807-quad > - const: marvell,armada-ap807 > > + - description: AC5X RD COM Express Carrier for Armada CN9131 SoC with one external CP > + items: > + - const: marvell,ac5x_rd_carrier No underscores in compatibles. Do you see them anywhere? Please use existing, recent code as start of your contributions, not something buggy 5 years old. Best regards, Krzysztof
On 26/10/2023 10:47, Elad Nachman wrote: > From: Elad Nachman <enachman@marvell.com> > > Add dt bindings for AC5X RD COM Express Type 7 carrier board. > This board will Accept a CN9131 COM Express Type 7 CPU module. > > Signed-off-by: Elad Nachman <enachman@marvell.com> Please order your patches correctly, so bindings come before their users. You cannot have other way. > --- > .../devicetree/bindings/arm/marvell/armada-7k-8k.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) Best regards, Krzysztof
On Fri, Oct 27, 2023 at 01:09:58PM +0200, Krzysztof Kozlowski wrote: > On 26/10/2023 10:47, Elad Nachman wrote: > > From: Elad Nachman <enachman@marvell.com> > > > > Add dt bindings for AC5X RD COM Express Type 7 carrier board. > > This board will Accept a CN9131 COM Express Type 7 CPU module. > > > > Signed-off-by: Elad Nachman <enachman@marvell.com> > > --- > > .../devicetree/bindings/arm/marvell/armada-7k-8k.yaml | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > > index 52d78521e412..71bc94047d1b 100644 > > --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > > @@ -60,4 +60,12 @@ properties: > > - const: marvell,armada-ap807-quad > > - const: marvell,armada-ap807 > > > > + - description: AC5X RD COM Express Carrier for Armada CN9131 SoC with one external CP > > + items: > > + - const: marvell,ac5x_rd_carrier > > No underscores in compatibles. Oh shit, I didn't notice that somehow. Un-acked until that's removed. > Do you see them anywhere? Please use > existing, recent code as start of your contributions, not something > buggy 5 years old. > > Best regards, > Krzysztof >
> > No underscores in compatibles. > > Oh shit, I didn't notice that somehow. Un-acked until that's removed. Not a problem. Its way too late for this merge window. The pull request for Marvell stuff has already been sent to arm-soc. There is plenty of time to fix this, and there are other problems to address as well. Andrew
diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml index 52d78521e412..71bc94047d1b 100644 --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml @@ -60,4 +60,12 @@ properties: - const: marvell,armada-ap807-quad - const: marvell,armada-ap807 + - description: AC5X RD COM Express Carrier for Armada CN9131 SoC with one external CP + items: + - const: marvell,ac5x_rd_carrier + - const: marvell,cn9131 + - const: marvell,cn9130 + - const: marvell,armada-ap807-quad + - const: marvell,armada-ap807 + additionalProperties: true