| Message ID | 20221116075736.1909690-2-vishal.l.verma@intel.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp12942wru;
Wed, 16 Nov 2022 00:00:06 -0800 (PST)
X-Google-Smtp-Source:
AA0mqf5ull9nOJjCdRo7qjKaskVgC/p17hB1iBHyISDHsFgfT7EVJw+OwCaT+xDWxkJLXRSDS1oK
X-Received: by 2002:a17:902:8697:b0:186:7fda:4d4a with SMTP id
g23-20020a170902869700b001867fda4d4amr7977919plo.66.1668585606679;
Wed, 16 Nov 2022 00:00:06 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1668585606; cv=none;
d=google.com; s=arc-20160816;
b=k5jqFe7ok3IP7WkBly1LE/d+K97YyysSG3rLihCd8DfKPKmfecYRs5Wje8eQJ9yilV
QENlqsQSvTUiO4abRMhPL2NtS9bMN6nvm6vBrIxX9IU347+Kk12I5EwSg1NKtPVV6R1m
+EEMbpKk3s8ZYiCXbEpcbycHjfaIdl9O+xspX7T99+4bPb4T/Ki1aqDSonKuu5nkyPn1
KsoRTnwqaK8u1leVazvBD0guHJGxhIV2DISmKakq9qH2XVD/CxfwkgVKiaLvvxI2p35Y
FfGIckXL6BLUcbTwa8d9H1fewbN1wYwCMjXpqvq7KXfIZJuWJeu1fnwC4MrvDK2Jei5R
kz2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=KNsmob5F5Q/Fc6pml6qFDXb1/UBNHw1CAUFr8UCemb8=;
b=T2ir6HaVebUOT4VlSv6ov3ybGr0ZHiZO9Rjww7guGGIX16HWvHiyCMuREiiFwFygar
wwEO0m0DBC+osKrUNtfsImIrVVZwacIN8y69q5ytFP/7vkm3F5UgJPzafhl+9+/zYaKL
GbXjIi5rvn8LYITXrW3z8l5AAPL7YslmVlHAe/JqEsdd820ThjmIq0c4cUWiUDSsCx+F
QID3ks8vxxaqL87QUlwtSh7idge0KoTP5yWhYwEQyEggo7du55aTfbT41HiU2kNZKCvG
QtI1gjGGrgWALjoJh+0YF+aSdzB2QHdBLx9JAWbUva73Iv2+F6eNEpfBkXhPYEQxxvoX
qFEg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@intel.com header.s=Intel header.b=epSkuVOh;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
b29-20020a631b5d000000b0046b2bef339csi14165898pgm.257.2022.11.15.23.59.53;
Wed, 16 Nov 2022 00:00:06 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@intel.com header.s=Intel header.b=epSkuVOh;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S232916AbiKPH55 (ORCPT <rfc822;maxim.cournoyer@gmail.com>
+ 99 others); Wed, 16 Nov 2022 02:57:57 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33904 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S232571AbiKPH5u (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 16 Nov 2022 02:57:50 -0500
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81A2123175;
Tue, 15 Nov 2022 23:57:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1668585469; x=1700121469;
h=from:to:cc:subject:date:message-id:in-reply-to:
references:mime-version:content-transfer-encoding;
bh=KiJFxHg73UmbAysUoUdzQCgP2Xj1YpjVLLbX13coZBc=;
b=epSkuVOhMEM8cejYioCxTlgAXcO7ftvT+P5aTum1VQHIek0JL3cUeOeC
SrcsnY6+gd5tPO0yl1FgiGvPbElWl2SRKqOisTsoTPRkFj9B6lpusMYkH
Se9k7pcrMyv/WJq+CW8jkCMzfjhL6TDtYTiXy94hfdEKRQDnBmRL6mBIW
D+ARez2KaX6RYrJMA/nbBxw8Ntuso0eUTOFBnDOK7K1QZ7xFSi2DENcKz
ecYdav4GtTmU6GiJnc9CIsZCPTbc6Yl+3cRd+6dDRluz2C1CU1MF/nwWQ
rhvdNm1rykexMDkaz0U+Asi/DjGz96FnoedFKhAPfi98DISdhBgqU5LI4
g==;
X-IronPort-AV: E=McAfee;i="6500,9779,10532"; a="398767159"
X-IronPort-AV: E=Sophos;i="5.96,167,1665471600";
d="scan'208";a="398767159"
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
15 Nov 2022 23:57:49 -0800
X-IronPort-AV: E=McAfee;i="6500,9779,10532"; a="702769364"
X-IronPort-AV: E=Sophos;i="5.96,167,1665471600";
d="scan'208";a="702769364"
Received: from ake-mobl.amr.corp.intel.com (HELO vverma7-desk1.intel.com)
([10.209.189.231])
by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
15 Nov 2022 23:57:48 -0800
From: Vishal Verma <vishal.l.verma@intel.com>
To: <linux-acpi@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <nvdimm@lists.linux.dev>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Dan Williams <dan.j.williams@intel.com>, liushixin2@huawei.com,
Vishal Verma <vishal.l.verma@intel.com>,
"Rafael J . Wysocki" <rafael@kernel.org>
Subject: [PATCH 1/2] ACPI: HMAT: remove unnecessary variable initialization
Date: Wed, 16 Nov 2022 00:57:35 -0700
Message-Id: <20221116075736.1909690-2-vishal.l.verma@intel.com>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221116075736.1909690-1-vishal.l.verma@intel.com>
References: <20221116075736.1909690-1-vishal.l.verma@intel.com>
MIME-Version: 1.0
X-Developer-Signature: v=1; a=openpgp-sha256; l=993; h=from:subject;
bh=KiJFxHg73UmbAysUoUdzQCgP2Xj1YpjVLLbX13coZBc=;
b=owGbwMvMwCXGf25diOft7jLG02pJDMkl0z8c2bBOhXPxhhcv27v8VlxRD5I49mFC+5c7y0NDmwr5
vVzPd5SyMIhxMciKKbL83fOR8Zjc9nyewARHmDmsTCBDGLg4BWAi5l8Z/ocvNH5QtEf3/525N/MSzF
9OCLPs6bb4nXLoWZLpm3m5WQ2MDJOd7b994WDqmGTY4Hjm3y0mnqA47QQfk7OVhVcu9lg2cgMA
X-Developer-Key: i=vishal.l.verma@intel.com; a=openpgp;
fpr=F8682BE134C67A12332A2ED07AFA61BEA3B84DFF
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1749638821203142175?=
X-GMAIL-MSGID: =?utf-8?q?1749638821203142175?=
|
| Series |
ACPI: HMAT: fix single-initiator target registrations
|
|
Commit Message
Verma, Vishal L
Nov. 16, 2022, 7:57 a.m. UTC
In hmat_register_target_initiators(), the variable 'best' gets
initialized in the outer per-locality-type for loop. The initialization
just before setting up 'Access 1' targets was unnecessary. Remove it.
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Liu Shixin <liushixin2@huawei.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
drivers/acpi/numa/hmat.c | 1 -
1 file changed, 1 deletion(-)
Comments
On Wed, Nov 16, 2022 at 12:57:35AM -0700, Vishal Verma wrote: > In hmat_register_target_initiators(), the variable 'best' gets > initialized in the outer per-locality-type for loop. The initialization > just before setting up 'Access 1' targets was unnecessary. Remove it. > > Cc: Rafael J. Wysocki <rafael@kernel.org> > Cc: Liu Shixin <liushixin2@huawei.com> > Cc: Dan Williams <dan.j.williams@intel.com> > Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
diff --git a/drivers/acpi/numa/hmat.c b/drivers/acpi/numa/hmat.c index 23f49a2f4d14..144a84f429ed 100644 --- a/drivers/acpi/numa/hmat.c +++ b/drivers/acpi/numa/hmat.c @@ -644,7 +644,6 @@ static void hmat_register_target_initiators(struct memory_target *target) /* Access 1 ignores Generic Initiators */ bitmap_zero(p_nodes, MAX_NUMNODES); list_sort(p_nodes, &initiators, initiator_cmp); - best = 0; for (i = WRITE_LATENCY; i <= READ_BANDWIDTH; i++) { loc = localities_types[i]; if (!loc)