| Message ID | 20231025110252.1089979-1-n-yadav@ti.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp2515009vqx;
Wed, 25 Oct 2023 04:03:41 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IFDKdFBqBFo41A9mvgCqgbUedn9XSWrNz+23RNij+1zmTHuOkeWaKJo67uHl29Uq6p05LLu
X-Received: by 2002:a67:c396:0:b0:457:cbdc:9d4d with SMTP id
s22-20020a67c396000000b00457cbdc9d4dmr14665715vsj.16.1698231821297;
Wed, 25 Oct 2023 04:03:41 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1698231821; cv=none;
d=google.com; s=arc-20160816;
b=KdLQHzjlUP6QaorbZcQmYAY32i4Sp+OZPWL4NhY8Yje7gaXM0X5551NWfdEMgtdb4/
g6q0CHmDCisRBCpib7aJvWH0yErdLgfAqdHVteW67VEiiunwyQABTw3vodvCtr8VGy9k
/oNx21JB5w4pfo3FUxyXwN5DJNcAIiL0UlyxA73fgakcLfs9yV2SEOCO3snDKsRkKnZZ
iPvWM2tXKjhLOoXOb6k0bOhd562cboiUhA68Q5Lw06QXd66DVFJvI5Z2J2GFTTw4NZYv
UNAaskbPX74xvW3fEgZLDjE3807MR+Hf7pvFuBDAoxIhino/395uZ4i7zyLlA2XjwaPY
0tGg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=tsR/jGeOS7j/byRLH70HD81QBaZOXaMQ6O8z9Vg2G8E=;
fh=wRy+0P4PRbqeISr0G5B5SsLmRsUbmsPjMVMxcl8infM=;
b=B3ew1WujALHazXLxCIRr3uH+7rEH+crPcHZvp+KOhEK6xwL0Rvf6cUmHHjMTEon/7k
1b5i/64GWxXqmRlAvkJH25rhZnIzm6rJfGyxxttcV7EARTUu0qQUEW5xqcyqoRurz7V6
jI1Z6p7zG9vLg/oxrKLPP+inra/+d1aLv9NHdbOjNHfUrsCAWPtNnGghe3/zuMmZBS0G
0Ybo59dmNvOUFBkD90aMrTrDqKKzjC2etI9GDHzvu6bJggZ+sqaf8CMSx/pjWyTViz7q
lPPbuJSzH7tGVEy3TxKmgDAjMlVhkX9o+PbBCMXNH2YvJn3ZMPRHombCpn1pl3nq5DQM
kCaw==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="xP2z/beP";
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:5 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com
Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5])
by mx.google.com with ESMTPS id
h22-20020a67c596000000b00457835ff141si1165756vsk.103.2023.10.25.04.03.40
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 25 Oct 2023 04:03:41 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:5 as permitted sender)
client-ip=2620:137:e000::3:5;
Authentication-Results: mx.google.com;
dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="xP2z/beP";
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:5 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by groat.vger.email (Postfix) with ESMTP id 968A38087F37;
Wed, 25 Oct 2023 04:03:38 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S233804AbjJYLDN (ORCPT <rfc822;aposhian.dev@gmail.com>
+ 26 others); Wed, 25 Oct 2023 07:03:13 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38252 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229456AbjJYLDL (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 25 Oct 2023 07:03:11 -0400
Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE98A10A;
Wed, 25 Oct 2023 04:03:09 -0700 (PDT)
Received: from lelv0266.itg.ti.com ([10.180.67.225])
by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 39PB2sMF052558;
Wed, 25 Oct 2023 06:02:54 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com;
s=ti-com-17Q1; t=1698231774;
bh=tsR/jGeOS7j/byRLH70HD81QBaZOXaMQ6O8z9Vg2G8E=;
h=From:To:CC:Subject:Date;
b=xP2z/bePPynE0V4wYxezNONKJl4QkGu/+Pu1waEI/yyar9AeozU5rW8W01WSpzAk3
rrDOBjpkzDhuAAgQ25eYVG0lpexdTVXTDfhiBKRdvxHNziQ1l4zMQ0pm4gnB+mgMJy
pm6pvdYPk6fMzDhVjEKS591JeLCMuamGHYNfmefM=
Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24])
by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 39PB2s0P090537
(version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL);
Wed, 25 Oct 2023 06:02:54 -0500
Received: from DFLE104.ent.ti.com (10.64.6.25) by DFLE103.ent.ti.com
(10.64.6.24) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 25
Oct 2023 06:02:54 -0500
Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE104.ent.ti.com
(10.64.6.25) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via
Frontend Transport; Wed, 25 Oct 2023 06:02:54 -0500
Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6])
by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 39PB2r0i025543;
Wed, 25 Oct 2023 06:02:53 -0500
From: Nitin Yadav <n-yadav@ti.com>
To: <nm@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>
CC: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] arm64: boot: dts: ti: k3-am62a-main: Fix GPIO pin count in DT
nodes.
Date: Wed, 25 Oct 2023 16:32:52 +0530
Message-ID: <20231025110252.1089979-1-n-yadav@ti.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]);
Wed, 25 Oct 2023 04:03:38 -0700 (PDT)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1780725130213250874
X-GMAIL-MSGID: 1780725130213250874
|
| Series |
arm64: boot: dts: ti: k3-am62a-main: Fix GPIO pin count in DT nodes.
|
|
Commit Message
Nitin Yadav
Oct. 25, 2023, 11:02 a.m. UTC
Fix number of gpio pins in main_gpio0 & main_gpio1 DT nodes according
to AM62a SK datasheet. The Link of datasheet is in the following line:
https://www.ti.com/lit/gpn/am62a3
Section: 6.3.10 GPIO (Page No. 52-55)
Fixes: '5fc6b1b62639c ("arm64: dts: ti: Introduce AM62A7 family of SoCs")'
Signed-off-by: Nitin Yadav <n-yadav@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 25/10/2023 13:02, Nitin Yadav wrote: > Fix number of gpio pins in main_gpio0 & main_gpio1 DT nodes according > to AM62a SK datasheet. The Link of datasheet is in the following line: > > https://www.ti.com/lit/gpn/am62a3 > > Section: 6.3.10 GPIO (Page No. 52-55) > > Fixes: '5fc6b1b62639c ("arm64: dts: ti: Introduce AM62A7 family of SoCs")' > No line breaks between tags. Best regards, Krzysztof
On 16:32-20231025, Nitin Yadav wrote: > Fix number of gpio pins in main_gpio0 & main_gpio1 DT nodes according > to AM62a SK datasheet. The Link of datasheet is in the following line: SK? line? Please rephrase above and just mention the section of the data sheet to refer to. > > https://www.ti.com/lit/gpn/am62a3 > > Section: 6.3.10 GPIO (Page No. 52-55) > > Fixes: '5fc6b1b62639c ("arm64: dts: ti: Introduce AM62A7 family of SoCs")' What is the single quote for? Also note the additional comment in the list to drop the extra EoL. Did you check the MCU and WKUP GPIO count as well? if there are bugs around it, fix it in a single commit please. > > Signed-off-by: Nitin Yadav <n-yadav@ti.com> > --- > arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi > index 3198af08fb9f..de36abb243f1 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi > @@ -462,7 +462,7 @@ main_gpio0: gpio@600000 { > <193>, <194>, <195>; > interrupt-controller; > #interrupt-cells = <2>; > - ti,ngpio = <87>; > + ti,ngpio = <92>; > ti,davinci-gpio-unbanked = <0>; > power-domains = <&k3_pds 77 TI_SCI_PD_EXCLUSIVE>; > clocks = <&k3_clks 77 0>; > @@ -480,7 +480,7 @@ main_gpio1: gpio@601000 { > <183>, <184>, <185>; > interrupt-controller; > #interrupt-cells = <2>; > - ti,ngpio = <88>; > + ti,ngpio = <52>; > ti,davinci-gpio-unbanked = <0>; > power-domains = <&k3_pds 78 TI_SCI_PD_EXCLUSIVE>; > clocks = <&k3_clks 78 0>; > -- > 2.25.1 >
On 25/10/23 21:27, Nishanth Menon wrote: > On 16:32-20231025, Nitin Yadav wrote: >> Fix number of gpio pins in main_gpio0 & main_gpio1 DT nodes according >> to AM62a SK datasheet. The Link of datasheet is in the following line: > > SK? line? > > Please rephrase above and just mention the section of the data sheet to > refer to. > >> >> https://www.ti.com/lit/gpn/am62a3 >> >> Section: 6.3.10 GPIO (Page No. 52-55) > >> >> Fixes: '5fc6b1b62639c ("arm64: dts: ti: Introduce AM62A7 family of SoCs")' > > What is the single quote for? > Also note the additional comment in the list to drop the extra EoL. > > > Did you check the MCU and WKUP GPIO count as well? if there are bugs > around it, fix it in a single commit please. yes, checked they are good. > >> >> Signed-off-by: Nitin Yadav <n-yadav@ti.com> >> --- >> arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi >> index 3198af08fb9f..de36abb243f1 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi >> @@ -462,7 +462,7 @@ main_gpio0: gpio@600000 { >> <193>, <194>, <195>; >> interrupt-controller; >> #interrupt-cells = <2>; >> - ti,ngpio = <87>; >> + ti,ngpio = <92>; >> ti,davinci-gpio-unbanked = <0>; >> power-domains = <&k3_pds 77 TI_SCI_PD_EXCLUSIVE>; >> clocks = <&k3_clks 77 0>; >> @@ -480,7 +480,7 @@ main_gpio1: gpio@601000 { >> <183>, <184>, <185>; >> interrupt-controller; >> #interrupt-cells = <2>; >> - ti,ngpio = <88>; >> + ti,ngpio = <52>; >> ti,davinci-gpio-unbanked = <0>; >> power-domains = <&k3_pds 78 TI_SCI_PD_EXCLUSIVE>; >> clocks = <&k3_clks 78 0>; >> -- >> 2.25.1 >> >
On 12:17-20231026, Nitin Yadav wrote: > On 25/10/23 21:27, Nishanth Menon wrote: > > On 16:32-20231025, Nitin Yadav wrote: > >> Fix number of gpio pins in main_gpio0 & main_gpio1 DT nodes according > >> to AM62a SK datasheet. The Link of datasheet is in the following line: > > > > SK? line? > > > > Please rephrase above and just mention the section of the data sheet to > > refer to. > > > >> > >> https://www.ti.com/lit/gpn/am62a3 > >> > >> Section: 6.3.10 GPIO (Page No. 52-55) > > > >> > >> Fixes: '5fc6b1b62639c ("arm64: dts: ti: Introduce AM62A7 family of SoCs")' > > > > What is the single quote for? > > Also note the additional comment in the list to drop the extra EoL. > > > > > > Did you check the MCU and WKUP GPIO count as well? if there are bugs > > around it, fix it in a single commit please. > yes, checked they are good. OK, Thanks for checking, please respin once rc1 is out.
diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi index 3198af08fb9f..de36abb243f1 100644 --- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi @@ -462,7 +462,7 @@ main_gpio0: gpio@600000 { <193>, <194>, <195>; interrupt-controller; #interrupt-cells = <2>; - ti,ngpio = <87>; + ti,ngpio = <92>; ti,davinci-gpio-unbanked = <0>; power-domains = <&k3_pds 77 TI_SCI_PD_EXCLUSIVE>; clocks = <&k3_clks 77 0>; @@ -480,7 +480,7 @@ main_gpio1: gpio@601000 { <183>, <184>, <185>; interrupt-controller; #interrupt-cells = <2>; - ti,ngpio = <88>; + ti,ngpio = <52>; ti,davinci-gpio-unbanked = <0>; power-domains = <&k3_pds 78 TI_SCI_PD_EXCLUSIVE>; clocks = <&k3_clks 78 0>;