Message ID | 20221116103457.27486-1-matt.hsiao@hpe.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp75197wru; Wed, 16 Nov 2022 03:00:16 -0800 (PST) X-Google-Smtp-Source: AA0mqf7VfZbKIfnRW85CyA90BB0yPYdU1lzPYEMOqbtKEKrYfjMvIzEZKRPohVdyZ+hBk4wVR7Z4 X-Received: by 2002:a17:906:b019:b0:78e:ebb:cbb7 with SMTP id v25-20020a170906b01900b0078e0ebbcbb7mr17600662ejy.38.1668596416666; Wed, 16 Nov 2022 03:00:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668596416; cv=none; d=google.com; s=arc-20160816; b=Y6NbZ0iBfcfii8mkaVxP01TsVh/GZpTMbNkbGtBatgcIwEDuCYgvHTlhk+EiFS10E7 eyxdlbr9XgSsbHyoSxr/Yp9yZmI016hJFY7PmXVEKG5SYatQCFi7rh2l3Em1wdz3WCWX vt5rdssWHZRG4sgd+vxcwXxWTLW/2blqlCkf9P0Hj9OnRT/ypZMifznYjOjj+h6sboy+ rZY/DOmmX5sp7LLDT9r5/8fq4KtkcYllDN0y5fJ17VWUUYUrPP4ibDx/ZLal879eF0F3 z4DIx1hK53DKn+dll9wci5LCkqBkl09lX5+iIj8WWuBCp32f5d1vd6dZbGM0UqJCsnh+ /KkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=WNs+HcR+QNWT2YDAGWmbUqdwl5tguMshyXbrCyDQhCY=; b=Gy6SOv2Sm3yAvniHw+DCvM1ckonZcPA0lCBkp1kTWDYBfKiRZHZ2P0gWfz0Mg+TYbz U/uTHNjR9ewi17TfX7j6ruVTWlMssaDh/uB8JGx2WV8Lj86Ofo/kru3CEMmHf2lM1/wL Am/e4YyKUw1y3U/LICFIWJRmZNXgy9rNF2fmJjEuYGcNvNR+tKfzccNrLq1LUdPzZCEJ SumWqQnnqTnN+nyehMyxXcMEMl5dt1uEsl0VqYxB7QrwYFfOGfb3FEvtHjiV9tvZZPDw h+xtRKg2mXBjfIInggmbYqzmd06Xay5IKtEfFgodV/YU6FJ4bGmDND23ZvrM3umSsV8P cX7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=YYbR6kPG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=hpe.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hz3-20020a1709072ce300b007acc6769292si14356610ejc.365.2022.11.16.02.59.52; Wed, 16 Nov 2022 03:00:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=YYbR6kPG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=hpe.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238660AbiKPKsA (ORCPT <rfc822;just.gull.subs@gmail.com> + 99 others); Wed, 16 Nov 2022 05:48:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239201AbiKPKre (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 16 Nov 2022 05:47:34 -0500 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B11048743 for <linux-kernel@vger.kernel.org>; Wed, 16 Nov 2022 02:35:21 -0800 (PST) Received: from pps.filterd (m0134422.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2AGAWQ2V003406; Wed, 16 Nov 2022 10:35:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id; s=pps0720; bh=WNs+HcR+QNWT2YDAGWmbUqdwl5tguMshyXbrCyDQhCY=; b=YYbR6kPGA1bsKZJdb1lhmvP0YBhVbblkdVaXbpjzMHNfnlUbqEbo7WaYM7AzlAN6O1oO gfBZWFjdrt3Ea56iPJpLQZLy65maFZH0Jw7yi95OJoREgCTV4iiFHQhfJaHQ17ta9dQH E8TZzkFiSIJlzNoaPRTCg+uiQFuqG5EbkXJ78r0EWyTgUiE1DBpIMWK5HX0Hk1Ey8kU7 vYRHfqGmKftp/oEPXhCa6AApsbE4QmfpGdU1M1hlKfcWIChEaXFBPU4GTSkVj6csaIbi uJdzJ6ocnTm/NuhN5MV8r5lB2TXGoQ0JfrLR2XXAhpt818ePOM2Drv64Hfmo2F5vyNMl WA== Received: from p1lg14879.it.hpe.com (p1lg14879.it.hpe.com [16.230.97.200]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 3kvx6p00tc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Nov 2022 10:35:06 +0000 Received: from p1lg14885.dc01.its.hpecorp.net (unknown [10.119.18.236]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by p1lg14879.it.hpe.com (Postfix) with ESMTPS id DCFA62FD00; Wed, 16 Nov 2022 10:35:05 +0000 (UTC) Received: from blofly.os1.tw (unknown [16.231.227.36]) by p1lg14885.dc01.its.hpecorp.net (Postfix) with ESMTP id 2CB21804081; Wed, 16 Nov 2022 10:35:00 +0000 (UTC) From: matt.hsiao@hpe.com To: linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, arnd@arndb.de, christophe.jaillet@wanadoo.fr, gustavoars@kernel.org, nishadkamdar@gmail.com, torvalds@linux-foundation.org, dhaval.experiance@gmail.com, viro@zeniv.linux.org.uk, arvind.yadav.cs@gmail.com, standby24x7@gmail.com, wfp5p@virginia.edu, jslaby@suse.cz, prarit@redhat.com, tj@kernel.org, adobriyan@gmail.com, Matt Hsiao <matt.hsiao@hpe.com> Subject: [PATCH v2] misc: hpilo: relicense HPE iLO driver as Dual MIT/GPL Date: Wed, 16 Nov 2022 18:34:57 +0800 Message-Id: <20221116103457.27486-1-matt.hsiao@hpe.com> X-Mailer: git-send-email 2.16.6 X-Proofpoint-GUID: 8CMyYqZ-qzxY5PQW7Q4LkMcIYrrr3I2g X-Proofpoint-ORIG-GUID: 8CMyYqZ-qzxY5PQW7Q4LkMcIYrrr3I2g X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-16_01,2022-11-16_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 spamscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 suspectscore=0 mlxlogscore=999 clxscore=1015 malwarescore=0 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211160073 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749646166983567874?= X-GMAIL-MSGID: =?utf-8?q?1749650156313396552?= |
Series |
[v2] misc: hpilo: relicense HPE iLO driver as Dual MIT/GPL
|
|
Commit Message
Matt Hsiao
Nov. 16, 2022, 10:34 a.m. UTC
From: Matt Hsiao <matt.hsiao@hpe.com> Currently, the hpilo driver is licensed as GPL. To run OpenBSD on HPE servers with BMC (HPE iLO) functionality, a dual MIT/GPL license is needed for porting the hpilo driver to OpenBSD. Signed-off-by: Matt Hsiao <matt.hsiao@hpe.com> --- Hello contributors in the CC list, Thanks for your contributions to the hpilo driver. Please kindly review the license change and hopefully you would agree and approve it. Thanks! Patch v2: --------- - Change MODULE_LICENSE to Dual MIT/GPL too drivers/misc/hpilo.c | 4 ++-- drivers/misc/hpilo.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
Comments
On 16. 11. 22, 11:34, matt.hsiao@hpe.com wrote: > From: Matt Hsiao <matt.hsiao@hpe.com> > > Currently, the hpilo driver is licensed as GPL. To run OpenBSD on HPE > servers with BMC (HPE iLO) functionality, a dual MIT/GPL license is needed > for porting the hpilo driver to OpenBSD. Acked-by: Jiri Slaby <jirislaby@kernel.org> > Signed-off-by: Matt Hsiao <matt.hsiao@hpe.com> > --- > > Hello contributors in the CC list, > > Thanks for your contributions to the hpilo driver. Please kindly review > the license change and hopefully you would agree and approve it. Thanks! > > Patch v2: > --------- > - Change MODULE_LICENSE to Dual MIT/GPL too > > drivers/misc/hpilo.c | 4 ++-- > drivers/misc/hpilo.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/misc/hpilo.c b/drivers/misc/hpilo.c > index 8d00df9243c4..137063857e8d 100644 > --- a/drivers/misc/hpilo.c > +++ b/drivers/misc/hpilo.c > @@ -1,4 +1,4 @@ > -// SPDX-License-Identifier: GPL-2.0 > +// SPDX-License-Identifier: GPL-2.0 OR MIT > /* > * Driver for the HP iLO management processor. > * > @@ -924,7 +924,7 @@ MODULE_VERSION("1.5.0"); > MODULE_ALIAS(ILO_NAME); > MODULE_DESCRIPTION(ILO_NAME); > MODULE_AUTHOR("David Altobelli <david.altobelli@hpe.com>"); > -MODULE_LICENSE("GPL v2"); > +MODULE_LICENSE("Dual MIT/GPL"); > > module_param(max_ccb, uint, 0444); > MODULE_PARM_DESC(max_ccb, "Maximum number of HP iLO channels to attach (8-24)(default=16)"); > diff --git a/drivers/misc/hpilo.h b/drivers/misc/hpilo.h > index d57c34680b09..581dfd7834b8 100644 > --- a/drivers/misc/hpilo.h > +++ b/drivers/misc/hpilo.h > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > +/* SPDX-License-Identifier: GPL-2.0 OR MIT */ > /* > * linux/drivers/char/hpilo.h > *
On Wed, Nov 16, 2022 at 06:34:57PM +0800, matt.hsiao@hpe.com wrote: > From: Matt Hsiao <matt.hsiao@hpe.com> > > Currently, the hpilo driver is licensed as GPL. To run OpenBSD on HPE > servers with BMC (HPE iLO) functionality, a dual MIT/GPL license is needed > for porting the hpilo driver to OpenBSD. > > Signed-off-by: Matt Hsiao <matt.hsiao@hpe.com> > --- > > Hello contributors in the CC list, > > Thanks for your contributions to the hpilo driver. Please kindly review > the license change and hopefully you would agree and approve it. Thanks! > > Patch v2: > --------- > - Change MODULE_LICENSE to Dual MIT/GPL too As I asked for on the v1 version (delayed email on my side), I need a lawyer from HPE to sign off on this change as well. thanks, greg k-h
On Wed, Nov 16, 2022 at 12:36:40PM +0100, Greg KH wrote: > On Wed, Nov 16, 2022 at 06:34:57PM +0800, matt.hsiao@hpe.com wrote: > > From: Matt Hsiao <matt.hsiao@hpe.com> > > > > Currently, the hpilo driver is licensed as GPL. To run OpenBSD on HPE > > servers with BMC (HPE iLO) functionality, a dual MIT/GPL license is needed > > for porting the hpilo driver to OpenBSD. > > > > Signed-off-by: Matt Hsiao <matt.hsiao@hpe.com> > > --- > > > > Hello contributors in the CC list, > > > > Thanks for your contributions to the hpilo driver. Please kindly review > > the license change and hopefully you would agree and approve it. Thanks! > > > > Patch v2: > > --------- > > - Change MODULE_LICENSE to Dual MIT/GPL too > > As I asked for on the v1 version (delayed email on my side), I need a > lawyer from HPE to sign off on this change as well. > > thanks, > > greg k-h Add HPE attorney Aahit Gaba to sign off.
On Thu, Feb 09, 2023 at 09:29:00AM +0530, Aahit Gaba wrote: > On Wed, Nov 16, 2022 at 12:36:40PM +0100, Greg KH wrote: > > On Wed, Nov 16, 2022 at 06:34:57PM +0800, matt.hsiao@hpe.com wrote: > > > From: Matt Hsiao <matt.hsiao@hpe.com> > > > > > > Currently, the hpilo driver is licensed as GPL. To run OpenBSD on > > > HPE servers with BMC (HPE iLO) functionality, a dual MIT/GPL license > > > is needed for porting the hpilo driver to OpenBSD. > > > > > > Signed-off-by: Matt Hsiao <matt.hsiao@hpe.com> > > > --- > > > > > > Hello contributors in the CC list, > > > > > > Thanks for your contributions to the hpilo driver. Please kindly > > > review the license change and hopefully you would agree and approve it. > Thanks! > > > > > > Patch v2: > > > --------- > > > - Change MODULE_LICENSE to Dual MIT/GPL too > > > > As I asked for on the v1 version (delayed email on my side), I need a > > lawyer from HPE to sign off on this change as well. > > > > thanks, > > > > greg k-h > > Add HPE attorney Aahit Gaba to sign off. Signed-off-by: Aahit Gaba <aahit.gaba@hpe.com> The reasons we want to dual license Linux hpilo driver are: - There are required bug fixes that are not copyrighted by HPE in the current Linux hpilo driver. - We want to maintain one hpilo driver between Linux and OpenBSD, and dual-licensing of hpilo driver's existing codebase and all the future bug fixes are the requirements for it. Therefore, we requested all other copyright owners of Linux hpilo driver to accept dual-licensing (MIT/GPL-2.0) for their respective contributions.
On Thu, Feb 09, 2023 at 11:38:12AM +0800, Matt Hsiao wrote: > On Wed, Nov 16, 2022 at 12:36:40PM +0100, Greg KH wrote: > > On Wed, Nov 16, 2022 at 06:34:57PM +0800, matt.hsiao@hpe.com wrote: > > > From: Matt Hsiao <matt.hsiao@hpe.com> > > > > > > Currently, the hpilo driver is licensed as GPL. To run OpenBSD on HPE > > > servers with BMC (HPE iLO) functionality, a dual MIT/GPL license is needed > > > for porting the hpilo driver to OpenBSD. > > > > > > Signed-off-by: Matt Hsiao <matt.hsiao@hpe.com> > > > --- > > > > > > Hello contributors in the CC list, > > > > > > Thanks for your contributions to the hpilo driver. Please kindly review > > > the license change and hopefully you would agree and approve it. Thanks! > > > > > > Patch v2: > > > --------- > > > - Change MODULE_LICENSE to Dual MIT/GPL too > > > > As I asked for on the v1 version (delayed email on my side), I need a > > lawyer from HPE to sign off on this change as well. > > > > thanks, > > > > greg k-h > > Add HPE attorney Aahit Gaba to sign off. You are responding to a 4 month old patch, which is long-gone from my review queue. greg k-h
On Thu, Feb 09, 2023 at 03:59:04AM +0000, Gaba, Aahit wrote: > On Thu, Feb 09, 2023 at 09:29:00AM +0530, Aahit Gaba wrote: > > On Wed, Nov 16, 2022 at 12:36:40PM +0100, Greg KH wrote: > > > On Wed, Nov 16, 2022 at 06:34:57PM +0800, matt.hsiao@hpe.com wrote: > > > > From: Matt Hsiao <matt.hsiao@hpe.com> > > > > > > > > Currently, the hpilo driver is licensed as GPL. To run OpenBSD on > > > > HPE servers with BMC (HPE iLO) functionality, a dual MIT/GPL license > > > > is needed for porting the hpilo driver to OpenBSD. > > > > > > > > Signed-off-by: Matt Hsiao <matt.hsiao@hpe.com> > > > > --- > > > > > > > > Hello contributors in the CC list, > > > > > > > > Thanks for your contributions to the hpilo driver. Please kindly > > > > review the license change and hopefully you would agree and approve it. > > Thanks! > > > > > > > > Patch v2: > > > > --------- > > > > - Change MODULE_LICENSE to Dual MIT/GPL too > > > > > > As I asked for on the v1 version (delayed email on my side), I need a > > > lawyer from HPE to sign off on this change as well. > > > > > > thanks, > > > > > > greg k-h > > > > Add HPE attorney Aahit Gaba to sign off. > > Signed-off-by: Aahit Gaba <aahit.gaba@hpe.com> > > The reasons we want to dual license Linux hpilo driver are: > - There are required bug fixes that are not copyrighted by HPE in the current Linux hpilo driver. And have you identified them and gotten a sign-off from those copyright holders? I don't see that here documented at all, so I imagine you documented it somewhere else? If so, where? > - We want to maintain one hpilo driver between Linux and OpenBSD, and dual-licensing of hpilo driver's existing codebase and all the future bug fixes are the requirements for it. Therefore, we requested all other copyright owners of Linux hpilo driver to accept dual-licensing (MIT/GPL-2.0) for their respective contributions. You can request, you can not require, right? How are you going to deal with the fact that the driver really can not be shared between these two operating systems without a lot of rewriting and changing of the code? Also, this code uses GPL-only symbols out of the Linux kernel, how are you going to handle them in openbsd? Do you have a port of the code to openbsd somewhere for review that shows how this all is translated? And this is really a tiny driver, why not just rewrite it from scratch for openbsd anyway? Odds are that's going to be required to fit into the openbsd driver and coding style, right? thanks, greg k-h
On Fri, Feb 10, 2023 at 12:29:53PM +0100, Greg KH wrote: > On Thu, Feb 09, 2023 at 03:59:04AM +0000, Gaba, Aahit wrote: > > On Thu, Feb 09, 2023 at 09:29:00AM +0530, Aahit Gaba wrote: > > > On Wed, Nov 16, 2022 at 12:36:40PM +0100, Greg KH wrote: > > > > On Wed, Nov 16, 2022 at 06:34:57PM +0800, matt.hsiao@hpe.com wrote: > > > > > From: Matt Hsiao <matt.hsiao@hpe.com> > > > > > > > > > > Currently, the hpilo driver is licensed as GPL. To run OpenBSD on > > > > > HPE servers with BMC (HPE iLO) functionality, a dual MIT/GPL license > > > > > is needed for porting the hpilo driver to OpenBSD. > > > > > > > > > > Signed-off-by: Matt Hsiao <matt.hsiao@hpe.com> > > > > > --- > > > > > > > > > > Hello contributors in the CC list, > > > > > > > > > > Thanks for your contributions to the hpilo driver. Please kindly > > > > > review the license change and hopefully you would agree and approve it. > > > Thanks! > > > > > > > > > > Patch v2: > > > > > --------- > > > > > - Change MODULE_LICENSE to Dual MIT/GPL too > > > > > > > > As I asked for on the v1 version (delayed email on my side), I need a > > > > lawyer from HPE to sign off on this change as well. > > > > > > > > thanks, > > > > > > > > greg k-h > > > > > > Add HPE attorney Aahit Gaba to sign off. > > > > Signed-off-by: Aahit Gaba <aahit.gaba@hpe.com> > > > > The reasons we want to dual license Linux hpilo driver are: > > - There are required bug fixes that are not copyrighted by HPE in the current Linux hpilo driver. > > And have you identified them and gotten a sign-off from those copyright > holders? I don't see that here documented at all, so I imagine you > documented it somewhere else? If so, where? We are under the assumption that hpilo contributors would reply to this thread with their 'Acked-by' or 'Signed-off-by'. Is that the proper approach? We have contacted a number of hpilo driver contributors through email outside of the Linux process. We do have their emails giving permission to dual-licensing their contribution. We can provide those emails if they add value beyond the 'Acked-by' or 'Signed-off-by' process. > > > - We want to maintain one hpilo driver between Linux and OpenBSD, and dual-licensing of hpilo driver's existing codebase and all the future bug fixes are the requirements for it. Therefore, we requested all other copyright owners of Linux hpilo driver to accept dual-licensing (MIT/GPL-2.0) for their respective contributions. > > You can request, you can not require, right? > > How are you going to deal with the fact that the driver really can not > be shared between these two operating systems without a lot of rewriting > and changing of the code? > > Also, this code uses GPL-only symbols out of the Linux kernel, how are > you going to handle them in openbsd? Do you have a port of the code to > openbsd somewhere for review that shows how this all is translated? > > And this is really a tiny driver, why not just rewrite it from scratch > for openbsd anyway? Odds are that's going to be required to fit into > the openbsd driver and coding style, right? > > thanks, > > greg k-h We shouldn't have used the term 'one driver'. More accurate description is we want the core driver features and any changes or bug fixes apply to that dual licensed. We understand that the parts of the driver that are calls to Linux specific functions would be different in OpenBSD. There are also some Linux infrastructure things that would be different in OpenBSD. The key for us is that the core driver features and any future changes be kept in sync between Linux and OpenBSD.
On Tue, Feb 14, 2023 at 04:30:17PM +0800, Matt Hsiao wrote: > On Fri, Feb 10, 2023 at 12:29:53PM +0100, Greg KH wrote: > > On Thu, Feb 09, 2023 at 03:59:04AM +0000, Gaba, Aahit wrote: > > > On Thu, Feb 09, 2023 at 09:29:00AM +0530, Aahit Gaba wrote: > > > > On Wed, Nov 16, 2022 at 12:36:40PM +0100, Greg KH wrote: > > > > > On Wed, Nov 16, 2022 at 06:34:57PM +0800, matt.hsiao@hpe.com wrote: > > > > > > From: Matt Hsiao <matt.hsiao@hpe.com> > > > > > > > > > > > > Currently, the hpilo driver is licensed as GPL. To run OpenBSD on > > > > > > HPE servers with BMC (HPE iLO) functionality, a dual MIT/GPL license > > > > > > is needed for porting the hpilo driver to OpenBSD. > > > > > > > > > > > > Signed-off-by: Matt Hsiao <matt.hsiao@hpe.com> > > > > > > --- > > > > > > > > > > > > Hello contributors in the CC list, > > > > > > > > > > > > Thanks for your contributions to the hpilo driver. Please kindly > > > > > > review the license change and hopefully you would agree and approve it. > > > > Thanks! > > > > > > > > > > > > Patch v2: > > > > > > --------- > > > > > > - Change MODULE_LICENSE to Dual MIT/GPL too > > > > > > > > > > As I asked for on the v1 version (delayed email on my side), I need a > > > > > lawyer from HPE to sign off on this change as well. > > > > > > > > > > thanks, > > > > > > > > > > greg k-h > > > > > > > > Add HPE attorney Aahit Gaba to sign off. > > > > > > Signed-off-by: Aahit Gaba <aahit.gaba@hpe.com> > > > > > > The reasons we want to dual license Linux hpilo driver are: > > > - There are required bug fixes that are not copyrighted by HPE in the current Linux hpilo driver. > > > > And have you identified them and gotten a sign-off from those copyright > > holders? I don't see that here documented at all, so I imagine you > > documented it somewhere else? If so, where? > > We are under the assumption that hpilo contributors would reply to this > thread with their 'Acked-by' or 'Signed-off-by'. Is that the proper > approach? Please work with your legal team to do this properly, they know what to do here. If not, then just don't worry about it (i.e. if it costs too much to do this, just spend the money to write a second driver.) > We shouldn't have used the term 'one driver'. More accurate description > is we want the core driver features and any changes or bug fixes apply > to that dual licensed. We understand that the parts of the driver that > are calls to Linux specific functions would be different in OpenBSD. > There are also some Linux infrastructure things that would be different > in OpenBSD. The key for us is that the core driver features and any > future changes be kept in sync between Linux and OpenBSD. Again, you have full control over this as you are making those changes yourself. I really don't see why you need to do this. Write the OpenBSD driver yourself and see if you could actually share anything. Odds are, the shared parts you already have copyright over today, so there's no issues involved. good luck! greg k-h
diff --git a/drivers/misc/hpilo.c b/drivers/misc/hpilo.c index 8d00df9243c4..137063857e8d 100644 --- a/drivers/misc/hpilo.c +++ b/drivers/misc/hpilo.c @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0 +// SPDX-License-Identifier: GPL-2.0 OR MIT /* * Driver for the HP iLO management processor. * @@ -924,7 +924,7 @@ MODULE_VERSION("1.5.0"); MODULE_ALIAS(ILO_NAME); MODULE_DESCRIPTION(ILO_NAME); MODULE_AUTHOR("David Altobelli <david.altobelli@hpe.com>"); -MODULE_LICENSE("GPL v2"); +MODULE_LICENSE("Dual MIT/GPL"); module_param(max_ccb, uint, 0444); MODULE_PARM_DESC(max_ccb, "Maximum number of HP iLO channels to attach (8-24)(default=16)"); diff --git a/drivers/misc/hpilo.h b/drivers/misc/hpilo.h index d57c34680b09..581dfd7834b8 100644 --- a/drivers/misc/hpilo.h +++ b/drivers/misc/hpilo.h @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0 */ +/* SPDX-License-Identifier: GPL-2.0 OR MIT */ /* * linux/drivers/char/hpilo.h *