Message ID | 20231024223032.3387487-2-chris.packham@alliedtelesis.co.nz |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp2239866vqx; Tue, 24 Oct 2023 15:31:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHXPmajFjxb9d4y8V2gPyuywT7/Iqzv+taYW3UIg4OBUIid2yrPQ35RdWPd+d86F7+YEcpe X-Received: by 2002:a05:6a00:1255:b0:68e:2d59:b1f3 with SMTP id u21-20020a056a00125500b0068e2d59b1f3mr11557418pfi.13.1698186708093; Tue, 24 Oct 2023 15:31:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698186708; cv=none; d=google.com; s=arc-20160816; b=f0N8rz76AKTEkJuByaUyUiayla3OWKqVoidNjqmzK6Zk+Eq9y0DLAtMSKqf4lyLdtQ M2fF4sdVCFrept5lXpy3uTRio1zGmLdK6oUvaUNy0kKR9pVexyjazEKPqVW9BGJlDEGA ONgkLhSOaLcwfwrqT7Xvr+xEJlP9q/txNUygNrIOBBIzw0TYI/ODdroPUh2oU2wGTFzj /WVeD+BCkFTZHt47wLGL0uvi2t6gZkc5j6MKhYr/+w9c6OUSgbupaBvwjwsNZBNI0A71 5EmWjkw4eCOw3yUmyZTkoS/TztLw/5bvstSAM4u7W+PGkJii/Dkem+uvxZnHncir1Le+ 3a+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=3bDTzpfSwjO3Sd+/p7MkKEl3QeZJyG1KTOU0ZV9QQAk=; fh=3tQj0XukzIaVVOd6lLPEALhtzKzMAG+0/N98Vq3ytYw=; b=0tKk62iOQPCVEtbJLEDARvySUTtLS0/b1KhuKApqPwZ9Wd4rjUtkBna1nfuhjFZf6X vNkTl8KdjA+G33ipitMqlWhfuxsxzcA3Tp3fdmpSSCbfKAxCmz+DDbha1/5+zLtIE6G1 9G7sNe+P5WBWUMKANdQLflZJC8QNa8EZDLiyqjaSDxB6U5mLZBoL2sksMLqQ7rcIzZaD bkytvkf+JRIUuRnPvKPPW3l7YvxIRj4lk/wwLv5YFaji7LZKFzqHd9H5upMosQJGsV/0 aaZy1av3sMq3WB0pGj3wL0rxn5KLgOzGpJON18Y1EW0Afg6lo+WvrSPdB7QE9JckcMl/ e+5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alliedtelesis.co.nz header.s=mail181024 header.b="1d/46ty3"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=alliedtelesis.co.nz Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id f4-20020aa79684000000b00690c1e51cdfsi8950770pfk.188.2023.10.24.15.31.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 15:31:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@alliedtelesis.co.nz header.s=mail181024 header.b="1d/46ty3"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=alliedtelesis.co.nz Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 84F3980D0E06; Tue, 24 Oct 2023 15:31:45 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344554AbjJXWbf (ORCPT <rfc822;aposhian.dev@gmail.com> + 27 others); Tue, 24 Oct 2023 18:31:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344519AbjJXWbZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 24 Oct 2023 18:31:25 -0400 Received: from gate2.alliedtelesis.co.nz (gate2.alliedtelesis.co.nz [IPv6:2001:df5:b000:5::4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDAFB3853 for <linux-kernel@vger.kernel.org>; Tue, 24 Oct 2023 15:30:42 -0700 (PDT) Received: from svr-chch-seg1.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id 5BE622C04C7; Wed, 25 Oct 2023 11:30:35 +1300 (NZDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1698186635; bh=3bDTzpfSwjO3Sd+/p7MkKEl3QeZJyG1KTOU0ZV9QQAk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1d/46ty3ZwCJ+DaNUgGFlsn/fcCEGxRmMWs9f+CmZiJWmGsUTyj/u9r5uYu7JsXoJ 63QS+4SnQuv1bXBuzbn0zdPivGmSTFK5QjKU28ysQuwykr+0IrlGi9wT+7tGndC4Qx OvXcffDVCWvmDy7aX8sYvLyUn3n4L+TnlyxuiN1ALqBDL2mGE+Dg0AAby0g5niMHA5 3ilHfNxIO1TRy6Xn20opxQfWxj30VHNSdvQuEv7XlpDA1idG/cEvWnWq/R3AerCBVM F8w7CIsgRrhvlX64ZYk3KB+B59aQ6qDSkuBVyp87KL9upO9MsHNapq93Lyowai95ab n7LXxdC0F2Kfw== Received: from pat.atlnz.lc (Not Verified[10.32.16.33]) by svr-chch-seg1.atlnz.lc with Trustwave SEG (v8,2,6,11305) id <B6538458b0001>; Wed, 25 Oct 2023 11:30:35 +1300 Received: from chrisp-dl.ws.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.30]) by pat.atlnz.lc (Postfix) with ESMTP id 148DC13EE44; Wed, 25 Oct 2023 11:30:35 +1300 (NZDT) Received: by chrisp-dl.ws.atlnz.lc (Postfix, from userid 1030) id 10F06280820; Wed, 25 Oct 2023 11:30:35 +1300 (NZDT) From: Chris Packham <chris.packham@alliedtelesis.co.nz> To: gregory.clement@bootlin.com, andi.shyti@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Packham <chris.packham@alliedtelesis.co.nz> Subject: [PATCH v4 1/2] dt-bindings: i2c: mv64xxx: add reset-gpios property Date: Wed, 25 Oct 2023 11:30:31 +1300 Message-ID: <20231024223032.3387487-2-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231024223032.3387487-1-chris.packham@alliedtelesis.co.nz> References: <20231024223032.3387487-1-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SEG-SpamProfiler-Analysis: v=2.3 cv=L6ZjvNb8 c=1 sm=1 tr=0 a=KLBiSEs5mFS1a/PbTCJxuA==:117 a=bhdUkHdE2iEA:10 a=KKAkSRfTAAAA:8 a=N1qcaoclDu5WUfG3NQYA:9 a=cvBusfyB2V15izCimMoJ:22 X-SEG-SpamProfiler-Score: 0 x-atlnz-ls: pat X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 24 Oct 2023 15:31:45 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780677825805066574 X-GMAIL-MSGID: 1780677825805066574 |
Series |
i2c: mv64xxx: reset-gpios
|
|
Commit Message
Chris Packham
Oct. 24, 2023, 10:30 p.m. UTC
Add reset-gpios and reset-duration-us properties to the marvell,mv64xxx-i2c binding. These can be used to describe hardware where a common reset GPIO is connected to all downstream devices on and I2C bus. This reset will be asserted then released before the downstream devices on the bus are probed. Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Notes: Changes in v4: - Add r-by from Krzysztof Changes in v3: - Rename reset-delay-us to reset-duration-us to better reflect its purpose - Add default: for reset-duration-us - Add description: for reset-gpios Changes in v2: - Update commit message - Add reset-delay-us property .../devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+)
Comments
Hi Chris, On Wed, Oct 25, 2023 at 11:30:31AM +1300, Chris Packham wrote: > Add reset-gpios and reset-duration-us properties to the > marvell,mv64xxx-i2c binding. These can be used to describe hardware > where a common reset GPIO is connected to all downstream devices on and > I2C bus. This reset will be asserted then released before the downstream > devices on the bus are probed. > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Andi Shyti <andi.shyti@kernel.org> Thanks, Andi
> + reset-gpios: > + description: > + GPIO pin providing a common reset for all downstream devices. This GPIO > + will be asserted then released before the downstream devices are probed. How about renaming this to "bus-reset-gpios"? Reason: When I read "reset-gpios", then I assume the device itself will be reset. In this case, the Marvell I2C controller. Some I2C mux devices and PCA9564 already use the property like I described.
(resend as plain text) On 27/10/23 00:15, Wolfram Sang wrote: >> + reset-gpios: >> + description: >> + GPIO pin providing a common reset for all downstream devices. This GPIO >> + will be asserted then released before the downstream devices are probed. > How about renaming this to "bus-reset-gpios"? > > Reason: When I read "reset-gpios", then I assume the device itself will > be reset. In this case, the Marvell I2C controller. Some I2C mux devices > and PCA9564 already use the property like I described. I don't have an objection to "bus-reset-gpios" it would be trivial for me to spin a v5 with the naming changed if everyone is in agreement (given my timezone I might just send out a v5 with this change and then it can be argued whether to apply v4 or v5).
diff --git a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml index 461d1c9ee3f7..ecf5b279cfa4 100644 --- a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml +++ b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml @@ -70,6 +70,16 @@ properties: resets: maxItems: 1 + reset-gpios: + description: + GPIO pin providing a common reset for all downstream devices. This GPIO + will be asserted then released before the downstream devices are probed. + maxItems: 1 + + reset-duration-us: + description: Reset duration in us. + default: 1 + dmas: items: - description: RX DMA Channel