diff mbox series

[7/7] pinctrl: qcom: spmi-gpio: add support for pmr735d gpio control

Message ID 20221114-narmstrong-sm8550-upstream-spmi-v1-7-6338a2b4b241@linaro.org
State New
Headers
Series qcom: add support for SPMI PMICs found on SM8550 platforms |

Commit Message

Neil Armstrong Nov. 16, 2022, 10:11 a.m. UTC 
  Add support for the pmr735d gpio controller providing GPIO control over SPMI.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Konrad Dybcio Nov. 16, 2022, 10:22 a.m. UTC | #1 
On 16/11/2022 11:11, Neil Armstrong wrote:
> Add support for the pmr735d gpio controller providing GPIO control over SPMI.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
Any particular reason this could not be a part of the previous patch?

For the addition itself:
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>   drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index f758522d035e..66d6d7ffbd43 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -1242,6 +1242,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
>   	{ .compatible = "qcom,pmp8074-gpio", .data = (void *) 12 },
>   	{ .compatible = "qcom,pmr735a-gpio", .data = (void *) 4 },
>   	{ .compatible = "qcom,pmr735b-gpio", .data = (void *) 4 },
> +	{ .compatible = "qcom,pmr735d-gpio", .data = (void *) 2 },
>   	/* pms405 has 12 GPIOs with holes on 1, 9, and 10 */
>   	{ .compatible = "qcom,pms405-gpio", .data = (void *) 12 },
>   	/* pmx55 has 11 GPIOs with holes on 3, 7, 10, 11 */
>
Neil Armstrong Nov. 16, 2022, 10:35 a.m. UTC | #2 
Hi,

On 16/11/2022 11:22, Konrad Dybcio wrote:
> 
> 
> On 16/11/2022 11:11, Neil Armstrong wrote:
>> Add support for the pmr735d gpio controller providing GPIO control over SPMI.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
> Any particular reason this could not be a part of the previous patch?

I thought it would be cleaner splitting them by family names, but yeah they could be squashed, same for bindings.

> 
> For the addition itself:
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Thanks!
Neil
> 
> Konrad
>>   drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
>> index f758522d035e..66d6d7ffbd43 100644
>> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
>> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
>> @@ -1242,6 +1242,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
>>       { .compatible = "qcom,pmp8074-gpio", .data = (void *) 12 },
>>       { .compatible = "qcom,pmr735a-gpio", .data = (void *) 4 },
>>       { .compatible = "qcom,pmr735b-gpio", .data = (void *) 4 },
>> +    { .compatible = "qcom,pmr735d-gpio", .data = (void *) 2 },
>>       /* pms405 has 12 GPIOs with holes on 1, 9, and 10 */
>>       { .compatible = "qcom,pms405-gpio", .data = (void *) 12 },
>>       /* pmx55 has 11 GPIOs with holes on 3, 7, 10, 11 */
>>
diff mbox series

Patch

diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index f758522d035e..66d6d7ffbd43 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1242,6 +1242,7 @@  static const struct of_device_id pmic_gpio_of_match[] = {
 	{ .compatible = "qcom,pmp8074-gpio", .data = (void *) 12 },
 	{ .compatible = "qcom,pmr735a-gpio", .data = (void *) 4 },
 	{ .compatible = "qcom,pmr735b-gpio", .data = (void *) 4 },
+	{ .compatible = "qcom,pmr735d-gpio", .data = (void *) 2 },
 	/* pms405 has 12 GPIOs with holes on 1, 9, and 10 */
 	{ .compatible = "qcom,pms405-gpio", .data = (void *) 12 },
 	/* pmx55 has 11 GPIOs with holes on 3, 7, 10, 11 */