[v2,2/3] dt-bindings: adis16475: Add 'spi-cs-inactive-delay-ns' property

Message ID 20231023140534.704312-3-ramona.gradinariu@analog.com
State New
Headers
Series iio: imu: adis: Use spi cs inactive delay |

Commit Message

Ramona Gradinariu Oct. 23, 2023, 2:05 p.m. UTC
  The devices supported by adis16475 driver require a stall period
between SPI transactions (during which the chip select is
inactive), with a minimum value equal to 16 microseconds, thus
adding 'spi-cs-inactive-delay-ns' property, which should indicate
the stall time between consecutive SPI transactions.

Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com>
---
changes in v2:
 - added default value
 - updated description
 - updated commit message
 .../devicetree/bindings/iio/imu/adi,adis16475.yaml          | 6 ++++++
 1 file changed, 6 insertions(+)

--
2.34.1
  

Comments

Krzysztof Kozlowski Oct. 24, 2023, 1:48 p.m. UTC | #1
On 23/10/2023 16:05, Ramona Gradinariu wrote:
> The devices supported by adis16475 driver require a stall period
> between SPI transactions (during which the chip select is
> inactive), with a minimum value equal to 16 microseconds, thus
> adding 'spi-cs-inactive-delay-ns' property, which should indicate
> the stall time between consecutive SPI transactions.
> 
> Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com>
> ---
> changes in v2:
>  - added default value
>  - updated description
>  - updated commit message
>  .../devicetree/bindings/iio/imu/adi,adis16475.yaml          | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
> index c73533c54588..135ccdd5c392 100644
> --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
> @@ -47,6 +47,12 @@ properties:
>    spi-max-frequency:
>      maximum: 2000000
> 
> +  spi-cs-inactive-delay-ns:
> +    minimum: 16000
> +    default: 16000
> +    description:
> +      Indicates the stall time between consecutive SPI transactions.

You can skip the description entirely, it is coming from
spi-peripheral-props.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
  

Patch

diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
index c73533c54588..135ccdd5c392 100644
--- a/Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
+++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16475.yaml
@@ -47,6 +47,12 @@  properties:
   spi-max-frequency:
     maximum: 2000000

+  spi-cs-inactive-delay-ns:
+    minimum: 16000
+    default: 16000
+    description:
+      Indicates the stall time between consecutive SPI transactions.
+
   interrupts:
     maxItems: 1