diff mbox series

[net-next,v6,1/7] dt-bindings: net: dsa: Require ports or ethernet-ports

Message ID 20231024-marvell-88e6152-wan-led-v6-1-993ab0949344@linaro.org
State New
Headers
Series Create a binding for the Marvell MV88E6xxx DSA switches |

Commit Message

Linus Walleij Oct. 24, 2023, 9:24 a.m. UTC 
  Bindings using dsa.yaml#/$defs/ethernet-ports specify that
a DSA switch node need to have a ports or ethernet-ports
subnode, and that is actually required, so add requirements
using oneOf.

Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 Documentation/devicetree/bindings/net/dsa/dsa.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Rob Herring Oct. 24, 2023, 12:48 p.m. UTC | #1 
On Tue, 24 Oct 2023 11:24:53 +0200, Linus Walleij wrote:
> Bindings using dsa.yaml#/$defs/ethernet-ports specify that
> a DSA switch node need to have a ports or ethernet-ports
> subnode, and that is actually required, so add requirements
> using oneOf.
> 
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  Documentation/devicetree/bindings/net/dsa/dsa.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/net/dsa/dsa.yaml:60:5: [warning] wrong indentation: expected 6 but found 4 (indentation)
./Documentation/devicetree/bindings/net/dsa/dsa.yaml:62:5: [warning] wrong indentation: expected 6 but found 4 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231024-marvell-88e6152-wan-led-v6-1-993ab0949344@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Linus Walleij Oct. 24, 2023, 1:18 p.m. UTC | #2 
On Tue, Oct 24, 2023 at 2:48 PM Rob Herring <robh@kernel.org> wrote:
> On Tue, 24 Oct 2023 11:24:53 +0200, Linus Walleij wrote:
> > Bindings using dsa.yaml#/$defs/ethernet-ports specify that
> > a DSA switch node need to have a ports or ethernet-ports
> > subnode, and that is actually required, so add requirements
> > using oneOf.
> >
> > Suggested-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/net/dsa/dsa.yaml | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/net/dsa/dsa.yaml:60:5: [warning] wrong indentation: expected 6 but found 4 (indentation)
> ./Documentation/devicetree/bindings/net/dsa/dsa.yaml:62:5: [warning] wrong indentation: expected 6 but found 4 (indentation)

Oh yeah Krzysztof actually explained to me why these have to have
two spaces extra.

Oh well I just keep hitting the robot for testing this.

Yours,
Linus Walleij
Vladimir Oltean Oct. 24, 2023, 8:10 p.m. UTC | #3 
On Tue, Oct 24, 2023 at 03:18:13PM +0200, Linus Walleij wrote:
> On Tue, Oct 24, 2023 at 2:48 PM Rob Herring <robh@kernel.org> wrote:
> > On Tue, 24 Oct 2023 11:24:53 +0200, Linus Walleij wrote:
> > > Bindings using dsa.yaml#/$defs/ethernet-ports specify that
> > > a DSA switch node need to have a ports or ethernet-ports
> > > subnode, and that is actually required, so add requirements
> > > using oneOf.
> > >
> > > Suggested-by: Rob Herring <robh@kernel.org>
> > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > > ---
> > >  Documentation/devicetree/bindings/net/dsa/dsa.yaml | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> > ./Documentation/devicetree/bindings/net/dsa/dsa.yaml:60:5: [warning] wrong indentation: expected 6 but found 4 (indentation)
> > ./Documentation/devicetree/bindings/net/dsa/dsa.yaml:62:5: [warning] wrong indentation: expected 6 but found 4 (indentation)
> 
> Oh yeah Krzysztof actually explained to me why these have to have
> two spaces extra.
> 
> Oh well I just keep hitting the robot for testing this.
> 
> Yours,
> Linus Walleij

FWIW, we have a rule in Documentation/process/maintainer-netdev.rst to
not repost more frequently than once every 24 hours. Unfortunately I
don't have a huge review capacity right now, so in my case it could
probably take even a bit more than that. But it's a bit unpleasant that
I left some feedback on v4, you posted v5 yesterday and since then we're
now at v7, only for me to find that I need to repeat my v4 feedback.
Linus Walleij Oct. 25, 2023, 8:38 p.m. UTC | #4 
On Tue, Oct 24, 2023 at 10:10 PM Vladimir Oltean <olteanv@gmail.com> wrote:

> FWIW, we have a rule in Documentation/process/maintainer-netdev.rst to
> not repost more frequently than once every 24 hours. Unfortunately I
> don't have a huge review capacity right now, so in my case it could
> probably take even a bit more than that. But it's a bit unpleasant that
> I left some feedback on v4, you posted v5 yesterday and since then we're
> now at v7, only for me to find that I need to repeat my v4 feedback.

I'm sorry, too enthusiastic.
I'll try to pace it down, the patches will not be for v6.7 anyway.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.yaml b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
index 6107189d276a..53ab2158fe2d 100644
--- a/Documentation/devicetree/bindings/net/dsa/dsa.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
@@ -46,4 +46,10 @@  $defs:
             $ref: dsa-port.yaml#
             unevaluatedProperties: false
 
+oneOf:
+  - required:
+    - ports
+  - required:
+    - ethernet-ports
+
 ...