diff mbox series

[3/3] dt-bindings: adis16460: Add 'spi-cs-inactive-delay-ns' property

Message ID 20231023123542.582392-4-ramona.gradinariu@analog.com
State New
Headers
Series iio: imu: adis: Use spi cs inactive delay |

Commit Message

Ramona Gradinariu Oct. 23, 2023, 12:35 p.m. UTC 
  Add 'spi-cs-inactive-delay-ns' property.

Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com>
---
 Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Krzysztof Kozlowski Oct. 23, 2023, 1:22 p.m. UTC | #1 
On 23/10/2023 14:35, Ramona Gradinariu wrote:
> Add 'spi-cs-inactive-delay-ns' property.

This we see from the diff. Commit should explain: Why?

> 
> Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com>
> ---
>  Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> index 4e43c80e5119..3691c0be4f9d 100644
> --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> @@ -25,6 +25,11 @@ properties:
>  
>    spi-cpol: true
>  
> +  spi-cs-inactive-delay-ns:
> +    minimum: 16000
> +    description:
> +      If not explicitly set in the device tree, the driver will set it to 16us.

Why do you even need it here?

Best regards,
Krzysztof
Jonathan Cameron Oct. 24, 2023, 12:27 p.m. UTC | #2 
On Mon, 23 Oct 2023 15:22:30 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 23/10/2023 14:35, Ramona Gradinariu wrote:
> > Add 'spi-cs-inactive-delay-ns' property.  
> 
> This we see from the diff. Commit should explain: Why?
> 
> > 
> > Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com>
> > ---
> >  Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > index 4e43c80e5119..3691c0be4f9d 100644
> > --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > @@ -25,6 +25,11 @@ properties:
> >  
> >    spi-cpol: true
> >  
> > +  spi-cs-inactive-delay-ns:
> > +    minimum: 16000
> > +    description:
> > +      If not explicitly set in the device tree, the driver will set it to 16us.  
> 
> Why do you even need it here?

Along side that, if you have a default
default: xxxx
rather than in the description.


> 
> Best regards,
> Krzysztof
> 
>
Jonathan Cameron Oct. 27, 2023, 1:57 p.m. UTC | #3 
On Tue, 24 Oct 2023 13:27:05 +0100
Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:

> On Mon, 23 Oct 2023 15:22:30 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> 
> > On 23/10/2023 14:35, Ramona Gradinariu wrote:  
> > > Add 'spi-cs-inactive-delay-ns' property.    
> > 
> > This we see from the diff. Commit should explain: Why?
> >   
> > > 
> > > Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com>
> > > ---
> > >  Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > > index 4e43c80e5119..3691c0be4f9d 100644
> > > --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > > @@ -25,6 +25,11 @@ properties:
> > >  
> > >    spi-cpol: true
> > >  
> > > +  spi-cs-inactive-delay-ns:
> > > +    minimum: 16000
> > > +    description:
> > > +      If not explicitly set in the device tree, the driver will set it to 16us.    
> > 
> > Why do you even need it here?  
> 
> Along side that, if you have a default
> default: xxxx
> rather than in the description.

ah. I didn't get Krzysztof's reply to patch 1 for some reason where he already
said this... 

Anyhow, I've nothing to add to comments on v2.  Will aim to pick up v3.

> 
> 
> > 
> > Best regards,
> > Krzysztof
> > 
> >   
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
index 4e43c80e5119..3691c0be4f9d 100644
--- a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
+++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
@@ -25,6 +25,11 @@  properties:
 
   spi-cpol: true
 
+  spi-cs-inactive-delay-ns:
+    minimum: 16000
+    description:
+      If not explicitly set in the device tree, the driver will set it to 16us.
+
   interrupts:
     maxItems: 1