dt-bindings: pinctrl: nuvoton,npcm845: Add missing additionalProperties on gpio child nodes
| Message ID | 20231020170017.3610978-1-robh@kernel.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:612c:2010:b0:403:3b70:6f57 with SMTP id
fe16csp1197721vqb;
Fri, 20 Oct 2023 10:00:57 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IFnMFhxK9UzWtGpMEptq/odH5UZw+wCGJZ4JCepubTi0yjS2Rcg0gWg4M6UrhqJ0aGSQEr2
X-Received: by 2002:a17:902:e542:b0:1c6:11ca:8861 with SMTP id
n2-20020a170902e54200b001c611ca8861mr8389382plf.21.1697821257533;
Fri, 20 Oct 2023 10:00:57 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1697821257; cv=none;
d=google.com; s=arc-20160816;
b=qUpkInNvAGrBBRNZxnRLDyBxyNd6IPmKuxggIejHlcsArNuvfH3vKQDSM3NmIxsxJN
ivrEzyPYeBIpynqj9GJjKbORmE3PkSOIOqTGvkYbRq0bW3i5Sk4+PHwOv9+TJgLDbmn1
17xApycLh3ckpji79HHvrltCizL4lrKkQtDvh/4cT6WznZN+SDmncSK+Nl01IZnz3gPR
gXL4AwI9PXhd1778L9U8ro/botuX1/1Q2aiPLHq8HuUO6VZN3I2e55zjef0QaslxVNrA
7kv8XL2g/MBKYaV3hDA/XWVMq1VTYZLiHhdOYFxYm27LEfVqFMWjSzV+iFjwVUmues1j
kN1w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from;
bh=gzgDuBFq97Xw3QhiJlj4wHN5k/h9ggUGNAdZwlEm5kY=;
fh=qloNASox7BsLpipMifaSpTU8bGHwXszvs3IWR84zXVo=;
b=ALTsbzNEofTowvldcPYa2UTz/SyW2bSNucSNBZrHXKKazdrnBx61PU0S4jlNIY6jby
paqDPUjG9dWXCjYVODRVc+cxab+fBCXwg5LtH8+iVREnKeXnPqe5ZOqVHXwUnT6qztlN
Ic1HiaI4dWNomULssRG3I3GTEBpo637F8SNJfR2RXaFBcFD0VkYeRet6hc4yO81PQ/QH
JCRULnywj7fCP6bVVqQXvxY1FGuKb9AJMvDa1CvVtkFedF3l1o4zDWBF71TKlkH9o9vG
OOc7QRsIjdFb82z6zHYbP7X6un9TKju28Y0xbTe5qqxDZJzNhuF5uUQU3I4jNeF+9Ntg
s1JA==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:1 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1])
by mx.google.com with ESMTPS id
n4-20020a170902968400b0019c354055d0si2046478plp.304.2023.10.20.10.00.52
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 20 Oct 2023 10:00:57 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:1 as permitted sender)
client-ip=2620:137:e000::3:1;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:1 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by morse.vger.email (Postfix) with ESMTP id B1E9683C7148;
Fri, 20 Oct 2023 10:00:50 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229843AbjJTRAk (ORCPT <rfc822;a1648639935@gmail.com>
+ 26 others); Fri, 20 Oct 2023 13:00:40 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32936 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229692AbjJTRAh (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 20 Oct 2023 13:00:37 -0400
Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com
[209.85.161.48])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC76218F;
Fri, 20 Oct 2023 10:00:35 -0700 (PDT)
Received: by mail-oo1-f48.google.com with SMTP id
006d021491bc7-57e4459aa29so537574eaf.0;
Fri, 20 Oct 2023 10:00:35 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1697821235; x=1698426035;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=gzgDuBFq97Xw3QhiJlj4wHN5k/h9ggUGNAdZwlEm5kY=;
b=WD5kBW3EzWl+4QsIBxzDAGjjNu/8dJf/9LEEuDWQW/KiD/sGMfrYMl6mO2vNtUfj0d
sdJqta0knaz8l8H2V1Cm+rthGYSfJPDtw4S3oeQqRKSTwQCvedngd9D9UvmPEO9y5fpl
XjVoW4mGgomqZ7TwqK7qrdwtPz/iTArl6olnc/nk53fo4fhaMUi8z+ZDfTu3l01NcBOu
WBQPqCtUuhRQQDxsAboXSX077J7X/XjVhfYgPT+cnTDzT0vYbt1ak3ISyKSyHn6zLiL3
XlrEDmu0aUU3Hm96J/pK+Ikvutcz4AmWf4qn4OoiFTvVWcDq96qZqXkMGFGsUFyD+3uj
bQBA==
X-Gm-Message-State: AOJu0YzWHeHeY3ORzF6nFP9jtjY8f79NS+YFO+sT3FP8WNLPl8fsWjgd
LxTAyHRMU7j5sJJAT4a9dQ==
X-Received: by 2002:a4a:c4ca:0:b0:581:f262:dde0 with SMTP id
g10-20020a4ac4ca000000b00581f262dde0mr1202983ooq.3.1697821234626;
Fri, 20 Oct 2023 10:00:34 -0700 (PDT)
Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net.
[66.90.144.107])
by smtp.gmail.com with ESMTPSA id
ce12-20020a056820218c00b0055975f57993sm409614oob.42.2023.10.20.10.00.33
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 20 Oct 2023 10:00:33 -0700 (PDT)
Received: (nullmailer pid 3613652 invoked by uid 1000);
Fri, 20 Oct 2023 17:00:32 -0000
From: Rob Herring <robh@kernel.org>
To: Avi Fishman <avifishman70@gmail.com>,
Tomer Maimon <tmaimon77@gmail.com>,
Tali Perry <tali.perry1@gmail.com>,
Patrick Venture <venture@google.com>,
Nancy Yuen <yuenn@google.com>,
Benjamin Fair <benjaminfair@google.com>,
Linus Walleij <linus.walleij@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] dt-bindings: pinctrl: nuvoton,npcm845: Add missing
additionalProperties on gpio child nodes
Date: Fri, 20 Oct 2023 12:00:16 -0500
Message-ID: <20231020170017.3610978-1-robh@kernel.org>
X-Mailer: git-send-email 2.42.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI,
SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]);
Fri, 20 Oct 2023 10:00:50 -0700 (PDT)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1780294622891981685
X-GMAIL-MSGID: 1780294622891981685
|
| Series |
dt-bindings: pinctrl: nuvoton,npcm845: Add missing additionalProperties on gpio child nodes
|
|
Commit Message
Rob Herring
Oct. 20, 2023, 5 p.m. UTC
Just as unevaluatedProperties or additionalProperties are required at
the top level of schemas, they should (and will) also be required for
child node schemas. That ensures only documented properties are
present for any node. Add the missing addtionalProperties to the 'gpio'
child nodes.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml | 1 +
1 file changed, 1 insertion(+)
Comments
On Fri, Oct 20, 2023 at 12:00:16PM -0500, Rob Herring wrote: > Just as unevaluatedProperties or additionalProperties are required at > the top level of schemas, they should (and will) also be required for > child node schemas. That ensures only documented properties are > present for any node. Add the missing addtionalProperties to the 'gpio' > child nodes. > > Signed-off-by: Rob Herring <robh@kernel.org> Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > .../devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml > index e4b9f3da2cf0..3e8472898800 100644 > --- a/Documentation/devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml > @@ -35,6 +35,7 @@ properties: > patternProperties: > '^gpio@': > type: object > + additionalProperties: false > > description: > Eight GPIO banks that each contain 32 GPIOs. > -- > 2.42.0 >
On Fri, Oct 20, 2023 at 7:00 PM Rob Herring <robh@kernel.org> wrote: > Just as unevaluatedProperties or additionalProperties are required at > the top level of schemas, they should (and will) also be required for > child node schemas. That ensures only documented properties are > present for any node. Add the missing addtionalProperties to the 'gpio' > child nodes. > > Signed-off-by: Rob Herring <robh@kernel.org> Patch applied! Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml index e4b9f3da2cf0..3e8472898800 100644 --- a/Documentation/devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/nuvoton,npcm845-pinctrl.yaml @@ -35,6 +35,7 @@ properties: patternProperties: '^gpio@': type: object + additionalProperties: false description: Eight GPIO banks that each contain 32 GPIOs.