wwwdocs: gcc-14: mark amdgcn fiji deprecated
Checks
Commit Message
OK to commit?
Andrew
gcc-14: mark amdgcn fiji deprecated
Comments
On 19.10.23 11:49, Andrew Stubbs wrote:
> OK to commit?
(I think as maintainer you don't need approval - but of course comments
by others can be helpful; I hope mine are. Additionally, Gerald (CCed)
helps with keeping the webpages in good shape (thanks!).)
> gcc-14: mark amdgcn fiji deprecated
> diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
> index c817dde4..91ab8132 100644
> --- a/htdocs/gcc-14/changes.html
> +++ b/htdocs/gcc-14/changes.html
> @@ -178,6 +178,16 @@ a work-in-progress.</p>
>
> <!-- <h3 id="aarch64">AArch64</h3> -->
>
> +<h3 id="amdgcn">AMD Radeon (GCN)</h3>
> +
> +<ul>
> + <li>The Fiji device support is now deprecated and will be removed from a
> + future release. The default compiler configuration no longer uses Fiji
> + as the default device, and no longer includes the Fiji libraries. Both
> + can be restored by configuring with <code>--with-arch=fiji</code>.</li>
> + <li>The default device architecture is now <code>gfx900</code> (Vega).</li>
> +</ul>
Can you add <a href="...">...</a> around the "--with-arch=fiji"? Linking to
https://gcc.gnu.org/install/specific.html#amdgcn-x-amdhsa
I think that page is helpful (once the cron job has updated that page).
Additionally, I wonder whether "Fiji" should be changed to "Fiji
(gfx803)" in the first line and whether the "," should be removed in
"The ... configuration ... , and no longer includes".
Thanks,
Tobias
> +
> <!-- <h3 id="arc">ARC</h3> -->
>
> <!-- <h3 id="arm">arm</h3> -->
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
On 19/10/2023 11:07, Tobias Burnus wrote:
> On 19.10.23 11:49, Andrew Stubbs wrote:
>> OK to commit?
>
> (I think as maintainer you don't need approval - but of course comments
> by others can be helpful; I hope mine are. Additionally, Gerald (CCed)
> helps with keeping the webpages in good shape (thanks!).)
>
>
>> gcc-14: mark amdgcn fiji deprecated
>> diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
>> index c817dde4..91ab8132 100644
>> --- a/htdocs/gcc-14/changes.html
>> +++ b/htdocs/gcc-14/changes.html
>> @@ -178,6 +178,16 @@ a work-in-progress.</p>
>>
>> <!-- <h3 id="aarch64">AArch64</h3> -->
>>
>> +<h3 id="amdgcn">AMD Radeon (GCN)</h3>
>> +
>> +<ul>
>> + <li>The Fiji device support is now deprecated and will be removed
>> from a
>> + future release. The default compiler configuration no longer
>> uses Fiji
>> + as the default device, and no longer includes the Fiji
>> libraries. Both
>> + can be restored by configuring with
>> <code>--with-arch=fiji</code>.</li>
>> + <li>The default device architecture is now <code>gfx900</code>
>> (Vega).</li>
>> +</ul>
>
> Can you add <a href="...">...</a> around the "--with-arch=fiji"? Linking to
>
> https://gcc.gnu.org/install/specific.html#amdgcn-x-amdhsa
>
> I think that page is helpful (once the cron job has updated that page).
>
> Additionally, I wonder whether "Fiji" should be changed to "Fiji
> (gfx803)" in the first line and whether the "," should be removed in
> "The ... configuration ... , and no longer includes".
Fair enough, how's this version? (I like the comma, even if it is optional.)
Andrew
gcc-14: mark amdgcn fiji deprecated
diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
index c817dde4..23694310 100644
--- a/htdocs/gcc-14/changes.html
+++ b/htdocs/gcc-14/changes.html
@@ -178,6 +178,21 @@ a work-in-progress.</p>
<!-- <h3 id="aarch64">AArch64</h3> -->
+<h3 id="amdgcn">AMD Radeon (GCN)</h3>
+
+<ul>
+ <li>
+ The Fiji (gfx803) device support is now deprecated and will be removed from
+ a future release. The default compiler configuration no longer uses Fiji
+ as the default device, and no longer includes the Fiji libraries. Both can
+ be restored by configuring with
+ <a href="https://gcc.gnu.org/install/specific.html#amdgcn-x-amdhsa">
+ <code>--with-arch=fiji</code>
+ </a>.
+ </li>
+ <li>The default device architecture is now <code>gfx900</code> (Vega).</li>
+</ul>
+
<!-- <h3 id="arc">ARC</h3> -->
<!-- <h3 id="arm">arm</h3> -->
On 20.10.23 14:58, Andrew Stubbs wrote:
> Fair enough, how's this version? (I like the comma, even if it is
> optional.)
LGTM – for what it is worth.
Thanks!
Tobias
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
Hi Andrew,
On Fri, 20 Oct 2023, Andrew Stubbs wrote:
>> Additionally, I wonder whether "Fiji" should be changed to "Fiji
>> (gfx803)" in the first line and whether the "," should be removed in
>> "The ... configuration ... , and no longer includes".
> Fair enough, how's this version? (I like the comma, even if it is optional.)
it's definitely fine. I do have a recommendation and a question, though
feel free to go about them as you prefer.
+ <li>The default device architecture is now <code>gfx900</code> (Vega).</li>
How about starting with this as the first sub-item, as a "positive",
then follow with the deprecation?
+<ul>
+ <li>
+ The Fiji (gfx803) device support is now deprecated and will be removed from
Could this be "Fiji (gfx803) device support" without the article?
Gerald
On 22/10/2023 13:24, Gerald Pfeifer wrote:
> Hi Andrew,
>
> On Fri, 20 Oct 2023, Andrew Stubbs wrote:
>>> Additionally, I wonder whether "Fiji" should be changed to "Fiji
>>> (gfx803)" in the first line and whether the "," should be removed in
>>> "The ... configuration ... , and no longer includes".
>> Fair enough, how's this version? (I like the comma, even if it is optional.)
>
> it's definitely fine. I do have a recommendation and a question, though
> feel free to go about them as you prefer.
>
> + <li>The default device architecture is now <code>gfx900</code> (Vega).</li>
>
> How about starting with this as the first sub-item, as a "positive",
> then follow with the deprecation?
>
> +<ul>
> + <li>
> + The Fiji (gfx803) device support is now deprecated and will be removed from
>
> Could this be "Fiji (gfx803) device support" without the article?
Thank you for your suggestions; I have committed the attached.
Andrew
gcc-14: mark amdgcn fiji deprecated
diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
index c817dde4..a20499e9 100644
--- a/htdocs/gcc-14/changes.html
+++ b/htdocs/gcc-14/changes.html
@@ -178,6 +178,21 @@ a work-in-progress.</p>
<!-- <h3 id="aarch64">AArch64</h3> -->
+<h3 id="amdgcn">AMD Radeon (GCN)</h3>
+
+<ul>
+ <li>The default device architecture is now <code>gfx900</code> (Vega).</li>
+ <li>
+ Fiji (gfx803) device support is now deprecated and will be removed from
+ a future release. The default compiler configuration no longer uses Fiji
+ as the default device, and no longer includes the Fiji libraries. Both can
+ be restored by configuring with
+ <a href="https://gcc.gnu.org/install/specific.html#amdgcn-x-amdhsa">
+ <code>--with-arch=fiji</code>
+ </a>.
+ </li>
+</ul>
+
<!-- <h3 id="arc">ARC</h3> -->
<!-- <h3 id="arm">arm</h3> -->
@@ -178,6 +178,16 @@ a work-in-progress.</p>
<!-- <h3 id="aarch64">AArch64</h3> -->
+<h3 id="amdgcn">AMD Radeon (GCN)</h3>
+
+<ul>
+ <li>The Fiji device support is now deprecated and will be removed from a
+ future release. The default compiler configuration no longer uses Fiji
+ as the default device, and no longer includes the Fiji libraries. Both
+ can be restored by configuring with <code>--with-arch=fiji</code>.</li>
+ <li>The default device architecture is now <code>gfx900</code> (Vega).</li>
+</ul>
+
<!-- <h3 id="arc">ARC</h3> -->
<!-- <h3 id="arm">arm</h3> -->