| Message ID | 20231018182943.18700-12-ddrokosov@salutedevices.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id
ib8csp4989624vqb;
Wed, 18 Oct 2023 11:31:38 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IGn+4c72tmZl2hGnfN2sOI2++LA7afgp78s9bdDebsI+k1EO/T+tSRocwMP5JjirpJzV7us
X-Received: by 2002:a05:6870:288e:b0:1c5:56f:ac08 with SMTP id
gy14-20020a056870288e00b001c5056fac08mr238886oab.12.1697653898250;
Wed, 18 Oct 2023 11:31:38 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1697653898; cv=none;
d=google.com; s=arc-20160816;
b=xVugBzWIiDARNZHccMEeolUk4jlZ0CDe/xW1SdhG9HdrEbi74Wj5VbXB12rWg0OC93
igbQJmy8LHa7/gFLO+On/JOrrrSx8qPwmtaiz3Yet3DcQdeUuih8u+S9v+Wqmw+CCYIS
4Bw6pxa74CPibUj16neVwRdEt/WMeOw52cdiROUP0c3Ffrt6T6fq2qvM99CPDlp5qw06
n0D4DGKvem+k199NdbrVEN1I+dV4mvIornYaFynCRTnN11PUVX1PVXxPic/bICPIpYDH
dqadBB4AVMJc/KQUzHTrpZPnVQ43o+n8Fh0oB1DSjEZskxmHmdAmZ9RmrVPYXe7sayXf
/vVw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature:dkim-filter;
bh=F2RtCFL49u4f1chUWQQeWaGTuLV7xQMAnXLi744tnNQ=;
fh=sGimd2ZdVvk8/MILn8/B31HxCT6JTOun9AZJxJGQyuE=;
b=0HqAh5vrtZ7U2QQMMC4ElG8LpWWO0zzsvV3tItka1pmorXOlGw7WAcu5Ah7YEqgVa+
HQi2HrG3vGkPPPs2IYTcXkdwP/MXTeF3ST/ftDoHzOIu/VxUQAXLb6+EIr07IkItyMo9
DwNLstv2zvx3ZkYpkk2FXc6QfH0YSYIKJI83IlNqqGxNN23VrmA3JaD/KCoZUTboMWKA
UuFd7+e5TvqGDrq9oYvVE4++VPkNdtSQsr2G2YL2Ggk/7uu6GmLH2481dxRxLwoUIZOS
CT76XwNyyMCvSpIwqzH70zAZ3LZlTeM2GjfEd8dlPKGbE7q1dfJMKjA2HbS/MCw3JJ0G
4qcw==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@salutedevices.com header.s=mail header.b=SJS07sb7;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.37 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=salutedevices.com
Received: from snail.vger.email (snail.vger.email. [23.128.96.37])
by mx.google.com with ESMTPS id
t28-20020a63955c000000b00582dcfe3b41si2684639pgn.374.2023.10.18.11.31.37
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 18 Oct 2023 11:31:38 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Authentication-Results: mx.google.com;
dkim=pass header.i=@salutedevices.com header.s=mail header.b=SJS07sb7;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.37 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=salutedevices.com
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by snail.vger.email (Postfix) with ESMTP id 40D928066657;
Wed, 18 Oct 2023 11:30:48 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S1344824AbjJRSa2 (ORCPT <rfc822;zwp10758@gmail.com> + 24 others);
Wed, 18 Oct 2023 14:30:28 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48362 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S232596AbjJRSaN (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 18 Oct 2023 14:30:13 -0400
Received: from mx1.sberdevices.ru (mx2.sberdevices.ru [45.89.224.132])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30784122;
Wed, 18 Oct 2023 11:30:08 -0700 (PDT)
Received: from p-infra-ksmg-sc-msk02 (localhost [127.0.0.1])
by mx1.sberdevices.ru (Postfix) with ESMTP id 6FF12120013;
Wed, 18 Oct 2023 21:30:06 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru 6FF12120013
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com;
s=mail; t=1697653806;
bh=F2RtCFL49u4f1chUWQQeWaGTuLV7xQMAnXLi744tnNQ=;
h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From;
b=SJS07sb7fNooor7nUmSlkiKskrmWW89dKPQaB9O0s2fFsHlzWHeEKpRTE1rzzyAKe
jZtkt9knArsyjBJkjSVfon1lwJyQAIOHCug2Xj+vYR7IycZo+mc1myKeOgyGm3duUr
u+0f536ZGjCidnRiPTJHuY7si1ku11kaEiCDQWtZFWtJ+GQJ/wSOd8mPYUq1eI0cmy
ToM8uD8hJRVA3gsi+lVO50m0PQlOKD1stIy0/4jXGw85NWAvHQnmCiHkstOjJLDozL
MVChYsDKrAny5ouw2aUXQgApAav3Jb9CG97qkIxh4eHGf0oAXV6Xi/TIzA/+rVaWDW
RLb3Kp2FfiUkA==
Received: from p-i-exch-sc-m01.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru
[172.16.192.107])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by mx1.sberdevices.ru (Postfix) with ESMTPS;
Wed, 18 Oct 2023 21:30:06 +0300 (MSK)
Received: from localhost.localdomain (100.64.160.123) by
p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.2.1118.37; Wed, 18 Oct 2023 21:30:00 +0300
From: Dmitry Rokosov <ddrokosov@salutedevices.com>
To: <lee@kernel.org>, <pavel@ucw.cz>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<andy.shevchenko@gmail.com>
CC: <kernel@sberdevices.ru>, <rockosov@gmail.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-leds@vger.kernel.org>,
Dmitry Rokosov <ddrokosov@salutedevices.com>
Subject: [PATCH v2 11/11] dt-bindings: leds: aw200xx: fix led pattern and add
reg constraints
Date: Wed, 18 Oct 2023 21:29:43 +0300
Message-ID: <20231018182943.18700-12-ddrokosov@salutedevices.com>
X-Mailer: git-send-email 2.36.0
In-Reply-To: <20231018182943.18700-1-ddrokosov@salutedevices.com>
References: <20231018182943.18700-1-ddrokosov@salutedevices.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Originating-IP: [100.64.160.123]
X-ClientProxiedBy: p-i-exch-sc-m02.sberdevices.ru (172.16.192.103) To
p-i-exch-sc-m01.sberdevices.ru (172.16.192.107)
X-KSMG-Rule-ID: 10
X-KSMG-Message-Action: clean
X-KSMG-AntiSpam-Lua-Profiles: 180713 [Oct 18 2023]
X-KSMG-AntiSpam-Version: 6.0.0.2
X-KSMG-AntiSpam-Envelope-From: ddrokosov@salutedevices.com
X-KSMG-AntiSpam-Rate: 0
X-KSMG-AntiSpam-Status: not_detected
X-KSMG-AntiSpam-Method: none
X-KSMG-AntiSpam-Auth: dkim=none
X-KSMG-AntiSpam-Info: LuaCore: 541 541
6f62a06a82e8ec968d29b8e7c7bba6aeceb34f57,
{Tracking_from_domain_doesnt_match_to},
127.0.0.199:7.1.2;p-i-exch-sc-m01.sberdevices.ru:7.1.1,5.0.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;100.64.160.123:7.1.2;salutedevices.com:7.1.1,
FromAlignment: s, ApMailHostAddress: 100.64.160.123
X-MS-Exchange-Organization-SCL: -1
X-KSMG-AntiSpam-Interceptor-Info: scan successful
X-KSMG-AntiPhishing: Clean
X-KSMG-LinksScanning: Clean
X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960,
bases: 2023/10/18 17:21:00 #22224798
X-KSMG-AntiVirus-Status: Clean, skipped
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]);
Wed, 18 Oct 2023 11:30:48 -0700 (PDT)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1780119133634682727
X-GMAIL-MSGID: 1780119133634682727
|
| Series |
leds: aw200xx: several driver updates
|
|
Commit Message
Dmitry Rokosov
Oct. 18, 2023, 6:29 p.m. UTC
AW200XX controllers have the capability to declare more than 0xf LEDs,
therefore, it is necessary to accept LED names using an appropriate
regex pattern.
The register offsets can be adjusted within the specified range, with
the maximum value corresponding to the highest number of LEDs that can
be connected to the controller.
Fixes: e338a05e76ca ("dt-bindings: leds: Add binding for AW200xx")
Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>
---
.../devicetree/bindings/leds/awinic,aw200xx.yaml | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
Comments
On Wed, Oct 18, 2023 at 09:29:43PM +0300, Dmitry Rokosov wrote: > AW200XX controllers have the capability to declare more than 0xf LEDs, > therefore, it is necessary to accept LED names using an appropriate > regex pattern. > > The register offsets can be adjusted within the specified range, with > the maximum value corresponding to the highest number of LEDs that can > be connected to the controller. Do all of these controllers have identical max numbers of LEDs? Cheers, Conor. > > Fixes: e338a05e76ca ("dt-bindings: leds: Add binding for AW200xx") > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > --- > .../devicetree/bindings/leds/awinic,aw200xx.yaml | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml b/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml > index efb18ddce383..677c73aa6232 100644 > --- a/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml > +++ b/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml > @@ -42,16 +42,18 @@ properties: > maxItems: 1 > > patternProperties: > - "^led@[0-9a-f]$": > + "^led@[0-9a-f]+$": > type: object > $ref: common.yaml# > unevaluatedProperties: false > > properties: > reg: > - description: > - LED number > - maxItems: 1 > + items: > + description: > + LED number > + minimum: 0 > + maximum: 108 > > led-max-microamp: > default: 9780 > -- > 2.36.0 >
On Thu, Oct 19, 2023 at 03:08:38PM +0100, Conor Dooley wrote: > On Wed, Oct 18, 2023 at 09:29:43PM +0300, Dmitry Rokosov wrote: > > AW200XX controllers have the capability to declare more than 0xf LEDs, > > therefore, it is necessary to accept LED names using an appropriate > > regex pattern. > > > > The register offsets can be adjusted within the specified range, with > > the maximum value corresponding to the highest number of LEDs that can > > be connected to the controller. > > Do all of these controllers have identical max numbers of LEDs? Nope... I believe you are hinting at some conditional logic based on the value of 'compatible'. I will figure it out and send the appropriate implementation in the next version. > > > > Fixes: e338a05e76ca ("dt-bindings: leds: Add binding for AW200xx") > > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > > --- > > .../devicetree/bindings/leds/awinic,aw200xx.yaml | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml b/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml > > index efb18ddce383..677c73aa6232 100644 > > --- a/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml > > +++ b/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml > > @@ -42,16 +42,18 @@ properties: > > maxItems: 1 > > > > patternProperties: > > - "^led@[0-9a-f]$": > > + "^led@[0-9a-f]+$": > > type: object > > $ref: common.yaml# > > unevaluatedProperties: false > > > > properties: > > reg: > > - description: > > - LED number > > - maxItems: 1 > > + items: > > + description: > > + LED number > > + minimum: 0 > > + maximum: 108 > > > > led-max-microamp: > > default: 9780 > > -- > > 2.36.0 > >
diff --git a/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml b/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml index efb18ddce383..677c73aa6232 100644 --- a/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml +++ b/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml @@ -42,16 +42,18 @@ properties: maxItems: 1 patternProperties: - "^led@[0-9a-f]$": + "^led@[0-9a-f]+$": type: object $ref: common.yaml# unevaluatedProperties: false properties: reg: - description: - LED number - maxItems: 1 + items: + description: + LED number + minimum: 0 + maximum: 108 led-max-microamp: default: 9780