Message ID | 20231019100639.4026283-1-andre.draszik@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2010:b0:403:3b70:6f57 with SMTP id fe16csp274947vqb; Thu, 19 Oct 2023 03:07:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEhMLl6qMhLGT1QAwiq68cMAJB9Z1nWZ96YVkEANDPEiLsqzUzrZIwaZj+ZDRpZA5/FudEI X-Received: by 2002:a9d:63ca:0:b0:6b9:4516:7d1e with SMTP id e10-20020a9d63ca000000b006b945167d1emr1798570otl.30.1697710021110; Thu, 19 Oct 2023 03:07:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697710021; cv=none; d=google.com; s=arc-20160816; b=mP7ITL9sUJ1nt4ExJ5yqsdqPn1uifXq97x1XOBMRlBKNOW13hV2TsM+vzkjgyd3XWS keV8TjHiBiiMWKZwWtseyAljl0Nj1C4FdHX59AUsSs6L9MuFXatN9+ZnlBES31kpQUoL fGmF+Fdnx0Bf0nTkMDYtepc4DQS+/WiGRFdNSJcww20ReaJl17jQejm9QrOPsUDHnIw1 YoxflxdrbBxgjjSZqf1HMbF7zaYTtjqRT6V13gWKjRkoI56jFSj93rs/gN+GQYCjWDwh SzZK9txhnq6qsAOG8iXPZY1LwcTQV99tuAN6JnZTcwuMAOfeIo+MZyUaOeou49Jt/6gx rxOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=aNH+cUkvJq9kPceEcJ89sVVgm6IQTkIk2n1XM45Z5uk=; fh=y2Rflr5XT7bJktbLkKSib1Ax+sq7ZWXmzS7XHOanCdU=; b=UpqJpwDn0rAT/HGDpisWYbwOFmurrQ5+93Dk4We2w5E5B2vKZ2A/6Q+8koNydEbq4O LdfJbwcF7sG8/CP8eaTPWZuGDqk7Ba4L0W4ydQf0BIhKpDhxaxgbgzQpIjnZGuc8okl9 VwhMOhH7gnGgvWguv8ziieBIg0I3R1Nihq6uBurKSeqx4hS7KG9IdT1PCCJMywYZn6Rp PtgOUH3X3rFo2KgyB4Es/HL3DFs98xEsWevNWy5kp+4MBZ9oUGSFPXEB12ZmJHrmvaM3 B87Sids+tMTQY/JNuKczavol+kDpparirXBs49x0qq4YAQcj3syyEGekW8GLXIeUy4Wh 2R/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZyfXDo4b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id a6-20020a654186000000b0059779ae5899si3934273pgq.836.2023.10.19.03.07.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 03:07:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZyfXDo4b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id BA19A826EC48; Thu, 19 Oct 2023 03:06:58 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345187AbjJSKGw (ORCPT <rfc822;zwp10758@gmail.com> + 24 others); Thu, 19 Oct 2023 06:06:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345115AbjJSKGv (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 19 Oct 2023 06:06:51 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B5BC10F for <linux-kernel@vger.kernel.org>; Thu, 19 Oct 2023 03:06:49 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-40836ea8cbaso19420945e9.0 for <linux-kernel@vger.kernel.org>; Thu, 19 Oct 2023 03:06:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697710007; x=1698314807; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aNH+cUkvJq9kPceEcJ89sVVgm6IQTkIk2n1XM45Z5uk=; b=ZyfXDo4bVVMme0ghDUVYhhps+R2YkPljIBDykBKcbkqWKtGmB6hbasy0sMudL4o188 xNv3i3SZLdGYvJ7qFRf8kYPIiccnpB4GcwPY+/YDmqKeMFeGZC9eHFuUnB/3F2Zy20FZ j++i4FbQfeJjIgMD1HWSOFgkN0nG1NnmeSIY0zMWok34drIKhjiasTd7zLU/mm9gK94u pztSvfTDVPIWM+R2rly4SmOeuMsaq/kAxMbYckbh3fQh9KKBVw/nULOF0/m1xonU9vKI 9fbm0hflYtKbkMw0P8Brb2PyA+sKG+/RhNxZ6jQ/eiLNosTWS4bJ8aMLOdwqiX/bXTXE 1JYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697710007; x=1698314807; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aNH+cUkvJq9kPceEcJ89sVVgm6IQTkIk2n1XM45Z5uk=; b=jjdn1WEqbgaJSFcbUlJcX3GYwPCJ1JD5x2cz964uxYCS/+JpZWv2KVuKBIboYsemDv TIdG/nG1Dk24HQzvdbSJYnVQD4vjZLlqJfCfeXfXNor93EG0pjJQ14VhBQQ/thTzc5pv /GUwqtFcmHGofwyX/hVDuMUgpTdMIRfmq11DmndCBIULdb64EowKKT9MSdcDaKMFjcUh rTkKEfDDvk3QFvi1b3NTPz7XC7dpN7S2i10dJQqk8xJYj+bEuohaQSIhpfOxt80J0Rxk yWJNtExH9O9ts94P9kCtrFpPb2bJntU0FqX01u4h+QxPFyX6NRocJQNzgYsaYqqhUxNC H1EA== X-Gm-Message-State: AOJu0YzgpXEkeAnvMqnPAUXyffNVvnqkA5dp7jbyDM9MTDlt0C/71G2m 4sPr4xn1uVNYA0amiwDsjlf7lbe80b+kDkd9y8NS3xno X-Received: by 2002:adf:e80f:0:b0:32d:8872:aac8 with SMTP id o15-20020adfe80f000000b0032d8872aac8mr1164054wrm.31.1697710007466; Thu, 19 Oct 2023 03:06:47 -0700 (PDT) Received: from salami.lan ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id f14-20020a5d664e000000b0032d687fd9d0sm4169035wrw.19.2023.10.19.03.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 03:06:46 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= <andre.draszik@linaro.org> To: linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, alim.akhtar@samsung.com, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH 1/2] tty: serial: samsung: drop earlycon support for unsupported platforms Date: Thu, 19 Oct 2023 11:06:38 +0100 Message-Id: <20231019100639.4026283-1-andre.draszik@linaro.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 19 Oct 2023 03:06:58 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780177982643209954 X-GMAIL-MSGID: 1780177982643209954 |
Series |
[1/2] tty: serial: samsung: drop earlycon support for unsupported platforms
|
|
Commit Message
André Draszik
Oct. 19, 2023, 10:06 a.m. UTC
Commit 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks") removed
support here for several old platforms, but kept support for earlycon
for those same platforms.
As earlycon support for otherwise unsupported platforms doesn't seem to
be useful, just drop it as well.
Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
drivers/tty/serial/samsung_tty.c | 16 +---------------
1 file changed, 1 insertion(+), 15 deletions(-)
Comments
On 19/10/2023 12:06, André Draszik wrote: > Commit 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks") removed > support here for several old platforms, but kept support for earlycon > for those same platforms. > > As earlycon support for otherwise unsupported platforms doesn't seem to > be useful, just drop it as well. > > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: André Draszik <andre.draszik@linaro.org> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Thu, Oct 19, 2023 at 5:06 AM André Draszik <andre.draszik@linaro.org> wrote: > > Commit 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks") removed > support here for several old platforms, but kept support for earlycon > for those same platforms. > > As earlycon support for otherwise unsupported platforms doesn't seem to > be useful, just drop it as well. > > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: André Draszik <andre.draszik@linaro.org> > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > drivers/tty/serial/samsung_tty.c | 16 +--------------- > 1 file changed, 1 insertion(+), 15 deletions(-) > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > index 6b8d4b4402e9..a74ecc78f4e0 100644 > --- a/drivers/tty/serial/samsung_tty.c > +++ b/drivers/tty/serial/samsung_tty.c > @@ -2735,17 +2735,7 @@ static struct samsung_early_console_data s3c2410_early_console_data = { > .rxfifo_mask = S3C2410_UFSTAT_RXFULL | S3C2410_UFSTAT_RXMASK, > }; > > -static int __init s3c2410_early_console_setup(struct earlycon_device *device, > - const char *opt) > -{ > - device->port.private_data = &s3c2410_early_console_data; > - return samsung_early_console_setup(device, opt); > -} > - > -OF_EARLYCON_DECLARE(s3c2410, "samsung,s3c2410-uart", > - s3c2410_early_console_setup); > - > -/* S3C2412, S3C2440, S3C64xx */ > +/* S3C64xx */ > static struct samsung_early_console_data s3c2440_early_console_data = { > .txfull_mask = S3C2440_UFSTAT_TXFULL, > .rxfifo_mask = S3C2440_UFSTAT_RXFULL | S3C2440_UFSTAT_RXMASK, > @@ -2758,10 +2748,6 @@ static int __init s3c2440_early_console_setup(struct earlycon_device *device, > return samsung_early_console_setup(device, opt); > } > > -OF_EARLYCON_DECLARE(s3c2412, "samsung,s3c2412-uart", > - s3c2440_early_console_setup); > -OF_EARLYCON_DECLARE(s3c2440, "samsung,s3c2440-uart", > - s3c2440_early_console_setup); > OF_EARLYCON_DECLARE(s3c6400, "samsung,s3c6400-uart", > s3c2440_early_console_setup); > > -- > 2.40.1 > >
diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 6b8d4b4402e9..a74ecc78f4e0 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -2735,17 +2735,7 @@ static struct samsung_early_console_data s3c2410_early_console_data = { .rxfifo_mask = S3C2410_UFSTAT_RXFULL | S3C2410_UFSTAT_RXMASK, }; -static int __init s3c2410_early_console_setup(struct earlycon_device *device, - const char *opt) -{ - device->port.private_data = &s3c2410_early_console_data; - return samsung_early_console_setup(device, opt); -} - -OF_EARLYCON_DECLARE(s3c2410, "samsung,s3c2410-uart", - s3c2410_early_console_setup); - -/* S3C2412, S3C2440, S3C64xx */ +/* S3C64xx */ static struct samsung_early_console_data s3c2440_early_console_data = { .txfull_mask = S3C2440_UFSTAT_TXFULL, .rxfifo_mask = S3C2440_UFSTAT_RXFULL | S3C2440_UFSTAT_RXMASK, @@ -2758,10 +2748,6 @@ static int __init s3c2440_early_console_setup(struct earlycon_device *device, return samsung_early_console_setup(device, opt); } -OF_EARLYCON_DECLARE(s3c2412, "samsung,s3c2412-uart", - s3c2440_early_console_setup); -OF_EARLYCON_DECLARE(s3c2440, "samsung,s3c2440-uart", - s3c2440_early_console_setup); OF_EARLYCON_DECLARE(s3c6400, "samsung,s3c6400-uart", s3c2440_early_console_setup);