Message ID | 20231016153232.2851095-7-Frank.Li@nxp.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp3544026vqb; Mon, 16 Oct 2023 08:33:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQtVq+zRh2nhU57nlxMpJ9Sm3stXswqh1GZYg3nTdPNhVr9obIb3oyNHFCopTcw6C81ZF7 X-Received: by 2002:a17:90a:4ca4:b0:274:99ed:a80c with SMTP id k33-20020a17090a4ca400b0027499eda80cmr31799545pjh.3.1697470424701; Mon, 16 Oct 2023 08:33:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1697470424; cv=pass; d=google.com; s=arc-20160816; b=KEpgYY6qvM+vzSqFJ8w5dD859ZRPAkKJ6BmpvzWCHxS6HsturKCx7uiazD22yv+YCn cSDb/iawkdWtD8One/1WnAz19cnMgbTi4gEU11iDkDVg5bWhriGjcBQuTRlM++8oAVuZ xmWlRLQ/HFgGAKBSB/KMk/liovWxexfIVe/pM5PRsWlQHtCMhVVLgzpdUtn9A5Bfk2+U oRNuRkBMLejVqZVPNZdHmphglxjpmfIxcjXBGGGT4S1CX8L3oYPlufYUVKM2vs63H7Ma mJ/VEWOz78jdZMAkNL0g4xWgke4HZE9ZeR+XQUqmbeNfo9FY+4r17YmSNh26C0JBBH0q NMjA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=jorvWz4GxmzMDIDvdhZin08SLMEa5RtSrhynf9Gb3b0=; fh=bn4KwJ7hiZC6iHD6ocv1YpB9R5Bd8J/ZarfJ7QImr28=; b=b7mJ1j7UMEuuO8NeanfhsP4+iNkMGKBvKvjK3No2+a8LkEnA6tLB1oAv5Cx6DlNHQo KOtqKXu/ekOyRqMe4DrM3+cKsOHIh62xhCiFxUsly11+PoLMJfOevneMHHjsB21XERSi sPDAQOpjZzLwewTpuatm1jc0NMjZAvKPP+wKN1NnHm/PKsuGWvXKTi9NGyk8KHextU/m muR7hmUBN1i6ORKEcGLM9THZYkgxGjwA1QGzXUmRAaJJN2we8l7DPCZ2wWWJA5ZbngTw 9quGw1U496dsjTw6tfTFyx0svSYsssPSRDIhPUPgfvNvglYJwWMHWBcL6e6qimkg9mqv EIdg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=rXMw7J8Y; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id bw42-20020a056a0204aa00b005b3097b75c0si5982290pgb.56.2023.10.16.08.33.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 08:33:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=rXMw7J8Y; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id C58208021B2D; Mon, 16 Oct 2023 08:33:42 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233930AbjJPPd0 (ORCPT <rfc822;hjfbswb@gmail.com> + 18 others); Mon, 16 Oct 2023 11:33:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233759AbjJPPdF (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 16 Oct 2023 11:33:05 -0400 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2040.outbound.protection.outlook.com [40.107.104.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BA5DE6 for <linux-kernel@vger.kernel.org>; Mon, 16 Oct 2023 08:33:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VmAUmKqK401Br0AJYvqvy2dhoSu6Jr4/dla8smGWtMbUi6brrR/zqnDLIwave4E1bgEmTNGF7/PwkzkpzznWWiK4l7Sf8NAOgc+3NBwGbq5dbwpT8Rebji7bRFVEDG1OONMXwFkripuQy8Gbi207tLUPzdat8FjwayVr97ZTQjMc1BJPiv0g8DXe+KLASzdllnozlkex6rI/wJG8bZCKGOigVXsYhqJfAwJlqHq5seNSB+G8WCu4kUkDlvvPe1c5GVTw8wMH6m9wnADGFbELLlKuT/MwX3ZNbbQLKQRp2PQBkN4Yo/q1pQn2LteMcyw7DiGAH22RxsuXts3L2vLczA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jorvWz4GxmzMDIDvdhZin08SLMEa5RtSrhynf9Gb3b0=; b=hbBBJzrpUdsNUr3nyIYyEaS3peWMMRi8E2mi0tCB7cisHWJYO9TYeHPyxvgXzTHEAmSfDvYt+5geF4oteQcS/gtWlndfaWDAOHgmNO0bO0q2zHpUvcowHxPgstUk2tmCwtl+TxKBgaJnehyKhvP3nMW0KDYXbHHBdj5mg22E0XyNWRZMgvtYj2O4YBWeO8Wc68etqMAZgYrhvHrelVTC5rkJeDA6Z5BhGVlG6V0WvIXFpL6cqF0QJTRs190mskX4HRteCUtoscuDkqc/UqUQW83nvidP2PbQ44exixder3WwfPEhFWg7PgSOMkxi/+SPFLJnP3s0Rt7tpQGQGa4ERw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jorvWz4GxmzMDIDvdhZin08SLMEa5RtSrhynf9Gb3b0=; b=rXMw7J8YJAr9dIX79Jwi742ViKY2IebJHIkhjS46zoxHOWin6/j6/fvhLRKFt483vhvHs1FWn6KvOkKv3Mwzp8ro0f2szkUJknyuc73l0AEf325MNHLyMEJ5RTgTQcod1m3Hy9m2LJeAebTfHINZeBeCFu7Dcts2iHSTuEtvy5w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by AS8PR04MB7592.eurprd04.prod.outlook.com (2603:10a6:20b:23f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Mon, 16 Oct 2023 15:33:00 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2%4]) with mapi id 15.20.6886.034; Mon, 16 Oct 2023 15:33:00 +0000 From: Frank Li <Frank.Li@nxp.com> To: miquel.raynal@bootlin.com, conor.culhane@silvaco.com, alexandre.belloni@bootlin.com, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: [PATCH 6/6] i3c: master: svc: fix random hot join failure since timeout error Date: Mon, 16 Oct 2023 11:32:32 -0400 Message-Id: <20231016153232.2851095-7-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231016153232.2851095-1-Frank.Li@nxp.com> References: <20231016153232.2851095-1-Frank.Li@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SJ0P220CA0029.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:41b::13) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|AS8PR04MB7592:EE_ X-MS-Office365-Filtering-Correlation-Id: 29fbe925-b5c6-4cb2-63fb-08dbce5d2dca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Omz6K+ukA2OsFCNQkf2lslJ4lb67m29Rgfg2LOyTuzX/C7R7xjDeKlpMGquTaz9qCcsqmhkTEZ0kM3oXw+QUxlJXqpD6YW/bSz+yKiJa0I7hf8GfSbQ/EAMD6OfZdSMUxtueeayvCg1FIFAcCPnThMEe8ORXTKrvwMuZXDDPNbiJkBOcFpMvHSYR2PJqMUbTJVsbcCgXFZXlAlVMrpSKBooWa7xIKog5KLsd2DH0lkYdpn87CIIy2/fi3MFNZxxFWKcBD0s41VvNYbAknJkgQwkbSbGVp6gepjiB87D3AZG6fhIPTwIf0AkVMsFp1p1lJWHk9vUC7KElqjPVkMFj1rSmiMGo8xse/OWuEEZnphQwoomvDbGNldr/VhKlzR66CLGKc8BetbzUEEa0vy7rvVlK/+0wtvxSTK4SaL2nnrYPLGd7M8/aHXEXd6oKaN8N1GmY8Pa6AKw3kGNXi48EJDMNtrD4VypogQyq1AkEgNcXaJfclbhMDPX7Y16MwJBUBl1EexWwW1AawmCFEdzzChJ8QeCk9Ra0xPGyuwCl+n1cTQlOo6eLUakzx3aENFWbSdRSWSifjqJmh4wRIQTyv8nPgW2HVY3FP03v39YUFu8Hd7Qlu0jVpxavlvJ5bF7+ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(376002)(366004)(39860400002)(396003)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(6486002)(38350700005)(36756003)(38100700002)(83380400001)(6666004)(6512007)(26005)(6506007)(316002)(66946007)(66556008)(66476007)(478600001)(1076003)(2616005)(52116002)(2906002)(41300700001)(86362001)(5660300002)(8936002)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?hzE9PFifwDBpRzJ15Xezk4zAiddL?= =?utf-8?q?irHceZP6ASlN+eghLVVWO6IIkRI5jaItOPJoPVvvCNuhgkrhuXpeZ2tw20Xto7fD2?= =?utf-8?q?AcrrVlyGZaF8oXgz6zO38jI93vIRrtQQuRg97JaSCyZGuUqYew8egcVTEfuXe+vYH?= =?utf-8?q?iXxHHrmKmiaquryKom1bGW0hnY1DSUVii+5R9Lt7zCB+fppiQChHTRmZwaQN7KlGi?= =?utf-8?q?LtZIEdnP+hVovPa7xaKE2ImO8msxrttvIiUKMF48unCimCPRXLUzYqs1vMLrOjv2i?= =?utf-8?q?Q9fU0vmBuDNCOsbiZ5YV4dhkSF6b2sbHCLBabOk7wxO2Kp0+6qDvIFGGkOdyo0lb0?= =?utf-8?q?ZRR3yQgQ47FBQ9dCWOdOBPmzXfUbqik8Ylu3OvwFkEA8aXzMiLyuTaBYKj4qdzDSI?= =?utf-8?q?vHbys+Ay8hDvNIHHAU4R2+ZmqWXAroKSorT4cZjuaJ8qJJ1zZKyKlTqfZj2tA6tqn?= =?utf-8?q?kBJgCIyduFfohEkicH1/314agJ4A1FDwnHJH47g3UsO8zIH1kzdYgy5RS6k+vFFgg?= =?utf-8?q?gob3yxyvl+rLzzG5agpVf/7+qGoeuS5UnyczPO7TvBxkm6EzQ8voajRTqFf8QmbUG?= =?utf-8?q?XvbBC0G/4eUnrYHNJKymCpoEdRg70bfOoEAYvT+HxW1hSZPwk61O5/Gv947pYD8vz?= =?utf-8?q?6eaxTXuTCXfWdu6F/VkVDwfynzQDbsfdY7rOiJOFb4Zy2MDLDHB+wYjocZrBj2RYZ?= =?utf-8?q?Zv12VU8wRYPu1Ga5Pd6ZVxbecg1icdCqlUTQ3qrJmCiiHxfk4NwHq8B2SDCyYW1/I?= =?utf-8?q?GbFHvLTphLPSVUvj23CEUuFGYLjQvV0ZV6fXJH8UKcwQMncK58EYFj7VmvdG1lnX6?= =?utf-8?q?XxZcUf6dkDj02VW0TlwtppbrjvJJkUVgC6upAorhisCTDVayBcEkJ+ZNzkAaVVc4V?= =?utf-8?q?tSNoXjD7e/m+sF44E8ewIMpV/zphJjPhPraocTsgeJhz8nISEhXXT5T15uv+o7A5L?= =?utf-8?q?NKT1iMvz+U/5dmshh88eur8RP9PwhITY1jJ154l7+HmjBih92hNrr/cUN13dnX9rj?= =?utf-8?q?gN2TwH4Ynj9ioUyYrVkiONWYFvR3qTxVoBOSsuKEV6LuEr7aXsrcwzWWhK1TtjDug?= =?utf-8?q?vxiqE+bOyDIuHId+emMkQCWD7A82eoMZY2zHFT9NyTUqwXxbZEAYQuQq+o+NDr9RP?= =?utf-8?q?cMvlQt3QfAEK5Dqx6xmkJ8/pptgyfqpERV93teGYhVe3jwUxCvHnzpELnjg4Cbw8+?= =?utf-8?q?+YVZ93BlTge1TRuEQGdXLGQvyMTYyXexD0KAmEigSIUg/WgshY7IVRIcFYOylZwv4?= =?utf-8?q?XmMORpB2VL8qNZLM36OZ0lCpNoJ454fz/qUNcmxPdPuIgr/3xbqh2Qi/MQgFy1Ls9?= =?utf-8?q?YubbEOhvR6k1VfCCn43nDY0d+eTBM65kXhDZWPj9ICGh/6ULMsfDMMjAG+hMyUias?= =?utf-8?q?Q4lqDQlG3vU1OnApVrP11VzC2PIWYHSBQdD7hVUmKTNyL+C9EdzftWs4rApfVSqzI?= =?utf-8?q?h7sGvMgTgI2qG2yOAL01SYDAQFsBnrONcMi8Tk5SifGiu08CUK0tHh7E=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29fbe925-b5c6-4cb2-63fb-08dbce5d2dca X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 15:33:00.0238 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fqbvfMzSso1nkE2LhfC/pJvaW4YIKna9QxITqKKFJWBikliTVEChVSNdZ1P9bHbeCTwLzvsTfflphDNHgJHNcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7592 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 16 Oct 2023 08:33:42 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779926748149928261 X-GMAIL-MSGID: 1779926748149928261 |
Series |
i3c: master: svc: collection of bugs fixes
|
|
Commit Message
Frank Li
Oct. 16, 2023, 3:32 p.m. UTC
master side report:
silvaco-i3c-master 44330000.i3c-master: Error condition: MSTATUS 0x020090c7, MERRWARN 0x00100000
BIT 20: TIMEOUT error
The module has stalled too long in a frame. This happens when:
- The TX FIFO or RX FIFO is not handled and the bus is stuck in the
middle of a message,
- No STOP was issued and between messages,
- IBI manual is used and no decision was made.
The maximum stall period is 10 KHz or 100 μs.
This is a just warning. System irq thread schedule latency is possible
bigger than 100us. Just omit this waring.
Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
Cc: stable@vger.kernel.org
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
drivers/i3c/master/svc-i3c-master.c | 6 ++++++
1 file changed, 6 insertions(+)
Comments
Hi Frank, Frank.Li@nxp.com wrote on Mon, 16 Oct 2023 11:32:32 -0400: > master side report: > silvaco-i3c-master 44330000.i3c-master: Error condition: MSTATUS 0x020090c7, MERRWARN 0x00100000 > > BIT 20: TIMEOUT error > The module has stalled too long in a frame. This happens when: > - The TX FIFO or RX FIFO is not handled and the bus is stuck in the > middle of a message, > - No STOP was issued and between messages, > - IBI manual is used and no decision was made. > The maximum stall period is 10 KHz or 100 μs. > > This is a just warning. System irq thread schedule latency is possible can be bigger > bigger than 100us. Just omit this waring. I'm not sure this is the correct approach. It's a real issue but there is not much we can do about it. Perhaps dev_err is too high, but I would not entirely drop this message. Maybe a comment and turning the message into a dbg printk would be more appropriate? > Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") > Cc: stable@vger.kernel.org > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > drivers/i3c/master/svc-i3c-master.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c > index 5bca369d6912..18bc277edc8a 100644 > --- a/drivers/i3c/master/svc-i3c-master.c > +++ b/drivers/i3c/master/svc-i3c-master.c > @@ -93,6 +93,7 @@ > #define SVC_I3C_MINTMASKED 0x098 > #define SVC_I3C_MERRWARN 0x09C > #define SVC_I3C_MERRWARN_NACK BIT(2) > +#define SVC_I3C_MERRWARN_TIMEOUT BIT(20) > #define SVC_I3C_MDMACTRL 0x0A0 > #define SVC_I3C_MDATACTRL 0x0AC > #define SVC_I3C_MDATACTRL_FLUSHTB BIT(0) > @@ -225,6 +226,11 @@ static bool svc_i3c_master_error(struct svc_i3c_master *master) > if (SVC_I3C_MSTATUS_ERRWARN(mstatus)) { > merrwarn = readl(master->regs + SVC_I3C_MERRWARN); > writel(merrwarn, master->regs + SVC_I3C_MERRWARN); > + > + /* ignore timeout error */ > + if (merrwarn & SVC_I3C_MERRWARN_TIMEOUT) > + return false; > + > dev_err(master->dev, > "Error condition: MSTATUS 0x%08x, MERRWARN 0x%08x\n", > mstatus, merrwarn); Thanks, Miquèl
On Tue, Oct 17, 2023 at 04:33:35PM +0200, Miquel Raynal wrote: > Hi Frank, > > Frank.Li@nxp.com wrote on Mon, 16 Oct 2023 11:32:32 -0400: > > > master side report: > > silvaco-i3c-master 44330000.i3c-master: Error condition: MSTATUS 0x020090c7, MERRWARN 0x00100000 > > > > BIT 20: TIMEOUT error > > The module has stalled too long in a frame. This happens when: > > - The TX FIFO or RX FIFO is not handled and the bus is stuck in the > > middle of a message, > > - No STOP was issued and between messages, > > - IBI manual is used and no decision was made. > > The maximum stall period is 10 KHz or 100 μs. > > > > This is a just warning. System irq thread schedule latency is possible > > can be bigger > > bigger than 100us. Just omit this waring. > > I'm not sure this is the correct approach. It's a real issue but there > is not much we can do about it. Perhaps dev_err is too high, but I > would not entirely drop this message. Maybe a comment and turning the > message into a dbg printk would be more appropriate? The key is not message. It return true, means IBI/HJ thread will not run. Frank > > > Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") > > Cc: stable@vger.kernel.org > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > drivers/i3c/master/svc-i3c-master.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c > > index 5bca369d6912..18bc277edc8a 100644 > > --- a/drivers/i3c/master/svc-i3c-master.c > > +++ b/drivers/i3c/master/svc-i3c-master.c > > @@ -93,6 +93,7 @@ > > #define SVC_I3C_MINTMASKED 0x098 > > #define SVC_I3C_MERRWARN 0x09C > > #define SVC_I3C_MERRWARN_NACK BIT(2) > > +#define SVC_I3C_MERRWARN_TIMEOUT BIT(20) > > #define SVC_I3C_MDMACTRL 0x0A0 > > #define SVC_I3C_MDATACTRL 0x0AC > > #define SVC_I3C_MDATACTRL_FLUSHTB BIT(0) > > @@ -225,6 +226,11 @@ static bool svc_i3c_master_error(struct svc_i3c_master *master) > > if (SVC_I3C_MSTATUS_ERRWARN(mstatus)) { > > merrwarn = readl(master->regs + SVC_I3C_MERRWARN); > > writel(merrwarn, master->regs + SVC_I3C_MERRWARN); > > + > > + /* ignore timeout error */ > > + if (merrwarn & SVC_I3C_MERRWARN_TIMEOUT) > > + return false; > > + > > dev_err(master->dev, > > "Error condition: MSTATUS 0x%08x, MERRWARN 0x%08x\n", > > mstatus, merrwarn); > > > Thanks, > Miquèl
Hi Frank, Frank.li@nxp.com wrote on Tue, 17 Oct 2023 10:45:14 -0400: > On Tue, Oct 17, 2023 at 04:33:35PM +0200, Miquel Raynal wrote: > > Hi Frank, > > > > Frank.Li@nxp.com wrote on Mon, 16 Oct 2023 11:32:32 -0400: > > > > > master side report: > > > silvaco-i3c-master 44330000.i3c-master: Error condition: MSTATUS 0x020090c7, MERRWARN 0x00100000 > > > > > > BIT 20: TIMEOUT error > > > The module has stalled too long in a frame. This happens when: > > > - The TX FIFO or RX FIFO is not handled and the bus is stuck in the > > > middle of a message, > > > - No STOP was issued and between messages, > > > - IBI manual is used and no decision was made. > > > The maximum stall period is 10 KHz or 100 μs. > > > > > > This is a just warning. System irq thread schedule latency is possible > > > > can be bigger > > > bigger than 100us. Just omit this waring. > > > > I'm not sure this is the correct approach. It's a real issue but there > > is not much we can do about it. Perhaps dev_err is too high, but I > > would not entirely drop this message. Maybe a comment and turning the > > message into a dbg printk would be more appropriate? > > The key is not message. It return true, means IBI/HJ thread will not run. But why should the workers run if it's too late? Thanks, Miquèl
On Tue, Oct 17, 2023 at 05:06:03PM +0200, Miquel Raynal wrote: > Hi Frank, > > Frank.li@nxp.com wrote on Tue, 17 Oct 2023 10:45:14 -0400: > > > On Tue, Oct 17, 2023 at 04:33:35PM +0200, Miquel Raynal wrote: > > > Hi Frank, > > > > > > Frank.Li@nxp.com wrote on Mon, 16 Oct 2023 11:32:32 -0400: > > > > > > > master side report: > > > > silvaco-i3c-master 44330000.i3c-master: Error condition: MSTATUS 0x020090c7, MERRWARN 0x00100000 > > > > > > > > BIT 20: TIMEOUT error > > > > The module has stalled too long in a frame. This happens when: > > > > - The TX FIFO or RX FIFO is not handled and the bus is stuck in the > > > > middle of a message, > > > > - No STOP was issued and between messages, > > > > - IBI manual is used and no decision was made. > > > > The maximum stall period is 10 KHz or 100 μs. > > > > > > > > This is a just warning. System irq thread schedule latency is possible > > > > > > can be bigger > > > > bigger than 100us. Just omit this waring. > > > > > > I'm not sure this is the correct approach. It's a real issue but there > > > is not much we can do about it. Perhaps dev_err is too high, but I > > > would not entirely drop this message. Maybe a comment and turning the > > > message into a dbg printk would be more appropriate? > > > > The key is not message. It return true, means IBI/HJ thread will not run. > > But why should the workers run if it's too late? IBI ACK already sent, target think master already accepted IBI. then master driver check TIMEOUT, If without run IBI thread, target's driver will wait target sent IBI. And target wait for driver handle IBI. So the whole system may lock or wait for long time out. Hardware check TIMEOUT and software send ACK is totally async. > > Thanks, > Miquèl
diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index 5bca369d6912..18bc277edc8a 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -93,6 +93,7 @@ #define SVC_I3C_MINTMASKED 0x098 #define SVC_I3C_MERRWARN 0x09C #define SVC_I3C_MERRWARN_NACK BIT(2) +#define SVC_I3C_MERRWARN_TIMEOUT BIT(20) #define SVC_I3C_MDMACTRL 0x0A0 #define SVC_I3C_MDATACTRL 0x0AC #define SVC_I3C_MDATACTRL_FLUSHTB BIT(0) @@ -225,6 +226,11 @@ static bool svc_i3c_master_error(struct svc_i3c_master *master) if (SVC_I3C_MSTATUS_ERRWARN(mstatus)) { merrwarn = readl(master->regs + SVC_I3C_MERRWARN); writel(merrwarn, master->regs + SVC_I3C_MERRWARN); + + /* ignore timeout error */ + if (merrwarn & SVC_I3C_MERRWARN_TIMEOUT) + return false; + dev_err(master->dev, "Error condition: MSTATUS 0x%08x, MERRWARN 0x%08x\n", mstatus, merrwarn);