diff mbox series

coredump: Fix build error for ‘dump_emit_page’ defined but not used

Message ID 20221115040400.53712-1-hucool.lihua@huawei.com
State New
Headers
Series coredump: Fix build error for ‘dump_emit_page’ defined but not used |

Commit Message

Lihua (lihua, ran) Nov. 15, 2022, 4:04 a.m. UTC 
  If CONFIG_ELF_CORE is not set:
    fs/coredump.c:834:12: error: ‘dump_emit_page’ defined but not used [-Werror=unused-function]
    static int dump_emit_page(struct coredump_params *cprm, struct page *page)
            ^~~~~~~~~~~~~~

Fix this by adding the missing CONFIG_ELF_CORE for dump_emit_page.

Fixes: 06bbaa6dc53c ("[coredump] don't use __kernel_write() on kmap_local_page()")
Signed-off-by: Li Hua <hucool.lihua@huawei.com>
---
 fs/coredump.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Chaitanya Kulkarni Nov. 15, 2022, 7:35 p.m. UTC | #1 
On 11/14/22 20:04, Li Hua wrote:
> If CONFIG_ELF_CORE is not set:
>      fs/coredump.c:834:12: error: ‘dump_emit_page’ defined but not used [-Werror=unused-function]
>      static int dump_emit_page(struct coredump_params *cprm, struct page *page)
>              ^~~~~~~~~~~~~~
> 
> Fix this by adding the missing CONFIG_ELF_CORE for dump_emit_page.
> 
> Fixes: 06bbaa6dc53c ("[coredump] don't use __kernel_write() on kmap_local_page()")
> Signed-off-by: Li Hua <hucool.lihua@huawei.com>
> ---


Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck
diff mbox series

Patch

diff --git a/fs/coredump.c b/fs/coredump.c
index 7bad7785e8e6..8663042ebe9c 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -831,6 +831,7 @@  static int __dump_skip(struct coredump_params *cprm, size_t nr)
 	}
 }
 
+#ifdef CONFIG_ELF_CORE
 static int dump_emit_page(struct coredump_params *cprm, struct page *page)
 {
 	struct bio_vec bvec = {
@@ -863,6 +864,7 @@  static int dump_emit_page(struct coredump_params *cprm, struct page *page)
 
 	return 1;
 }
+#endif
 
 int dump_emit(struct coredump_params *cprm, const void *addr, int nr)
 {