Message ID | 20231004185732.98621-1-brgl@bgdev.pl |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:254a:b0:403:3b70:6f57 with SMTP id hf10csp345318vqb; Wed, 4 Oct 2023 12:04:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGyLQ9D6O3F5V1qbWL8hipT5zc0X5JhlRfcBFSahxULhfdnmC2uhFt0WajmjCbWF7JT6Hzr X-Received: by 2002:a17:902:ea0c:b0:1c6:3157:29f3 with SMTP id s12-20020a170902ea0c00b001c6315729f3mr3771463plg.36.1696446298983; Wed, 04 Oct 2023 12:04:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696446298; cv=none; d=google.com; s=arc-20160816; b=vstYrJJQKUuROvgiVcNQczViXGIu7eyTIPOxHg0sUatZWWLKA430tFts/gll7pjUhP pJRccDKVDNfkW3R0cAdZzDqKwmPNpH0l8sIcN6hGKVzJt7Wa45+4qbf4xjCg91HBQU/e xlgmUr4uuD/uhK2pqaDt6/2/+rVe1wGXDohLq5pPH4VTZp79g0XfHEFCoTsU8+qnUmMw jefSqpy+oqwzzT9WSBwS7kD1awThDMhBjkz/ND6M9XQhLpJ/8aYnne0QbwlykNa1762Y 0Dag2yIeDxIGdt0GJCtYwkUkiK6oWj2XxF/c9SYb2MNR+dHAMmyFyWGrkluigOzQeHY7 S0NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=VP/93kPYzgXpGiMnYL3cDAWfcq1rdpyqoQ0GDHykkdc=; fh=nOgyBSsZwDUKwvxeLKXlJLHJkKq16abwFCfX7ssZ4qM=; b=FK5uqXFc8U6Z8DfKRk+rTmjf5meLPPczwxpCGqbwSBXQGUIjDbZ3XeCRRXqh3/NO8v adXfv9gx5eMIk+c46m+EmdYOk8toofUYgEUez2QMeerqlddF6nQmP5RB5a6sjIIxCvcv TXdRo0pdsrRPtziYrmO8XDPU6w3OhzM/RW5rC3IlkrvRjqvEYE+Xqib/uzM4Bd1J0xKQ 7Crw8UooD9CZ4+qLH9uAvro0P78/OmxhddUlJQWUPriYODDeh2YHm0d7ajaV/lcbAh/3 3DHc6x8GgM01zNQ2U0LvEMDm0Jj1kXw7AlnN0xaK/zhI+BQXlqb78TgV3LyDKzehKXbn eoIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=L9a9tG9a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id kr13-20020a170903080d00b001c60c5bbff2si3987384plb.201.2023.10.04.12.04.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 12:04:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=L9a9tG9a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 3C0098411D4B; Wed, 4 Oct 2023 12:04:58 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245388AbjJDTEu (ORCPT <rfc822;ezelljr.billy@gmail.com> + 19 others); Wed, 4 Oct 2023 15:04:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344059AbjJDTCu (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 4 Oct 2023 15:02:50 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC31349DA for <linux-kernel@vger.kernel.org>; Wed, 4 Oct 2023 11:57:41 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-32167a4adaaso170267f8f.1 for <linux-kernel@vger.kernel.org>; Wed, 04 Oct 2023 11:57:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1696445860; x=1697050660; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VP/93kPYzgXpGiMnYL3cDAWfcq1rdpyqoQ0GDHykkdc=; b=L9a9tG9aIH8P939QhipXrnN4BkS5st5dPYQIQe2hgyHOW7t6ysB8YQCI2jRis+KCq/ RakwqEm/zdd5O/Pxzcl2nwuG2Xqf6sF7n8pWIpPYyojEMjvQxEAcYxf8wexTdkQVH0+W jHZGDOegygX/Qdz+GK5XFGWF6S3ZUD0CHpC4cmLmLBP28drJpKj2i/61AKGC7Y80/+km sq/TTFgEta4KnSORaSDlJKzh5c003SGxYBhFXdi9l8twN2+idd8BTR4PsPkaxrKLLsIE zWUxOphpdaiJS/zF25BOkpjiWAuA4alWqwQwAFD4EkwNhzaCNqaa2WGblaUe8ePooTWu kS0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696445860; x=1697050660; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VP/93kPYzgXpGiMnYL3cDAWfcq1rdpyqoQ0GDHykkdc=; b=nescIBXSckD0KnGZCWYzqxOzIt6qByEhxeIMhm5aAZylKbXL3FTrSQZDn0I3vWJiEH zoAmer+va0N/ys1NYhHNkwLIa3CzuXkw7Rz/Nw2kMwatCRgdSM0eTgDKvjrQSSmY1SCU 4h2W7LqWnUkDDg6re60is/y8J1iGMQlX2kc+46p6eMHzNfiftZD+5avqYRGk6DK2i+hY 8TQa0uqV+pdAwmShrjySsOlJLjyxUrZxMFk1hT4M86LypYhF6tnqLDozpVXXjF72TAH0 eXwe5953osTMrI6b1jDgtPqZSBHcD0I9h02kmcgBgLIT1apZr26eWnxeM5Tqn721CBLY lCXw== X-Gm-Message-State: AOJu0YyCS9gO4B0YlZHlXklgztr38bb21oHh0SgZ5flvXLDnyVD+IwcU AyRjbHwDGluJW959hJ/OsQEG+Z1xTNSBNL3UrSw= X-Received: by 2002:a5d:4b11:0:b0:31f:ecb2:1bed with SMTP id v17-20020a5d4b11000000b0031fecb21bedmr3137805wrq.15.1696445859897; Wed, 04 Oct 2023 11:57:39 -0700 (PDT) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:4cd6:4440:32bb:f50d]) by smtp.gmail.com with ESMTPSA id u12-20020adfa18c000000b00327de0173f6sm1284961wru.115.2023.10.04.11.57.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 11:57:39 -0700 (PDT) From: Bartosz Golaszewski <brgl@bgdev.pl> To: Bjorn Andersson <andersson@kernel.org>, Maximilian Luz <luzmaximilian@gmail.com> Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Subject: [PATCH] firmware: qcom: qseecom: add missing include guards Date: Wed, 4 Oct 2023 20:57:32 +0200 Message-Id: <20231004185732.98621-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 04 Oct 2023 12:04:58 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778852874372872232 X-GMAIL-MSGID: 1778852874372872232 |
Series |
firmware: qcom: qseecom: add missing include guards
|
|
Commit Message
Bartosz Golaszewski
Oct. 4, 2023, 6:57 p.m. UTC
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> The qseecom header does not contain ifdef guards against multiple inclusion. Add them. Fixes: 00b1248606ba ("firmware: qcom_scm: Add support for Qualcomm Secure Execution Environment SCM interface") Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> --- include/linux/firmware/qcom/qcom_qseecom.h | 6 ++++++ 1 file changed, 6 insertions(+)
Comments
On 10/4/23 20:57, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > The qseecom header does not contain ifdef guards against multiple > inclusion. Add them. > > Fixes: 00b1248606ba ("firmware: qcom_scm: Add support for Qualcomm Secure Execution Environment SCM interface") > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Oh, thanks for spotting and fixing that. Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> PS: I haven't forgotten about your SHM Bridge patches. Testing those is now next up on my kernel TODO list. Unfortunately, it might take a couple more days until I can get around to do it properly. > --- > include/linux/firmware/qcom/qcom_qseecom.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/linux/firmware/qcom/qcom_qseecom.h b/include/linux/firmware/qcom/qcom_qseecom.h > index b531547e1dc9..5c28298a98be 100644 > --- a/include/linux/firmware/qcom/qcom_qseecom.h > +++ b/include/linux/firmware/qcom/qcom_qseecom.h > @@ -5,6 +5,10 @@ > * > * Copyright (C) 2023 Maximilian Luz <luzmaximilian@gmail.com> > */ > + > +#ifndef __QCOM_QSEECOM_H > +#define __QCOM_QSEECOM_H > + > #include <linux/auxiliary_bus.h> > #include <linux/types.h> > > @@ -44,3 +48,5 @@ static inline int qcom_qseecom_app_send(struct qseecom_client *client, void *req > { > return qcom_scm_qseecom_app_send(client->app_id, req, req_size, rsp, rsp_size); > } > + > +#endif /* __QCOM_QSEECOM_H */
On Wed, Oct 4, 2023 at 9:10 PM Maximilian Luz <luzmaximilian@gmail.com> wrote: > > On 10/4/23 20:57, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > The qseecom header does not contain ifdef guards against multiple > > inclusion. Add them. > > > > Fixes: 00b1248606ba ("firmware: qcom_scm: Add support for Qualcomm Secure Execution Environment SCM interface") > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Oh, thanks for spotting and fixing that. > > Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> > > PS: I haven't forgotten about your SHM Bridge patches. Testing those is > now next up on my kernel TODO list. Unfortunately, it might take a > couple more days until I can get around to do it properly. Thanks, you may as well wait for v3 as it'll be reworked significantly again due to some new information I got. Bart > > > --- > > include/linux/firmware/qcom/qcom_qseecom.h | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/include/linux/firmware/qcom/qcom_qseecom.h b/include/linux/firmware/qcom/qcom_qseecom.h > > index b531547e1dc9..5c28298a98be 100644 > > --- a/include/linux/firmware/qcom/qcom_qseecom.h > > +++ b/include/linux/firmware/qcom/qcom_qseecom.h > > @@ -5,6 +5,10 @@ > > * > > * Copyright (C) 2023 Maximilian Luz <luzmaximilian@gmail.com> > > */ > > + > > +#ifndef __QCOM_QSEECOM_H > > +#define __QCOM_QSEECOM_H > > + > > #include <linux/auxiliary_bus.h> > > #include <linux/types.h> > > > > @@ -44,3 +48,5 @@ static inline int qcom_qseecom_app_send(struct qseecom_client *client, void *req > > { > > return qcom_scm_qseecom_app_send(client->app_id, req, req_size, rsp, rsp_size); > > } > > + > > +#endif /* __QCOM_QSEECOM_H */
On Wed, 04 Oct 2023 20:57:32 +0200, Bartosz Golaszewski wrote: > The qseecom header does not contain ifdef guards against multiple > inclusion. Add them. > > Applied, thanks! [1/1] firmware: qcom: qseecom: add missing include guards commit: ada1682d60ac6017037305166d02eb0cd5ee50fa Best regards,
diff --git a/include/linux/firmware/qcom/qcom_qseecom.h b/include/linux/firmware/qcom/qcom_qseecom.h index b531547e1dc9..5c28298a98be 100644 --- a/include/linux/firmware/qcom/qcom_qseecom.h +++ b/include/linux/firmware/qcom/qcom_qseecom.h @@ -5,6 +5,10 @@ * * Copyright (C) 2023 Maximilian Luz <luzmaximilian@gmail.com> */ + +#ifndef __QCOM_QSEECOM_H +#define __QCOM_QSEECOM_H + #include <linux/auxiliary_bus.h> #include <linux/types.h> @@ -44,3 +48,5 @@ static inline int qcom_qseecom_app_send(struct qseecom_client *client, void *req { return qcom_scm_qseecom_app_send(client->app_id, req, req_size, rsp, rsp_size); } + +#endif /* __QCOM_QSEECOM_H */