Message ID | b12bdef9-d5c0-49cf-aea2-ff7b56220fdc@p183 |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp2561726vqb; Sat, 14 Oct 2023 09:14:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG53gqAmngsWVTRJ9nigwoP9ijqD0YuEsfz6XeLjoABN4c1vbbYzgdW6t/tkNSYi6UK1jDR X-Received: by 2002:a05:6a20:c18f:b0:16e:26fd:7c02 with SMTP id bg15-20020a056a20c18f00b0016e26fd7c02mr21928811pzb.2.1697300072584; Sat, 14 Oct 2023 09:14:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697300072; cv=none; d=google.com; s=arc-20160816; b=tzVwdV+Vcb9h4gFia4vpNSk91Deh9YlTb3RUL6rFOqz/rYZISBJRFXxoCtHoHfiI9H zmn/Nv7eVBJCfW3rehdHO02yVPPO7//CSBM7ortj7qbCB5SDmNTxsC1brFB2Tomc6WlY H3Gk90Xbn3ZfcWuxVG86HWb+bDLDeiSXhO2f3WZWlfKQjk0WsPfOATzS6k+WBInMwqFa f+PrCMhhw/tRO5abG1OlSc9Ja1xu7lejWeZDZJ3rPTF2hOm9SpQ+hcfy3XlzBs7jyL0J HR9yAlSMLko4iIvv/qTmYrBjUFNoPceoR4PSgswIHmf8R3UtZxfBM4Yc9Lqvw5r9Vrp6 GatA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=8+ivNfTDHIsqHJ1JTSXb0uVQIdYQ3DRGLDEgHrf6wmY=; fh=OsxpHFVO0TTWpkd9nz9iIoXNJG/cbfzAlmsmMnvz/wI=; b=KFe9WXu4hQdb18bdvXSVgVjDthqE4VUiD+3U4TWJFC2xBE+26cTfH2wd8Lmn8aVcH8 8QAfwCKj2WaB0gSJq834b8ZsO+JTjB7UB3wRfLis0hRyls7NoGXBWf0HvMVXlB0Yg0nS MP2Tw2hEMb5jD/W64H56s4gh3Q54qKzwFvwXcS8lA4oVWa8IkcFkEOSi13VDNorysWWc nwFSHUsFQl3TSRjb+hxKR0tV2VqGoXYn9fvKGzR6o44OW3fePGY8FnDpMJpWb2HagpSS HLdmmu6BWAe4ZWw3XbXKufrBAqbByf1+6+Ajmwv4aRunQ2R/DE/TSSLvpZVg9pkfFEGz dwZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="UvODmFS/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id i16-20020a17090332d000b001b8b437b01esi7443167plr.350.2023.10.14.09.14.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Oct 2023 09:14:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="UvODmFS/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id CC12580401C2; Sat, 14 Oct 2023 09:14:30 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233237AbjJNQOY (ORCPT <rfc822;hjfbswb@gmail.com> + 19 others); Sat, 14 Oct 2023 12:14:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233227AbjJNQOV (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 14 Oct 2023 12:14:21 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91FDAD7 for <linux-kernel@vger.kernel.org>; Sat, 14 Oct 2023 09:14:19 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-53e84912038so521499a12.1 for <linux-kernel@vger.kernel.org>; Sat, 14 Oct 2023 09:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697300058; x=1697904858; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=8+ivNfTDHIsqHJ1JTSXb0uVQIdYQ3DRGLDEgHrf6wmY=; b=UvODmFS/hi9UX2xFdOxaYy8urpjdOToMJkOLov/9d7gipGogeOB7FHXjOqwZXmG3/4 8gUowlgzO3kx6sps/EhwMQkq7XPo62/BPBALKuafQJUWbILgAN+sEYPS90wWRor9G1NG lzYdiKtm14BE54tEPO7JitJaQIIe1yTTKUf+jB+6NfQuU/6MUyPsGQOjdy5yMN9LXEjJ eOKYO17/GLU/KBS/4A59xAVZNhB6VMmW5TZ3PV7BJcRxACHJIA8KuZOUxjp/I0nqkVgG q/o9WgSmMawntPz0JvxQOOWPCEnLl7QkwlZAo1jatjcWrls6R+YrddLAR94dba558FKY alfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697300058; x=1697904858; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8+ivNfTDHIsqHJ1JTSXb0uVQIdYQ3DRGLDEgHrf6wmY=; b=l8L930EJpxUym0CiGBCndp+ukfCfqzb3gmqPKLlf5JOE+Svb0zF89sxT07wCjlhrAX B+3g3zQb2tyFJRuJLSSvS5DS0z4QByKLdMZuTKaRXie9PpR0zvWI1KVUNhJqHP7EPaXC bEw547dGUvjwXsjGWkis+yIRmGLaIqs9lWDjd93kP11EdbZ1OQNfevoWp7JpwRrjE+w7 Y7RffvxdGNiknxGE9o7fZi1lVCZosujn15XOnlAOLOFbc3MyRIpSS1SKsPzBGcc8B+o4 sdaOzI/cx9LvGkEkDofaHUAhjGftKtmBrSk5Ry+7VxE448zIQp4xMfDA3CaLRqzU3l7q Mh1w== X-Gm-Message-State: AOJu0YyQ4pO00QOKaZlV2nR7RgHdE1JnINZJYZTsq5FKRnln5/g0XwIG +6OFcMlT/vysCSK5kpRWRndq01GT8g== X-Received: by 2002:a17:907:31c2:b0:9be:30c2:b8ff with SMTP id xf2-20020a17090731c200b009be30c2b8ffmr2805103ejb.61.1697300057731; Sat, 14 Oct 2023 09:14:17 -0700 (PDT) Received: from p183 ([46.53.253.206]) by smtp.gmail.com with ESMTPSA id hg22-20020a1709072cd600b0099d9dee8108sm1130147ejc.149.2023.10.14.09.14.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Oct 2023 09:14:17 -0700 (PDT) Date: Sat, 14 Oct 2023 19:14:15 +0300 From: Alexey Dobriyan <adobriyan@gmail.com> To: akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] smp: fix __smp_processor_id() backup macro Message-ID: <b12bdef9-d5c0-49cf-aea2-ff7b56220fdc@p183> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sat, 14 Oct 2023 09:14:30 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779748120819122188 X-GMAIL-MSGID: 1779748120819122188 |
Series |
smp: fix __smp_processor_id() backup macro
|
|
Commit Message
Alexey Dobriyan
Oct. 14, 2023, 4:14 p.m. UTC
Every __smp_processor_id usage doesn't have arguments and
every raw_smp_processor_id usage doesn't have arguments,
therefore "#define __smp_processor_id(x)" can not possibly work.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
include/linux/smp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Sat, 14 Oct 2023 19:14:15 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote: > Every __smp_processor_id usage doesn't have arguments and > every raw_smp_processor_id usage doesn't have arguments, > therefore "#define __smp_processor_id(x)" can not possibly work. > > ... > > --- a/include/linux/smp.h > +++ b/include/linux/smp.h > @@ -261,7 +261,7 @@ static inline int get_boot_cpu_id(void) > * regular asm read for the stable. > */ > #ifndef __smp_processor_id > -#define __smp_processor_id(x) raw_smp_processor_id(x) > +#define __smp_processor_id() raw_smp_processor_id() > #endif > It's been that way for at least 4 years. Presumably this is never used and should be removed?
On Sat, Oct 14, 2023 at 03:12:21PM -0700, Andrew Morton wrote: > On Sat, 14 Oct 2023 19:14:15 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote: > > > Every __smp_processor_id usage doesn't have arguments and > > every raw_smp_processor_id usage doesn't have arguments, > > therefore "#define __smp_processor_id(x)" can not possibly work. > > > > ... > > > > --- a/include/linux/smp.h > > +++ b/include/linux/smp.h > > @@ -261,7 +261,7 @@ static inline int get_boot_cpu_id(void) > > * regular asm read for the stable. > > */ > > #ifndef __smp_processor_id > > -#define __smp_processor_id(x) raw_smp_processor_id(x) > > +#define __smp_processor_id() raw_smp_processor_id() > > #endif > > > > It's been that way for at least 4 years. Presumably this is never used > and should be removed? Deleting breaks compilation immediately. C89 6.8.3 §4 says "The number of arguments in an invocation of a function-like macro shall agree with the number of parameters in the macro definition, ..." C99 relaxes this in 6.10.3 §4 the number of arguments (including those arguments consisting of no preprocesing tokens) ... shall equal the number of parameters in the macro definition. So, "#define M()" works with M() only, but "#define M(a)" worked with M(1) and started working as M() which is very funny. In other words changelog is wrong: it can and does work (sort of by accident).
--- a/include/linux/smp.h +++ b/include/linux/smp.h @@ -261,7 +261,7 @@ static inline int get_boot_cpu_id(void) * regular asm read for the stable. */ #ifndef __smp_processor_id -#define __smp_processor_id(x) raw_smp_processor_id(x) +#define __smp_processor_id() raw_smp_processor_id() #endif #ifdef CONFIG_DEBUG_PREEMPT