diff mbox series

[v3,09/14] serial: liteuart: fix rx loop variable types

Message ID	20221112212125.448824-10-gsomlo@gmail.com
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Gabriel Somlo <gsomlo@gmail.com> To: linux-kernel@vger.kernel.org Cc: linux-serial@vger.kernel.org, gregkh@linuxfoundation.org, jirislaby@kernel.org, kgugala@antmicro.com, mholenko@antmicro.com, joel@jms.id.au, david.abdurachmanov@gmail.com, florent@enjoy-digital.fr, geert@linux-m68k.org Subject: [PATCH v3 09/14] serial: liteuart: fix rx loop variable types Date: Sat, 12 Nov 2022 16:21:20 -0500 Message-Id: <20221112212125.448824-10-gsomlo@gmail.com> In-Reply-To: <20221112212125.448824-1-gsomlo@gmail.com> References: <20221112212125.448824-1-gsomlo@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	serial: liteuart: add IRQ support \| [v3,00/14] serial: liteuart: add IRQ support [v3,01/14] serial: liteuart: use KBUILD_MODNAME as driver name [v3,02/14] serial: liteuart: use bit number macros [v3,03/14] serial: liteuart: remove unused uart_ops stubs [v3,04/14] serial: liteuart: don't set unused port fields [v3,05/14] serial: liteuart: minor style fix in liteuart_init() [v3,06/14] serial: liteuart: move tty_flip_buffer_push() out of rx loop [v3,07/14] serial: liteuart: rx loop should only ack rx events [v3,08/14] serial: liteuart: simplify passing of uart_insert_char() flag [v3,09/14] serial: liteuart: fix rx loop variable types [v3,10/14] serial: liteuart: separate rx loop from poll timer [v3,11/14] serial: liteuart: move function definitions [v3,12/14] serial: liteuart: add IRQ support for the RX path [v3,13/14] serial: liteuart: add IRQ support for the TX path [v3,14/14] serial: liteuart: move polling putchar() function

Commit Message

Gabriel L. Somlo Nov. 12, 2022, 9:21 p.m. UTC

  Update variable types to match the signature of uart_insert_char()
which consumes them.

Signed-off-by: Gabriel Somlo <gsomlo@gmail.com>
---
 drivers/tty/serial/liteuart.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Ilpo Järvinen Nov. 15, 2022, 3:46 p.m. UTC | #1

On Sat, 12 Nov 2022, Gabriel Somlo wrote:

> Update variable types to match the signature of uart_insert_char()
> which consumes them.
> 
> Signed-off-by: Gabriel Somlo <gsomlo@gmail.com>
> ---
>  drivers/tty/serial/liteuart.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
> index e9e99d6b5fef..974da0f73257 100644
> --- a/drivers/tty/serial/liteuart.c
> +++ b/drivers/tty/serial/liteuart.c
> @@ -72,8 +72,7 @@ static void liteuart_timer(struct timer_list *t)
>  	struct liteuart_port *uart = from_timer(uart, t, timer);
>  	struct uart_port *port = &uart->port;
>  	unsigned char __iomem *membase = port->membase;
> -	int ch;
> -	unsigned long status;
> +	unsigned int status, ch;
>  
>  	while ((status = !litex_read8(membase + OFF_RXEMPTY)) == 1) {
>  		ch = litex_read8(membase + OFF_RXTX);

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

diff mbox series

Patch

diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
index e9e99d6b5fef..974da0f73257 100644
--- a/drivers/tty/serial/liteuart.c
+++ b/drivers/tty/serial/liteuart.c
@@ -72,8 +72,7 @@  static void liteuart_timer(struct timer_list *t)
 	struct liteuart_port *uart = from_timer(uart, t, timer);
 	struct uart_port *port = &uart->port;
 	unsigned char __iomem *membase = port->membase;
-	int ch;
-	unsigned long status;
+	unsigned int status, ch;
 
 	while ((status = !litex_read8(membase + OFF_RXEMPTY)) == 1) {
 		ch = litex_read8(membase + OFF_RXTX);