diff mbox series

[v2] Libvtv-test: Fix bug that scansarif.exp cannot be found in libvtv regression test.

Message ID 20220927060228.573975-1-chenglulu@loongson.cn
State Accepted, archived
Headers
Series [v2] Libvtv-test: Fix bug that scansarif.exp cannot be found in libvtv regression test. |

Checks

Context Check Description
snail/gcc-patches-check success Github commit url

Commit Message

chenglulu Sept. 27, 2022, 6:02 a.m. UTC 
  SARIF support was added in r13-967 but libvtv wasn't updated.

libvtv/ChangeLog:

	* testsuite/lib/libvtv-dg.exp: Add load_gcc_lib of scansarif.exp.
---
 libvtv/testsuite/lib/libvtv-dg.exp | 2 ++
 1 file changed, 2 insertions(+)

Comments

David Malcolm Sept. 27, 2022, 2:01 p.m. UTC | #1 
On Tue, 2022-09-27 at 14:02 +0800, Lulu Cheng wrote:
>         SARIF support was added in r13-967 but libvtv wasn't updated.

Sorry about breaking this.  The patch looks reasonable to me, FWIW,
assuming that it fixes the issue, of course!

Looks like my normal testing process missed this when I was testing the
SARIF patch; presumably we need to configure with --enable-vtable-
verify=yes to enable this feature.

Thanks
Dave

> 
> libvtv/ChangeLog:
> 
>         * testsuite/lib/libvtv-dg.exp: Add load_gcc_lib of
> scansarif.exp.
> ---
>  libvtv/testsuite/lib/libvtv-dg.exp | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libvtv/testsuite/lib/libvtv-dg.exp
> b/libvtv/testsuite/lib/libvtv-dg.exp
> index b140c194cdc..454d916e556 100644
> --- a/libvtv/testsuite/lib/libvtv-dg.exp
> +++ b/libvtv/testsuite/lib/libvtv-dg.exp
> @@ -12,6 +12,8 @@
>  # along with this program; if not, write to the Free Software
>  # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
> 02110-1301, USA.
>  
> +load_gcc_lib scansarif.exp
> +
>  proc libvtv-dg-test { prog do_what extra_tool_flags } {
>      return [gcc-dg-test-1 libvtv_target_compile $prog $do_what
> $extra_tool_flags]
>  }
chenglulu Sept. 28, 2022, 3:05 a.m. UTC | #2 
在 2022/9/27 下午10:01, David Malcolm 写道:
> On Tue, 2022-09-27 at 14:02 +0800, Lulu Cheng wrote:
>>          SARIF support was added in r13-967 but libvtv wasn't updated.
> Sorry about breaking this.  The patch looks reasonable to me, FWIW,
> assuming that it fixes the issue, of course!
>
> Looks like my normal testing process missed this when I was testing the
> SARIF patch; presumably we need to configure with --enable-vtable-
> verify=yes to enable this feature.
>
> Thanks
> Dave
>
Hi, Dave:

  I have passed the test, if there is no problem, I will merge into the 
master branch.
chenglulu Oct. 12, 2022, 2:53 a.m. UTC | #3 
Pushed to r13-3241

在 2022/9/27 下午10:01, David Malcolm 写道:
> On Tue, 2022-09-27 at 14:02 +0800, Lulu Cheng wrote:
>>          SARIF support was added in r13-967 but libvtv wasn't updated.
> Sorry about breaking this.  The patch looks reasonable to me, FWIW,
> assuming that it fixes the issue, of course!
>
> Looks like my normal testing process missed this when I was testing the
> SARIF patch; presumably we need to configure with --enable-vtable-
> verify=yes to enable this feature.
>
> Thanks
> Dave
>
>> libvtv/ChangeLog:
>>
>>          * testsuite/lib/libvtv-dg.exp: Add load_gcc_lib of
>> scansarif.exp.
>> ---
>>   libvtv/testsuite/lib/libvtv-dg.exp | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/libvtv/testsuite/lib/libvtv-dg.exp
>> b/libvtv/testsuite/lib/libvtv-dg.exp
>> index b140c194cdc..454d916e556 100644
>> --- a/libvtv/testsuite/lib/libvtv-dg.exp
>> +++ b/libvtv/testsuite/lib/libvtv-dg.exp
>> @@ -12,6 +12,8 @@
>>   # along with this program; if not, write to the Free Software
>>   # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
>> 02110-1301, USA.
>>   
>> +load_gcc_lib scansarif.exp
>> +
>>   proc libvtv-dg-test { prog do_what extra_tool_flags } {
>>       return [gcc-dg-test-1 libvtv_target_compile $prog $do_what
>> $extra_tool_flags]
>>   }
diff mbox series

Patch

diff --git a/libvtv/testsuite/lib/libvtv-dg.exp b/libvtv/testsuite/lib/libvtv-dg.exp
index b140c194cdc..454d916e556 100644
--- a/libvtv/testsuite/lib/libvtv-dg.exp
+++ b/libvtv/testsuite/lib/libvtv-dg.exp
@@ -12,6 +12,8 @@ 
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 
+load_gcc_lib scansarif.exp
+
 proc libvtv-dg-test { prog do_what extra_tool_flags } {
     return [gcc-dg-test-1 libvtv_target_compile $prog $do_what $extra_tool_flags]
 }