Message ID | 20231009153427.20951-16-brgl@bgdev.pl |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp1952799vqo; Mon, 9 Oct 2023 08:36:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGsF90B16HSiK4McULhmy6EKJcEnOM1UG14jX+GvGSUHlopW5/FA8+Y45ZgZu+Ka9eNSAWl X-Received: by 2002:a17:90a:ee86:b0:277:522d:11e5 with SMTP id i6-20020a17090aee8600b00277522d11e5mr12174230pjz.2.1696865801647; Mon, 09 Oct 2023 08:36:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696865801; cv=none; d=google.com; s=arc-20160816; b=pr7a6xLLy+kd97BRpFMvB8LAk++CTJYsN8do9G6PDFc1As0B4qcrdXBuFEo48CS6bB qGmWufjlVJAhFYDXzlm9S8B5xEhvHO1ZKyORolnLfrr5LgOT3TTm8zWALIeVgjWNZXHe q5NoFMd6J6oSjotNBimsPiYeDhPYErzG/g7EUgtm47uvb/sbUeVe79VED82zdBzLrXlv cMsWecilR+2oRolymqDzWE77Y2PCUd+2nG18c9SCbi+/mzHTS2Yy3YV86G2ClDYEY1o3 pPP42G4Y/wR7uF8+qD62LtzCuGb5w8SvIVOWvz/T+LIUdLxmVb2gcB4OmOR7MQrVuYn3 1rBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ICq8xSC80Kt4obE0o4+sSt1jGbe7ldZCyofAgnJ+E2Q=; fh=O6SiPHn5iCqd45TFk28gzUt5THQm6tVf4326AZjzWQs=; b=SpfpPKyQmigQQYHHxRyou2Ykw77JJLQXw2wSiqs++eYQN6UMVQOuvX3pA3JAYAMjxL DeTUXjCnWIwODIEPbC8jNKzXkdK+swPNUu/yZ8i+9cDmX56VvzewimFwa9hYHjfigWhV TDXuXjaiDzFGnKxxTg22IHMgviNhp6Nbt/loO/zPwXZqpH0C3KzjnwugjtsunQs4NCw+ 4ewEqqDhigUuk4wkXh5jvkeQJ5U3s8z2sVts4VJbX96H/nG6hjBvC/cBDO35uDOUVyGk whnww4y9O6qPbtNc6y7uzAaz6xxEc9/WWNlPCEitvNk8yVIlDoSEIp9YFscXKfBCyX2e aoHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=jQ0ZKIZl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id lx17-20020a17090b4b1100b00274c8943b59si13267931pjb.64.2023.10.09.08.36.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 08:36:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=jQ0ZKIZl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 7659080ABF35; Mon, 9 Oct 2023 08:36:37 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376553AbjJIPgH (ORCPT <rfc822;ezelljr.billy@gmail.com> + 18 others); Mon, 9 Oct 2023 11:36:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377659AbjJIPfb (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 9 Oct 2023 11:35:31 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D0F2138 for <linux-kernel@vger.kernel.org>; Mon, 9 Oct 2023 08:35:00 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-3226cc3e324so4617691f8f.3 for <linux-kernel@vger.kernel.org>; Mon, 09 Oct 2023 08:35:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1696865698; x=1697470498; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ICq8xSC80Kt4obE0o4+sSt1jGbe7ldZCyofAgnJ+E2Q=; b=jQ0ZKIZlzGyLX63Hd6C7dK8bEhUkd9OIc8rYtcT7RwTGzPxoaMcKraCSrPhbYelP7i SVm1aSneTNSxj/N5rWi2XIboQzi6ucXjckXWQhjR9WCQKLym2aLHX5J4WsyFa55Ctpx+ WZpRf8ZyvJXJDV/bAZameAjywUToqs5L4rzbdfKv4+KdduUOF/mJwL28vAQB1OAoEv4U OXGmMHo66mb7sfWN90GB8NaWBx3L4rXg1Qan1pBiC7u8DNC2QGlkK9ucDma6uNrqsynY hRu04rz3J6tzROeWULJjAnFXf+cKcqJl/jBoSX26Lg4IhdxyOjyRT0K5Be+N0Pjc+w/L pl9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696865698; x=1697470498; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ICq8xSC80Kt4obE0o4+sSt1jGbe7ldZCyofAgnJ+E2Q=; b=rWCG9R/aCQv4BWBtySzPOUGxY9+6vdW+z1UvNWcoiN9sVMQUeZa6CbXOL71mULNf99 sI+o4Obal7gDiR8tRjQyOdZ87kD3SGIEElgHV6x8D6YmH9htPazlZfRVMLFjNVqTjATG H+TvaZYTt6WUz+wegkFbNwxAH9Dm5wVGxLk9GYs4SAjlzwPCfJUs+QpilUhQqhq+iXoX Eyy6doMMC+36K/UAuymVkm76hstzNeJYspYXARbg+yg6yERZexjyZIY9T6X/DnCAYURH UgHdGvAjh095AWxrnyP056LP4iYLh/3+q9SfJTrLWvESjEhQA6EjrggnCFhhB8Ws5bAm 4Faw== X-Gm-Message-State: AOJu0YzsS9uc/lHd2vyqifTPU/4p0xuVdndQdfJ25CC23yuIGC/XZT5r +wpRanmOWAo+MKmW8ZrW7UnOZQ== X-Received: by 2002:adf:f08f:0:b0:318:f7a:e3c8 with SMTP id n15-20020adff08f000000b003180f7ae3c8mr15642287wro.57.1696865698736; Mon, 09 Oct 2023 08:34:58 -0700 (PDT) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:f20d:2959:7545:e99f]) by smtp.gmail.com with ESMTPSA id b3-20020adff243000000b0031431fb40fasm10016521wrp.89.2023.10.09.08.34.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 08:34:58 -0700 (PDT) From: Bartosz Golaszewski <brgl@bgdev.pl> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Elliot Berman <quic_eberman@quicinc.com>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Guru Das Srinagesh <quic_gurus@quicinc.com>, Andrew Halaney <ahalaney@redhat.com>, Maximilian Luz <luzmaximilian@gmail.com>, Alex Elder <elder@linaro.org>, Srini Kandagatla <srinivas.kandagatla@linaro.org> Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@quicinc.com, Bartosz Golaszewski <bartosz.golaszewski@linaro.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Arnd Bergmann <arnd@arndb.de> Subject: [PATCH v3 15/15] arm64: defconfig: enable SHM Bridge support for the TZ memory allocator Date: Mon, 9 Oct 2023 17:34:27 +0200 Message-Id: <20231009153427.20951-16-brgl@bgdev.pl> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231009153427.20951-1-brgl@bgdev.pl> References: <20231009153427.20951-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=2.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_SBL_CSS, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 09 Oct 2023 08:36:37 -0700 (PDT) X-Spam-Level: ** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779292754665830458 X-GMAIL-MSGID: 1779292754665830458 |
Series |
arm64: qcom: add and enable SHM Bridge support
|
|
Commit Message
Bartosz Golaszewski
Oct. 9, 2023, 3:34 p.m. UTC
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Enable SHM Bridge support in the Qualcomm TrustZone allocator by default as even on architectures that don't support it, we automatically fall back to the default behavior. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)
Comments
On Mon, Oct 09, 2023 at 05:34:27PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Enable SHM Bridge support in the Qualcomm TrustZone allocator by default > as even on architectures that don't support it, we automatically fall > back to the default behavior. Can you give some motivation for the Kconfig? It seems like what you've wrote should just fallback to the non SHM bridge allocated memory, so I don't see what having the option to exclude that at build time gives us. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 07011114eef8..ebe97fec6e33 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -255,6 +255,7 @@ CONFIG_INTEL_STRATIX10_RSU=m > CONFIG_EFI_CAPSULE_LOADER=y > CONFIG_IMX_SCU=y > CONFIG_IMX_SCU_PD=y > +CONFIG_QCOM_TZMEM_MODE_SHMBRIDGE=y > CONFIG_GNSS=m > CONFIG_GNSS_MTK_SERIAL=m > CONFIG_MTD=y > -- > 2.39.2 >
On Wed, Oct 11, 2023 at 11:20 PM Andrew Halaney <ahalaney@redhat.com> wrote: > > On Mon, Oct 09, 2023 at 05:34:27PM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > Enable SHM Bridge support in the Qualcomm TrustZone allocator by default > > as even on architectures that don't support it, we automatically fall > > back to the default behavior. > > Can you give some motivation for the Kconfig? It seems like what you've > wrote should just fallback to the non SHM bridge allocated memory, so I > don't see what having the option to exclude that at build time gives us. > If the hypervisor gets quirky in a new place other than the PAS image calls, we will be able to just disable SHM Bridge, otherwise the kernel will use it if it's supported even if it causes problems? Bart > > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > --- > > arch/arm64/configs/defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > index 07011114eef8..ebe97fec6e33 100644 > > --- a/arch/arm64/configs/defconfig > > +++ b/arch/arm64/configs/defconfig > > @@ -255,6 +255,7 @@ CONFIG_INTEL_STRATIX10_RSU=m > > CONFIG_EFI_CAPSULE_LOADER=y > > CONFIG_IMX_SCU=y > > CONFIG_IMX_SCU_PD=y > > +CONFIG_QCOM_TZMEM_MODE_SHMBRIDGE=y > > CONFIG_GNSS=m > > CONFIG_GNSS_MTK_SERIAL=m > > CONFIG_MTD=y > > -- > > 2.39.2 > > >
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 07011114eef8..ebe97fec6e33 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -255,6 +255,7 @@ CONFIG_INTEL_STRATIX10_RSU=m CONFIG_EFI_CAPSULE_LOADER=y CONFIG_IMX_SCU=y CONFIG_IMX_SCU_PD=y +CONFIG_QCOM_TZMEM_MODE_SHMBRIDGE=y CONFIG_GNSS=m CONFIG_GNSS_MTK_SERIAL=m CONFIG_MTD=y