diff mbox series

[1/1] selftests/mm: include mman header to access MREMAP_DONTUNMAP identifier

Message ID 20231012064048.433346-1-samasth.norway.ananda@oracle.com
State New
Headers
Series [1/1] selftests/mm: include mman header to access MREMAP_DONTUNMAP identifier |

Commit Message

Samasth Norway Ananda Oct. 12, 2023, 6:40 a.m. UTC 
  Definition for MREMAP_DONTUNMAP not present in the selftest for
mremap_dontunmap thus throwing an undeclared error when running make
on mm.

Fixes: 0183d777c29a ("selftests: mm: remove duplicate unneeded defines")
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Closes: https://lore.kernel.org/linux-mm/CA+G9fYvV-71XqpCr_jhdDfEtN701fBdG3q+=bafaZiGwUXy_aA@mail.gmail.com/
Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>
---
 tools/testing/selftests/mm/mremap_dontunmap.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Muhammad Usama Anjum Oct. 12, 2023, 8:06 a.m. UTC | #1 
On 10/12/23 11:40 AM, Samasth Norway Ananda wrote:
> Definition for MREMAP_DONTUNMAP not present in the selftest for
> mremap_dontunmap thus throwing an undeclared error when running make
> on mm.
Thanks for sending the patch.

You have mentioned in other email that MREMAP_DONTUNMAP isn't present in
glibc older than 2.32. So including linux/mman.h solves the build error for
people having older glibc. Please add this to the description of the patch
to give the exact reason this patch should be accepted.

> 
> Fixes: 0183d777c29a ("selftests: mm: remove duplicate unneeded defines")
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> Closes: https://lore.kernel.org/linux-mm/CA+G9fYvV-71XqpCr_jhdDfEtN701fBdG3q+=bafaZiGwUXy_aA@mail.gmail.com/
> Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>
> ---
>  tools/testing/selftests/mm/mremap_dontunmap.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/mm/mremap_dontunmap.c b/tools/testing/selftests/mm/mremap_dontunmap.c
> index ca2359835e75..a06e73ec8568 100644
> --- a/tools/testing/selftests/mm/mremap_dontunmap.c
> +++ b/tools/testing/selftests/mm/mremap_dontunmap.c
> @@ -7,6 +7,7 @@
>   */
>  #define _GNU_SOURCE
>  #include <sys/mman.h>
> +#include <linux/mman.h>
>  #include <errno.h>
>  #include <stdio.h>
>  #include <stdlib.h>
Tested-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Muhammad Usama Anjum Oct. 12, 2023, 8:17 a.m. UTC | #2 
On 10/12/23 1:06 PM, Muhammad Usama Anjum wrote:
> On 10/12/23 11:40 AM, Samasth Norway Ananda wrote:
>> Definition for MREMAP_DONTUNMAP not present in the selftest for
>> mremap_dontunmap thus throwing an undeclared error when running make
>> on mm.
> Thanks for sending the patch.
> 
> You have mentioned in other email that MREMAP_DONTUNMAP isn't present in
> glibc older than 2.32. So including linux/mman.h solves the build error for
> people having older glibc. Please add this to the description of the patch
> to give the exact reason this patch should be accepted.
> 
>>
>> Fixes: 0183d777c29a ("selftests: mm: remove duplicate unneeded defines")
>> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>> Closes: https://lore.kernel.org/linux-mm/CA+G9fYvV-71XqpCr_jhdDfEtN701fBdG3q+=bafaZiGwUXy_aA@mail.gmail.com/
>> Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>
>> ---
>>  tools/testing/selftests/mm/mremap_dontunmap.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/testing/selftests/mm/mremap_dontunmap.c b/tools/testing/selftests/mm/mremap_dontunmap.c
>> index ca2359835e75..a06e73ec8568 100644
>> --- a/tools/testing/selftests/mm/mremap_dontunmap.c
>> +++ b/tools/testing/selftests/mm/mremap_dontunmap.c
>> @@ -7,6 +7,7 @@
>>   */
>>  #define _GNU_SOURCE
>>  #include <sys/mman.h>
>> +#include <linux/mman.h>
>>  #include <errno.h>
>>  #include <stdio.h>
>>  #include <stdlib.h>
> Tested-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Just to add more context, the build error doesn't trigger on latest glibc.
I've tested building this test with glic 2.31 and there is build error.
This patch fixes the build error.

>
Samasth Norway Ananda Oct. 12, 2023, 12:05 p.m. UTC | #3 
On 10/12/23 1:06 AM, Muhammad Usama Anjum wrote:

> You have mentioned in other email that MREMAP_DONTUNMAP isn't present in
> glibc older than 2.32. So including linux/mman.h solves the build error for
> people having older glibc. Please add this to the description of the patch
> to give the exact reason this patch should be accepted.
> 

Thanks Usama. I will send out a v2 patch with updated description as you 
suggested.
diff mbox series

Patch

diff --git a/tools/testing/selftests/mm/mremap_dontunmap.c b/tools/testing/selftests/mm/mremap_dontunmap.c
index ca2359835e75..a06e73ec8568 100644
--- a/tools/testing/selftests/mm/mremap_dontunmap.c
+++ b/tools/testing/selftests/mm/mremap_dontunmap.c
@@ -7,6 +7,7 @@ 
  */
 #define _GNU_SOURCE
 #include <sys/mman.h>
+#include <linux/mman.h>
 #include <errno.h>
 #include <stdio.h>
 #include <stdlib.h>