| Message ID | 20231006105803.3374241-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp231851vqo;
Fri, 6 Oct 2023 03:58:30 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IHJssHEc1URhOVCcls5kGyauiuAScfgQbuPRccodXdamaX7QaWkxM7DRau6/1CTQPD+YMSU
X-Received: by 2002:a05:6830:118f:b0:6bc:cd0d:427e with SMTP id
u15-20020a056830118f00b006bccd0d427emr6629108otq.38.1696589910502;
Fri, 06 Oct 2023 03:58:30 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1696589910; cv=none;
d=google.com; s=arc-20160816;
b=QAXBOI2Rafm/NQcPnr7NytosSeHvZRdyd16hTsiZbgYOmx81V7eg8L1WA2aXZj0oOU
dOJXfg+0DqW9Eib+n45liZN1z2gCmqAjRDF4c9rM7YlKD9HfpHaJ1rAB50Ia5x0co9sw
03p7hcWvsYLdL1rxNkTmpiYmHDxUgprqiRGcSuecgSl2yLTEiopIM7eiKRuxDczMxknf
gCRn0+0k3oMYteFVQD9hYiPqnuj2Gw5IQghDndxsVX2bVX6DTxbK3huf5n2/6UhkimIH
NWq3PCezUbA7gLTuag9LhhIwSt+r+03LXPjB87R15S3tQOBR0k6piep473ZdB2iu2fPF
oMiw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:to:from:dkim-signature;
bh=RwPAOa96lPPVpWvIP5PI54qzk061hmQomDVoT23UNyY=;
fh=wkg3aNw707R+3vA+XhVvqo40KTiysnczoHBtQFob+zQ=;
b=DHPgPfLmy9+mba30svEcEYgZjayE4huiQJL5Lo0YTza8PHhtM/dZZeCv0Y4kRXCb9e
50NvAqKr4T3Nf5scrMSWZUI/LZrlvzzuiVbZUNcvfHOVO4lmVebmYEPoKuz9TrPW5xJR
/f/zsGPSzs0LsKRU8q1dujns9v9MWYTam7No5FqfH4zqD0SCZqgDtP5+F0K1JaGs+qO7
PMR8liJldUC2fCLPdiBdidHUu4T6yNE075pGRMGorXI5hOxq3ZHYJu4bmNDfdpgwXj2s
Ck2Zj01mzytMW3676iUcPQ2kTNBS5ykEAUYpZiLfrYKaTaTLrIb+lGNBGWXVOZiUM+Y/
UWjg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@intel.com header.s=Intel header.b=eLfRYWCV;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.36 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com
Received: from pete.vger.email (pete.vger.email. [23.128.96.36])
by mx.google.com with ESMTPS id
q24-20020a63d618000000b00577f50580bbsi3323941pgg.299.2023.10.06.03.58.30
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 06 Oct 2023 03:58:30 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Authentication-Results: mx.google.com;
dkim=pass header.i=@intel.com header.s=Intel header.b=eLfRYWCV;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.36 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by pete.vger.email (Postfix) with ESMTP id 710DF83D8D5A;
Fri, 6 Oct 2023 03:58:28 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231874AbjJFK6N (ORCPT <rfc822;ezelljr.billy@gmail.com>
+ 18 others); Fri, 6 Oct 2023 06:58:13 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51360 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231822AbjJFK6K (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 6 Oct 2023 06:58:10 -0400
Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B252DB;
Fri, 6 Oct 2023 03:58:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1696589889; x=1728125889;
h=from:to:subject:date:message-id:mime-version:
content-transfer-encoding;
bh=xHrblxy5LJz/0z88RZl5mzsZZ2ICJvk7WRsbXXPcjSk=;
b=eLfRYWCV3bGI9irzossFRI9/pg/VNjFK9yV54VSiSlbq7GbosVmYoMF0
NYeCA7aTc8HLUYOe7QPebB05miOkvZAlYW7vKcTXUF4xeUj4z5bY9IaOJ
ViJL+cfyluUPt19JuP0J+E/Bzz14oIPiG9n09Q6uBjtBAkXdoc57oSrZy
nx0yPvJjhINCu/I2mtsCwkOMyaEtCbBbVEe28P9XHt4yM9T/lmJj/eT71
FaaAHwMFOr5tnFBBqaZmGN97EDfXImPgeAuTKT1FWUM/ulDCEZ/Iyfu9j
8XWlcWgdKo25EWBk5LUcLkeLEdGiiPsUOr7sH6M2GgXGp8Uyn9rjbXXy7
A==;
X-IronPort-AV: E=McAfee;i="6600,9927,10854"; a="363082468"
X-IronPort-AV: E=Sophos;i="6.03,203,1694761200";
d="scan'208";a="363082468"
Received: from orsmga004.jf.intel.com ([10.7.209.38])
by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
06 Oct 2023 03:58:08 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6600,9927,10854"; a="875906267"
X-IronPort-AV: E=Sophos;i="6.03,203,1694761200";
d="scan'208";a="875906267"
Received: from black.fi.intel.com ([10.237.72.28])
by orsmga004.jf.intel.com with ESMTP; 06 Oct 2023 03:58:07 -0700
Received: by black.fi.intel.com (Postfix, from userid 1003)
id 5C8934F4; Fri, 6 Oct 2023 13:58:05 +0300 (EEST)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1 1/2] mmc: sdhci-pltfm: Drop unnecessary error messages in
sdhci_pltfm_init()
Date: Fri, 6 Oct 2023 13:58:02 +0300
Message-Id: <20231006105803.3374241-1-andriy.shevchenko@linux.intel.com>
X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=2.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]);
Fri, 06 Oct 2023 03:58:28 -0700 (PDT)
X-Spam-Level: **
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1779003461783619651
X-GMAIL-MSGID: 1779003461783619651
|
| Series |
[v1,1/2] mmc: sdhci-pltfm: Drop unnecessary error messages in sdhci_pltfm_init()
|
|
Commit Message
Andy Shevchenko
Oct. 6, 2023, 10:58 a.m. UTC
The devm_platform_ioremap_resource() and platform_get_irq() print
the error messages themselves and our "failed" one brings no value
and just noise. Refactor code to avoid those noisy error messages.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/mmc/host/sdhci-pltfm.c | 22 +++++++---------------
1 file changed, 7 insertions(+), 15 deletions(-)
Comments
On 6/10/23 13:58, Andy Shevchenko wrote: > The devm_platform_ioremap_resource() and platform_get_irq() print > the error messages themselves and our "failed" one brings no value > and just noise. Refactor code to avoid those noisy error messages. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/host/sdhci-pltfm.c | 22 +++++++--------------- > 1 file changed, 7 insertions(+), 15 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c > index a72e123a585d..4d1a703a5bdb 100644 > --- a/drivers/mmc/host/sdhci-pltfm.c > +++ b/drivers/mmc/host/sdhci-pltfm.c > @@ -115,26 +115,21 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev, > { > struct sdhci_host *host; > void __iomem *ioaddr; > - int irq, ret; > + int irq; > > ioaddr = devm_platform_ioremap_resource(pdev, 0); > - if (IS_ERR(ioaddr)) { > - ret = PTR_ERR(ioaddr); > - goto err; > - } > + if (IS_ERR(ioaddr)) > + return ERR_CAST(ioaddr); > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - ret = irq; > - goto err; > - } > + if (irq < 0) > + return ERR_PTR(irq); > > host = sdhci_alloc_host(&pdev->dev, > sizeof(struct sdhci_pltfm_host) + priv_size); > - > if (IS_ERR(host)) { > - ret = PTR_ERR(host); > - goto err; > + dev_err(&pdev->dev, "%s failed %pe\n", __func__, host); > + return ERR_CAST(host); > } > > host->ioaddr = ioaddr; > @@ -152,9 +147,6 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev, > platform_set_drvdata(pdev, host); > > return host; > -err: > - dev_err(&pdev->dev, "%s failed %d\n", __func__, ret); > - return ERR_PTR(ret); > } > EXPORT_SYMBOL_GPL(sdhci_pltfm_init); >
On Fri, 6 Oct 2023 at 12:58, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > The devm_platform_ioremap_resource() and platform_get_irq() print > the error messages themselves and our "failed" one brings no value > and just noise. Refactor code to avoid those noisy error messages. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-pltfm.c | 22 +++++++--------------- > 1 file changed, 7 insertions(+), 15 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c > index a72e123a585d..4d1a703a5bdb 100644 > --- a/drivers/mmc/host/sdhci-pltfm.c > +++ b/drivers/mmc/host/sdhci-pltfm.c > @@ -115,26 +115,21 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev, > { > struct sdhci_host *host; > void __iomem *ioaddr; > - int irq, ret; > + int irq; > > ioaddr = devm_platform_ioremap_resource(pdev, 0); > - if (IS_ERR(ioaddr)) { > - ret = PTR_ERR(ioaddr); > - goto err; > - } > + if (IS_ERR(ioaddr)) > + return ERR_CAST(ioaddr); > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - ret = irq; > - goto err; > - } > + if (irq < 0) > + return ERR_PTR(irq); > > host = sdhci_alloc_host(&pdev->dev, > sizeof(struct sdhci_pltfm_host) + priv_size); > - > if (IS_ERR(host)) { > - ret = PTR_ERR(host); > - goto err; > + dev_err(&pdev->dev, "%s failed %pe\n", __func__, host); > + return ERR_CAST(host); > } > > host->ioaddr = ioaddr; > @@ -152,9 +147,6 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev, > platform_set_drvdata(pdev, host); > > return host; > -err: > - dev_err(&pdev->dev, "%s failed %d\n", __func__, ret); > - return ERR_PTR(ret); > } > EXPORT_SYMBOL_GPL(sdhci_pltfm_init); > > -- > 2.40.0.1.gaa8946217a0b >
diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c index a72e123a585d..4d1a703a5bdb 100644 --- a/drivers/mmc/host/sdhci-pltfm.c +++ b/drivers/mmc/host/sdhci-pltfm.c @@ -115,26 +115,21 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev, { struct sdhci_host *host; void __iomem *ioaddr; - int irq, ret; + int irq; ioaddr = devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(ioaddr)) { - ret = PTR_ERR(ioaddr); - goto err; - } + if (IS_ERR(ioaddr)) + return ERR_CAST(ioaddr); irq = platform_get_irq(pdev, 0); - if (irq < 0) { - ret = irq; - goto err; - } + if (irq < 0) + return ERR_PTR(irq); host = sdhci_alloc_host(&pdev->dev, sizeof(struct sdhci_pltfm_host) + priv_size); - if (IS_ERR(host)) { - ret = PTR_ERR(host); - goto err; + dev_err(&pdev->dev, "%s failed %pe\n", __func__, host); + return ERR_CAST(host); } host->ioaddr = ioaddr; @@ -152,9 +147,6 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev, platform_set_drvdata(pdev, host); return host; -err: - dev_err(&pdev->dev, "%s failed %d\n", __func__, ret); - return ERR_PTR(ret); } EXPORT_SYMBOL_GPL(sdhci_pltfm_init);