| Message ID | 20231010085434.2678144-1-chenhuacai@loongson.cn |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp52241vqb;
Tue, 10 Oct 2023 01:55:24 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IEpUsU5L+xeOC4VzOl1Dw9FNSDTJBkf21jpO+dnPkecb9zQxcReIadgzZyHLcW9imEuGft8
X-Received: by 2002:a17:903:249:b0:1c5:befa:d81d with SMTP id
j9-20020a170903024900b001c5befad81dmr19039114plh.10.1696928124499;
Tue, 10 Oct 2023 01:55:24 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1696928124; cv=none;
d=google.com; s=arc-20160816;
b=rvqZsDmpmYATh8daBss6MIBQxnjdnxtLrGh3G6++yEtKX12WRHiZGVlknuoDM/vx/Z
dWVJDbZh2BWkALTC8GenaQgXcdQPav/xkI3Hb+Y0IWtTyEfpZfENusDntVe6geeshY16
7ltTEXUP6YFmsEucU9ap4TSHyruNEem8tCZpAajbg1eSggG0CcUDE3y8bZf6hsPhnc9R
QJdjK5kPli7etestk9DThDRwyJtrme3R83G81O9pTeb29BBWXRVNKbw8RA7yd3J6huBr
je5duZQcNkw+7YsOYg+G9FE36yDzAsqc6OoaeJ5AcTr8YNpyCqlJB0J5+noOMsNniYAu
gW1Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from;
bh=7pRzvVTBJDmxmeQ3MaTFhMC0BsBz53yp2KAdkKe4ODM=;
fh=34sOZM5P8nVGID3gNsa0EB3sZZ7HIOVdIsLkuIDhrbA=;
b=cnHbPgcTYiZa+siBCypizbo0iP1GKxg2+WB834qNz2elaUi9WY3ilybdLy2BxRgnOX
ocB5Xt5F2OJvuH/oGGOAUa90UcQMvEpPqJN/YeyFMGRmRXXnJrT4d6aPZf5qo6m10wzM
a2kY0WF+YgKFBQ+NmzwloXWhmVi/tPVn/yxw564kSPYvn+zkp665Sx8EASSv3DRTrk7a
hakphLWiJhVgIhgLfsj6L0xC5l3mNYzq5nim/y205SPiiiKBumV0z45gQEvOXtTqTLTO
/fqERV/Ibb/n2cotTBV153wzwrZQ+Efu1ww33IFmVNpqzSSH+Of7Qkkb7vM3hFBBKAm+
6PLg==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:1 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1])
by mx.google.com with ESMTPS id
h12-20020a170902f7cc00b001c604f8de9fsi10899107plw.631.2023.10.10.01.55.24
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 10 Oct 2023 01:55:24 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:1 as permitted sender)
client-ip=2620:137:e000::3:1;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:1 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by morse.vger.email (Postfix) with ESMTP id 3A46E826E34C;
Tue, 10 Oct 2023 01:55:22 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229641AbjJJIzA (ORCPT <rfc822;rua109.linux@gmail.com>
+ 20 others); Tue, 10 Oct 2023 04:55:00 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59736 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229476AbjJJIy7 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 10 Oct 2023 04:54:59 -0400
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E81C197;
Tue, 10 Oct 2023 01:54:57 -0700 (PDT)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26153C433C7;
Tue, 10 Oct 2023 08:54:54 +0000 (UTC)
From: Huacai Chen <chenhuacai@loongson.cn>
To: Paolo Bonzini <pbonzini@redhat.com>,
Huacai Chen <chenhuacai@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: kvm@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Huacai Chen <chenhuacai@loongson.cn>, stable@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: [PATCH] MIPS: KVM: Fix a build warning about variable set but not
used
Date: Tue, 10 Oct 2023 16:54:34 +0800
Message-Id: <20231010085434.2678144-1-chenhuacai@loongson.cn>
X-Mailer: git-send-email 2.39.3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]);
Tue, 10 Oct 2023 01:55:22 -0700 (PDT)
X-Spam-Level: **
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1779358105237936540
X-GMAIL-MSGID: 1779358105237936540
|
| Series |
MIPS: KVM: Fix a build warning about variable set but not used
|
|
Commit Message
Huacai Chen
Oct. 10, 2023, 8:54 a.m. UTC
After commit 411740f5422a ("KVM: MIPS/MMU: Implement KVM_CAP_SYNC_MMU")
old_pte is no longer used in kvm_mips_map_page(). So remove it to fix a
build warning about variable set but not used:
arch/mips/kvm/mmu.c: In function 'kvm_mips_map_page':
>> arch/mips/kvm/mmu.c:701:29: warning: variable 'old_pte' set but not used [-Wunused-but-set-variable]
701 | pte_t *ptep, entry, old_pte;
| ^~~~~~~
Cc: stable@vger.kernel.org
Fixes: 411740f5422a960 ("KVM: MIPS/MMU: Implement KVM_CAP_SYNC_MMU")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202310070530.aARZCSfh-lkp@intel.com/
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
---
arch/mips/kvm/mmu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Comments
On 10/10/23 10:54, Huacai Chen wrote: > After commit 411740f5422a ("KVM: MIPS/MMU: Implement KVM_CAP_SYNC_MMU") Date: Tue Dec 13 16:32:39 2016 +0000 7 years ago... Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > old_pte is no longer used in kvm_mips_map_page(). So remove it to fix a > build warning about variable set but not used: > > arch/mips/kvm/mmu.c: In function 'kvm_mips_map_page': >>> arch/mips/kvm/mmu.c:701:29: warning: variable 'old_pte' set but not used [-Wunused-but-set-variable] > 701 | pte_t *ptep, entry, old_pte; > | ^~~~~~~ > > Cc: stable@vger.kernel.org > Fixes: 411740f5422a960 ("KVM: MIPS/MMU: Implement KVM_CAP_SYNC_MMU") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202310070530.aARZCSfh-lkp@intel.com/ > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> > --- > arch/mips/kvm/mmu.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-)
On Tue, Oct 10, 2023 at 04:54:34PM +0800, Huacai Chen wrote: > After commit 411740f5422a ("KVM: MIPS/MMU: Implement KVM_CAP_SYNC_MMU") > old_pte is no longer used in kvm_mips_map_page(). So remove it to fix a > build warning about variable set but not used: > > arch/mips/kvm/mmu.c: In function 'kvm_mips_map_page': > >> arch/mips/kvm/mmu.c:701:29: warning: variable 'old_pte' set but not used [-Wunused-but-set-variable] > 701 | pte_t *ptep, entry, old_pte; > | ^~~~~~~ > > Cc: stable@vger.kernel.org > Fixes: 411740f5422a960 ("KVM: MIPS/MMU: Implement KVM_CAP_SYNC_MMU") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202310070530.aARZCSfh-lkp@intel.com/ > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> > --- > arch/mips/kvm/mmu.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/mips/kvm/mmu.c b/arch/mips/kvm/mmu.c > index e8c08988ed37..cc09fd23aae3 100644 > --- a/arch/mips/kvm/mmu.c > +++ b/arch/mips/kvm/mmu.c > @@ -592,7 +592,7 @@ static int kvm_mips_map_page(struct kvm_vcpu *vcpu, unsigned long gpa, > gfn_t gfn = gpa >> PAGE_SHIFT; > int srcu_idx, err; > kvm_pfn_t pfn; > - pte_t *ptep, entry, old_pte; > + pte_t *ptep, entry; > bool writeable; > unsigned long prot_bits; > unsigned long mmu_seq; > @@ -664,7 +664,6 @@ static int kvm_mips_map_page(struct kvm_vcpu *vcpu, unsigned long gpa, > entry = pfn_pte(pfn, __pgprot(prot_bits)); > > /* Write the PTE */ > - old_pte = *ptep; > set_pte(ptep, entry); > > err = 0; > -- > 2.39.3 applied to mips-next. Thomas.
diff --git a/arch/mips/kvm/mmu.c b/arch/mips/kvm/mmu.c index e8c08988ed37..cc09fd23aae3 100644 --- a/arch/mips/kvm/mmu.c +++ b/arch/mips/kvm/mmu.c @@ -592,7 +592,7 @@ static int kvm_mips_map_page(struct kvm_vcpu *vcpu, unsigned long gpa, gfn_t gfn = gpa >> PAGE_SHIFT; int srcu_idx, err; kvm_pfn_t pfn; - pte_t *ptep, entry, old_pte; + pte_t *ptep, entry; bool writeable; unsigned long prot_bits; unsigned long mmu_seq; @@ -664,7 +664,6 @@ static int kvm_mips_map_page(struct kvm_vcpu *vcpu, unsigned long gpa, entry = pfn_pte(pfn, __pgprot(prot_bits)); /* Write the PTE */ - old_pte = *ptep; set_pte(ptep, entry); err = 0;