| Message ID | 20231010113915.436591-1-tiwei.btw@antgroup.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp129864vqb;
Tue, 10 Oct 2023 04:40:00 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IE/NrnDzgxrprp7HzS1sZDXrTXW7YsOW7pPgiNrjdhej/rFk1dqJzb9mwc82Xn0tw5jddp5
X-Received: by 2002:a17:902:ee89:b0:1c1:f5a6:bdfa with SMTP id
a9-20020a170902ee8900b001c1f5a6bdfamr14783313pld.7.1696938000290;
Tue, 10 Oct 2023 04:40:00 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1696938000; cv=none;
d=google.com; s=arc-20160816;
b=GEPJXkgsD5FHnmS/fncfDqqWO2IEpu14+0sMgAULQL74/+pTrEP9VwXigeblN/oMCq
8XAHghJasw/RGeLUngzqIYd5h7j5WKWDNbvbJ47C0QGbkTx7RjHS1Nwbxbwz8+034nJb
vSKHV/Wv6EE4posDjd3BfjJrSI9ldAPbV3j0eWMeA3r1Qcs9VZvfPH5Fpgh4jdp9J1y5
YddHcr0E5Mf3iG+JmhQESPKaV/aW+GP/KZi2XT8ZoUMFzAqhmTnqTMeQyanH3hS7EfKk
JZzpWXyijq+MYeNo8hpvQaJVLisCK28ZIrml6JKHb2d/SO6TrP6qHCxNuqDDMF1Qsqoo
Ip2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from;
bh=Q1uNUR3p+bsLHCGpAyDRwIF8oWu4vkq7rZA5Irlgj0g=;
fh=QrXgtEsVDmYX4QejanPzJ9/o8dKPezZDJ5S+6jr0zAA=;
b=VLAiOFBtK0F3Lpu4QYa6+q/n57t37UATW7FJiMDOeoHVJisqrj9WybCRW3ZZtX5O1u
AHzYp1NlO5bpe6ummpnU/+GJSiPJNjXsrMbs2x6/ri9dEPRXTMCSPda6SJ61ZZ2q9YdU
O+Ph73JaBEGMg+MFxZmEurLK8BrcBnzN6DYFC86DPTkWkDicesyOvjPsALVcxTanuodQ
noZ0v2aLW36BMHzlVpZH5vcNxyLjx2/aJmaiWJ7laxzbHh6DBPfyCtEwwDQvhmuW9iqo
vlhIonm4IdzcnyNNiowKZVrsvsnp3YUJjHreXRKhbgRESQH+6Hf4BUNKWzwzJpjEldlj
ZSnA==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:8 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=antgroup.com
Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8])
by mx.google.com with ESMTPS id
x6-20020a170902a38600b001c9ad7c1f82si1831383pla.287.2023.10.10.04.39.59
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 10 Oct 2023 04:40:00 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:8 as permitted sender)
client-ip=2620:137:e000::3:8;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:8 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=antgroup.com
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by fry.vger.email (Postfix) with ESMTP id C5430836D938;
Tue, 10 Oct 2023 04:39:55 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231406AbjJJLjl (ORCPT <rfc822;rua109.linux@gmail.com>
+ 20 others); Tue, 10 Oct 2023 07:39:41 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34334 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229921AbjJJLjk (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 10 Oct 2023 07:39:40 -0400
Received: from out0-209.mail.aliyun.com (out0-209.mail.aliyun.com
[140.205.0.209])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FE2299;
Tue, 10 Oct 2023 04:39:38 -0700 (PDT)
X-Alimail-AntiSpam:
AC=PASS;BC=-1|-1;BR=01201311R261e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018047198;MF=tiwei.btw@antgroup.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---.UxYjvU3_1696937965;
Received: from ubuntu..(mailfrom:tiwei.btw@antgroup.com
fp:SMTPD_---.UxYjvU3_1696937965)
by smtp.aliyun-inc.com;
Tue, 10 Oct 2023 19:39:34 +0800
From: "Tiwei Bie" <tiwei.btw@antgroup.com>
To: linux-erofs@lists.ozlabs.org, xiang@kernel.org
Cc: <ayushranjan@google.com>, "Tiwei Bie" <tiwei.btw@antgroup.com>,
"Chao Yu" <chao@kernel.org>, "Yue Hu" <huyue2@coolpad.com>,
"Jeffle Xu" <jefflexu@linux.alibaba.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] erofs: fix inode metadata space layout description in
documentation
Date: Tue, 10 Oct 2023 19:39:15 +0800
Message-Id: <20231010113915.436591-1-tiwei.btw@antgroup.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,
UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]);
Tue, 10 Oct 2023 04:39:55 -0700 (PDT)
X-Spam-Level: **
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1779368460229052400
X-GMAIL-MSGID: 1779368460229052400
|
| Series |
erofs: fix inode metadata space layout description in documentation
|
|
Commit Message
Tiwei Bie
Oct. 10, 2023, 11:39 a.m. UTC
Xattrs, extents, data inline are _placed after_, not _followed by_ the
corresponding inode. This patch fixes it.
Fixes: fdb0536469cb ("staging: erofs: add document")
Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com>
---
Documentation/filesystems/erofs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 10/10/23 7:39 PM, Tiwei Bie wrote: > Xattrs, extents, data inline are _placed after_, not _followed by_ the > corresponding inode. This patch fixes it. > > Fixes: fdb0536469cb ("staging: erofs: add document") > Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com> > --- > Documentation/filesystems/erofs.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/filesystems/erofs.rst b/Documentation/filesystems/erofs.rst > index f200d7874495..57c6ae23b3fc 100644 > --- a/Documentation/filesystems/erofs.rst > +++ b/Documentation/filesystems/erofs.rst > @@ -199,7 +199,7 @@ may not. All metadatas can be now observed in two different spaces (views): > | | > |__________________| 64 bytes > > - Xattrs, extents, data inline are followed by the corresponding inode with > + Xattrs, extents, data inline are placed after the corresponding inode with > proper alignment, and they could be optional for different data mappings. > _currently_ total 5 data layouts are supported: > Thanks for catching it! Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
Hi Tiwei, On 2023/10/10 19:39, Tiwei Bie via Linux-erofs wrote: > Xattrs, extents, data inline are _placed after_, not _followed by_ the > corresponding inode. This patch fixes it Thanks for the patch and sorry about my terrible English... > > Fixes: fdb0536469cb ("staging: erofs: add document") I'm not sure if it's necessary to tag document fixes anyway since docs.kernel.org already uses the latest version and `.rst` format is adapted much later.. I will drop this tag for the next merge window if not urgent. > Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com> Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com> Thanks, Gao Xiang > --- > Documentation/filesystems/erofs.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/filesystems/erofs.rst b/Documentation/filesystems/erofs.rst > index f200d7874495..57c6ae23b3fc 100644 > --- a/Documentation/filesystems/erofs.rst > +++ b/Documentation/filesystems/erofs.rst > @@ -199,7 +199,7 @@ may not. All metadatas can be now observed in two different spaces (views): > | | > |__________________| 64 bytes > > - Xattrs, extents, data inline are followed by the corresponding inode with > + Xattrs, extents, data inline are placed after the corresponding inode with > proper alignment, and they could be optional for different data mappings. > _currently_ total 5 data layouts are supported: >
On 10/10/23 9:06 PM, Gao Xiang wrote: >> Fixes: fdb0536469cb ("staging: erofs: add document") > > I'm not sure if it's necessary to tag document fixes anyway > since docs.kernel.org already uses the latest version and > `.rst` format is adapted much later.. > > I will drop this tag for the next merge window if not urgent. Thanks! This patch is not urgent. :) Regards, Tiwei
On 2023/10/10 21:06, Gao Xiang wrote: >> Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com> > > Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com> Looks fine to me for the version in dev-test branch. Reviewed-by: Chao Yu <chao@kernel.org> Thanks,
Hi Chao, On 2023/10/12 09:10, Chao Yu wrote: > On 2023/10/10 21:06, Gao Xiang wrote: >>> Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com> >> >> Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com> > > Looks fine to me for the version in dev-test branch. > > Reviewed-by: Chao Yu <chao@kernel.org> Yeah, thanks! I will add the tag when applying to -next. Thanks, Gao Xiang > > Thanks,
diff --git a/Documentation/filesystems/erofs.rst b/Documentation/filesystems/erofs.rst index f200d7874495..57c6ae23b3fc 100644 --- a/Documentation/filesystems/erofs.rst +++ b/Documentation/filesystems/erofs.rst @@ -199,7 +199,7 @@ may not. All metadatas can be now observed in two different spaces (views): | | |__________________| 64 bytes - Xattrs, extents, data inline are followed by the corresponding inode with + Xattrs, extents, data inline are placed after the corresponding inode with proper alignment, and they could be optional for different data mappings. _currently_ total 5 data layouts are supported: