| Message ID | 20231009142005.21338-1-quic_kriskura@quicinc.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp1906133vqo;
Mon, 9 Oct 2023 07:22:29 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IFqnl7m8tA5qUuaP9JfgFQuNFyzpxv7m1BPdW7ycI1pMwMS8ByQgVH8lRoBrEEZIrqX4SJH
X-Received: by 2002:a05:6a20:1004:b0:14c:628b:4b98 with SMTP id
gs4-20020a056a20100400b0014c628b4b98mr12060271pzc.4.1696861349157;
Mon, 09 Oct 2023 07:22:29 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1696861349; cv=none;
d=google.com; s=arc-20160816;
b=xKutbvhtRm9OFAnWrFNXgWc049ryAmtNzDeK4QNRj0YIxXHVvfOU+6KWDEfjb5sqcO
PNoAWf6aPoOF92JP2vjme6nyVfT4rrpYlD+5biCuKyS+6gFT0C2zsEHGrlBKhT8wnXK8
+3pShNuWmBV8jpmsD4V1wt7VB5cnadlKq94/TKBXQ5hyhx+m6GY2K0+47gG13+Abwnu9
lRSiVJOC5l2Cj8li7AdbmgIfKG2ARxjyfrU/aFgvh62PJrmwuKBD5Jz5fK4RE2Nj57Lq
jJkoKzZQZ6WqRywsYAb8BCK3jjB1LISfRg9T2kpRlkOaeTgOQDkYbsRireOAIqMJSkoh
WKPg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=7qdfQioX1zXubJuPh0HpCefHEHuSrBYDOMSQ4QrcvWM=;
fh=KAe0ppu4BSZM6v7Ru5xHNSeDPts1++GtjDbOXikzDnM=;
b=KYLpl8jJeggEVTaeBp5DYWwjo4mJk4hoDQfObu3C1HBo3wk+ZYldZ3iVYzmdm4GdJ/
+T6douaHC+Ag1InhMyz+sJJ/QuNxSKiSNZOb4yYAnY3rYAUBFkX5XWXnxtQTlcb9fvya
9r54VEhUVYIAr1ylflsEV8d74RybLNBfWj9Aw5XqIUkgP1hlFMBj5KH34Ts2T4etsECu
Xfd82r8c+LpDR9J+KJOuArTIk3m+ehV9Al8AiZl1+x+pnycD6fXjscsKV8J34ldcoJst
2XR3p0D/chmmc9WcPy3kh+jY1Rw53+OEEUcqaTwrQK/hVXT/hdyjLpWINTv+t+e+WhlZ
bI8g==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=aerRDdPV;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.34 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com
Received: from howler.vger.email (howler.vger.email. [23.128.96.34])
by mx.google.com with ESMTPS id
u14-20020a170902e80e00b001c56ede4c97si7895473plg.239.2023.10.09.07.22.28
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 09 Oct 2023 07:22:29 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Authentication-Results: mx.google.com;
dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=aerRDdPV;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.34 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by howler.vger.email (Postfix) with ESMTP id 0434180934A4;
Mon, 9 Oct 2023 07:22:27 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S1377753AbjJIOV0 (ORCPT <rfc822;ezelljr.billy@gmail.com>
+ 18 others); Mon, 9 Oct 2023 10:21:26 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60474 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S1377705AbjJIOVJ (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 9 Oct 2023 10:21:09 -0400
Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com
[205.220.180.131])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 942E2D4D;
Mon, 9 Oct 2023 07:20:40 -0700 (PDT)
Received: from pps.filterd (m0279869.ppops.net [127.0.0.1])
by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
399DvUFo009578;
Mon, 9 Oct 2023 14:20:37 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com;
h=from : to : cc :
subject : date : message-id : mime-version : content-transfer-encoding :
content-type; s=qcppdkim1;
bh=7qdfQioX1zXubJuPh0HpCefHEHuSrBYDOMSQ4QrcvWM=;
b=aerRDdPVoitYbuaf7LeSir/QWWhVEh0vffpdXcP9vyqKzFp6EqGVV2Nkr+1s51p8WxP6
/8xj/SE1BR6usNYMhLuzs+/7DwW8O8JeaDfdV8XI9oXVyiinjc70C0h8Ervlf1yO+8Nb
3tH5fCqayL89020+0vvYSl2/kCxnfy7sIlfkX28qCYp7IHRCJe8+jky3fR+O0BOvPN4R
zvzVk6m5+O1uZNpNb8PrMRfe122ETlgMeDULd6OjhLwu+KO15HTimWamtKUZJppeW703
zNFkUD2dsSULhjn3M6lz8rMyQBe5HuJRqpWXBpSDrZh9lHJ69Oz4CTX/5wMPEHLK2FiP vg==
Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com
[129.46.96.20])
by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3tkhx2jjdq-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Mon, 09 Oct 2023 14:20:36 +0000
Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com
[10.47.209.196])
by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id
399EKLsx008053
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Mon, 9 Oct 2023 14:20:21 GMT
Received: from hu-kriskura-hyd.qualcomm.com (10.80.80.8) by
nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.2.1118.36; Mon, 9 Oct 2023 07:20:16 -0700
From: Krishna Kurapati <quic_kriskura@quicinc.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, =?utf-8?q?Maciej_=C5=BB?=
=?utf-8?q?enczykowski?= <maze@google.com>, onathan Corbet <corbet@lwn.net>,
Linyu Yuan <quic_linyyuan@quicinc.com>
CC: <linux-usb@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_ppratap@quicinc.com>,
<quic_wcheng@quicinc.com>, <quic_jackp@quicinc.com>,
Krishna Kurapati <quic_kriskura@quicinc.com>
Subject: [PATCH 1/2] Documentation: usb: Update NCM configfs parameters
Date: Mon, 9 Oct 2023 19:50:04 +0530
Message-ID: <20231009142005.21338-1-quic_kriskura@quicinc.com>
X-Mailer: git-send-email 2.42.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Originating-IP: [10.80.80.8]
X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To
nalasex01a.na.qualcomm.com (10.47.209.196)
X-QCInternal: smtphost
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800
signatures=585085
X-Proofpoint-GUID: Xx960gByasl8Il6ueXmcyg3i4O4ybp_X
X-Proofpoint-ORIG-GUID: Xx960gByasl8Il6ueXmcyg3i4O4ybp_X
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
definitions=2023-10-09_12,2023-10-09_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
suspectscore=0
impostorscore=0 malwarescore=0 mlxscore=0 lowpriorityscore=0 phishscore=0
bulkscore=0 adultscore=0 priorityscore=1501 spamscore=0 mlxlogscore=688
clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
engine=8.12.0-2309180000 definitions=main-2310090118
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]);
Mon, 09 Oct 2023 07:22:27 -0700 (PDT)
X-Spam-Level: **
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1779288086209903654
X-GMAIL-MSGID: 1779288086209903654
|
| Series |
[1/2] Documentation: usb: Update NCM configfs parameters
|
|
Commit Message
Krishna Kurapati
Oct. 9, 2023, 2:20 p.m. UTC
Updateed NCM configfs parameters by adding max_segment_size
property and describing its effect on MTU configuration of
NCM interface.
Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
---
Documentation/usb/gadget-testing.rst | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)
Comments
On Mon, Oct 09, 2023 at 07:50:04PM +0530, Krishna Kurapati wrote: > Updateed NCM configfs parameters by adding max_segment_size > property and describing its effect on MTU configuration of > NCM interface. "Updated"? > > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > --- > Documentation/usb/gadget-testing.rst | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/Documentation/usb/gadget-testing.rst b/Documentation/usb/gadget-testing.rst > index 29072c166d23..6e5d96668e8e 100644 > --- a/Documentation/usb/gadget-testing.rst > +++ b/Documentation/usb/gadget-testing.rst > @@ -448,15 +448,17 @@ Function-specific configfs interface > The function name to use when creating the function directory is "ncm". > The NCM function provides these attributes in its function directory: > > - =============== ================================================== > - ifname network device interface name associated with this > - function instance > - qmult queue length multiplier for high and super speed > - host_addr MAC address of host's end of this > - Ethernet over USB link > - dev_addr MAC address of device's end of this > - Ethernet over USB link > - =============== ================================================== > + ================= ==================================================== > + ifname network device interface name associated with this > + function instance > + qmult queue length multiplier for high and super speed > + host_addr MAC address of host's end of this > + Ethernet over USB link > + dev_addr MAC address of device's end of this > + Ethernet over USB link > + max_segment_size Segment size required for P2P connections. This > + will inturn set MTU to (max_segment_size - 14 bytes) "inturn"??? > + ================= ==================================================== > What commit id does this fix? thanks, greg k-h
On 10/9/2023 8:35 PM, Greg Kroah-Hartman wrote: > On Mon, Oct 09, 2023 at 07:50:04PM +0530, Krishna Kurapati wrote: >> Updateed NCM configfs parameters by adding max_segment_size >> property and describing its effect on MTU configuration of >> NCM interface. > > "Updated"? My bad. Will fix it in v2. > >> >> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> >> --- >> Documentation/usb/gadget-testing.rst | 20 +++++++++++--------- >> 1 file changed, 11 insertions(+), 9 deletions(-) >> >> diff --git a/Documentation/usb/gadget-testing.rst b/Documentation/usb/gadget-testing.rst >> index 29072c166d23..6e5d96668e8e 100644 >> --- a/Documentation/usb/gadget-testing.rst >> +++ b/Documentation/usb/gadget-testing.rst >> @@ -448,15 +448,17 @@ Function-specific configfs interface >> The function name to use when creating the function directory is "ncm". >> The NCM function provides these attributes in its function directory: >> >> - =============== ================================================== >> - ifname network device interface name associated with this >> - function instance >> - qmult queue length multiplier for high and super speed >> - host_addr MAC address of host's end of this >> - Ethernet over USB link >> - dev_addr MAC address of device's end of this >> - Ethernet over USB link >> - =============== ================================================== >> + ================= ==================================================== >> + ifname network device interface name associated with this >> + function instance >> + qmult queue length multiplier for high and super speed >> + host_addr MAC address of host's end of this >> + Ethernet over USB link >> + dev_addr MAC address of device's end of this >> + Ethernet over USB link >> + max_segment_size Segment size required for P2P connections. This >> + will inturn set MTU to (max_segment_size - 14 bytes) > > "inturn"??? > >> + ================= ==================================================== >> > > What commit id does this fix? > This is not a bug fix. It is just an addition of a new property. Does it need a fixes tag ? Regards, Krishna,
On Mon, Oct 09, 2023 at 08:40:27PM +0530, Krishna Kurapati PSSNV wrote: > > > On 10/9/2023 8:35 PM, Greg Kroah-Hartman wrote: > > On Mon, Oct 09, 2023 at 07:50:04PM +0530, Krishna Kurapati wrote: > > > Updateed NCM configfs parameters by adding max_segment_size > > > property and describing its effect on MTU configuration of > > > NCM interface. > > > > "Updated"? > > My bad. Will fix it in v2. > > > > > > > > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > > > --- > > > Documentation/usb/gadget-testing.rst | 20 +++++++++++--------- > > > 1 file changed, 11 insertions(+), 9 deletions(-) > > > > > > diff --git a/Documentation/usb/gadget-testing.rst b/Documentation/usb/gadget-testing.rst > > > index 29072c166d23..6e5d96668e8e 100644 > > > --- a/Documentation/usb/gadget-testing.rst > > > +++ b/Documentation/usb/gadget-testing.rst > > > @@ -448,15 +448,17 @@ Function-specific configfs interface > > > The function name to use when creating the function directory is "ncm". > > > The NCM function provides these attributes in its function directory: > > > - =============== ================================================== > > > - ifname network device interface name associated with this > > > - function instance > > > - qmult queue length multiplier for high and super speed > > > - host_addr MAC address of host's end of this > > > - Ethernet over USB link > > > - dev_addr MAC address of device's end of this > > > - Ethernet over USB link > > > - =============== ================================================== > > > + ================= ==================================================== > > > + ifname network device interface name associated with this > > > + function instance > > > + qmult queue length multiplier for high and super speed > > > + host_addr MAC address of host's end of this > > > + Ethernet over USB link > > > + dev_addr MAC address of device's end of this > > > + Ethernet over USB link > > > + max_segment_size Segment size required for P2P connections. This > > > + will inturn set MTU to (max_segment_size - 14 bytes) > > > > "inturn"??? > > > > > + ================= ==================================================== > > > > What commit id does this fix? > > > This is not a bug fix. It is just an addition of a new property. Does it > need a fixes tag ? Where is the code for the new property? Ah, it's in patch 2/2, that wasn't obvious, sorry. Why is this a separate patch at all, shouldn't be part of the commit that adds the new property to the system? thanks, greg k-h
On 10/9/2023 8:51 PM, Greg Kroah-Hartman wrote: >>>> diff --git a/Documentation/usb/gadget-testing.rst b/Documentation/usb/gadget-testing.rst >>>> index 29072c166d23..6e5d96668e8e 100644 >>>> --- a/Documentation/usb/gadget-testing.rst >>>> +++ b/Documentation/usb/gadget-testing.rst >>>> @@ -448,15 +448,17 @@ Function-specific configfs interface >>>> The function name to use when creating the function directory is "ncm". >>>> The NCM function provides these attributes in its function directory: >>>> - =============== ================================================== >>>> - ifname network device interface name associated with this >>>> - function instance >>>> - qmult queue length multiplier for high and super speed >>>> - host_addr MAC address of host's end of this >>>> - Ethernet over USB link >>>> - dev_addr MAC address of device's end of this >>>> - Ethernet over USB link >>>> - =============== ================================================== >>>> + ================= ==================================================== >>>> + ifname network device interface name associated with this >>>> + function instance >>>> + qmult queue length multiplier for high and super speed >>>> + host_addr MAC address of host's end of this >>>> + Ethernet over USB link >>>> + dev_addr MAC address of device's end of this >>>> + Ethernet over USB link >>>> + max_segment_size Segment size required for P2P connections. This >>>> + will inturn set MTU to (max_segment_size - 14 bytes) >>> >>> "inturn"??? >>> >>>> + ================= ==================================================== >>> >>> What commit id does this fix? >>> >> This is not a bug fix. It is just an addition of a new property. Does it >> need a fixes tag ? > > Where is the code for the new property? > > Ah, it's in patch 2/2, that wasn't obvious, sorry. Why is this a > separate patch at all, shouldn't be part of the commit that adds the new > property to the system? > Sorry. I followed the practice of splitting patches like we usually do. Will club them up in a single patch in v2. Thanks for pointing this mistake. Regards, Krishna,
On Mon, Oct 09, 2023 at 09:03:41PM +0530, Krishna Kurapati PSSNV wrote: > > > On 10/9/2023 8:51 PM, Greg Kroah-Hartman wrote: > > > > > > diff --git a/Documentation/usb/gadget-testing.rst b/Documentation/usb/gadget-testing.rst > > > > > index 29072c166d23..6e5d96668e8e 100644 > > > > > --- a/Documentation/usb/gadget-testing.rst > > > > > +++ b/Documentation/usb/gadget-testing.rst > > > > > @@ -448,15 +448,17 @@ Function-specific configfs interface > > > > > The function name to use when creating the function directory is "ncm". > > > > > The NCM function provides these attributes in its function directory: > > > > > - =============== ================================================== > > > > > - ifname network device interface name associated with this > > > > > - function instance > > > > > - qmult queue length multiplier for high and super speed > > > > > - host_addr MAC address of host's end of this > > > > > - Ethernet over USB link > > > > > - dev_addr MAC address of device's end of this > > > > > - Ethernet over USB link > > > > > - =============== ================================================== > > > > > + ================= ==================================================== > > > > > + ifname network device interface name associated with this > > > > > + function instance > > > > > + qmult queue length multiplier for high and super speed > > > > > + host_addr MAC address of host's end of this > > > > > + Ethernet over USB link > > > > > + dev_addr MAC address of device's end of this > > > > > + Ethernet over USB link > > > > > + max_segment_size Segment size required for P2P connections. This > > > > > + will inturn set MTU to (max_segment_size - 14 bytes) > > > > > > > > "inturn"??? > > > > > > > > > + ================= ==================================================== > > > > > > > > What commit id does this fix? > > > > > > > This is not a bug fix. It is just an addition of a new property. Does it > > > need a fixes tag ? > > > > Where is the code for the new property? > > > > Ah, it's in patch 2/2, that wasn't obvious, sorry. Why is this a > > separate patch at all, shouldn't be part of the commit that adds the new > > property to the system? > > > > Sorry. I followed the practice of splitting patches like we usually do. Will > club them up in a single patch in v2. Thanks for pointing this mistake. Splitting is fine, but don't ask us to review documentation before the feature is even presented, that's reading backwards :)
diff --git a/Documentation/usb/gadget-testing.rst b/Documentation/usb/gadget-testing.rst index 29072c166d23..6e5d96668e8e 100644 --- a/Documentation/usb/gadget-testing.rst +++ b/Documentation/usb/gadget-testing.rst @@ -448,15 +448,17 @@ Function-specific configfs interface The function name to use when creating the function directory is "ncm". The NCM function provides these attributes in its function directory: - =============== ================================================== - ifname network device interface name associated with this - function instance - qmult queue length multiplier for high and super speed - host_addr MAC address of host's end of this - Ethernet over USB link - dev_addr MAC address of device's end of this - Ethernet over USB link - =============== ================================================== + ================= ==================================================== + ifname network device interface name associated with this + function instance + qmult queue length multiplier for high and super speed + host_addr MAC address of host's end of this + Ethernet over USB link + dev_addr MAC address of device's end of this + Ethernet over USB link + max_segment_size Segment size required for P2P connections. This + will inturn set MTU to (max_segment_size - 14 bytes) + ================= ==================================================== and after creating the functions/ncm.<instance name> they contain default values: qmult is 5, dev_addr and host_addr are randomly selected.