Message ID | 20231006164206.40710-2-quic_nkela@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp459196vqo; Fri, 6 Oct 2023 09:44:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHpEXFaKD+4cQpyrzyHmgB52b7QNtC71lK4xwps8f69ZFAWVO5NpfDkQZBgVP50SSrFyH6B X-Received: by 2002:a17:902:d511:b0:1c3:a2ea:64cb with SMTP id b17-20020a170902d51100b001c3a2ea64cbmr9629247plg.53.1696610641334; Fri, 06 Oct 2023 09:44:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696610641; cv=none; d=google.com; s=arc-20160816; b=NgT8Wb7uaQewhgiVpP+wcjyDsRjY7zwubL+rum4H01ADDDtyHMDsVHtRSoFJcxXiUY z5XDNy1z4E2UtgoGWB/qrFL95TXIuZvtabcsLcFXHx3s9iGkcE90ThWqKSM1mKyOjMZL f6X5+XNdTuP8BrlkJUo75EydOBdWy9H3kyRULJa9unX16efgsOj9BftWm5+WEKlzdgWL g57Ftv5flEtJkuSqHUKWMddZK8GSb+tyqyLmMPBxtmJ07Yu13fCzA11CII2wQ+YRmpHn HdIgnjrYY1djo03B2Ardt9Ls6xzsPlIK3aofVMqkQx9+Yh5gy84ug3AiATDiu523Dh/n 9Diw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=zCCGhIpTDZhz1bEO7bTAKC9aS5dTwZn/ILC7u8P+kCE=; fh=GEq5dEC3I2ew8qX2rLc4VZLR0KApgkJja2wJiy1iHxw=; b=Mj9nofPa/NAGMc0jCFQ8oDus5wV/tS9Id1o3c8WEWjYM42Z/HBkD3PxyiyV2/Fexto OhLuJ2g+5m5OiF/KkPvDRxIJmVV5CqMQPpXHqvYMuEakgdDFDaA7ZEhe0pwyRQqTF9WL TrLcpZdpwaJQpaCd+OYQWlLexcg0JtkEGHzmPdZfLtJoslGSTlV9ERzjh/caJkrpYio7 c6i7tf4KVAUIs+uEwdAm+jnV7uXpu+SPrGTcEaPvvnmtxXoUoNJxStzvkVexbdB7SLeD +KjQG6Bqc/W7tdwcLuf/MMc83OEbXJfuBOi9d4+dkiMuatyElPVDPDFV6oBx/3xxtVkZ HdNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=JSSgzwRk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id kp14-20020a170903280e00b001c35cccca33si3724556plb.448.2023.10.06.09.44.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 09:44:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=JSSgzwRk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 6B9C381E5928; Fri, 6 Oct 2023 09:44:00 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233118AbjJFQnp (ORCPT <rfc822;ezelljr.billy@gmail.com> + 18 others); Fri, 6 Oct 2023 12:43:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233062AbjJFQna (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 6 Oct 2023 12:43:30 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0716718D; Fri, 6 Oct 2023 09:42:45 -0700 (PDT) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 396BNode025360; Fri, 6 Oct 2023 16:42:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=zCCGhIpTDZhz1bEO7bTAKC9aS5dTwZn/ILC7u8P+kCE=; b=JSSgzwRkxS5tm+rEqfOzf/6fxFDdhVHIkSGv4gVvWIwyQMi6XR4SZ6nyEv7toK45RoPT ww0x3Aq47J8mmC3MpVd0usWKv5ri3YvePSFkjOQICktzTOchgTnI/HzBygGA3+7tve4U wzaCwt9KgBCgYL9gu0Pn+PrPyNX01OhAWeqiGgkj0x1TuvTTaBgY80YwzWhERJc4duhV XjJkSYGzH67igGdtj3l0MsBjkepiFNHEL9OvoUPCIUCXyUAO6I13/ctpXm76SCSr++du 1MirbJOCWrKwLw3RNqhZZdWF29o3rzuTnL+QprFmHtWdI4cTT9FzfzevIRGn7tDypI96 6A== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3thg7hvmq1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Oct 2023 16:42:24 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 396GgNFs014675 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 6 Oct 2023 16:42:23 GMT Received: from car-linux11.qualcomm.com (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Fri, 6 Oct 2023 09:42:22 -0700 From: Nikunj Kela <quic_nkela@quicinc.com> To: <sudeep.holla@arm.com> CC: <cristian.marussi@arm.com>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>, <andersson@kernel.org>, <konrad.dybcio@linaro.org>, <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>, Nikunj Kela <quic_nkela@quicinc.com> Subject: [PATCH v5 1/2] dt-bindings: arm: Add new compatible for smc/hvc transport for SCMI Date: Fri, 6 Oct 2023 09:42:05 -0700 Message-ID: <20231006164206.40710-2-quic_nkela@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20231006164206.40710-1-quic_nkela@quicinc.com> References: <20230718160833.36397-1-quic_nkela@quicinc.com> <20231006164206.40710-1-quic_nkela@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: r3Xfyhoi75f8sxv1b4osIqDuseWfkn2R X-Proofpoint-ORIG-GUID: r3Xfyhoi75f8sxv1b4osIqDuseWfkn2R X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-06_12,2023-10-06_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 priorityscore=1501 mlxscore=0 suspectscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310060125 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 06 Oct 2023 09:44:00 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778730781702430481 X-GMAIL-MSGID: 1779025199565314642 |
Series |
Add qcom smc/hvc transport support
|
|
Commit Message
Nikunj Kela
Oct. 6, 2023, 4:42 p.m. UTC
Introduce compatible "qcom,scmi-smc" for SCMI smc/hvc transport channel for
Qualcomm virtual platforms.
This compatible mandates populating an additional parameter 'capability-id'
from the last 8 bytes of the shmem channel.
Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com>
---
Documentation/devicetree/bindings/firmware/arm,scmi.yaml | 4 ++++
1 file changed, 4 insertions(+)
Comments
On Fri, Oct 06, 2023 at 09:42:05AM -0700, Nikunj Kela wrote: > Introduce compatible "qcom,scmi-smc" for SCMI smc/hvc transport channel for > Qualcomm virtual platforms. > > This compatible mandates populating an additional parameter 'capability-id' > from the last 8 bytes of the shmem channel. > > Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com> Reviewed-by: Brian Masney <bmasney@redhat.com>
On Fri, Oct 06, 2023 at 09:42:05AM -0700, Nikunj Kela wrote: > Introduce compatible "qcom,scmi-smc" for SCMI smc/hvc transport channel for > Qualcomm virtual platforms. > > This compatible mandates populating an additional parameter 'capability-id' > from the last 8 bytes of the shmem channel. > While I am happy with the simplification here, I am also bit nervous how long before Qualcomm abandons this. I hope this is adopted as is in all internal and downstream code without any modifications and this is not just a push for upstreaming some change to minimise delta with internal/ downstream code. -- Regards, Sudeep
On 10/9/2023 7:41 AM, Sudeep Holla wrote: > On Fri, Oct 06, 2023 at 09:42:05AM -0700, Nikunj Kela wrote: >> Introduce compatible "qcom,scmi-smc" for SCMI smc/hvc transport channel for >> Qualcomm virtual platforms. >> >> This compatible mandates populating an additional parameter 'capability-id' >> from the last 8 bytes of the shmem channel. >> > While I am happy with the simplification here, I am also bit nervous how > long before Qualcomm abandons this. I hope this is adopted as is in all > internal and downstream code without any modifications and this is not > just a push for upstreaming some change to minimise delta with internal/ > downstream code. > > -- > Regards, > Sudeep Qualcomm is using patch on all the virtual auto platforms using shmem/doorbell as scmi channel. This is already being used without any modifications in our downstream code. No delta for this patch series. Thanks!
On 10/9/23 16:52, Nikunj Kela wrote: > > On 10/9/2023 7:41 AM, Sudeep Holla wrote: >> On Fri, Oct 06, 2023 at 09:42:05AM -0700, Nikunj Kela wrote: >>> Introduce compatible "qcom,scmi-smc" for SCMI smc/hvc transport >>> channel for >>> Qualcomm virtual platforms. >>> >>> This compatible mandates populating an additional parameter >>> 'capability-id' >>> from the last 8 bytes of the shmem channel. >>> >> While I am happy with the simplification here, I am also bit nervous how >> long before Qualcomm abandons this. I hope this is adopted as is in all >> internal and downstream code without any modifications and this is not >> just a push for upstreaming some change to minimise delta with internal/ >> downstream code. >> >> -- >> Regards, >> Sudeep > > Qualcomm is using patch on all the virtual auto platforms using > shmem/doorbell as scmi channel. This is already being used without any > modifications in our downstream code. No delta for this patch series. > Thanks! AFAICT Sudeep is looking for a solid guarantee that it will continue to be used as-is, on more than one platform and on more than one BSP version. There have been cases where such firmware interfaces had silent ABI breaks (or were replaced altogether) between qc downstream branches and this would be unacceptable. Understandably, having a unified means of communication for *all* Qualcomm chips (i.e. not only auto) going forward would likely be expected.. Konrad
diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml index 563a87dfb31a..4591523b51a0 100644 --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml @@ -38,6 +38,9 @@ properties: with shmem address(4KB-page, offset) as parameters items: - const: arm,scmi-smc-param + - description: SCMI compliant firmware with Qualcomm SMC/HVC transport + items: + - const: qcom,scmi-smc - description: SCMI compliant firmware with SCMI Virtio transport. The virtio transport only supports a single device. items: @@ -313,6 +316,7 @@ else: enum: - arm,scmi-smc - arm,scmi-smc-param + - qcom,scmi-smc then: required: - arm,smc-id