diff mbox series

[09/11] MIPS: mobileye: Add EPM5 device tree

Message ID 20231004161038.2818327-10-gregory.clement@bootlin.com
State New
Headers
Series Add support for the Mobileye EyeQ5 SoC |

Commit Message

Gregory CLEMENT Oct. 4, 2023, 4:10 p.m. UTC 
  Add a device tree for the Mobileye EPM5 evaluation board.

Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
---
 arch/mips/boot/dts/mobileye/Makefile       |  2 ++
 arch/mips/boot/dts/mobileye/eyeq5-epm5.dts | 24 ++++++++++++++++++++++
 2 files changed, 26 insertions(+)
 create mode 100644 arch/mips/boot/dts/mobileye/eyeq5-epm5.dts

Comments

Arnd Bergmann Oct. 6, 2023, 11:18 a.m. UTC | #1 
On Wed, Oct 4, 2023, at 18:10, Gregory CLEMENT wrote:
> +
> +	chosen {
> +		bootargs = "cca=5 earlycon console=ttyAMA2 ddr32_alias=0x40000000";
> +		stdout-path = "serial2:115200n8";
> +	};
> +

The bootargs should not be needed here, at least most of them:

- no need to set both console= and the stdout-path if you have
  earlycon support

- ddr32_alias=0x40000000 sounds like something that should be
  part of the dtb elsewhere and not require a command line argument.
  I assume this is needed to even build?

- For cca=, it looks like this is intended to be autodetected from
  the c0_config register. Does that not work for you for some reason?

     Arnd
Gregory CLEMENT Oct. 9, 2023, 2:51 p.m. UTC | #2 
"Arnd Bergmann" <arnd@arndb.de> writes:

> On Wed, Oct 4, 2023, at 18:10, Gregory CLEMENT wrote:
>> +
>> +	chosen {
>> +		bootargs = "cca=5 earlycon console=ttyAMA2 ddr32_alias=0x40000000";
>> +		stdout-path = "serial2:115200n8";
>> +	};
>> +
>
> The bootargs should not be needed here, at least most of them:
>
> - no need to set both console= and the stdout-path if you have
>   earlycon support

OK I keep stdout-path.

>
> - ddr32_alias=0x40000000 sounds like something that should be
>   part of the dtb elsewhere and not require a command line argument.
>   I assume this is needed to even build?

I will answer on the other email but in short I agree.
>
> - For cca=, it looks like this is intended to be autodetected from
>   the c0_config register. Does that not work for you for some reason?

Indeed I checked and it it nost needed anymore, it is already set in
cps_smp_setup. I remove it.

Thanks,

Gregory

>
>      Arnd
diff mbox series

Patch

diff --git a/arch/mips/boot/dts/mobileye/Makefile b/arch/mips/boot/dts/mobileye/Makefile
index 99c4124fd4c0..539b2e1f4e07 100644
--- a/arch/mips/boot/dts/mobileye/Makefile
+++ b/arch/mips/boot/dts/mobileye/Makefile
@@ -1,4 +1,6 @@ 
 # SPDX-License-Identifier: GPL-2.0-only
 # Copyright 2023 Mobileye Vision Technologies Ltd.
 
+dtb-$(CONFIG_SOC_EYEQ5)		+= eyeq5-epm5.dtb
+
 obj-$(CONFIG_BUILTIN_DTB)	+= $(addsuffix .o, $(dtb-y))
diff --git a/arch/mips/boot/dts/mobileye/eyeq5-epm5.dts b/arch/mips/boot/dts/mobileye/eyeq5-epm5.dts
new file mode 100644
index 000000000000..ca03115a2858
--- /dev/null
+++ b/arch/mips/boot/dts/mobileye/eyeq5-epm5.dts
@@ -0,0 +1,24 @@ 
+// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+/*
+ * Copyright 2023 Mobileye Vision Technologies Ltd.
+ */
+
+/dts-v1/;
+
+#include "eyeq5.dtsi"
+
+/ {
+	compatible = "mobileye,eyeq5-epm5", "mobileye,eyeq5";
+	model = "Mobile EyeQ5 MP5 Evaluation board";
+
+	chosen {
+		bootargs = "cca=5 earlycon console=ttyAMA2 ddr32_alias=0x40000000";
+		stdout-path = "serial2:115200n8";
+	};
+
+	memory@0 {
+		device_type = "memory";
+		reg = <0x8 0x00000000 0x0 0x80000000>;
+	};
+};
+