diff mbox series

rust: fix bindgen build error with fstrict-flex-arrays

Message ID 20230815065346.131387-1-andrea.righi@canonical.com
State New
Headers
Series rust: fix bindgen build error with fstrict-flex-arrays |

Commit Message

Andrea Righi Aug. 15, 2023, 6:53 a.m. UTC 
  Commit df8fc4e934c1 ("kbuild: Enable -fstrict-flex-arrays=3") enabled
'-fstrict-flex-arrays=3' globally, but bindgen does not recognized this
compiler option, triggering the following build error:

 error: unknown argument: '-fstrict-flex-arrays=3', err: true

Add '-fstrict-flex-arrays' to the list of cflags that should be ignored
by bindgen.

Fixes: df8fc4e934c1 ("kbuild: Enable -fstrict-flex-arrays=3")
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
---
 rust/Makefile | 1 +
 1 file changed, 1 insertion(+)

Comments

Gary Guo Sept. 23, 2023, 3:43 a.m. UTC | #1 
On Tue, 15 Aug 2023 08:53:46 +0200
Andrea Righi <andrea.righi@canonical.com> wrote:

> Commit df8fc4e934c1 ("kbuild: Enable -fstrict-flex-arrays=3") enabled
> '-fstrict-flex-arrays=3' globally, but bindgen does not recognized this
> compiler option, triggering the following build error:
> 
>  error: unknown argument: '-fstrict-flex-arrays=3', err: true
> 
> Add '-fstrict-flex-arrays' to the list of cflags that should be ignored
> by bindgen.
> 
> Fixes: df8fc4e934c1 ("kbuild: Enable -fstrict-flex-arrays=3")
> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>

Tested-by: Gary Guo <gary@garyguo.net>

> ---
>  rust/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/rust/Makefile b/rust/Makefile
> index 4124bfa01798..ae2f5421da25 100644
> --- a/rust/Makefile
> +++ b/rust/Makefile
> @@ -258,6 +258,7 @@ bindgen_skip_c_flags := -mno-fp-ret-in-387 -mpreferred-stack-boundary=% \
>  	-fno-reorder-blocks -fno-allow-store-data-races -fasan-shadow-offset=% \
>  	-fzero-call-used-regs=% -fno-stack-clash-protection \
>  	-fno-inline-functions-called-once -fsanitize=bounds-strict \
> +	-fstrict-flex-arrays=% \
>  	--param=% --param asan-%
>  
>  # Derived from `scripts/Makefile.clang`.
Miguel Ojeda Oct. 8, 2023, 7:59 p.m. UTC | #2 
On Tue, Aug 15, 2023 at 8:54 AM Andrea Righi <andrea.righi@canonical.com> wrote:
>
> Commit df8fc4e934c1 ("kbuild: Enable -fstrict-flex-arrays=3") enabled
> '-fstrict-flex-arrays=3' globally, but bindgen does not recognized this
> compiler option, triggering the following build error:
>
>  error: unknown argument: '-fstrict-flex-arrays=3', err: true
>
> Add '-fstrict-flex-arrays' to the list of cflags that should be ignored
> by bindgen.
>
> Fixes: df8fc4e934c1 ("kbuild: Enable -fstrict-flex-arrays=3")
> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>

Applied to `rust-fixes` (with an extra summary of the discussion in
the list), thanks everyone!

Cheers,
Miguel
diff mbox series

Patch

diff --git a/rust/Makefile b/rust/Makefile
index 4124bfa01798..ae2f5421da25 100644
--- a/rust/Makefile
+++ b/rust/Makefile
@@ -258,6 +258,7 @@  bindgen_skip_c_flags := -mno-fp-ret-in-387 -mpreferred-stack-boundary=% \
 	-fno-reorder-blocks -fno-allow-store-data-races -fasan-shadow-offset=% \
 	-fzero-call-used-regs=% -fno-stack-clash-protection \
 	-fno-inline-functions-called-once -fsanitize=bounds-strict \
+	-fstrict-flex-arrays=% \
 	--param=% --param asan-%
 
 # Derived from `scripts/Makefile.clang`.