Message ID | 20231007102528.1544295-1-dongtai.guo@linux.dev |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp849118vqo; Sat, 7 Oct 2023 03:24:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFOe0c+TA36j+SN+0Y7NwUQdCuZAuUs2rlGiOpuc3z7Sc7FS8F8mzOdQEXzCKlOzET3mxxM X-Received: by 2002:a17:902:db0d:b0:1c7:61a1:9688 with SMTP id m13-20020a170902db0d00b001c761a19688mr13047000plx.7.1696674263002; Sat, 07 Oct 2023 03:24:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696674262; cv=none; d=google.com; s=arc-20160816; b=GJ020pofL1K4pq3z+f23iA9FCDsrBGn/4eww1v0HI5SmnVf05QzWrgNcwqsmG4qQO9 OeTOvnl4CjA84GrZSgzMlFdyUFKbgGU1SjFL0vBrfL5ajTZ3/uhEQoBKDjksL+M6YiV/ eNJ3FO1J6/xUhiOFY2Rdq+7wMSXxXWBXurQBoqX6AXfeG4+attRngkMLVDuLzwPmMyUc mVOUBlJD3prMHAFJYzrpF32t0e+CCc93EoxTvHfXi2hNChIiSSLxxciu+2Vu3xxzqKg9 +TknqYQh4gJmLRl/FdP2SadN9kJwsJEJgk131VNCiAQ/b7Z8Dak0WN8KhKwMHQ/QK5Fg 4Gsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=rPXmlx1ESs+dS6YD/9BfFLmuB90hUrMhRVQrlDgcFxo=; fh=RNRy5VIsiekbSaNFOSQUmooEHSAjaEAuZKl0K+C4C4E=; b=gfHAWCkJNtg9eATNc4IB/Wc8F9X6rse4BF+yIt+7w9LgK8t8MpdpnabhNaB0IF9i3U STAkDNTCijjSOw+cvawf+TVzOsE8ZpcjDuqVoLDSsvCQLYJKISThKqUbyTTaeoiLky4/ or1tNkOWsjKSFz+rcR712pk5v6xWcjIqcp1giTnDTjalN7rWjO70MxKfZTmnv/isXUvf zm8CTUPblc7bGioAjITDrsyWpsaQOY9l5FDrJQ4AtAKAz7EAland/8RUXB07r0+OleBH NxmyqV+KlCrscH0Cwfz0rSS8rlKd4EXvVVTJYIqcAJqHGVxswIDWf2nYDtcaLDP1d1zJ ZlhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b="rQwpQ/o3"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id v19-20020a170902ca9300b001b7ea20dbf2si5164716pld.224.2023.10.07.03.24.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Oct 2023 03:24:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b="rQwpQ/o3"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 43C1480F6964; Sat, 7 Oct 2023 03:24:21 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343822AbjJGKYK (ORCPT <rfc822;ezelljr.billy@gmail.com> + 18 others); Sat, 7 Oct 2023 06:24:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343815AbjJGKYI (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 7 Oct 2023 06:24:08 -0400 X-Greylist: delayed 3712 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sat, 07 Oct 2023 03:24:06 PDT Received: from out-192.mta0.migadu.com (out-192.mta0.migadu.com [91.218.175.192]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01C7593 for <linux-kernel@vger.kernel.org>; Sat, 7 Oct 2023 03:24:05 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1696674243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=rPXmlx1ESs+dS6YD/9BfFLmuB90hUrMhRVQrlDgcFxo=; b=rQwpQ/o3/wo43UAIV2jM2gbs6AiRkfgePBhdei1ZexKfWs5D7Pg4t9JODHoKsFfPi9zz52 Ibd7lVPXrP8NXymUpg0BXxha1Wht/HtwirHfkbagcpHbVKiuenJw+yjLQEQAtzj6TtnXKm 2G9cQ+AOKikkHu2GpX6dcmI27D03NBY= From: George Guo <dongtai.guo@linux.dev> To: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, George Guo <guodongtai@kylinos.cn> Subject: [PATCH] netfilter: remove inaccurate code comments from struct nft_table Date: Sat, 7 Oct 2023 18:25:28 +0800 Message-Id: <20231007102528.1544295-1-dongtai.guo@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sat, 07 Oct 2023 03:24:21 -0700 (PDT) X-Spam-Level: ** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779091911538239908 X-GMAIL-MSGID: 1779091911538239908 |
Series |
netfilter: remove inaccurate code comments from struct nft_table
|
|
Commit Message
George Guo
Oct. 7, 2023, 10:25 a.m. UTC
From: George Guo <guodongtai@kylinos.cn> afinfo is no longer a member of struct nft_table, so remove the comment for it. Signed-off-by: George Guo <guodongtai@kylinos.cn> --- include/net/netfilter/nf_tables.h | 1 - 1 file changed, 1 deletion(-)
Comments
George Guo <dongtai.guo@linux.dev> wrote: > From: George Guo <guodongtai@kylinos.cn> > > afinfo is no longer a member of struct nft_table, so remove the comment > for it. Correct, but could you please send a v2 that fixes up all the comments and gets them back in sync with the structure? Eg. nlpid, family, udlen and udata exist in struct but are not mentioned in the comments.
diff --git a/include/net/netfilter/nf_tables.h b/include/net/netfilter/nf_tables.h index dd40c75011d2..acbb18c212e9 100644 --- a/include/net/netfilter/nf_tables.h +++ b/include/net/netfilter/nf_tables.h @@ -1200,7 +1200,6 @@ static inline void nft_use_inc_restore(u32 *use) * @use: number of chain references to this table * @flags: table flag (see enum nft_table_flags) * @genmask: generation mask - * @afinfo: address family info * @name: name of the table * @validate_state: internal, set when transaction adds jumps */