diff mbox series

[v1,1/1] pinctrl: denverton: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE()

Message ID 20231005135945.3672438-1-andriy.shevchenko@linux.intel.com
State New
Headers
Series [v1,1/1] pinctrl: denverton: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE() |

Commit Message

Andy Shevchenko Oct. 5, 2023, 1:59 p.m. UTC 
  As Krzysztof pointed out the better is to use MODULE_DEVICE_TABLE()
as it will be consistent with the content of the real ID table of
the platform devices.

Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/pinctrl/intel/pinctrl-denverton.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andy Shevchenko Oct. 6, 2023, 8:24 a.m. UTC | #1 
On Thu, Oct 05, 2023 at 04:32:38PM +0200, Krzysztof Kozlowski wrote:
> On 05/10/2023 15:59, Andy Shevchenko wrote:
> > As Krzysztof pointed out the better is to use MODULE_DEVICE_TABLE()
> > as it will be consistent with the content of the real ID table of
> > the platform devices.

> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Pushed to my review and testing queue, thanks!
diff mbox series

Patch

diff --git a/drivers/pinctrl/intel/pinctrl-denverton.c b/drivers/pinctrl/intel/pinctrl-denverton.c
index a1a7242e0451..562a4f9188e4 100644
--- a/drivers/pinctrl/intel/pinctrl-denverton.c
+++ b/drivers/pinctrl/intel/pinctrl-denverton.c
@@ -261,6 +261,7 @@  static const struct platform_device_id dnv_pinctrl_platform_ids[] = {
 	{ "denverton-pinctrl", (kernel_ulong_t)&dnv_soc_data },
 	{ }
 };
+MODULE_DEVICE_TABLE(platform, dnv_pinctrl_platform_ids);
 
 static struct platform_driver dnv_pinctrl_driver = {
 	.probe = intel_pinctrl_probe_by_hid,
@@ -287,5 +288,4 @@  module_exit(dnv_pinctrl_exit);
 MODULE_AUTHOR("Mika Westerberg <mika.westerberg@linux.intel.com>");
 MODULE_DESCRIPTION("Intel Denverton SoC pinctrl/GPIO driver");
 MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("platform:denverton-pinctrl");
 MODULE_IMPORT_NS(PINCTRL_INTEL);