diff mbox series

[27/29] overlayfs: move xattr tables to .rodata

Message ID	20230930050033.41174-28-wedsonaf@gmail.com
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; From: Wedson Almeida Filho <wedsonaf@gmail.com> To: Alexander Viro <viro@zeniv.linux.org.uk>, Christian Brauner <brauner@kernel.org>, linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Wedson Almeida Filho <walmeida@microsoft.com>, Miklos Szeredi <miklos@szeredi.hu>, Amir Goldstein <amir73il@gmail.com>, linux-unionfs@vger.kernel.org Subject: [PATCH 27/29] overlayfs: move xattr tables to .rodata Date: Sat, 30 Sep 2023 02:00:31 -0300 Message-Id: <20230930050033.41174-28-wedsonaf@gmail.com> In-Reply-To: <20230930050033.41174-1-wedsonaf@gmail.com> References: <20230930050033.41174-1-wedsonaf@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	const xattr tables \| [00/29] const xattr tables [01/29] xattr: make the xattr array itself const [02/29] ext4: move ext4_xattr_handlers to .rodata [03/29] 9p: move xattr-related structs to .rodata [04/29] afs: move afs_xattr_handlers to .rodata [05/29] btrfs: move btrfs_xattr_handlers to .rodata [06/29] ceph: move ceph_xattr_handlers to .rodata [07/29] ecryptfs: move ecryptfs_xattr_handlers to .rodata [08/29] erofs: move erofs_xattr_handlers and xattr_handler_map to .rodata [09/29] ext2: move ext2_xattr_handlers and ext2_xattr_handler_map to .rodata [10/29] f2fs: move f2fs_xattr_handlers and f2fs_xattr_handler_map to .rodata [11/29] fuse: move fuse_xattr_handlers to .rodata [12/29] gfs2: move gfs2_xattr_handlers_max to .rodata [13/29] hfs: move hfs_xattr_handlers to .rodata [14/29] hfsplus: move hfsplus_xattr_handlers to .rodata [15/29] jffs2: move jffs2_xattr_handlers to .rodata [16/29] jfs: move jfs_xattr_handlers to .rodata [17/29] kernfs: move kernfs_xattr_handlers to .rodata [18/29] nfs: move nfs4_xattr_handlers to .rodata [19/29] ntfs3: move ntfs_xattr_handlers to .rodata [20/29] ocfs2: move ocfs2_xattr_handlers and ocfs2_xattr_handler_map to .rodata [21/29] orangefs: move orangefs_xattr_handlers to .rodata [22/29] reiserfs: move reiserfs_xattr_handlers to .rodata [23/29] smb: move cifs_xattr_handlers to .rodata [24/29] squashfs: move squashfs_xattr_handlers to .rodata [25/29] ubifs: move ubifs_xattr_handlers to .rodata [26/29] xfs: move xfs_xattr_handlers to .rodata [27/29] overlayfs: move xattr tables to .rodata [28/29] shmem: move shmem_xattr_handlers to .rodata [29/29] net: move sockfs_xattr_handlers to .rodata

Commit Message

Wedson Almeida Filho Sept. 30, 2023, 5 a.m. UTC

  From: Wedson Almeida Filho <walmeida@microsoft.com>

This makes it harder for accidental or malicious changes to
ovl_trusted_xattr_handlers or ovl_user_xattr_handlers at runtime.

Cc: Miklos Szeredi <miklos@szeredi.hu>
Cc: Amir Goldstein <amir73il@gmail.com>
Cc: linux-unionfs@vger.kernel.org
Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
---
 fs/overlayfs/super.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Amir Goldstein Oct. 3, 2023, 4:41 p.m. UTC | #1

On Sat, Sep 30, 2023 at 8:02 AM Wedson Almeida Filho <wedsonaf@gmail.com> wrote:
>
> From: Wedson Almeida Filho <walmeida@microsoft.com>
>
> This makes it harder for accidental or malicious changes to
> ovl_trusted_xattr_handlers or ovl_user_xattr_handlers at runtime.
>
> Cc: Miklos Szeredi <miklos@szeredi.hu>
> Cc: Amir Goldstein <amir73il@gmail.com>
> Cc: linux-unionfs@vger.kernel.org
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>

Acked-by: Amir Goldstein <amir73il@gmail.com>

> ---
>  fs/overlayfs/super.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
> index cc8977498c48..fe7af47be621 100644
> --- a/fs/overlayfs/super.c
> +++ b/fs/overlayfs/super.c
> @@ -477,13 +477,13 @@ static const struct xattr_handler ovl_other_xattr_handler = {
>         .set = ovl_other_xattr_set,
>  };
>
> -static const struct xattr_handler *ovl_trusted_xattr_handlers[] = {
> +static const struct xattr_handler * const ovl_trusted_xattr_handlers[] = {
>         &ovl_own_trusted_xattr_handler,
>         &ovl_other_xattr_handler,
>         NULL
>  };
>
> -static const struct xattr_handler *ovl_user_xattr_handlers[] = {
> +static const struct xattr_handler * const ovl_user_xattr_handlers[] = {
>         &ovl_own_user_xattr_handler,
>         &ovl_other_xattr_handler,
>         NULL
> --
> 2.34.1
>

diff mbox series

Patch

diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index cc8977498c48..fe7af47be621 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -477,13 +477,13 @@  static const struct xattr_handler ovl_other_xattr_handler = {
 	.set = ovl_other_xattr_set,
 };
 
-static const struct xattr_handler *ovl_trusted_xattr_handlers[] = {
+static const struct xattr_handler * const ovl_trusted_xattr_handlers[] = {
 	&ovl_own_trusted_xattr_handler,
 	&ovl_other_xattr_handler,
 	NULL
 };
 
-static const struct xattr_handler *ovl_user_xattr_handlers[] = {
+static const struct xattr_handler * const ovl_user_xattr_handlers[] = {
 	&ovl_own_user_xattr_handler,
 	&ovl_other_xattr_handler,
 	NULL