Message ID | 20231002145737.538934-1-Frank.Li@nxp.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2a8e:b0:403:3b70:6f57 with SMTP id in14csp1617508vqb; Mon, 2 Oct 2023 11:36:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGUTbOcSAoVG/oiNPlDYiCOu9lIwgPWlaf9V94Yq36J6B3UEuRti1ufzt5Ssolv2sd1oE+e X-Received: by 2002:a17:902:efc2:b0:1b8:a67f:1c15 with SMTP id ja2-20020a170902efc200b001b8a67f1c15mr485542plb.25.1696271781513; Mon, 02 Oct 2023 11:36:21 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1696271781; cv=pass; d=google.com; s=arc-20160816; b=wwqbXFORzHXQPSdrcy4hSBxlyJCvd9zakWLZHFx+c2Zv3yFc7wObgehbgf+xvrGgzL 4tazq7O45uY0g1KWnTyJBosKMi5bRnNzk7huynvhnl9t7TofEqkWDgKWXcJXsMZFGLjB lDbkf7PxFu2Vv+f+0DII/15IFSxGeUjGQr4B20GZpRyrkRN4hiLj0s394woC+/YqAReJ bfFdE20jvw4ZHbpTvP4EXdPBEBeXUmirZA7okCJJ5kx5AVSyAAtbWDNm/2k7sGfF38xo uB8/HCLd/8zZwfRJBeUYdCWhONYHM9AyQLRSnmukw4lR4C2k1MEXm4aR+L9WhFz6wSCt QaOA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :message-id:date:subject:cc:to:from:dkim-signature; bh=agg4p5GigpgpJnC3NANg8pARD2qcBdhnIzE5/bQX57g=; fh=65xFqsFZb7k6TNJSNn0AD4GZFrAosKbGCNTXcP6/ZmA=; b=PxvHA3R9tK0vtCG97PvY6+HnpcXN9Jq/996JZOviq7qLPO+w9X0yZHQRmZ/E//yhHP Vr3otd790VQxWb+uxUmIUUDlHwf5jLDrFrTJn9HtmzRZyuWDEn5+SgLbBTd/fiT0hZtK n/w1i/BGNu4XglXuS5Zz+UczsR03zkL1Q5b1JDvqJKV1jkU1q0DbAS4NZHnNv2qKpfXD 2eEd0tuFhBWyuMebCuhwJYSJFrn1Ugnr0HGrhytq8FF7bJ6QRDTd0uAWFqcc/FDRkmnr yJvRHh/rFR3SEagS1Lhjoubn2M8H3Nwep4tpUv0AuD7XOfCM/5ANb39TBX4Bx9D1T2vT eYVw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b="GapmF/aS"; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id 144-20020a630096000000b005780b4905f1si28226925pga.460.2023.10.02.11.36.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 11:36:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b="GapmF/aS"; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id B99D980924B6; Mon, 2 Oct 2023 07:58:09 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237911AbjJBO6B (ORCPT <rfc822;pusanteemu@gmail.com> + 18 others); Mon, 2 Oct 2023 10:58:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237894AbjJBO57 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 2 Oct 2023 10:57:59 -0400 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2066.outbound.protection.outlook.com [40.107.105.66]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E96969D; Mon, 2 Oct 2023 07:57:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AKlkUabgcq8GY3gjHDgxowAOwAHUVD+5pJa82TZhFskaSiFrG43QGsINVH1NEOE/xIzxQ4H9xfCqA5cRE+W8LZfohAjAfmkBhr98/c3Xilnx6f2BmFrmUttu4AMKVijxTtZx4+77s6Zo5mayYzRzPsOO12OtGeATJrperTYCf2hTjty0hNCWJb5csW7f9XsxcIBLYDjf6gOHP8chabZn0C1t0UKeJ7wI6DRX1EVZFuR3MOref4C9nlfbNQff0V1BVfpcmmIC0bvknh3vJFCQqeRA8L8SIU2ono6Ew50m4HIhwSgeAfWLMZsHoZ5Rs0TQCsJ4GMKEtXj05Pjo6EEv6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=agg4p5GigpgpJnC3NANg8pARD2qcBdhnIzE5/bQX57g=; b=gH8GTVbLhaXB4k5JiTB16DUoXtIADtUtpzHuAKE3Et3f368yJXgULv1DLBX5WvZJgfpsevEsuJOsFvce+v/JJmRA3TfCgfXoeaU1iCZWjF5dtX4lGRj0vFvihiMVn3BTXHZF0YRPV5tXDQx7/8y7j4+jGovzcmMWCfLVhUTpkRGXNnLtv0Ub0UrIadmtgs3IOPRFEKaHMYdvODi8pdrbz4dOsjTkfEAEjIr2LkeZvbHvs5orZVXthR+1kwQoTQWoPhNrhi6jtp3Pc7CO/Qo3dHBMI7lRlB1K/yjoo8yucyuCM1CefqMEBQuZBu303rbLSKolhDoYEx0SH31yyuD/eQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=agg4p5GigpgpJnC3NANg8pARD2qcBdhnIzE5/bQX57g=; b=GapmF/aS1DtzXGqijDe323F4zlQlL8yMtv34U8OrYz95CkwY1qKR6whp53XywDxhor4SwE+RMZzABvbUgpbgrzT85VJdOzdxyx4u605Nh9DwlPWYDBNtw8nZSjcFxgvs9AK23tZyu5dMkLxCLRyn4Wn6bgJ3yCaYqI5s1FZ2gG0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by AM8PR04MB7986.eurprd04.prod.outlook.com (2603:10a6:20b:245::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Mon, 2 Oct 2023 14:57:53 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2%4]) with mapi id 15.20.6813.027; Mon, 2 Oct 2023 14:57:52 +0000 From: Frank Li <Frank.Li@nxp.com> To: bhe@redhat.com Cc: Frank.Li@nxp.com, arnd@arndb.de, dmaengine@vger.kernel.org, gregkh@linuxfoundation.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, lkp@intel.com, oe-kbuild-all@lists.linux.dev, rafael@kernel.org, vkoul@kernel.org Subject: [PATCH v2 1/1] fs: debugfs: fix build error at powerpc platform Date: Mon, 2 Oct 2023 10:57:37 -0400 Message-Id: <20231002145737.538934-1-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SJ0PR13CA0195.namprd13.prod.outlook.com (2603:10b6:a03:2c3::20) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|AM8PR04MB7986:EE_ X-MS-Office365-Filtering-Correlation-Id: d6bfdf01-00c5-4cfe-c8d4-08dbc357f400 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HbXIUegZPy3wPr+SbMoybK5sT+yNimn4/F5JLehsfFptltuNrLIpumsuPTUDI9tYWJkzWXyRaf0efSQYg/PYRSGOrR3Bn5+fuHoAnYgVZTvIbQUoOWDmgJ7xS4QxOjKxCCTinN9GcwutzzUqYJHjdfh3UxYaVDW1QSl026H65J3nW6kaHtFL/YrP+JcQ5lm1ou0UP1rLuIRHRasYziqbQSjTnY6rJOA7qMkAgCVrPN34DhLaLKyccLn4DGdCgEHWGuopK+r28StCeM6IFRSuuotDBi9+l6TiJmPyoQD6beyQXk5qNrJhuuRIqtTUfSUtfWuTgS08WOsNmbLZ6B8HqSLfIpHRLgXpMWzsqvj669F0lA+ctudx14s/5KsS7O3SLEgz1OtUFLGPkguKm03CObXQn1dxkkqNKqupNwsBt2CL8dPbOGy7KqNQFNi3QUCEEUM4A8Lj0m/mHIuy5SmMkZHhamR7JLLiZ6hZxqVHXGtzKBP72h2UI3V7r2BWyBDszkrwPNba6PuQDK+Z9Em6CbkcOVPv7Y5sJgxw9CVemN64pqeKsWRAOdJ00qM68I4qET750LP5s9pkpWAqYqfjiujNHpJa4LTcTw8UfpZnBB0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(346002)(366004)(136003)(39860400002)(396003)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(2906002)(7416002)(4744005)(36756003)(86362001)(6512007)(38100700002)(316002)(1076003)(26005)(2616005)(478600001)(52116002)(41300700001)(6666004)(6916009)(4326008)(966005)(6486002)(6506007)(66476007)(38350700002)(8936002)(66946007)(8676002)(83380400001)(66556008)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: YMwfuw8fsKFyVkG4Wwmb8e32SCVuntEWBCQxzhQnuJiw2EXDlAqP2YzCY2IfcPVpv4BOsaeGbG9Yvt5Xwj6/tSLsnQFz7nhTERzoX/f4dKzYQ20fFxhTJiYZSmo+sMP+ELovv6oNbtoETPrnpOh2BqXnHHIjAD0TO50BB6aOTvVma8A2Y0FKqT/t98Zllpn++k/h1Vj/r7kAKv5EW4Gar19WI3afmWg8JUktH1BtQygeQV7RQo56CzyCLw6YpBAEXupQNFAr/SXyXkXtdBlJhZP7VSCMxgfGzwOoBbLoYPf7AkwjEB53t9eK8WqqJBoKAFxvTwgpj6SU/DjR4eBSH3MNvSZui4B3bUbl0qkclsUZZaCMrPQkNN6y7USujAsgBV1s+jkWy9ZDqdTMrPlR5o4T4HNdtcf2YEKbYlCPAPYwvAMR11xAGBfMvTn5IBogSXCT2tmt5BDohvWssxdMxUVnuG2NHdXbEAAm6zXvMRHIo8xNEwUNJ9HaRqB93Gvtwfh9ay7KwvA8FkCNZIlYWf7aoeMUjvEuaM0EANSVHPxltT6fSgZXznKRZxVoes679v3Ybhfi7mKE6Y3x4EMFfDtZYC2S2Nk1yyWVKWWeNJwSqAWvgpGh8BfQe7WDQUoaISOWFe8ThxqZ9/t6dWuq6m0BzqWdJ0MJqb19NJRAHrIIKo3nBRI2Xi2uDhMdaqsDBlDmh8pvIypa+EduMlnmvUNqRTbg/9MLaEZjdswUEgMhtcaZX+qeHnSVB2ZrFe9+UEPdCqHTECWKdgYc0yvAbSx559agq2BjDFnKRlBOtIuvCCrXUgbAX4bVeOX0FCqgTV6qjBgc6KBrFOw1Cx0tNkqKwiNcKYLNBNrdOuYzdzdXfzV824eVoZvGPVQbGtv33ssCEESLb0U024+oimKqtUOtDmfiTKqZJ/NQquj+91KmgXleYeC2QCad6zDsH0sKGNMvf1LX3QVLmBNjjkLZNIrtPcS75/k8beeQcC+OKA/WpLTrsztU+nfY78PPXs5/fDZH+D+pOlJtfUeSsOrLFJFpzHRU3JUjbz37CE0o+Ym8EOkQaENVNfa4RzV6sPRGMoFD46ZzmJu1NXizrCq/+0NgcpsRclMQJMo6S5XY2Ft5ll570ok3AScsc2TfNq+kYogq+hABGF+SLEEy1xHbrQx3EJOvCtqdX+NdDgmkzKy4nBZRAX935CIfdENCnblJasR1zn02ByE0x4bOQeOXMZ61y0hIFIqT6cUwrC4PT0G8FlQUTtUbRgtYco5aooo0pWzyNGNH7/Kf1NXVGRPABMlXHUMAfmDYpNOWWWvndXpwRzAZL/MsHSwKBn4WlFMmOqatxNPl1GM9mkykAYVxZf1a1t9SUwqj9UDcKjmdUf4vsnSEsQo7gsy/ST/XAlC01RBmry9EAQ5YXsHP9SOxSbPHVRP77QRFELXE4QYr1P3rFp64WG/J0HQbmeO3PxhwJCQw0wRpdzoCBDTzS0A9s0CmZZ8/ar9LsqSgkRRccxOrenhwwa3ANp3V+aGtG4zrs+dXKW++9q4/Yqs5xXXCY4hhHWwfrsSYEe+x56nEVq4= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6bfdf01-00c5-4cfe-c8d4-08dbc357f400 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 14:57:52.9151 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HbRXADmWevK3rNyi8cB/yFsSL01NMJDGpQ5kioKPRIWLDOzdUOEGGbwzQJV8cc/1haaIyrdfbFAIT1H09C6t4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7986 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 02 Oct 2023 07:58:09 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778393005562405685 X-GMAIL-MSGID: 1778669879867598369 |
Series |
[v2,1/1] fs: debugfs: fix build error at powerpc platform
|
|
Commit Message
Frank Li
Oct. 2, 2023, 2:57 p.m. UTC
ld: fs/debugfs/file.o: in function `debugfs_print_regs': file.c:(.text+0x95a): undefined reference to `ioread64be' >> ld: file.c:(.text+0x9dd): undefined reference to `ioread64' Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202309291322.3pZiyosI-lkp@intel.com/ Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Notes: Change from v1 to v2 - fixed it by #include <linux/io-64-nonatomic-hi-lo.h> fs/debugfs/file.c | 1 + 1 file changed, 1 insertion(+)
Comments
On Mon, Oct 2, 2023, at 16:57, Frank Li wrote: > ld: fs/debugfs/file.o: in function `debugfs_print_regs': > file.c:(.text+0x95a): undefined reference to `ioread64be' >>> ld: file.c:(.text+0x9dd): undefined reference to `ioread64' > > Reported-by: kernel test robot <lkp@intel.com> > Closes: > https://lore.kernel.org/oe-kbuild-all/202309291322.3pZiyosI-lkp@intel.com/ > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- I still think this is wrong, for the reasons I explained in https://lore.kernel.org/all/b795ed61-0174-487f-a263-8431e7c76af5@app.fastmail.com/ The part that I had missed earlier is how this is related to GENERIC_IOMAP, since on those architectures, the ioread helpers are not just fixed-endian MMIO accessors like readl and readq but also multiplex to the PIO functions (inb/inw/inl) that do not have a 64-bit version because x86 and PCI both only define those up to 32 bit width. The best workaround is probably to use readq() instead of ioread64(), or swab64(readl()) instead of ioread64_be(). This should work on all 64-bit architectures, plus any 32-bit one that defines readq(), so you can just use an 'ifdef readq' around the call. Arnd
On Mon, Oct 02, 2023 at 08:14:47PM +0200, Arnd Bergmann wrote: > On Mon, Oct 2, 2023, at 16:57, Frank Li wrote: > > ld: fs/debugfs/file.o: in function `debugfs_print_regs': > > file.c:(.text+0x95a): undefined reference to `ioread64be' > >>> ld: file.c:(.text+0x9dd): undefined reference to `ioread64' > > > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: > > https://lore.kernel.org/oe-kbuild-all/202309291322.3pZiyosI-lkp@intel.com/ > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > I still think this is wrong, for the reasons I explained in > https://lore.kernel.org/all/b795ed61-0174-487f-a263-8431e7c76af5@app.fastmail.com/ > > The part that I had missed earlier is how this is > related to GENERIC_IOMAP, since on those architectures, > the ioread helpers are not just fixed-endian MMIO accessors > like readl and readq but also multiplex to the PIO functions > (inb/inw/inl) that do not have a 64-bit version because x86 > and PCI both only define those up to 32 bit width. > > The best workaround is probably to use readq() instead of > ioread64(), or swab64(readl()) instead of ioread64_be(). > > This should work on all 64-bit architectures, plus any 32-bit > one that defines readq(), so you can just use an 'ifdef readq' > around the call. My previous patchs were dropped by vinod. I think it'd better remove 64bit register at previous patch serise. Let me create a seperate patch to enable 64bit register support for debug fs. Frank > > Arnd
diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 5b8d4fd7c747..ca6208c49339 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c @@ -15,6 +15,7 @@ #include <linux/pagemap.h> #include <linux/debugfs.h> #include <linux/io.h> +#include <linux/io-64-nonatomic-hi-lo.h> #include <linux/slab.h> #include <linux/atomic.h> #include <linux/device.h>