diff mbox series

[2/4] pata_parport: implement set_devctl

Message ID 20230930191511.24994-3-linux@zary.sk
State New
Headers
Series pata_parport: fix EXP Computer CD-865 with MC-1285B EPP cable |

Commit Message

Ondrej Zary Sept. 30, 2023, 7:15 p.m. UTC 
  Add missing ops->sff_set_devctl implementation.

Signed-off-by: Ondrej Zary <linux@zary.sk>
---
 drivers/ata/pata_parport/pata_parport.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Sergey Shtylyov Oct. 2, 2023, 7:52 p.m. UTC | #1 
On 9/30/23 10:15 PM, Ondrej Zary wrote:

> Add missing ops->sff_set_devctl implementation.

   This is also a bug fix, right?

> Signed-off-by: Ondrej Zary <linux@zary.sk>

Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Fixes: 246a1c4c6b7f ("ata: pata_parport: add driver (PARIDE replacement)")

[...]

MBR, Sergey
diff mbox series

Patch

diff --git a/drivers/ata/pata_parport/pata_parport.c b/drivers/ata/pata_parport/pata_parport.c
index 258d189f42e5..cf87bbb52f1f 100644
--- a/drivers/ata/pata_parport/pata_parport.c
+++ b/drivers/ata/pata_parport/pata_parport.c
@@ -51,6 +51,13 @@  static void pata_parport_dev_select(struct ata_port *ap, unsigned int device)
 	ata_sff_pause(ap);
 }
 
+static void pata_parport_set_devctl(struct ata_port *ap, u8 ctl)
+{
+	struct pi_adapter *pi = ap->host->private_data;
+
+	pi->proto->write_regr(pi, 1, 6, ctl);
+}
+
 static bool pata_parport_devchk(struct ata_port *ap, unsigned int device)
 {
 	struct pi_adapter *pi = ap->host->private_data;
@@ -252,6 +259,7 @@  static struct ata_port_operations pata_parport_port_ops = {
 	.hardreset		= NULL,
 
 	.sff_dev_select		= pata_parport_dev_select,
+	.sff_set_devctl		= pata_parport_set_devctl,
 	.sff_check_status	= pata_parport_check_status,
 	.sff_check_altstatus	= pata_parport_check_altstatus,
 	.sff_tf_load		= pata_parport_tf_load,