Message ID | 20231002094813.6633-2-ilpo.jarvinen@linux.intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2a8e:b0:403:3b70:6f57 with SMTP id in14csp1419939vqb; Mon, 2 Oct 2023 06:17:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG9bjVZ1H3iDjmGCyNyow8RdmfxF3S8PEPds9OKJ+b1tYZrMdESgzCtcjJ2eauOneFF+qss X-Received: by 2002:a9d:67cb:0:b0:6c4:9ca1:f13a with SMTP id c11-20020a9d67cb000000b006c49ca1f13amr12029772otn.35.1696252640793; Mon, 02 Oct 2023 06:17:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696252640; cv=none; d=google.com; s=arc-20160816; b=QgeMN240sYIVQmZU3ZM+nK30evnlLPhRGANvHif5KVsdDCwoDcxZWZLg52/ZXPaqqb lcbndETCvU7m33Rs+lfG/ESVt79CgoBqzcqregN+meRNqo8rX9E6j5TDsIVfHLEhMocG PzbXZo/DlleGm40DFPh9Feo010ZsD4cPU2sseZkkfTU9gEuscNiQ6DZUioLzabHblJbo cVIqxyfT9ZAHvh4me4GsFgfpgjFmKgPd9fsUiw6Yw27834JKU+Wvcs4XoriNRNGvUU3b /bqotsOXoOaXRkxOOeIzaQWaLI8p/rnmT3ktRvvWI744GkPsf3yav8MkXtSuTLbKngnn PUcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0grpHKBKriuHPUQJKdYHq+f4X7zkqio3MOAI4rFyzJc=; fh=0zBAjxShfumhVJgCQ7/PrZqZq2D8mhtAJK1GC38L6Jc=; b=VUYg/dxeQDjiPTQb9I5HGpJQy12V/Rs5Jr06zIS/Pl81Sl6Z3JugCTnoW2PLDNS7Yn QI9DXGcNEkk4VN7eaWTd/GGP+shaPdqnx6RbC2eXj73Ae73PMtaHXigX1c70ftfFKe+R 2AsT6fNmN92DHJlIMF/tv0inBYnH7p3Inv/RIJotYx3jlZxjiHsKtCBCNjeeoVjRaBiW grTWgIY/iOUlYcQlKhfwKQ7/yyZU5BC5a0mtFuIz5MCh9+JMJhtcUuBrGTvmZ2xQmbId Y/zGOjdXu0jFn6liGjsBDAPs31eP5qv6w0vEWBYMDZDIFypY60AABJdoJhiwe/y8pvLI Po5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GM98pN79; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id r5-20020a63fc45000000b0057744d09d1bsi27288707pgk.251.2023.10.02.06.17.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 06:17:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GM98pN79; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 7FEF180417FB; Mon, 2 Oct 2023 02:49:04 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236208AbjJBJsk (ORCPT <rfc822;pwkd43@gmail.com> + 16 others); Mon, 2 Oct 2023 05:48:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236246AbjJBJsi (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 2 Oct 2023 05:48:38 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3AA5BD; Mon, 2 Oct 2023 02:48:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696240114; x=1727776114; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8pmtfWXMI20eJN8ahNBeDBXwc3u2yQV2h67SqlOWlpQ=; b=GM98pN79RLVzYkQeYQe5HRrIA0yGrz13YMwe1IX6ODD0xCuyfrOb1MBs Ow/pOfF6ObmgzF2phOpifosbbKgpg2uVuQQgqyhg+m+oH1f3pnABsil10 CSr0A12ZGeBFoO/P7Bv3bvGTb94vjLNU+jvQZCPvjqQjwOBGxlTHiu1Xg IpOWdqQ0Q6oYA0KNPOnhk3fMwO8Po1wT8v05vgowvUR0dO4bMiM/z4RaA /Nop38L5A0QehXrYf0ft5NN/jGhuZWOeyKNhQR0IXLnlCMPF/oFMxTccc fVG/urisyefso4Vo1/yRkzZ1SgNJEbzrlSvL8Vpf3gP3XxJY0lRTOdsio Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10850"; a="382517286" X-IronPort-AV: E=Sophos;i="6.03,194,1694761200"; d="scan'208";a="382517286" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2023 02:48:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10850"; a="1081593242" X-IronPort-AV: E=Sophos;i="6.03,194,1694761200"; d="scan'208";a="1081593242" Received: from aanantha-mobl.gar.corp.intel.com (HELO localhost) ([10.251.221.191]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2023 02:48:30 -0700 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com> To: linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>, Reinette Chatre <reinette.chatre@intel.com>, =?utf-8?q?Maciej_Wiecz=C3=B3r-?= =?utf-8?q?Retman?= <maciej.wieczor-retman@intel.com>, Shaopeng Tan <tan.shaopeng@jp.fujitsu.com> Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, =?utf-8?q?Ilpo_J?= =?utf-8?q?=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com> Subject: [PATCH v4 1/7] selftests/resctrl: Fix uninitialized .sa_flags Date: Mon, 2 Oct 2023 12:48:07 +0300 Message-Id: <20231002094813.6633-2-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20231002094813.6633-1-ilpo.jarvinen@linux.intel.com> References: <20231002094813.6633-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 02 Oct 2023 02:49:04 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778649808613292891 X-GMAIL-MSGID: 1778649808613292891 |
Series |
selftests/resctrl: Fixes to failing tests
|
|
Commit Message
Ilpo Järvinen
Oct. 2, 2023, 9:48 a.m. UTC
signal_handler_unregister() calls sigaction() with uninitializing
sa_flags in the struct sigaction.
Make sure sa_flags is always initialized in signal_handler_unregister()
by initializing the struct sigaction when declaring it. Also add the
initialization to signal_handler_register() even if there are no know
bugs in there because correctness is then obvious from the code itself.
Fixes: 73c55fa5ab55 ("selftests/resctrl: Commonize the signal handler register/unregister for all tests")
Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Cc: <stable@vger.kernel.org>
---
tools/testing/selftests/resctrl/resctrl_val.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
Hi Ilpo, On 10/2/2023 2:48 AM, Ilpo Järvinen wrote: > signal_handler_unregister() calls sigaction() with uninitializing > sa_flags in the struct sigaction. > > Make sure sa_flags is always initialized in signal_handler_unregister() > by initializing the struct sigaction when declaring it. Also add the > initialization to signal_handler_register() even if there are no know > bugs in there because correctness is then obvious from the code itself. > > Fixes: 73c55fa5ab55 ("selftests/resctrl: Commonize the signal handler register/unregister for all tests") > Suggested-by: Reinette Chatre <reinette.chatre@intel.com> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > Cc: <stable@vger.kernel.org> Thank you. Reviewed-by: Reinette Chatre <reinette.chatre@intel.com> Reinette
diff --git a/tools/testing/selftests/resctrl/resctrl_val.c b/tools/testing/selftests/resctrl/resctrl_val.c index 51963a6f2186..01bbe11a8983 100644 --- a/tools/testing/selftests/resctrl/resctrl_val.c +++ b/tools/testing/selftests/resctrl/resctrl_val.c @@ -482,7 +482,7 @@ void ctrlc_handler(int signum, siginfo_t *info, void *ptr) */ int signal_handler_register(void) { - struct sigaction sigact; + struct sigaction sigact = {}; int ret = 0; sigact.sa_sigaction = ctrlc_handler; @@ -504,7 +504,7 @@ int signal_handler_register(void) */ void signal_handler_unregister(void) { - struct sigaction sigact; + struct sigaction sigact = {}; sigact.sa_handler = SIG_DFL; sigemptyset(&sigact.sa_mask);