diff mbox series

rust: error: fix the description for `ECHILD`

Message ID 20230930144958.46051-1-wedsonaf@gmail.com
State New
Headers
Series rust: error: fix the description for `ECHILD` |

Commit Message

Wedson Almeida Filho Sept. 30, 2023, 2:49 p.m. UTC 
  From: Wedson Almeida Filho <walmeida@microsoft.com>

A mistake was made and the description of `ECHILD` is wrong (it reuses
the description of `ENOEXEC`). This fixes it to reflect what's in
`errno-base.h`.

Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
---
 rust/kernel/error.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d

Comments

Trevor Gross Sept. 30, 2023, 5:30 p.m. UTC | #1 
On Sat, Sep 30, 2023 at 10:50 AM Wedson Almeida Filho
<wedsonaf@gmail.com> wrote:
>
> From: Wedson Almeida Filho <walmeida@microsoft.com>
>
> A mistake was made and the description of `ECHILD` is wrong (it reuses
> the description of `ENOEXEC`). This fixes it to reflect what's in
> `errno-base.h`.
>
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
> ---

Reviewed-by: Trevor Gross <tmgross@umich.edu>
Martin Rodriguez Reboredo Sept. 30, 2023, 10:42 p.m. UTC | #2 
On 9/30/23 11:49, Wedson Almeida Filho wrote:
> From: Wedson Almeida Filho <walmeida@microsoft.com>
> 
> A mistake was made and the description of `ECHILD` is wrong (it reuses
> the description of `ENOEXEC`). This fixes it to reflect what's in
> `errno-base.h`.
> 
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
> ---
> [...]
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
Alice Ryhl Oct. 1, 2023, 11:40 a.m. UTC | #3 
On 9/30/23 16:49, Wedson Almeida Filho wrote:
> From: Wedson Almeida Filho <walmeida@microsoft.com>
> 
> A mistake was made and the description of `ECHILD` is wrong (it reuses
> the description of `ENOEXEC`). This fixes it to reflect what's in
> `errno-base.h`.
> 
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
> ---
>   rust/kernel/error.rs | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Finn Behrens Oct. 2, 2023, 3:12 p.m. UTC | #4 
On 30 Sep 2023, at 16:49, Wedson Almeida Filho wrote:

> From: Wedson Almeida Filho <walmeida@microsoft.com>
>
> A mistake was made and the description of `ECHILD` is wrong (it reuses
> the description of `ENOEXEC`). This fixes it to reflect what's in
> `errno-base.h`.
>
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
> ---

Reviewed-by: Finn Behrens <me@kloenk.dev>
Miguel Ojeda Oct. 8, 2023, 8:01 p.m. UTC | #5 
On Sat, Sep 30, 2023 at 4:50 PM Wedson Almeida Filho <wedsonaf@gmail.com> wrote:
>
> From: Wedson Almeida Filho <walmeida@microsoft.com>
>
> A mistake was made and the description of `ECHILD` is wrong (it reuses
> the description of `ENOEXEC`). This fixes it to reflect what's in
> `errno-base.h`.
>
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>

Applied to `rust-fixes`, thanks everyone!

Cheers,
Miguel
Benno Lossin Oct. 9, 2023, 2:54 p.m. UTC | #6 
On 30.09.23 16:49, Wedson Almeida Filho wrote:
> From: Wedson Almeida Filho <walmeida@microsoft.com>
> 
> A mistake was made and the description of `ECHILD` is wrong (it reuses
> the description of `ENOEXEC`). This fixes it to reflect what's in
> `errno-base.h`.
> 
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
> ---
>   rust/kernel/error.rs | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
> index 05fcab6abfe6..bab2c043fc42 100644
> --- a/rust/kernel/error.rs
> +++ b/rust/kernel/error.rs
> @@ -37,7 +37,7 @@ macro_rules! declare_err {
>       declare_err!(E2BIG, "Argument list too long.");
>       declare_err!(ENOEXEC, "Exec format error.");
>       declare_err!(EBADF, "Bad file number.");
> -    declare_err!(ECHILD, "Exec format error.");
> +    declare_err!(ECHILD, "No child process.");

Strictly speaking, `errno-base.h` documents this as "No child
processes" (note the plural), but I am fine with taking it as-is.

Reviewed-by: Benno Lossin <benno.lossin@proton.me>
Miguel Ojeda Oct. 12, 2023, 9 p.m. UTC | #7 
On Mon, Oct 9, 2023 at 4:54 PM Benno Lossin <benno.lossin@proton.me> wrote:
>
> Strictly speaking, `errno-base.h` documents this as "No child
> processes" (note the plural), but I am fine with taking it as-is.

Good catch.

POSIX seems to use both (General Information vs. `<errno.h>`), so
perhaps that is where Wedson picked it from.

Given the kernel uses the plural, and that the commit message says it
mimics `errno-base.h`, I have amended it.

Cheers,
Miguel

1:  77983c791960 ! 1:  17bfcd6a8153 rust: error: fix the description
for `ECHILD`
    @@ Commit message
         Fixes: 266def2a0f5b ("rust: error: add codes from `errno-base.h`")
         Cc: stable@vger.kernel.org
         Link: https://lore.kernel.org/r/20230930144958.46051-1-wedsonaf@gmail.com
    +    [ Use the plural, as noticed by Benno. ]
         Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

      ## rust/kernel/error.rs ##
    @@ rust/kernel/error.rs: macro_rules! declare_err {
          declare_err!(ENOEXEC, "Exec format error.");
          declare_err!(EBADF, "Bad file number.");
     -    declare_err!(ECHILD, "Exec format error.");
    -+    declare_err!(ECHILD, "No child process.");
    ++    declare_err!(ECHILD, "No child processes.");
          declare_err!(EAGAIN, "Try again.");
          declare_err!(ENOMEM, "Out of memory.");
          declare_err!(EACCES, "Permission denied.");
diff mbox series

Patch

diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
index 05fcab6abfe6..bab2c043fc42 100644
--- a/rust/kernel/error.rs
+++ b/rust/kernel/error.rs
@@ -37,7 +37,7 @@  macro_rules! declare_err {
     declare_err!(E2BIG, "Argument list too long.");
     declare_err!(ENOEXEC, "Exec format error.");
     declare_err!(EBADF, "Bad file number.");
-    declare_err!(ECHILD, "Exec format error.");
+    declare_err!(ECHILD, "No child process.");
     declare_err!(EAGAIN, "Try again.");
     declare_err!(ENOMEM, "Out of memory.");
     declare_err!(EACCES, "Permission denied.");