diff mbox series

drm/bridge: tc358767: Convert to use maple tree register cache

Message ID 20231001-drm-tc358767-maple-v1-1-f759fcc4bd98@kernel.org
State New
Headers
Series drm/bridge: tc358767: Convert to use maple tree register cache |

Commit Message

Mark Brown Sept. 30, 2023, 11:43 p.m. UTC 
  The maple tree register cache is based on a much more modern data structure
than the rbtree cache and makes optimisation choices which are probably
more appropriate for modern systems than those made by the rbtree cache.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/gpu/drm/bridge/tc358767.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: 6465e260f48790807eef06b583b38ca9789b6072
change-id: 20230929-drm-tc358767-maple-db143f667958

Best regards,

Comments

Neil Armstrong Oct. 2, 2023, 7:02 a.m. UTC | #1 
On 01/10/2023 01:43, Mark Brown wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>   drivers/gpu/drm/bridge/tc358767.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
> index b45bffab7c81..ef2e373606ba 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -2005,7 +2005,7 @@ static const struct regmap_config tc_regmap_config = {
>   	.val_bits = 32,
>   	.reg_stride = 4,
>   	.max_register = PLL_DBG,
> -	.cache_type = REGCACHE_RBTREE,
> +	.cache_type = REGCACHE_MAPLE,
>   	.readable_reg = tc_readable_reg,
>   	.volatile_table = &tc_volatile_table,
>   	.writeable_reg = tc_writeable_reg,
> 
> ---
> base-commit: 6465e260f48790807eef06b583b38ca9789b6072
> change-id: 20230929-drm-tc358767-maple-db143f667958
> 
> Best regards,

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Neil Armstrong Oct. 2, 2023, 7:11 a.m. UTC | #2 
Hi,

On Sun, 01 Oct 2023 01:43:13 +0200, Mark Brown wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
> 
> 

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

[1/1] drm/bridge: tc358767: Convert to use maple tree register cache
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=4dd9368671fb7649dc914e661256a07250c271ca
diff mbox series

Patch

diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
index b45bffab7c81..ef2e373606ba 100644
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drivers/gpu/drm/bridge/tc358767.c
@@ -2005,7 +2005,7 @@  static const struct regmap_config tc_regmap_config = {
 	.val_bits = 32,
 	.reg_stride = 4,
 	.max_register = PLL_DBG,
-	.cache_type = REGCACHE_RBTREE,
+	.cache_type = REGCACHE_MAPLE,
 	.readable_reg = tc_readable_reg,
 	.volatile_table = &tc_volatile_table,
 	.writeable_reg = tc_writeable_reg,